From 3db20e3ed4070c1291c28868f90d283a088dd2b0 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Thu, 12 Dec 2024 00:28:19 +0300 Subject: [PATCH 1/3] test: actually use masternode with basic bls pubkey in mnauth test --- test/functional/rpc_mnauth.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/functional/rpc_mnauth.py b/test/functional/rpc_mnauth.py index 155c3f720a..df372789ce 100755 --- a/test/functional/rpc_mnauth.py +++ b/test/functional/rpc_mnauth.py @@ -21,8 +21,9 @@ class FakeMNAUTHTest(DashTestFramework): def run_test(self): self.activate_v19(expected_activation_height=900) + self.dynamically_add_masternode() - masternode = self.mninfo[0] + masternode = self.mninfo[1] masternode.node.add_p2p_connection(P2PInterface()) protx_hash = masternode.proTxHash From 6519856344e0551c5da22158d094d87b1176c36f Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Thu, 12 Dec 2024 13:30:17 +0300 Subject: [PATCH 2/3] test: don't add legacy bls mn on start --- test/functional/rpc_mnauth.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/functional/rpc_mnauth.py b/test/functional/rpc_mnauth.py index df372789ce..36309554aa 100755 --- a/test/functional/rpc_mnauth.py +++ b/test/functional/rpc_mnauth.py @@ -17,13 +17,13 @@ Tests mnauth RPC command class FakeMNAUTHTest(DashTestFramework): def set_test_params(self): - self.set_dash_test_params(2, 1) + self.set_dash_test_params(1, 0) def run_test(self): self.activate_v19(expected_activation_height=900) self.dynamically_add_masternode() - masternode = self.mninfo[1] + masternode = self.mninfo[0] masternode.node.add_p2p_connection(P2PInterface()) protx_hash = masternode.proTxHash From ec00c372c7c4230fb7de75bb1a00d4b81896dcd6 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Thu, 12 Dec 2024 13:31:14 +0300 Subject: [PATCH 3/3] test: fix off-by-one in dynamically_add_masternode --- test/functional/test_framework/test_framework.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py index 9c84236369..487a59c19a 100755 --- a/test/functional/test_framework/test_framework.py +++ b/test/functional/test_framework/test_framework.py @@ -1279,7 +1279,7 @@ class DashTestFramework(BitcoinTestFramework): return self.dynamically_initialize_datadir(node_p2p_port, node_rpc_port) - node_info = self.add_dynamically_node(self.extra_args[1]) + node_info = self.add_dynamically_node(self.extra_args[0]) args = ['-masternodeblsprivkey=%s' % created_mn_info.keyOperator] + node_info.extra_args self.start_node(mn_idx, args)