diff --git a/doc/developer-notes.md b/doc/developer-notes.md index f20d72b08a..90bad116f0 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -521,6 +521,12 @@ Source code organization - *Rationale*: Shorter and simpler header files are easier to read, and reduce compile time +- Use only the lowercase alphanumerics (`a-z0-9`), underscore (`_`) and hyphen (`-`) in source code filenames. + + - *Rationale*: `grep`:ing and auto-completing filenames is easier when using a consistent + naming pattern. Potential problems when building on case-insensitive filesystems are + avoided when using only lowercase characters in source code filenames. + - Every `.cpp` and `.h` file should `#include` every header file it directly uses classes, functions or other definitions from, even if those headers are already included indirectly through other headers. One exception is that a `.cpp` file does not need to re-include the includes already included in its corresponding `.h` file. diff --git a/src/Makefile.bench.include b/src/Makefile.bench.include index f722769792..ddf8f152cc 100644 --- a/src/Makefile.bench.include +++ b/src/Makefile.bench.include @@ -21,7 +21,7 @@ bench_bench_dash_SOURCES = \ bench/checkblock.cpp \ bench/checkqueue.cpp \ bench/ecdsa.cpp \ - bench/Examples.cpp \ + bench/examples.cpp \ bench/rollingbloom.cpp \ bench/chacha20.cpp \ bench/chacha_poly_aead.cpp \ diff --git a/src/Makefile.test.include b/src/Makefile.test.include index ed06a153e0..6696ad1bf7 100644 --- a/src/Makefile.test.include +++ b/src/Makefile.test.include @@ -51,7 +51,7 @@ BITCOIN_TESTS =\ test/compress_tests.cpp \ test/crypto_tests.cpp \ test/cuckoocache_tests.cpp \ - test/DoS_tests.cpp \ + test/denialofservice_tests.cpp \ test/evo_deterministicmns_tests.cpp \ test/evo_simplifiedmns_tests.cpp \ test/getarg_tests.cpp \ @@ -80,7 +80,7 @@ BITCOIN_TESTS =\ test/rpc_tests.cpp \ test/sanity_tests.cpp \ test/scheduler_tests.cpp \ - test/script_P2SH_tests.cpp \ + test/script_p2sh_tests.cpp \ test/script_P2PK_tests.cpp \ test/script_P2PKH_tests.cpp \ test/script_tests.cpp \ diff --git a/src/bench/Examples.cpp b/src/bench/examples.cpp similarity index 100% rename from src/bench/Examples.cpp rename to src/bench/examples.cpp diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 53b682a7a8..13f53213b5 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -836,7 +836,7 @@ size_t GetRequestedObjectCount(NodeId nodeId) } // This function is used for testing the stale tip eviction logic, see -// DoS_tests.cpp +// denialofservice_tests.cpp void UpdateLastBlockAnnounceTime(NodeId node, int64_t time_in_seconds) { LOCK(cs_main); diff --git a/src/test/DoS_tests.cpp b/src/test/denialofservice_tests.cpp similarity index 99% rename from src/test/DoS_tests.cpp rename to src/test/denialofservice_tests.cpp index 6481b5520a..aa8cbf448b 100644 --- a/src/test/DoS_tests.cpp +++ b/src/test/denialofservice_tests.cpp @@ -45,7 +45,7 @@ static NodeId id = 0; void UpdateLastBlockAnnounceTime(NodeId node, int64_t time_in_seconds); -BOOST_FIXTURE_TEST_SUITE(DoS_tests, TestingSetup) +BOOST_FIXTURE_TEST_SUITE(denialofservice_tests, TestingSetup) // Test eviction of an outbound peer whose chain never advances // Mock a node connection, and use mocktime to simulate a peer diff --git a/src/test/script_P2SH_tests.cpp b/src/test/script_p2sh_tests.cpp similarity index 99% rename from src/test/script_P2SH_tests.cpp rename to src/test/script_p2sh_tests.cpp index 1a368e1932..86069db0ff 100644 --- a/src/test/script_P2SH_tests.cpp +++ b/src/test/script_p2sh_tests.cpp @@ -46,7 +46,7 @@ Verify(const CScript& scriptSig, const CScript& scriptPubKey, bool fStrict, Scri } -BOOST_FIXTURE_TEST_SUITE(script_P2SH_tests, BasicTestingSetup) +BOOST_FIXTURE_TEST_SUITE(script_p2sh_tests, BasicTestingSetup) BOOST_AUTO_TEST_CASE(sign) {