sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 04:22:55 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: remove size_t usage in spentindex structs

Browse Source 
the size of size_t is platform-dependent, (de)serialization is done
assuming the the value is 32 bits. changed to uint32_t as index value
cannot be less than zero.
This commit is contained in:
Kittywhiskers Van Gogh 2023-09-13 22:58:06 +05:30
parent 6a5e74eff4
commit fc2d193d07
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/spentindex.h
View File

@ -170,14 +170,14 @@ public:
uint8_t m_address_type{AddressType::UNKNOWN}; uint8_t m_address_type{AddressType::UNKNOWN};
uint160 m_address_bytes; uint160 m_address_bytes;
uint256 m_tx_hash; uint256 m_tx_hash;
size_t m_tx_index{0}; uint32_t m_tx_index{0};
public: public:
CAddressUnspentKey() { CAddressUnspentKey() {
SetNull(); SetNull();
} }
CAddressUnspentKey(uint8_t address_type, uint160 address_bytes, uint256 tx_hash, size_t tx_index) : CAddressUnspentKey(uint8_t address_type, uint160 address_bytes, uint256 tx_hash, uint32_t tx_index) :
m_address_type{address_type}, m_address_bytes{address_bytes}, m_tx_hash{tx_hash}, m_tx_index{tx_index} {}; m_address_type{address_type}, m_address_bytes{address_bytes}, m_tx_hash{tx_hash}, m_tx_index{tx_index} {};
void SetNull() { void SetNull() {
@ -247,7 +247,7 @@ public:
int32_t m_block_height{0}; int32_t m_block_height{0};
uint32_t m_block_tx_pos{0}; uint32_t m_block_tx_pos{0};
uint256 m_tx_hash; uint256 m_tx_hash;
size_t m_tx_index{0}; uint32_t m_tx_index{0};
bool m_tx_spent{false}; bool m_tx_spent{false};
public: public:
@ -256,7 +256,7 @@ public:
} }
CAddressIndexKey(uint8_t address_type, uint160 address_bytes, int32_t block_height, uint32_t block_tx_pos, uint256 tx_hash, CAddressIndexKey(uint8_t address_type, uint160 address_bytes, int32_t block_height, uint32_t block_tx_pos, uint256 tx_hash,
size_t tx_index, bool tx_spent) : uint32_t tx_index, bool tx_spent) :
m_address_type{address_type}, m_address_type{address_type},
m_address_bytes{address_bytes}, m_address_bytes{address_bytes},
m_block_height{block_height}, m_block_height{block_height},