UdjinM6
58cfeaf321
fix(dkg): let masternodes miss few connection attempts before considering them "bad" ( #4907 )
...
* fix(dkg): let masternodes miss few connection attempts before considering them "bad"
Should help with dashd updates/restarts for nodes that were successfully probed recently.
* fix
2022-07-07 10:49:34 +03:00
UdjinM6
320edd5575
fix(net): Let MNs accept conections as soon as blockchain is synced ( #4905 )
...
Do not wait for governance data, it's not needed for DKGs
2022-07-07 00:25:02 +03:00
UdjinM6
40486ada82
feat(llmq): avoid probing mns too often instead of using a tiny window to probe them ( #4904 )
...
We only call AddQuorumProbeConnections when a new quorum is intialized. It's possible to miss the 10 minute probe window if Contribute phase takes too long (when 2 blocks were mined in 10+ minutes). 50 minutes should be enough and probing once in 10 minutes should be safe.
2022-07-07 00:24:34 +03:00
Kittywhiskers Van Gogh
5715842187
merge bitcoin#21349: Fix fuzz-cuckoocache cross-compiling for Windows with DEBUG=1
2022-07-07 01:01:32 +05:30
Kittywhiskers Van Gogh
d016ccd065
merge bitcoin#18565: Add fuzzing harnesses for classes/functions in checkqueue.h and cuckoocache.h. Add fuzzing coverage.
2022-07-06 22:14:04 +05:30
Kittywhiskers Van Gogh
ee7e37ae01
merge bitcoin#18455: Add fuzzing harness for functions/classes in flatfile.h, merkleblock.h, random.h, serialize.h and span.h
2022-07-06 22:13:37 +05:30
Kittywhiskers Van Gogh
1b424f6b3b
merge bitcoin#18407: Add proof-of-work fuzzing harness
2022-07-06 22:13:37 +05:30
Kittywhiskers Van Gogh
7a954b8bd7
merge bitcoin#18423: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing
2022-07-06 22:13:37 +05:30
Kittywhiskers Van Gogh
f319ddbe85
merge bitcoin#18176: Add fuzzing harness for CScript and CScriptNum operations
2022-07-06 22:13:37 +05:30
Kittywhiskers Van Gogh
26ea6762d3
merge bitcoin#18529: Add fuzzer version of randomized prevector test
2022-07-06 22:13:37 +05:30
Kittywhiskers Van Gogh
1552a1e9dc
merge bitcoin#18521: Add process_messages harness
2022-07-06 22:13:37 +05:30
Kittywhiskers Van Gogh
6ee033b2da
merge bitcoin#18417: Add fuzzing harnesses for functions in addrdb.h, net_permissions.h and timedata.h
2022-07-06 22:13:36 +05:30
Kittywhiskers Van Gogh
ab8822c184
merge bitcoin#18353: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions
2022-07-06 21:48:11 +05:30
Kittywhiskers Van Gogh
d807cc7a8a
merge bitcoin#17926: Add key_io fuzzing harness. Fuzz additional functions in existing fuzzing harnesses
2022-07-06 21:48:10 +05:30
UdjinM6
22262137a2
Merge pull request #4900 from UdjinM6/followup_4880
...
fix(qt): fix crashes introduced by 15937 and 19099 backports
2022-07-05 17:36:56 +03:00
PastaPastaPasta
87b6d1c958
Merge pull request #4830 from kittywhiskers/auxiliary_ports
...
backport: bitcoin#15141, #15437 , #16240 , #18923 , #19219 , #19277 , #20016 , #20671 (auxiliary backports)
2022-07-03 12:13:11 -05:00
UdjinM6
8755067a32
feat(qt): Make wallet repair options only available when there is a single loaded wallet only
...
Also fixes a crash for `-nowallet` introduced via 15937 backport (in 4880)
2022-07-03 11:01:19 +03:00
MarcoFalke
867b6efe4d
Merge bitcoin-core/gui#102 : Fix SplashScreen crash when run with -disablewallet
...
c056064a4a93be3601a63b37afea41f8b878df79 gui: Fix SplashScreen crash when run with -disablewallet (Hennadii Stepanov)
Pull request description:
This PR fixes the bug introduced in https://github.com/bitcoin/bitcoin/pull/19099 :
```
$ src/qt/bitcoin-qt -disablewallet
bitcoin-qt: interfaces/node.cpp:236: auto interfaces::(anonymous namespace)::NodeImpl::walletClient()::(anonymous class)::operator()() const: Assertion `"m_context->wallet_client" && check' failed.
Aborted (core dumped)
```
ACKs for top commit:
Sjors:
tACK c056064
promag:
ACK c056064a4a93be3601a63b37afea41f8b878df79.
Tree-SHA512: 263d9efd5899cc6e447dfc5142bf911ca627149fac0a1c5e5b58dd196aa5e0d12fe13e3f750fb5f3c4338222f7959935d2f77391263f967dbca2e0e79a416a29
2022-07-03 11:00:20 +03:00
Kittywhiskers Van Gogh
af2984b2ae
merge bitcoin#18923: Never schedule MaybeCompactWalletDB when -flushwallet is off
...
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2022-07-03 00:14:47 +05:30
Kittywhiskers Van Gogh
9e50d3a159
merge bitcoin#16240: JSONRPCRequest-aware RPCHelpMan
2022-07-03 00:14:47 +05:30
Kittywhiskers Van Gogh
21f5405e4a
merge bitcoin#19277: Add Assert identity function
2022-07-03 00:14:47 +05:30
Kittywhiskers Van Gogh
e235d834da
merge bitcoin#20671: Replace boost::optional with std::optional
2022-07-03 00:14:47 +05:30
UdjinM6
ef8cf4bfea
Merge pull request #4741 from kittywhiskers/ci2
...
backport: bitcoin#16597, #17176 , #14794 , #17205 , #17240 , #17367 , #18862 , #21405 (ci reworking: part 2)
2022-07-02 21:27:26 +03:00
Kittywhiskers Van Gogh
c8a5fa207d
merge bitcoin#20016: 1 is a constant
2022-07-02 23:47:42 +05:30
Kittywhiskers Van Gogh
51eac2a5d7
llmq: remove unused variable "hash" from Unserialize
2022-07-02 23:47:42 +05:30
Kittywhiskers Van Gogh
281569adaa
test: remove global assignment patch used for args definition in qt tests
2022-07-02 23:47:42 +05:30
Kittywhiskers Van Gogh
93a01604c3
refactor: define a UINT256_ONE global constant
...
Borrowed from https://github.com/bitcoin/bitcoin/pull/17261 , commit 4977c30d59
2022-07-02 23:47:42 +05:30
Kittywhiskers Van Gogh
d2d7febd0e
fuzz: sort ENABLE_FUZZ block alphabetically to avoid merge conflicts
2022-07-02 23:47:42 +05:30
UdjinM6
14402a1b34
fix(llmq): Fix quorum commitments requirement conditions ( #4899 )
...
Wasn't really requiring other commitments for rotation quorums once a single commitment was mined
2022-07-02 21:02:42 +03:00
UdjinM6
44d095b59c
Merge pull request #4880 from PastaPastaPasta/backports-19754
...
backport: 19754 and necessary pre-reqs
2022-07-02 21:01:26 +03:00
PastaPastaPasta
9021e3a314
merge #19754 : wallet, gui: Reload previously loaded wallets on startup
...
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2022-07-01 15:53:24 -05:00
UdjinM6
7a7144012c
ci: align TEST_RUNNER_EXTRA with INTEGRATION_TESTS_ARGS
...
Also, drop FUNCTIONAL_TESTS_CONFIG
2022-07-01 09:04:01 +05:30
Kittywhiskers Van Gogh
c52992aaa4
ci: reconcile differences between ci setups
2022-07-01 09:04:01 +05:30
Kittywhiskers Van Gogh
eb52580c0b
ci: remove redundant "release" build fulfilled by qt
2022-07-01 09:02:53 +05:30
Kittywhiskers Van Gogh
a2be837a40
ci: rename variables to be more similar to bitcoin's styling
2022-07-01 09:02:53 +05:30
Kittywhiskers Van Gogh
94786b9f75
merge bitcoin#21405: remove memcpy -> memmove backwards compatibility alias
2022-07-01 09:02:38 +05:30
Kittywhiskers Van Gogh
959518fdfd
merge bitcoin#18862: Remove fdelt_chk back-compat code and sanity check
2022-07-01 09:02:38 +05:30
Kittywhiskers Van Gogh
6b69c6c5cf
merge bitcoin#17367: Run non-cross-compile builds natively
2022-07-01 09:02:37 +05:30
Kittywhiskers Van Gogh
afe11fff56
merge bitcoin#17240: Disable functional tests on mac host
2022-07-01 09:00:52 +05:30
Kittywhiskers Van Gogh
8652b2ca1e
merge bitcoin#17205: Enable address sanitizer (ASan) stack-use-after-return checking
2022-07-01 09:00:52 +05:30
Kittywhiskers Van Gogh
469e959682
rename all references of TRAVIS_BUILD_DIR to BASE_BUILD_DIR
2022-07-01 09:00:41 +05:30
Kittywhiskers Van Gogh
e22b5b7a5f
merge bitcoin#14794: Add AddressSanitizer (ASan) Travis build
2022-07-01 09:00:41 +05:30
Kittywhiskers Van Gogh
e5b015988f
merge bitcoin#17176: Cleanup macOS runs
2022-07-01 08:59:38 +05:30
Kittywhiskers Van Gogh
b19b30ba9c
merge bitcoin#16597: run full test suite on native macOS
2022-07-01 08:59:07 +05:30
UdjinM6
def2e98d61
Merge pull request #4898 from PastaPastaPasta/backport-18530
...
Merge #18530 : Add test for -blocksonly and -whitelistforcerelay param interaction
2022-06-30 22:06:15 +03:00
PastaPastaPasta
d89de3a2fa
Merge pull request #4866 from Munkybooty/backports-0.20-pr4
...
Backports 0.20 pr4
2022-06-30 10:08:59 -05:00
MarcoFalke
4d6f0cd2f2
Merge #18530 : Add test for -blocksonly and -whitelistforcerelay param interaction
...
0ea5d70b4756f376342417e0019490233cb4a918 Updated comment for the condition where a transaction relay is denied (glowang)
be01449cc8eb7bb97531a967f5d1dcc7b8865d1e Add test for param interaction b/w -blocksonly and -whitelistforcerelay (glowang)
Pull request description:
Related to: #18428
When -blocksonly is turned on, a node would still relay transactions from whitelisted peers. This funcitonality has not been tested.
ACKs for top commit:
MarcoFalke:
ACK 0ea5d70b4756f376342417e0019490233cb4a918
Tree-SHA512: 4e99c88281cb518cc67f5f3be7171a7b413933047b5d24a04bb3ff2210a82e914d69079f64cd5bac9206ec435e21a622c8e69cedbc2ccb39d2328ac5c01668e5
2022-06-29 10:14:58 -05:00
UdjinM6
24205ccce9
Merge pull request #4897 from PastaPastaPasta/backport/v18-llmq-fixes
...
Backport: v18 llmq fixes
2022-06-29 04:13:44 +03:00
pasta
7c8ce7019a
chore: bump to rc7
2022-06-28 19:19:54 -05:00
UdjinM6
9b0222a01a
llmq: Various fixes and improvements ( #4890 )
...
* feat(llmq): Introduce useRotation in LLMQParams
* fix(llmq): Fix IsQuorumRotationEnabled to recognize all dip0024 quorums
* fix(llmq): Do not allow rotation llmqs for `-llmqinstantsend` and non-rotation ones for `-llmqinstantsenddip0024`
* fix(llmq): Unify and fix IsMiningPhase
NOTE: no need for 1 extra block in mining phase for rotation quorums
* chore(llmq): Reduce the number of IsQuorumRotationEnabled calls
* chore(llmq): Improve logging
* feat(llmq): Make `llmq-` threads for rotation quorums distinguishable by quorum index
* fix(llmq): Fix another endless loop in GetQuorumRelayMembers
* throw an error when a llmq type with an incompatible rotation flag is picked for `-llmq...` params
* Add a note about loop conditions
* llmq: Make TransactionRemovedFromMempool the last action for invalid txes, just like we do for orphans with rejected parents
Write to log, send reject msg and (maybe) punish first and only then notify IS about the tx removal. Makes it easier to reason about it when reading logs.
2022-06-28 19:19:03 -05:00
