Jeff Garzik
309aa76d27
Merge pull request #4599
2014-08-29 15:23:13 -04:00
Wladimir J. van der Laan
faeb341da3
Merge pull request #4777
...
8bdd287
Fix a few "Uninitialized scalar field" warnings (Wladimir J. van der Laan)
2014-08-29 10:53:47 +02:00
Wladimir J. van der Laan
3ed668dbe2
Merge pull request #4772
...
87d9819
fix comments ExtractAddress() -> ExtractDestination() (jtimon)
2014-08-28 18:14:03 +02:00
Wladimir J. van der Laan
8bdd2877c4
Fix a few "Uninitialized scalar field" warnings
...
Fix a few warnings reported by Coverity.
None of these is critical, but making sure that class fields are
initialized can avoid heisenbugs.
2014-08-28 15:30:50 +02:00
Jeff Garzik
11a899445e
qt/splashscreen: #include version.h
...
Needed to build breakage reported by Arnavion on IRC:
qt/splashscreen.cpp: In constructor 'SplashScreen::SplashScreen(const QPixmap&, Qt::WindowFlags, bool)':
qt/splashscreen.cpp:33:98: error: 'FormatFullVersion' was not declared in this scope
2014-08-27 22:39:01 -04:00
jtimon
87d9819d4d
fix comments ExtractAddress() -> ExtractDestination()
2014-08-28 01:54:45 +02:00
Wladimir J. van der Laan
d2d6f708e4
Fix build with DEBUG_LOCKORDER
...
Fixes #4771
2014-08-28 01:52:22 +02:00
Pieter Wuille
d1062e32fa
Merge pull request #4377
...
654871d
replace ComputeMinWork with CheckMinWork (jtimon)
b343c1a
Move CBlockIndex::GetBlockWork() to pow::GetProofIncrement(nBits) (jtimon)
c2c02f3
Move UpdateTime to pow (jtimon)
2014-08-27 22:39:28 +02:00
Pieter Wuille
cd3d80be67
Merge pull request #4764
...
92bb6f2
Bypass reloading blocks from disk (Pieter Wuille)
2014-08-27 22:21:33 +02:00
Wladimir J. van der Laan
70352e11c0
Revert "Add a getutxos command to the p2p protocol. It allows querying of the UTXO set"
...
This reverts commit da2ec100f3
.
2014-08-27 18:04:29 +02:00
Wladimir J. van der Laan
f30801afbd
qt: Add null check in setClientModel(0)
...
Don't clear tray icon menu if it was never created.
Necessary precaution after #4649 .
2014-08-26 17:59:57 +02:00
Wladimir J. van der Laan
d49b0876a4
Merge pull request #4673
...
1c5f0af
[Qt] Add column Watch-only to transactions list (Cozz Lovan)
939ed97
Add boolean HaveWatchonly and signal NotifyWatchonlyChanged (Cozz Lovan)
2014-08-26 17:41:33 +02:00
Wladimir J. van der Laan
b9bd6282c5
Merge pull request #4649
...
b197bf3
[Qt] disable tray interactions when client model set to 0 (Philip Kaufmann)
314fbd9
[Qt] use BitcoinGUI::DEFAULT_WALLET constant in bitcoin.cpp (Philip Kaufmann)
8ca6a16
[Qt] ensure all class attributes are init to 0 (Philip Kaufmann)
2014-08-26 17:39:16 +02:00
Pieter Wuille
3da58b216b
Merge pull request #4748
...
ad49c25
Split up util.cpp/h (Wladimir J. van der Laan)
f841aa2
Move `COIN` and `CENT` to core.h (Wladimir J. van der Laan)
6e5fd00
Move `*Version()` functions to version.h/cpp (Wladimir J. van der Laan)
b4aa769
Move `S_I*` constants and `MSG_NOSIGNAL` to compat.h (Wladimir J. van der Laan)
af8297c
Move functions in wallet.h to implementation file (Wladimir J. van der Laan)
651480c
move functions in main and net to implementation files (Wladimir J. van der Laan)
610a8c0
Move SetThreadPriority implementation to util.cpp instead of the header (Wladimir J. van der Laan)
f780e65
Remove unused function `ByteReverse` from util.h (Wladimir J. van der Laan)
121d6ad
Remove unused `alignup` function from util.h (Wladimir J. van der Laan)
d1e26d4
Move CMedianFilter to timedata.cpp (Wladimir J. van der Laan)
2014-08-26 16:57:05 +02:00
Pieter Wuille
727298cef3
Merge pull request #4763
...
aa41ac2
Test IsPushOnly() with invalid push (Peter Todd)
2014-08-26 16:50:17 +02:00
Wladimir J. van der Laan
ad49c256c3
Split up util.cpp/h
...
Split up util.cpp/h into:
- string utilities (hex, base32, base64): no internal dependencies, no dependency on boost (apart from foreach)
- money utilities (parsesmoney, formatmoney)
- time utilities (gettime*, sleep, format date):
- and the rest (logging, argument parsing, config file parsing)
The latter is basically the environment and OS handling,
and is stripped of all utility functions, so we may want to
rename it to something else than util.cpp/h for clarity (Matt suggested
osinterface).
Breaks dependency of sha256.cpp on all the things pulled in by util.
2014-08-26 13:25:22 +02:00
Wladimir J. van der Laan
f841aa2892
Move COIN
and CENT
to core.h
...
Eventually these should end up in `money.h` after monetary
amounts are typedef'ed, but at least they don't belong in `util.h`.
2014-08-26 13:25:22 +02:00
Wladimir J. van der Laan
6e5fd003e0
Move *Version()
functions to version.h/cpp
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
b4aa769bcb
Move S_I*
constants and MSG_NOSIGNAL
to compat.h
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
af8297c010
Move functions in wallet.h to implementation file
...
Breaks compile-time dependency of wallet.h on util.
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
651480c8e4
move functions in main and net to implementation files
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
610a8c0759
Move SetThreadPriority implementation to util.cpp instead of the header
...
Put the THREAD_* and PRIO_ constants in compat.h.
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
f780e65ac6
Remove unused function ByteReverse
from util.h
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
121d6ad9db
Remove unused alignup
function from util.h
2014-08-26 13:25:21 +02:00
Wladimir J. van der Laan
d1e26d4e71
Move CMedianFilter to timedata.cpp
...
Now that we no longer use the median filter to keep track of
the number of blocks of peers, that's the only place it is used.
2014-08-26 13:25:20 +02:00
Daniel Kraft
d0867acb0e
Use const CCoinsView's at some places.
...
At some places where it is possible (e. g., CheckInputs), use a const
version of CCoinsView instead of a non-const one.
2014-08-26 11:29:18 +02:00
Daniel Kraft
a3dc587a62
Make appropriate getter-routines "const" in CCoinsView.
...
Mark the "Get"/"Have" routines in CCoinsView and subclasses as "const".
2014-08-26 11:29:18 +02:00
Daniel Kraft
ffb4c210bc
Mark LevelDB "Read" and "Exists" functions as const.
...
Mark the "Read" and "Exists" functions in CLevelDBWrapper as "const".
They do not change anything in the DB, by definition.
2014-08-26 11:26:58 +02:00
Pieter Wuille
92bb6f2f17
Bypass reloading blocks from disk
2014-08-26 02:26:41 +02:00
Wladimir J. van der Laan
49f954f154
Merge pull request #4716
...
0d27dad
Clean-up SyncWithWallets/SyncTransaction (Cozz Lovan)
2014-08-25 15:04:28 +02:00
Wladimir J. van der Laan
26f3a05cf1
Merge pull request #4654
...
c4a7709
Fixes ignored qt 4.8 codecs path on windows when configuring with --with-qt-libdir (ntrgn)
2014-08-25 13:44:41 +02:00
Wladimir J. van der Laan
11270ebde4
Merge pull request #4351
...
da2ec10
Add a getutxos command to the p2p protocol. It allows querying of the UTXO set given a set of outpoints. (Mike Hearn)
2014-08-25 10:37:40 +02:00
Peter Todd
aa41ac216e
Test IsPushOnly() with invalid push
2014-08-24 21:16:51 -04:00
Pieter Wuille
fff7455ded
Make CScript::clear() release its memory
2014-08-24 02:08:33 +02:00
Pieter Wuille
b0875eb3fe
Allow BatchWrite to destroy its input, reducing copying
2014-08-24 02:08:33 +02:00
Pieter Wuille
5cd00bc8cb
Merge pull request #4618
...
eb0b56b
Simplify serialize.h's exception handling (Pieter Wuille)
2014-08-24 02:06:09 +02:00
Jeff Garzik
57fe1eaadc
Merge pull request #4632
2014-08-23 12:59:55 -04:00
jtimon
654871d436
replace ComputeMinWork with CheckMinWork
2014-08-23 13:21:51 +02:00
jtimon
b343c1a1e3
Move CBlockIndex::GetBlockWork() to pow::GetProofIncrement(nBits)
2014-08-23 13:21:51 +02:00
jtimon
c2c02f3fa9
Move UpdateTime to pow
2014-08-23 13:21:50 +02:00
Wladimir J. van der Laan
92b3d3630d
Merge pull request #4718
...
88fe88c
gui: remove redundant numTransactions tracking (Wladimir J. van der Laan)
2014-08-23 09:30:47 +02:00
Jeff Garzik
fac54dcb71
Merge pull request #4733
2014-08-22 10:35:39 -04:00
Wladimir J. van der Laan
93ed3d9b4e
Merge pull request #4735
...
3802224
Remove all other print() methods (Wladimir J. van der Laan)
9b6d4c5
Move strprintf define to tinyformat.h (Wladimir J. van der Laan)
8121258
Remove print() from core functions (Wladimir J. van der Laan)
2014-08-21 16:05:47 +02:00
Wladimir J. van der Laan
56953925db
Merge pull request #4706
...
8695a39
replace int with size_t in stream methods (Kamil Domanski)
2014-08-21 08:51:19 +02:00
Jeff Garzik
9c31174992
Merge pull request #4744
2014-08-20 23:16:21 -04:00
Jeff Garzik
7f836c66bd
rpc_tests: use BOOST_CHECK_EQUAL
...
Upon failure, BOOST_CHECK_EQUAL provides additional diagnostic information,
displaying that data that failed to match.
2014-08-20 22:43:36 -04:00
Wladimir J. van der Laan
3802224110
Remove all other print() methods
...
All unused.
2014-08-20 20:54:27 +02:00
Wladimir J. van der Laan
9b6d4c5cdc
Move strprintf define to tinyformat.h
...
This avoids a dependency on util.h if just tinyformat is needed.
2014-08-20 10:51:18 +02:00
Wladimir J. van der Laan
81212588c0
Remove print() from core functions
...
Break dependency on util.
2014-08-20 10:43:47 +02:00
Jeff Garzik
dc271fc025
UniValue tests: use more BOOST_CHECK()
2014-08-20 01:09:21 -04:00