Alex Morcos
68d4282774
Fix calculation of balances and available coins.
...
No longer consider coins which aren't in our mempool.
Add test for regression in abandonconflict.py
2016-03-18 09:56:30 -04:00
BtcDrak
12c89c9185
Policy: allow transaction version 2 relay policy.
...
This commit introduces a way to gracefully bump the default
transaction version in a two step process.
2016-03-18 08:09:06 +00:00
BtcDrak
02c2435802
Soft fork logic for BIP68
2016-03-18 08:09:06 +00:00
BtcDrak
478fba6d52
Soft fork logic for BIP113
2016-03-18 08:09:06 +00:00
Pieter Wuille
65751a3cf2
Add CHECKSEQUENCEVERIFY softfork through BIP9
2016-03-18 08:09:06 +00:00
João Barbosa
0f176927f8
Improve COutPoint less operator
2016-03-18 08:03:55 +00:00
Wladimir J. van der Laan
73b7eb501e
Merge #7575 : Minimal BIP9 implementation
...
8c74ced7870deb532cbb2d23f6c6732e7746851107
2016-03-18 08:50:43 +01:00
MarcoFalke
faf756ae4e
[amount] Make GetFee() monotonic
...
This reverts the hard-to-read and buggy code introduced in
d88af56011
2016-03-17 17:00:45 +01:00
MarcoFalke
fab6880494
[qa] Add amount tests
2016-03-17 16:59:37 +01:00
Wladimir J. van der Laan
f034bced26
Merge #7686 : [qt] Remove 0-fee from send dialog
...
fae8467fa48bb3
2016-03-17 16:21:56 +01:00
MarcoFalke
fae8467d41
[qt] Remove unneeded "fSendFreeTransactions" check
2016-03-17 14:48:12 +01:00
Wladimir J. van der Laan
01f4267623
Merge #7594 : Mempool: Add tracking of ancestor packages
...
ce019bfe2eeb5d72abd2c76a76325de2baa7659438
2016-03-17 13:33:54 +01:00
Wladimir J. van der Laan
14d6324a24
Merge #7187 : Keep reorgs fast for SequenceLocks checks
...
982670c
2016-03-16 21:20:04 +01:00
Alex Morcos
982670c333
Add LockPoints
...
Obtain LockPoints to store in CTxMemPoolEntry and during a reorg, evaluate whether they are still valid and if not, recalculate them.
2016-03-16 16:11:46 -04:00
Wladimir J. van der Laan
3d0dfdbf9f
Merge #7684 : [qa] Extend tests
...
fad8cfbfa8cd46fad7dc8fa3a81a
2016-03-16 17:32:05 +01:00
Suhas Daftuar
7870debceb
Test versionbits deployments
2016-03-15 16:54:39 +01:00
Suhas Daftuar
532cbb22b5
Add testing of ComputeBlockVersion
2016-03-15 16:54:39 +01:00
Pieter Wuille
d23f6c6a0d
Softfork status report in RPC
2016-03-15 16:54:38 +01:00
Pieter Wuille
732e774c06
Versionbits tests
2016-03-15 16:54:38 +01:00
Pieter Wuille
6851107b3a
BIP9 Implementation
...
Inspired by former implementations by Eric Lombrozo and Rusty Russell, and
based on code by Jorge Timon.
2016-03-15 16:54:38 +01:00
Wladimir J. van der Laan
a6a860796a
Merge #7621 : Fixes ZMQ startup with bad arguments.
...
0040118
2016-03-15 09:29:58 +01:00
MarcoFalke
fa48bb3148
[qt] Remove 0-fee from send dialog
2016-03-14 18:32:09 +01:00
Suhas Daftuar
ce019bf90f
Check all ancestor state in CTxMemPool::check()
2016-03-14 12:13:34 -04:00
Suhas Daftuar
e2eeb5dda7
Add ancestor feerate index to mempool
2016-03-14 12:13:34 -04:00
Suhas Daftuar
72abd2ce3c
Add ancestor tracking to mempool
...
This implements caching of ancestor state to each mempool entry, similar to
descendant tracking, but also including caching sigops-with-ancestors (as that
metric will be helpful to future code that implements better transaction
selection in CreatenewBlock).
2016-03-14 12:13:33 -04:00
Suhas Daftuar
76a76321d2
Remove work limit in UpdateForDescendants()
...
The work limit served to prevent the descendant walking algorithm from doing
too much work by marking the parent transaction as dirty. However to implement
ancestor tracking, it's not possible to similarly mark those descendant
transactions as dirty without having to calculate them to begin with.
This commit removes the work limit altogether. With appropriate
chain limits (-limitdescendantcount) the concern about doing too much
work inside this function should be mitigated.
2016-03-14 12:13:31 -04:00
Suhas Daftuar
5de2baa138
Rename CTxMemPool::remove -> removeRecursive
...
remove is no longer called non-recursively, so simplify the logic
and eliminate an unnecessary parameter
2016-03-14 12:11:09 -04:00
Suhas Daftuar
7659438a63
CTxMemPool::removeForBlock now uses RemoveStaged
2016-03-14 12:11:08 -04:00
Jonas Schnelli
3d7e97376a
Fix torcontrol.cpp unused private field warning
2016-03-14 16:07:42 +01:00
MarcoFalke
fa3a81af18
[tests] Extend util_ParseMoney test case
2016-03-14 15:49:33 +01:00
Wladimir J. van der Laan
0735c0ca7c
Merge #7608 : [wallet] Move hardcoded file name out of log messages
...
fa19b18
2016-03-14 13:56:23 +01:00
MarcoFalke
fa19b18c63
[wallet] Move hardcoded file name out of log messages
2016-03-14 13:54:05 +01:00
Wladimir J. van der Laan
322a7a2fe0
qt: Remove reflection from about icon
...
While trying to find a black/white version of the Bitcoin
logo for the organization I noticed the about.png is not
entirely black - it has some reflection. Remove this to make
it the same as other icons.
Also ran the icons through `contrib/devtools/optimize-pngs.py`,
so `chevron.png` was optimized too.
2016-03-14 12:46:59 +01:00
Wladimir J. van der Laan
c9a1265754
Merge #7670 : use cached block hash in blockToJSON()
...
a6ee0ca
2016-03-14 12:22:40 +01:00
Wladimir J. van der Laan
c87f51e55b
Merge #7663 : Make the generate RPC call function for non-regtest
...
8a253b3
2016-03-14 11:36:20 +01:00
Wladimir J. van der Laan
11c769966a
Merge #7507 : Remove internal miner
...
8d1de43
2016-03-14 11:35:41 +01:00
Wladimir J. van der Laan
5b3b5a7d71
Merge #7577 : [Wallet] move "load wallet phase" to CWallet
...
15e6e13fc7c60d
2016-03-14 11:34:50 +01:00
Wladimir J. van der Laan
f1ca8915bb
Merge #7517 : test: script_error checking in script_invalid tests
...
0ecb3402317ad7b0ff857
2016-03-14 11:30:06 +01:00
Wladimir J. van der Laan
56d2c4e0fe
Merge #7667 : Move GetTempPath() to testutil
...
2fdaa25393b22e
2016-03-14 11:26:52 +01:00
Jonas Schnelli
15e6e13624
[Wallet] optimize return value of InitLoadWallet()
2016-03-14 09:33:27 +01:00
Jonas Schnelli
b24266c207
Merge #7668 : Fix history deletion bug after font size change
...
21e45a0
2016-03-14 09:24:39 +01:00
Jonas Schnelli
3798e5de33
Merge #7613 : Add autocomplete to bitcoin-qt's console window.
...
ce7413f
2016-03-14 09:20:29 +01:00
Pavel Vasin
a6ee0caa4e
use cached block hash in blockToJSON()
2016-03-12 17:11:59 +03:00
Luv Khemani
ce7413fcb7
Add autocomplete to bitcoin-qt's console window.
...
Removed externs
Added listCommands() to CRPCTable
Move autocomplete init to RPCConsole::setClientModel()
2016-03-12 13:04:23 +08:00
Andrew C
21e45a097e
Fix history deletion bug after font change
...
The history is no longer cleared after the font size is changed
2016-03-11 13:19:19 -05:00
Mustafa
2fdaa25529
Move GetTempPath() to testutil.
2016-03-11 15:04:05 +00:00
Jonas Schnelli
fc7c60d699
[Wallet] move "load wallet phase" to CWallet
2016-03-11 14:31:06 +01:00
Mustafa
393b22eacb
Add a source file for unit test utils.
2016-03-11 12:03:45 +00:00
Wladimir J. van der Laan
86a1ec5b2c
Merge #7576 : [Wallet] move wallet help string creation to CWallet
...
72c2651
2016-03-11 08:40:37 +01:00
Wladimir J. van der Laan
9f14e5ad91
Merge #7553 : Remove vfReachable and modify IsReachable to only use vfLimited.
...
110b62f
2016-03-11 08:25:28 +01:00
Wladimir J. van der Laan
26a2a7214f
Merge #7592 : mempool: Re-remove ERROR logging for mempool rejects
...
8fc81e0
2016-03-11 08:20:42 +01:00
Wladimir J. van der Laan
3da5d1bc2e
Merge #7637 : Fix memleak in TorController [rework]
...
e219503
2016-03-11 08:19:55 +01:00
Pieter Wuille
8a253b342c
Make the generate RPC call function for non-regtest
2016-03-09 22:30:15 +01:00
Pieter Wuille
c8d2473e6c
Merge #7642 : Avoid "Unknown command" messages when receiving getaddr on outbound c…
...
9988554
2016-03-09 21:52:17 +01:00
Pavel Vasin
7d2f84c72f
remove unused NOBLKS_VERSION_{START,END} constants
2016-03-09 19:29:23 +03:00
João Barbosa
3252208cb1
Improve EncodeBase58 performance
2016-03-09 10:10:36 +00:00
João Barbosa
d6cc6a1830
Use CCoinControl selection in CWallet::FundTransaction
2016-03-08 15:14:47 +00:00
Jonas Schnelli
87d6562299
Merge #7628 : QT: Add 'copy full transaction details' option
...
b51ed40
2016-03-08 10:15:22 +01:00
R E Broadley
9988554fc7
No "Unknown command" for getaddr command.
2016-03-08 08:49:42 +00:00
Eric Shaw
b51ed4036e
QT: Add 'copy full transaction details' option
...
Adds feature from issue #7484
modifies the ctrl-c binding to copy full transaction details in transaction view.
Added translation
2016-03-07 19:50:57 -05:00
Jonas Schnelli
72c2651581
[Wallet] move wallet help string creation to CWallet
2016-03-05 13:27:04 -05:00
Pieter Wuille
9f33dba05c
Merge #7539 : Add tags to mempool's mapTx indices
...
086da92
2016-03-05 06:56:33 +01:00
Wladimir J. van der Laan
3368895c3b
Merge #7521 : Don't resend wallet txs that aren't in our own mempool
...
5a2b1c0
2016-03-03 15:09:50 +01:00
Wladimir J. van der Laan
7f001bdf64
Merge #7605 : Remove openssl info from init/log and from Qt debug window
...
5ecfa36 Remove openssl info from init/log and from Qt debug window (Jonas Schnelli)
2016-03-03 13:55:56 +01:00
Wladimir J. van der Laan
e219503711
Fix memleak in TorController [rework]
...
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().
Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).
Replaces the fix by Jonas Schnelli in #7610 , see discussion there.
2016-03-03 13:31:26 +01:00
Wladimir J. van der Laan
e5121eb951
Merge #7617 : [doc/log] Fix markdown syntax and line terminate LogPrint
...
fa26652fa97f95fa06ce0
2016-03-01 18:39:21 +01:00
MarcoFalke
fa26652459
Make sure LogPrintf strings are line-terminated
2016-03-01 14:59:30 +01:00
mrbandrews
0040118959
Fixes ZMQ startup with bad arguments.
2016-02-29 13:34:09 -05:00
Wladimir J. van der Laan
78e81b0bc5
Merge #7537 : wallet: Warn on unexpected EOF while salvaging wallet
...
ca8fb59
2016-02-29 10:05:07 +01:00
MarcoFalke
fa06ce0949
Fix doxygen comment for payTxFee
2016-02-27 18:14:57 +01:00
Jonas Schnelli
5ecfa36fd0
Remove openssl info from init/log and from Qt debug window
2016-02-26 09:35:39 +01:00
Wladimir J. van der Laan
8fc81e0983
mempool: Reduce ERROR logging for mempool rejects
...
Continues "Make logging for validation optional" from #6519 .
The idea there was to remove all ERROR logging of rejected transaction,
and move it to one message in the class 'mempoolrej' which logs the
state message (and debug info). The superfluous ERRORs in the log
"terrify" users, see for example issue #5794 .
Unfortunately a lot of new logging was introduced in #6871 (RBF) and
#7287 (misc refactoring). This pull updates that new code.
2016-02-24 19:40:29 +01:00
Wladimir J. van der Laan
8b958ab15b
Merge #7550 : rpc: Input-from-stdin mode for bitcoin-cli
...
f22f14c92bcca3
2016-02-24 11:33:25 +01:00
Wladimir J. van der Laan
92bcca37ab
rpc: Input-from-stdin mode for bitcoin-cli
...
Implements #7442 by adding an option `-stdin` which reads
additional arguments from stdin, one per line.
For example
```bash
echo -e "mysecretcode\n120" | src/bitcoin-cli -stdin walletpassphrase
echo -e "walletpassphrase\nmysecretcode\n120" | src/bitcoin-cli -stdin
```
2016-02-24 10:12:25 +01:00
Matthew Zipkin
7eef1d0dad
Clarify description of blockindex
...
see issues:
https://github.com/bitcoin-dot-org/bitcoin.org/issues/1237
https://github.com/bitcoin/bitcoin/issues/7532
2016-02-18 12:42:59 -08:00
Patrick Strateman
110b62f069
Remove vfReachable and modify IsReachable to only use vfLimited.
...
We do not know that a class of Network is reachable, only that it is not.
2016-02-17 23:21:27 -08:00
Suhas Daftuar
086da92ea7
Add tags to mempool's mapTx indices
2016-02-16 12:35:16 -05:00
Wladimir J. van der Laan
8b70a64d62
Merge #7526 : fix spelling of advertise (shows up in the debug log)
...
37767fd
2016-02-16 12:37:03 +01:00
Wladimir J. van der Laan
93c85d458a
Merge #7524 : BIP-112: Mempool-only CHECKSEQUENCEVERIFY
...
a381076c3c375253e53a3
2016-02-16 10:46:34 +01:00
BtcDrak
a38107643f
Code style fix.
...
This if statement is a little obtuse and using braces here
improves readability.
2016-02-16 09:39:44 +00:00
Wladimir J. van der Laan
2d4f73f47e
Merge #7509 : Common argument defaults for NODE_BLOOM stuff and -wallet
...
1fb91b3
2016-02-16 10:00:21 +01:00
Wladimir J. van der Laan
ce5fc02e61
Merge #7536 : test: test leading spaces for ParseHex
...
f31b6b8
2016-02-16 09:26:53 +01:00
Wladimir J. van der Laan
19324cf09c
Merge #7504 : Crystal clean make clean
...
ae6eca0
2016-02-15 17:18:41 +01:00
Wladimir J. van der Laan
f31b6b8995
test: test leading space for ParseHex
...
BerkeleyDB dump files have key and value lines indented.
The salvage code passes these to ParseHex as-is.
Check this in the tests (should just pass with current code).
2016-02-15 17:14:30 +01:00
Wladimir J. van der Laan
ca8fb59ae1
wallet: Warn on unexpected EOF while salvaging wallet
...
Check for EOF before every getline, and warn when reading gets to EOF
before the end of the data.
Stricter error checking could shed more light on issues such as #7463
and #7379 .
2016-02-15 16:35:12 +01:00
BtcDrak
c3c375226e
Separate CheckLockTime() and CheckSequence() logic
...
For the sake of a little repetition, make code more readable.
2016-02-14 11:29:40 +00:00
Mark Friedenbach
53e53a33c9
BIP112: Implement CHECKSEQUENCEVERIFY
...
- Replace NOP3 with CHECKSEQUENCEVERIFY (BIP112)
<nSequence> CHECKSEQUENCEVERIFY -> <nSequence>
- Fails if txin.nSequence < nSequence, allowing funds of a txout to be locked for a number of blocks or a duration of time after its inclusion in a block.
- Pull most of CheckLockTime() out into VerifyLockTime(), a local function that will be reused for CheckSequence()
- Add bitwise AND operator to CScriptNum
- Enable CHECKSEQUENCEVERIFY as a standard script verify flag
- Transactions that fail CSV verification will be rejected from the mempool, making it easy to test the feature. However blocks containing "invalid" CSV-using transactions will still be accepted; this is *not* the soft-fork required to actually enable CSV for production use.
2016-02-14 11:29:38 +00:00
jloughry
37767fd46f
fix spelling of advertise in src and doc
2016-02-12 12:51:54 -07:00
instagibbs
c372572595
Fix and cleanup listreceivedbyX documentation
2016-02-12 14:06:59 -05:00
Wladimir J. van der Laan
80d1f2e483
Merge #7184 : Implement SequenceLocks functions for BIP 68
...
b043c4ba51c79bda6ad5fc6c2f0f
2016-02-12 17:03:46 +01:00
Wladimir J. van der Laan
621940e040
Merge #7520 : LibreSSL doesn't define OPENSSL_VERSION, use LIBRESSL_VERSION_TEXT instead
...
a0a17b3
2016-02-12 13:06:02 +01:00
Pavel Janík
a0a17b3e44
LibreSSL doesn't define OPENSSL_VERSION, use LIBRESSL_VERSION_TEXT instead
2016-02-12 07:01:33 +01:00
Alex Morcos
5a2b1c0c8b
Don't resend wallet txs that aren't in our own mempool
2016-02-11 17:34:55 -05:00
Alex Morcos
b043c4b746
fix sdaftuar's nits again
...
it boggles the mind why these nits can't be delivered on a more timely basis
2016-02-11 15:34:04 -05:00
Wladimir J. van der Laan
0ecb3401fe
test: Script_error checking in script_invalid tests
...
Check the returned script_error. Add expected script_error
for generated as well as custom tests.
The specific error is not part of consensus, however
it could avoid unclear reporting issues such as #6862 in the future.
Fixes #7513 .
2016-02-11 17:33:28 +01:00
Wladimir J. van der Laan
2317ad7c56
test: Re-introduce JSON pretty printing in test builder
2016-02-11 17:33:28 +01:00
Wladimir J. van der Laan
b0ff8572ae
test: Move non-generated script_invalid test to the correct place
...
This test was introduced in 9fadf1c874
2016-02-11 16:16:40 +01:00
Luke Dashjr
1fb91b3496
Common argument defaults for NODE_BLOOM stuff and -wallet
2016-02-11 06:38:04 +00:00
Leviathn
8d1de43f0c
Remove internal miner
...
This code removes the internal miner which is only useful on Testnet.
This leaves the internal miner that is useful on RegTest intact.
2016-02-10 18:29:13 -08:00
Alex Morcos
c6c2f0fd78
Implement SequenceLocks functions
...
SequenceLocks functions are used to evaluate sequence lock times or heights per BIP 68.
The majority of this code is copied from maaku in #6312
Further credit: btcdrak, sipa, NicolasDorier
2016-02-10 15:35:33 -05:00
