Gregory Maxwell
5b0150a060
Make orphan parent fetching ask for witnesses.
...
In 0.13 orphan transactions began being treated as implicit
INVs for their parents. But the resulting getdata were
not getting the witness flag.
This fixes issue #9182 reported by chjj and roasbeef on IRC.
2016-11-18 19:11:08 +00:00
Pieter Wuille
9346f84299
Merge #9075 : Decouple peer-processing-logic from block-connection-logic ( #3 )
...
ae22357
Replace CValidationState param in ProcessNewBlock with BlockChecked (Matt Corallo)
7c98ce5
Remove pfrom parameter from ProcessNewBlock (Matt Corallo)
e2e069d
Revert "RPC: Give more details when "generate" fails" (Matt Corallo)
2016-11-17 13:23:50 -08:00
Wladimir J. van der Laan
f6db48ad1c
Merge #8838 : Calculate size and weight of block correctly in CreateNewBlock()
...
5f274a1
log block size and weight correctly. (jnewbery)
2016-11-17 14:14:51 +01:00
MarcoFalke
cb2ed300a8
Merge #9155 : [trivial] update comments for tx weight
...
07ede5d
update comments for tx weight (Brian Deery)
2016-11-16 11:05:40 +01:00
Wladimir J. van der Laan
434e683f7b
Merge #9133 : Unset fImporting for loading mempool
...
79f755d
Unset fImporting for loading mempool (Alex Morcos)
2016-11-16 10:11:41 +01:00
Wladimir J. van der Laan
62af164638
Merge #9131 : fNetworkActive is not protected by a lock, use an atomic
...
079142b
fNetworkActive is not protected by a lock, use an atomic (Jonas Schnelli)
2016-11-16 10:09:52 +01:00
Pieter Wuille
6eeac6e30d
Merge #9164 : [trivial] credit values are CAmount
...
20c3215
credit values are CAmount (Gregory Sanders)
2016-11-15 09:44:07 -08:00
Gregory Sanders
20c3215a90
credit values are CAmount
2016-11-15 09:19:23 -05:00
Wladimir J. van der Laan
018a4eb120
Merge #9140 : Bugfix: Correctly replace generated headers and fail cleanly
...
b74ff5c
Bugfix: Correctly replace generated headers and fail cleanly (Luke Dashjr)
2016-11-15 10:34:56 +01:00
Wladimir J. van der Laan
f54e4605fc
Merge #9132 : Make strWalletFile const
...
f734505
Make strWalletFile const (Jonas Schnelli)
2016-11-15 10:06:01 +01:00
Wladimir J. van der Laan
770364b8ea
Merge #9160 : [trivial] Fix hungarian variable name
...
ec34648
[trivial] Fix hungarian variable name (Russell Yanofsky)
2016-11-15 09:52:14 +01:00
Russell Yanofsky
ec34648766
[trivial] Fix hungarian variable name
...
Follow up to comment https://github.com/bitcoin/bitcoin/pull/9058#discussion_r87676593
2016-11-14 14:02:24 -05:00
Brian Deery
07ede5d711
update comments for tx weight
2016-11-14 00:38:07 -06:00
MarcoFalke
fa42e4a082
[qt] Make network disabled icon 50% opaque
2016-11-13 22:06:35 +01:00
Luke Dashjr
b74ff5cf0c
Bugfix: Correctly replace generated headers and fail cleanly
...
Also removes generation of headers for *.raw files in test_bitcoin (none exist anymore)
2016-11-12 07:16:28 +00:00
Alex Morcos
79f755db41
Unset fImporting for loading mempool
2016-11-11 09:33:16 -05:00
Jonas Schnelli
f7345050e9
Make strWalletFile const
2016-11-11 14:32:38 +01:00
Jonas Schnelli
079142b757
fNetworkActive is not protected by a lock, use an atomic
2016-11-11 14:09:52 +01:00
Wladimir J. van der Laan
87ab49e4fe
Merge #9124 : Use better name for local variable to prevent -Wshadow compiler warning
...
bf49f10
Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
2016-11-11 11:46:49 +01:00
Jonas Schnelli
ab914a6530
Merge #8996 : Network activity toggle
...
19f46f1
Qt: New network_disabled icon (Luke Dashjr)
54cf997
RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr)
b2b33d9
Overhaul network activity toggle (Jonas Schnelli)
32efa79
Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen)
e38993b
RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen)
7c9a98a
Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
2016-11-11 11:16:40 +01:00
Wladimir J. van der Laan
7977a1157a
Merge #9058 : Fixes for p2p-compactblocks.py test timeouts on travis ( #8842 )
...
dac53b5
Modify getblocktxn handler not to drop requests for old blocks (Russell Yanofsky)
55bfddc
[qa] Fix stale data bug in test_compactblocks_not_at_tip (Russell Yanofsky)
47e9659
[qa] Fix bug in compactblocks v2 merge (Russell Yanofsky)
2016-11-11 11:02:44 +01:00
Wladimir J. van der Laan
46027e8668
Merge #9112 : Avoid ugly exception in log on unknown inv type
...
e9f25dd
Avoid ugly exception in log on unknown inv type (Wladimir J. van der Laan)
2016-11-11 10:58:58 +01:00
Pavel Janík
bf49f107ef
Use better name for local variable to prevent -Wshadow compiler warning
2016-11-10 21:38:07 +01:00
Wladimir J. van der Laan
71bc39eb74
Merge #9049 : Remove duplicatable duplicate-input check from CheckTransaction
...
e2b3fb3
Optimize vInOutPoints insertion a bit (Matt Corallo)
eecffe5
Remove redundant duplicate-input check from CheckTransaction (Matt Corallo)
b2e178a
Add deserialize + CheckBlock benchmarks, and a full block hex (Matt Corallo)
2016-11-10 16:02:55 +01:00
MarcoFalke
4a2b170c07
Merge #9122 : fix getnettotals RPC description about timemillis.
...
a79f864 fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
2016-11-10 11:05:59 +01:00
Wladimir J. van der Laan
aab102cbae
Merge #9121 : Initialize variable to prevent compiler warning
...
bdcba6d
Initialize variable to prevent compiler warning (Pavel Janík)
2016-11-10 10:35:07 +01:00
Wladimir J. van der Laan
537e0cb252
Merge #9120 : bug: Missed one "return false" in recent refactoring in #9067
...
45d372f
Missed one "return false" in recent refactoring in #9067 (UdjinM6)
2016-11-10 10:30:54 +01:00
Masahiko Hyuga
a79f864945
fix getnettotals RPC description about timemillis.
2016-11-10 18:18:52 +09:00
Pavel Janík
bdcba6d933
Initialize variable to prevent compiler warning
2016-11-10 08:11:51 +01:00
UdjinM6
45d372f889
Missed one "return false" in recent refactoring in #9067
2016-11-10 00:53:55 +03:00
Wladimir J. van der Laan
fb156100f9
Merge #9111 : Remove unused variable UNLIKELY_PCT from fees.h
...
d8edf03
Remove unused var UNLIKELY_PCT from fees.h (fanquake)
2016-11-09 21:54:56 +01:00
Matt Corallo
e2b3fb349e
Optimize vInOutPoints insertion a bit
2016-11-09 11:28:41 -08:00
Matt Corallo
eecffe50ef
Remove redundant duplicate-input check from CheckTransaction
2016-11-09 11:28:00 -08:00
Matt Corallo
b2e178a2d2
Add deserialize + CheckBlock benchmarks, and a full block hex
2016-11-09 11:27:59 -08:00
Matt Corallo
ae22357607
Replace CValidationState param in ProcessNewBlock with BlockChecked
2016-11-09 11:21:55 -08:00
Matt Corallo
7c98ce584e
Remove pfrom parameter from ProcessNewBlock
...
This further decouples ProcessNewBlock from networking/peer logic.
2016-11-09 11:21:45 -08:00
Wladimir J. van der Laan
e81df49644
Merge #9039 : Various serialization simplifcations and optimizations
...
d59a518
Use fixed preallocation instead of costly GetSerializeSize (Pieter Wuille)
25a211a
Add optimized CSizeComputer serializers (Pieter Wuille)
a2929a2
Make CSerAction's ForRead() constexpr (Pieter Wuille)
a603925
Avoid -Wshadow errors (Pieter Wuille)
5284721
Get rid of nType and nVersion (Pieter Wuille)
657e05a
Make GetSerializeSize a wrapper on top of CSizeComputer (Pieter Wuille)
fad9b66
Make nType and nVersion private and sometimes const (Pieter Wuille)
c2c5d42
Make streams' read and write return void (Pieter Wuille)
50e8a9c
Remove unused ReadVersion and WriteVersion (Pieter Wuille)
2016-11-09 13:52:04 +01:00
Wladimir J. van der Laan
e9f25ddd00
Avoid ugly exception in log on unknown inv type
...
It is unexpected behavior for `ToString` to raise an exception. It
is expected to do a best-effort attempt at formatting but never fail.
Catch the exception and simply print unknown inv types as hexadecimal.
Fixes #9110 .
2016-11-09 11:16:39 +01:00
Wladimir J. van der Laan
e9847303e7
Merge #8874 : Multiple Selection for peer and ban tables
...
1077577
Fix auto-deselection of peers (Andrew Chow)
addfdeb
Multiple Selection for peer and ban tables (Andrew Chow)
2016-11-09 11:05:15 +01:00
fanquake
d8edf03db7
Remove unused var UNLIKELY_PCT from fees.h
2016-11-09 17:51:27 +08:00
Matt Corallo
e2e069dabc
Revert "RPC: Give more details when "generate" fails"
...
This only returned information in the case of CheckBlock failure,
but breaks future changes.
2016-11-08 17:39:44 -08:00
Andrew Chow
1077577546
Fix auto-deselection of peers
2016-11-08 15:11:25 -05:00
Jorge Timón
1adf82ac39
RPC: Give more details when "generate" fails
2016-11-08 15:08:56 +01:00
Andrew Chow
addfdebe1a
Multiple Selection for peer and ban tables
...
Allows multiple selection and action for the nodes in the peer and ban tables in the Debug Window.
2016-11-08 08:50:04 -05:00
Wladimir J. van der Laan
4e5782438c
Merge #9088 : Reduce ambiguity of warning message
...
77cbbd9
Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)
2016-11-08 11:05:08 +01:00
Wladimir J. van der Laan
f53023dbb8
Merge #9067 : Fix exit codes
...
4441018
Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers (UdjinM6)
bd0de13
Fix exit codes: - `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error) - error reading config file should exit with `1` (UdjinM6)
2016-11-08 10:55:03 +01:00
Jonas Schnelli
b8f43e3331
Merge #9095 : test: Fix test_random includes
...
fa8278e
test: Fix test_random includes (MarcoFalke)
2016-11-08 08:41:57 +01:00
Pieter Wuille
dc6b9406bd
Merge #9026 : Fix handling of invalid compact blocks
...
d4833ff
Bump the protocol version to distinguish new banning behavior. (Suhas Daftuar)
88c3549
Fix compact block handling to not ban if block is invalid (Suhas Daftuar)
c93beac
[qa] Test that invalid compactblocks don't result in ban (Suhas Daftuar)
2016-11-07 18:11:18 -08:00
Pieter Wuille
9f554e03eb
Merge #9045 : Hash P2P messages as they are received instead of at process-time
...
fe1dc62
Hash P2P messages as they are received instead of at process-time (Matt Corallo)
2016-11-07 14:19:44 -08:00
Pieter Wuille
d59a518466
Use fixed preallocation instead of costly GetSerializeSize
...
Dbwrapper used GetSerializeSize() to compute the size of the buffer
to preallocate. For some cases (specifically: CCoins) this requires
a costly compression call. Avoid this by just using fixed size
preallocations instead.
2016-11-07 13:56:27 -08:00