1110 Commits

Author	SHA1	Message	Date
Wladimir J. van der Laan	91cc5488af	Merge #16634: doc: Refer in rpcbind doc to the manpage ... fa0119af226255ce1e0e573a575ab37539ff8693 doc: Refer in rpcbind doc to the manpage (MarcoFalke) Pull request description: The help was outdated, so refer to the updated manpage instead. * closes #14740 * closes #9272 ACKs for top commit: emilengler: Concept ACK fa0119a laanwj: ACK fa0119af226255ce1e0e573a575ab37539ff8693 fanquake: ACK fa0119af226255ce1e0e573a575ab37539ff8693 Tree-SHA512: 9836e4f31ece7acae334b47e3104b4595d0d1c1977af386a9463faf49aea9de3ab1c1dc3de248d0ee09e3b13693eaf6902dc82d277062e1bb1980b1117236fbb	2021-07-12 18:42:39 -05:00
fanquake	184c0e0f8f	Merge #16201: devtools: Always use unabbreviated commit IDs in github-merge.py ... 067fba563 devtools: Always use unabbreviated commit IDs in github-merge.py (Wladimir J. van der Laan) Pull request description: Always put the unabbreviated commit IDs in the generated commit messages and other places. This prevents the developer's `core.abbrev` git setting from leaking through and is better against ambiguity too. ACKs for commit 067fba: MarcoFalke: ACK 067fba56314f399674dd471c663e663040be52a3 (replaces `h` with `H`, didn't test) promag: ACK 067fba56314f399674dd471c663e663040be52a3, from the documentation https://git-scm.com/docs/pretty-formats: fanquake: ACK 067fba5631. Tested by merging this PR into master, then merging a second PR ontop and checking that full commit hashes were being used. Also checked documentation linked to above. Did not check that this works when a different `core.abbrev` is set locally. Tree-SHA512: a851d10490cd8bcd8bca29094b08a6b9f883cfe1b0767ccda7ca789e4c8eff6260a4d82c33cb3d9bab01dd30ac8c9100cb7adbcb1911bb399d9385c1e1f15ecd	2021-07-12 17:11:12 -05:00
MarcoFalke	0de37c265a	Merge #16143: tests: Mark unit test blockfilter_index_initial_sync as non-deterministic ... c061be1e2f tests: Mark unit test blockfilter_index_initial_sync as non-deterministic (practicalswift) Pull request description: Mark unit test `blockfilter_index_tests/blockfilter_index_initial_sync` as non-deterministic. Before this PR: ``` $ contrib/devtools/test_deterministic_coverage.sh 500 [2019-06-04 09:58:57] Measuring coverage, run #1 of 500 [2019-06-04 10:00:33] Measuring coverage, run #2 of 500 [2019-06-04 10:02:19] Measuring coverage, run #3 of 500 The line coverage is non-deterministic between runs. Exiting. The test suite must be deterministic in the sense that the set of lines executed at least once must be identical between runs. This is a necessary condition for meaningful coverage measuring. --- gcovr.run-1.txt 2019-06-04 10:00:33.389059973 +0000 +++ gcovr.run-3.txt 2019-06-04 10:03:45.619491207 +0000 @@ -72,7 +72,7 @@ hash.h 54 33 61% 71,74-77,82,85-89,111,113,128,147-148,175,178-181 httprpc.cpp 120 3 2% 31,34-35,38-40,46,49,52,54,56,58,70,73-74,76,78-79,81,83-84,89,91,94-95,97,99-101,103,106-107,111-112,117-119,121-122,125,128,130,132,134-136,138-139,142,145,148,151-153,156-160,163-166,171,173-175,180-182,185,187,189-190,192,195,198-199,201,203-204,212,215,217,219-222,224,227-228,230,232,237,239-240,243-245,247-251,254,256,259,261-264,266-267 [* 205-206,208-209] httpserver.cpp 312 6 1% 46,49-50,53,55,80-81,90,92-93,96-98,101,104,106-109,111-112,114,118,120-122,126,128-129,153,155,157-158,164,166-178,180,182,184-188,192,194-196,198-199,201-202,204-205,207-208,213,216-221,225,228-232,236-239,243-244,247-254,256-258,264-267,270-271,274,279,281-282,286,288-290,292-293,297,299-300,303-307,309-310,312-317,322-328,330,332,335,339,341-342,346,352-353,355,358,360,364,368-369,375,378,381-384,388-391,393-394,398-400,402,404-406,409,411-412,414,416,426,428-431,433-434,438,440-441,443,445-446,449,451-455,457-459,463-464,466-469,471-473,475-477,479,482,484,487,490-493,496-497,499-500,502,504,506,508-509,511,513-514,517,519,521-522,527,529-533,535,538,540-543,550-555,558,560-562,570,572-574,577-582,585-590,594-597,600,602-604,606-609,611,614,616,619,621,625-626,628-629,631-632,634-635,640,642-643,646,648-651,653,655-656 -index/base.cpp 149 94 63% 20,22-25,28,66,98,102-103,117-118,140-141,145-146,155,163,175,177-178,181-182,184-185,200-201,203,212,214-215,219-221,228-229,234,236,240,243-244,247-249,258-260,262,270,292-294,308-309 [* 263] +index/base.cpp 149 97 65% 20,22-25,28,66,98,102-103,117-118,140-141,145-146,155,163,175,177-178,181-182,184-185,200-201,203,212,214-215,219-221,228-229,234,236,240,243-244,247-249,258-260,262,270,308-309 [* 263] index/base.h 3 2 66% 77 index/blockfilterindex.cpp 199 134 67% 70,79,81,84-88,91,122,139,142,179-181,184-185,188-189,193-194,201-202,207,233,258,262-263,265-266,268,271-272,274,277,279,284,286,288-289,294,301-302,304,322,329,332-333,350,371,373,438,440-441,444,446,449,455-456,459,461,464,466 [* 162-163] index/blockfilterindex.h 4 4 100% @@ -358,7 +358,7 @@ util/validation.cpp 5 1 20% 12,15-17 validation.cpp 2167 808 37% 291,293,297-300,302,330,332,340,348,355-357,359,362,364-365,368,371,380,382-383,385-386,388-389,396,398-402,406-413,415,417,419,422-425,439-440,442-443,446,449,455-458,461-464,467,469-470,472,474,476,492,494-495,502-503,505-507,511-513,515,517,523,526,528,533,535,540,542-544,550,552-556,558-560,564,574,578-583,586,590-591,594-596,601-602,607-608,611-612,616-617,619-621,635-636,638,640,647-648,651,657-658,660-662,665-667,673,675,677-678,682-683,690,693,700-701,703-705,709-710,713-714,716,719-720,724-727,733-735,737-739,741-743,747-748,751-752,754,757-764,771,773-774,776-779,785-788,793-794,796-800,815-816,818-822,825,827,830,835,838-839,841-843,846-848,850,853,859,864-867,875,877-879,884-885,887-891,895,899-900,904-906,908-909,911,930-931,933,936,942,944-950,952,959,962,965-968,972,978,982-984,990-991,994-996,999,1003-1004,1011,1013,1015-1019,1022-1023,1026-1032,1056,1065,1079,1091,1108,1112,1114-1118,1125,1127-1130,1133-1135,1138-1139,1147,1149,1151-1152,1155,1197,1199-1201,1206-1209,1211-1212,1226,1230,1232-1234,1236,1238-1241,1245-1246,1256,1258,1260-1262,1264-1266,1268,1278-1280,1282-1283,1286,1289,1291-1292,1294-1302,1305-1311,1319-1323,1330,1332-1333,1336-1339,1379,1383-1384,1395,1401,1405-1407,1411-1414,1423-1428,1438-1440,1451,1455,1458,1471,1480,1497,1503,1519,1525,1527-1530,1532-1533,1536,1538-1539,1549,1551,1553,1555,1559-1562,1571,1573,1578,1580,1582-1584,1588-1589,1594-1597,1601-1606,1613-1616,1619-1623,1630,1632,1635,1637,1639-1640,1642-1646,1658,1660,1675,1688,1711,1713-1715,1742,1755,1760,1765,1769,1811,1815,1817,1841-1845,1855,1942,1946-1947,1956,1984-1986,1991-1992,1994,1996-1999,2005-2007,2010-2012,2022-2023,2028-2031,2038-2039,2042,2044,2049,2058-2061,2064,2114-2115,2117-2118,2120-2124,2152-2153,2156,2159-2163,2165-2169,2171-2172,2176-2178,2187-2188,2191-2194,2199,2207-2211,2215-2220,2224,2227-2230,2235,2237-2238,2261-2263,2265,2274,2278,2286,2301,2303-2304,2306-2309,2311,2313-2318,2320,2322,2325,2327-2328,2330,2332-2334,2338,2340,2343-2344,2407-2410,2430,2445-2447,2507-2509,2511-2514,2518,2520-2521,2523-2524,2561,2564,2590,2592-2593,2595-2598,2603,2620,2626,2658,2719,2724,2773,2776-2777,2779,2781,2783,2785-2788,2791,2793-2795,2799,2801-2802,2805,2807-2809,2813,2816,2818-2821,2825-2826,2832-2834,2841-2845,2848,2854,2858-2859,2861,2865-2868,2872-2875,2880,2884-2885,2890-2891,2894-2895,2897,2900-2906,2908,2910,2912,2918-2922,2924,2928-2929,2940,3002-3005,3009-3010,3026-3028,3036-3037,3039-3040,3045,3053,3056,3077,3080,3090,3112,3118,3129,3133,3135-3136,3141-3142,3150,3190-3193,3259,3268,3273,3277,3282-3285,3303,3314,3321-3324,3338-3341,3345-3346,3348-3350,3360,3372,3392,3397,3403,3406,3408,3435-3441,3443,3468-3469,3485,3487-3488,3492-3493,3534-3536,3542,3547-3549,3552,3565-3566,3601-3602,3610,3628,3630,3632,3645,3647,3649-3651,3653,3657,3659,3661-3669,3675-3680,3686-3687,3691,3693-3697,3702,3704,3706-3708,3711-3718,3720,3724,3726-3729,3748,3750-3752,3754,3758-3759,3763,3765,3767,3772,3774,3777-3778,3780-3781,3783,3787-3788,3790,3792-3794,3798-3800,3823,3825,3828,3830,3832,3836-3838,3841-3843,3845,3848,3850,3854-3856,3858-3859,3861-3862,3864-3867,3870-3873,3875-3876,3879,3882-3883,3886-3893,3899,3901,3905-3909,3911-3915,3922-3924,3926-3928,3931,3933-3934,3940-3942,3945-3947,3952,3954-3955,3957,3960-3961,3964,3966,3968-3972,3975,3977,3980,3982,3985,3987-3988,3992-3996,3998-4006,4008-4009,4011-4012,4014,4016,4019,4021-4022,4024-4026,4028-4032,4037-4041,4043-4045,4047,4050,4053-4054,4057,4060-4064,4066-4067,4069-4075,4079-4080,4086,4089-4091,4094-4097,4101,4106,4108,4110,4112-4114,4116-4117,4119,4121,4123-4124,4126,4128-4130,4132-4134,4138-4142,4144-4147,4154,4158-4163,4166-4169,4172-4173,4177,4179-4180,4183,4185,4187-4189,4191-4193,4195,4197-4201,4207-4208,4212,4220-4223,4230,4232-4233,4237,4240,4243,4247,4249,4251,4253-4255,4265-4266,4277,4279,4282,4285-4287,4292-4293,4296,4298,4302,4305-4306,4310-4311,4315-4318,4360,4363-4367,4370,4377,4397,4412,4415-4416,4418,4421-4422,4424,4426-4429,4433-4437,4439-4441,4448-4452,4454-4456,4458,4460,4462-4467,4471-4475,4477,4480-4481,4486-4488,4493,4496-4503,4505,4507-4511,4513-4514,4517-4519,4529-4531,4546,4600,4638-4639,4647,4653,4662-4664,4696,4703-4704,4718,4720,4723,4725,4727,4730,4732-4733,4736,4738-4739,4742,4744-4745,4750,4752-4757,4761-4765,4769-4770,4774-4776,4779-4781,4783-4785,4787-4790,4793-4794,4800-4801,4803,4807,4809-4810,4812-4813,4815-4816,4823,4827,4829,4831-4832,4834-4835,4838-4840,4842,4845,4848-4849,4853,4855-4856,4858-4863,4866-4872,4877,4891,4907 [* 1085-1086,1140-1141,1513-1514,2201-2202,2428,3569-3570,4400-4401,4442,4453,4504,4522-4523,4526-4527,4818-4819,4873-4874] validation.h 19 5 26% 338,350-352,356-363,366,484 -validationinterface.cpp 81 50 61% 78-82,85-86,112-113,116,119-120,123-124,126-128,130,133-136,151-153,163-165,169-171 +validationinterface.cpp 83 60 72% 78-82,85-86,112-113,116,133-136,151-153,163-165,169-171 validationinterface.h 9 4 44% 94,105,112,118,135 versionbits.cpp 92 27 29% 33,35-36,38-39,48-50,52-54,56-57,61-62,67-71,73,75-76,80,82-83,91,98,100,102-103,105,109-110,113-118,121-122,124,127,129-130,134,137,141,149,151,153-155,159,177,179,184,194,196,199,201,204,206 [* 26] versionbits.h 1 1 100% @@ -400,5 +400,5 @@ zmq/zmqpublishnotifier.h 5 0 0% 12,31,37,43,49 zmq/zmqrpc.cpp 23 3 13% 16,18,20,23,33-35,37,40-47,51,62,64-65 ------------------------------------------------------------------------------ -TOTAL 52472 7784 14% +TOTAL 52474 7797 14% ------------------------------------------------------------------------------ $ ``` After this PR: ``` $ contrib/devtools/test_deterministic_coverage.sh 500 [2019-06-03 14:45:25] Measuring coverage, run #1 of 500 [2019-06-03 14:48:15] Measuring coverage, run #2 of 500 [2019-06-03 14:50:49] Measuring coverage, run #3 of 500 [2019-06-03 14:52:20] Measuring coverage, run #4 of 500 [2019-06-03 14:53:49] Measuring coverage, run #5 of 500 … [2019-06-04 09:04:58] Measuring coverage, run #496 of 500 [2019-06-04 09:07:42] Measuring coverage, run #497 of 500 [2019-06-04 09:10:32] Measuring coverage, run #498 of 500 [2019-06-04 09:13:26] Measuring coverage, run #499 of 500 [2019-06-04 09:16:32] Measuring coverage, run #500 of 500 Coverage test passed: Deterministic coverage across 500 runs. $ ``` ACKs for commit c061be: Tree-SHA512: 00cd55b4371290d8587ab667c64249bc31d26cc9dc3dd519677eb91ddb9dbc5333dfbdef5e90c7a0d74eecd24757113e7ec3eda836859ddc033b1de715df81b6	2021-07-12 17:11:12 -05:00
Wladimir J. van der Laan	876a5075fe	Merge #16162: scripts: add key for Michael Ford (fanquake) to trusted keys list ... 8081927c33299e82498a85ac773c9f162e69ecaf scripts: add key for fanquake to trusted keys list (fanquake) Pull request description: Adding my key to the [trusted keys list](https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys) to join the maintainer group. I'll gain merge access and will continue with all triage/repo management work. I'll be focusing primarily on build system development with some guidance from theuni. Some maintainer related discussion from the Core Dev meetup in Amsterdam is available [here](http://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2019-06-06-maintainers/). ACKs for commit 808192: MarcoFalke: ACK 8081927c33299e82498a85ac773c9f162e69ecaf laanwj: ACK, this matches the key I have 8081927c33299e82498a85ac773c9f162e69ecaf: meshcollider: ACK, this matches the key I have from the CoreDev New York 2018 keysigning party 8081927c33 IlyasRidhuan: ACK. 8081927c33299e82498a85ac773c9f162e69ecaf matches the key I have. Tree-SHA512: 63c390f5ede316263def2f9a897a1046d4ae58e4ea758f379164c6c5afce4928e2c9463fbcac004742838fd4ac1e48679e7a2a0f9095fd134a900f9064584056	2021-07-12 17:11:12 -05:00
Wladimir J. van der Laan	87800e4bcc	Merge #16130: Don't GPG sign intermediate commits with github-merge tool ... a352d2ae5 Don't GPG sign intermediate commits with github-merge tool (Steven Roose) Pull request description: When you don't have an unencrypted key and you have git configured to always sign all commits, you have to sign three times instead of one. ACKs for commit a352d2: MarcoFalke: utACK a352d2ae5f5e8a0204d49d66ff458a1505609de3 Tree-SHA512: f5a1c0868c42de2b5df45126e1e94b4a7d88b041d179244228bb7b02d43d41f565388eb1052a097ab0666fc6003f8453b9e283801fcb33aef47f412b72ba9fb6	2021-07-12 17:11:12 -05:00
MarcoFalke	4e703d7bbc	Merge #15863: scripts and tools: Ensure repos are up-to-date in gitian-build.py ... feed98e189 Ensure repos are up-to-date (Hennadii Stepanov) Pull request description: These steps are provided by the [release process](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#setup-and-perform-gitian-builds). ACKs for commit feed98: Tree-SHA512: ad6876d211e524cf6b8dbe4f0f026b77792c8ae3b728e1419f17d5679766603d21c057a7866c183794c814b914a9e4584e16fc501bec77af7e3472a34bd4d913	2021-07-12 17:11:08 -05:00
Kittywhiskers Van Gogh	2a5bcecb91	merge #17052: update copyright_header script to include additional files	2021-07-11 13:55:26 +05:30
Kittywhiskers Van Gogh	3ee097114e	merge #16314: Update copyright_header.py script	2021-07-11 13:54:58 +05:30
Kittywhiskers Van Gogh	a2f4e9c74a	merge #14785: Fix detection of copyright holders	2021-07-11 13:53:37 +05:30
UdjinM6	08558d67ee	Merge pull request #4235 from PastaPastaPasta/backport-triv-pr7 ... backport: 'trivial' pr7	2021-07-10 21:46:25 +03:00
MarcoFalke	206c1ed9ba	Merge #15444: [docs] Additional productivity tips ... ff7f31e07d [doc] productivity: more advanced git range-diff (Sjors Provoost) 3a21905a4e [doc] devtools: mention clang-format dependency (Sjors Provoost) bf12093191 [doc] productivity: fix broken link (Sjors Provoost) Pull request description: Fixes a broken link to `devtools/README.md`, points out the `clang-format` dependency and adds a `git range-diff` incantation that works even with rebases and squashes. Tree-SHA512: 36e46282f1e28d1bf3f48ada995fbac548f61b7747091eb032b60919cf76c7bdad0fa8aecb0c47adbdaa9ef986d3ec7752b0bb94c63191401856e2ddeec48f3e	2021-07-10 12:10:51 -05:00
Wladimir J. van der Laan	a33756c72e	Merge #15549: gitian: Improve error handling ... 32da92bdf6bb55d6d312b0f85797d439cc942db5 gitian: Improve error handling (Wladimir J. van der Laan) Pull request description: Improve error handling in gitian builds: - Set fail-on-error and pipefail flag, this causes a command to fail when either of the pipe stages fails, not only when the last of the stages fails, so this improves error detection. - Also use `xargs` instead of `find -exec`, because `find` will not propagate errors in the executed command, but `xargs` will. This will avoid some issues like #15541 where non-determinism is silently introduced due to errors caused by environment conditions (such as lack of disk space in that case). Tree-SHA512: d5d3f22ce2d04a75e5c25e935744327c3adc704c2d303133f2918113573a564dff3d3243d5569a2b93ee7eb0e97f8e1b1ba81767e966af9015ea711a14091035	2021-07-10 12:10:51 -05:00
MarcoFalke	dd2f85c084	Merge #15296: tests: Add script checking for deterministic line coverage in unit tests ... 43206239a8 tests: Add script checking for deterministic line coverage (practicalswift) Pull request description: Add script checking for deterministic line coverage in unit tests. Context: #14343 ("coverage reports non-deterministic") When the coverage is deterministic this script can be invoked from Travis to guard against regressions, but left inactive for now. Output in case of determinism: ``` $ contrib/test_deterministic_coverage.sh 2 [2019-01-30 20:08:46] Measuring coverage, run #1 of 2 [2019-01-30 20:10:45] Measuring coverage, run #2 of 2 Coverage test passed: Deterministic coverage across 2 runs. ``` Output in case of non-determinism: ``` $ contrib/test_deterministic_coverage.sh 2 [2019-01-30 20:08:46] Measuring coverage, run #1 of 2 [2019-01-30 20:10:45] Measuring coverage, run #2 of 2 The line coverage is non-deterministic between runs. The test suite must be deterministic in the sense that the set of lines executed at least once must be identical between runs. This is a neccessary condition for meaningful coverage measuring. --- gcovr.run-1.txt 2019-01-30 23:14:07.419418694 +0100 +++ gcovr.run-2.txt 2019-01-30 23:15:57.998811282 +0100 @@ -471,7 +471,7 @@ test/crypto_tests.cpp 270 270 100% test/cuckoocache_tests.cpp 142 142 100% test/dbwrapper_tests.cpp 148 148 100% -test/denialofservice_tests.cpp 225 225 100% +test/denialofservice_tests.cpp 225 224 99% 363 test/descriptor_tests.cpp 116 116 100% test/fs_tests.cpp 24 3 12% 14,16-17,19-20,23,25-26,29,31-32,35-36,39,41-42,45-46,49,51-52 test/getarg_tests.cpp 111 111 100% @@ -585,5 +585,5 @@ zmq/zmqpublishnotifier.h 5 0 0% 12,31,37,43,49 zmq/zmqrpc.cpp 21 0 0% 16,18,20,22,33-35,38-45,49,52,56,60,62-63 ------------------------------------------------------------------------------ -TOTAL 61561 27606 44% +TOTAL 61561 27605 44% ------------------------------------------------------------------------------ ``` In this case line 363 of `test/denialofservice_tests.cpp` was executed only in the second run. Non-determinism detected! Tree-SHA512: 03f45590e70a87146f89aa7838beeff0925d7fd303697ff03e0e69f8a5861694be5f0dd10cb0020e3e3d40c9cf662f71dfcd838f6affb31bd5212314e0a4e3a9	2021-07-10 12:10:51 -05:00
UdjinM6	90266a9465	Merge pull request #4234 from UdjinM6/backports-0.17-pr35 ... Backports 0.17 pr35	2021-07-10 12:11:49 +03:00
PastaPastaPasta	3bdf9922af	Merge pull request #4223 from Munkybooty/backports-0.18-pr4 ... Backports 0.18 pr4	2021-07-09 12:10:22 -05:00
UdjinM6	637a8a28fe	Merge pull request #4226 from PastaPastaPasta/backport-triv-pr6 ... backport: 'trivial' pr6	2021-07-08 23:25:09 +03:00
MarcoFalke	d6a4bdead4	Merge #13935: contrib: Adjust output to current test format ... a9910d82c3 contrib: Adjust output to current test format (Akio Nakamura) Pull request description: This PR makes the output of ```gen_base58_test_vectors.py``` to fit to current test format. The test has already been changed(separated) from ```base58_test``` to ```key_io_test```, so change the file name of this script as well. (This will solve #13553 ) Tree-SHA512: 2986009acd734edd5b6ee0a5efed9e8d156c99b1919a0e9f6ffdd4c863f52f4d1c6bfdaca359937ea380e311dda559d96449fc6a7224092c1fb2517ee5b83369 # Conflicts: # contrib/testgen/gen_base58_test_vectors.py	2021-07-08 13:09:43 -04:00
Wladimir J. van der Laan	1070f797e6	Merge #14869: scripts: Add trusted key for Samuel Dobson ... 1ca050254145ebbbbf5910bfee2e82a45e465ca1 scripts: Add trusted key for Samuel Dobson (Wladimir J. van der Laan) Pull request description: Add trusted GPG key so that Samuel Dobson (MeshCollider), who is now wallet maintainer, can merge PRs. Tree-SHA512: 6b2ef8ac1c8965eaaf5fc677dbf3bb7109e1f9dd4b56072a3409bcd232d5f1241c4e3d5fe962fcabb32880a4dbc49e5d6fb5e087e535a53f8d5d954d4f10db1b	2021-07-08 11:57:11 -05:00
Wladimir J. van der Laan	50168b66a2	Merge #14848: docs: Fix broken Gmane URL in security-check.py ... af1ed206f Fix broken Gmane URLs (Craig Younkins) Pull request description: This is an automated pull request to fix broken Gmane URLs. Here's what I did: First I searched for Gmane URLs in your repo. For each Gmane URL, I checked if the content was available at the URL. For URLs where the content was not available, I first checked the `article` subdomain of Gmane, which has some content not available on the `thread` and `comments` subdomains. If the content wasn't anywhere on Gmane's web interface, I resolved the URL to a [Message-ID](https://en.wikipedia.org/wiki/Message-ID) via the Gmane NNTP interface and tried to find the Message-ID on other mailing list archivers. I checked `mail-archive.com`, then `marc.info`, then `lists.debian.org` and so on. If a new URL was found, I replaced it in this pull request. If the content wasn't found, I left the link alone. Tree-SHA512: b46258de485a411fc4fbd6b8fb044c30fa062fd3a7ef78c6b8b405802c91283bc5c9f7f8b8c83385f3a12fe39578ea0695efd19ce19f3bb4606fbbd1be894d0e	2021-07-08 11:57:04 -05:00
Wladimir J. van der Laan	7214b034eb	Merge #14128: lint: Make sure we read the command line inputs using utf-8 decoding in python ... 5d62dcf9cfb5c0b2511c10667ed47ec3b3610d72 lint: Make sure we read the command line inputs using utf-8 decoding in python (Chun Kuan Lee) Pull request description: Make sure we read the command line inputs using utf-8 decoding in python occurred from travis cron job: contrib/verify-commits/verify-commits.py should run with utf-8, otherwise it would raise UnicodeDecodeError `UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 744: ordinal not in range(128)` Tree-SHA512: 90e4ad57fdbbbecb0a21fc2d2b03a04f5ef125e54124719ef36e5a85326930b732b47534757a7c3a8730096f3947b009ec898191928b5c2d38f9f4b3e37db48d # Conflicts: # contrib/devtools/optimize-pngs.py	2021-07-07 12:04:53 -04:00
Jonas Schnelli	5582a6796a	Merge #11491: [gui] Add proxy icon in statusbar ... 73cd5b25b [gui] Add proxy icon in statusbar (Cristian Mircea Messel) Pull request description: Relates to #7734  Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :( I plan to extend this feature in future PRs to include: - custom Tor icon - clickable icon which opens network settings Old proposals, dropped in favor of current    Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589	2021-07-06 19:50:27 +03:00
Kittywhiskers Van Gogh	b5db3c3d65	merge #18011: Replace current benchmarking framework with nanobench	2021-07-05 18:28:55 +05:30
PastaPastaPasta	df65bd0238	Merge pull request #4224 from Munkybooty/backports-0.18-pr5 ... Backports 0.18 pr5	2021-07-03 12:33:17 -05:00
Wladimir J. van der Laan	f5a46e294f	Merge #13724: [contrib] Support ARM and RISC-V symbol check ... c516c3a770e93dcd283dc4a9275cba88221d0e3a [contrib] Support ARM and RISC-V symbol check (Chun Kuan Lee) Pull request description: Solve the TODO in the gitian-descripter Tree-SHA512: 8115e2958af3dde43d9d9d05f0b1b1b93b1c2aa513e771a3e4e1342a5d78af2b0e40c0bbb7e9a0d15954897317e6f5a0d80996239af3b376d5ddd527f73428ae # Conflicts: # contrib/devtools/symbol-check.py # contrib/gitian-descriptors/gitian-linux.yml	2021-07-02 11:39:23 -04:00
Wladimir J. van der Laan	a9fb8a57ab	Merge #13482: Remove boost::program_options dependency ... f447a0a7079619f0d650084df192781cca9fd826 Remove program options from build system (Chun Kuan Lee) 11588c639e8912f1b28e981c1a2a0e4306dbd093 Replace boost program_options (Chun Kuan Lee) Pull request description: Concept from #12744, but without parsing negated options. Tree-SHA512: 7f418744bb8934e313d77a5f162633746ef5d043de802b9c9cd9f7c1842e7e566eb5f171cd9e2cc13317281b2449c6fbd553fa4f09b837e6af2f5d2b2aabdca2	2021-07-02 12:59:27 +03:00
pasta	f9a16ff05d	prevent clean / accidental merging of bitcoin#13782 ... Signed-off-by: pasta <pasta@dashboost.org>	2021-07-01 16:33:23 -05:00
Wladimir J. van der Laan	2de80ac210	Merge #14037: Add README.md to linux release tarballs ... 8550f1fb28292a081aab3f49ba2fb561710c4572 Add README.md to linux release tarballs (Hennadii Stepanov) Pull request description: fix #8160 Gitian building report for 0.17.0rc2: ``` 7d89d7dc3488915ec2380253a69fb3b8f8065592e24c5b2a99a91da30f2142cc bitcoin-0.17.0-aarch64-linux-gnu-debug.tar.gz fcb292fd2c4fca88e5cc5a97ee7fa3390d3c7221aada166fe7822d64a2ee9dfa bitcoin-0.17.0-aarch64-linux-gnu.tar.gz 0ec6f979a823a6b6084d2e80605dffd3ccdda359e8459cebec25092c1087348f bitcoin-0.17.0-arm-linux-gnueabihf-debug.tar.gz 45af8757a2315125afe2f4d4f276d9b9cf616b8ab814284ce2f82b9a345971d8 bitcoin-0.17.0-arm-linux-gnueabihf.tar.gz b37b6d9bda864af968dfab6eebb245e75ecc56eb18b139b946270933381ea288 bitcoin-0.17.0-i686-pc-linux-gnu-debug.tar.gz 20c96a5509eeb3e8ec505f18914ef9231beef1fec5e9e1c4b33ec6c6b613d146 bitcoin-0.17.0-i686-pc-linux-gnu.tar.gz d505888594a04dab2b34ccd6863b8f25eb97d9cb76650e39d93f4d6c09d4c55a bitcoin-0.17.0-x86_64-linux-gnu-debug.tar.gz f55b16716c3295e309c816e170911380a5a26e9be3a336b213f2f412f0b159b3 bitcoin-0.17.0-x86_64-linux-gnu.tar.gz 01c6b5ce15b9f3fcdcce96baae14eb04ab2605f2294d333e96b66e004594eea6 src/bitcoin-0.17.0.tar.gz ``` Release tarball content: ``` $ tar -tf bitcoin-binaries/0.17.0rc2/bitcoin-0.17.0-x86_64-linux-gnu.tar.gz bitcoin-0.17.0/ bitcoin-0.17.0/bin/ bitcoin-0.17.0/bin/bitcoin-cli bitcoin-0.17.0/bin/bitcoind bitcoin-0.17.0/bin/bitcoin-qt bitcoin-0.17.0/bin/bitcoin-tx bitcoin-0.17.0/bin/test_bitcoin bitcoin-0.17.0/include/ bitcoin-0.17.0/include/bitcoinconsensus.h bitcoin-0.17.0/lib/ bitcoin-0.17.0/lib/libbitcoinconsensus.so bitcoin-0.17.0/lib/libbitcoinconsensus.so.0 bitcoin-0.17.0/lib/libbitcoinconsensus.so.0.0.0 bitcoin-0.17.0/README.md bitcoin-0.17.0/share/ bitcoin-0.17.0/share/man/ bitcoin-0.17.0/share/man/man1/ bitcoin-0.17.0/share/man/man1/bitcoin-cli.1 bitcoin-0.17.0/share/man/man1/bitcoind.1 bitcoin-0.17.0/share/man/man1/bitcoin-qt.1 bitcoin-0.17.0/share/man/man1/bitcoin-tx.1 ``` Tree-SHA512: 2a0c069d6533502a95a83eaba57b9828bddd03ab4a4fc47027b0068c9f04837f107abc448d82c929aa1f45441d2459cf6f2ad74b97a4d953f66dc81031bd521a	2021-07-01 16:33:23 -05:00
UdjinM6	a29d3d4332	Merge pull request #4218 from PastaPastaPasta/backport-triv-pr1 ... backport: 'trivial' pr3	2021-06-29 02:08:34 +03:00
UdjinM6	d5e432a278	Merge pull request #4215 from PastaPastaPasta/backports-0.18-triv ... backport: 'trivial' pr1	2021-06-29 02:06:27 +03:00
Wladimir J. van der Laan	bb0200bf04	Merge #12852: [doc] devtools: Setup ots git integration ... fa385c3 [doc] devtools: Setup ots git integration (MarcoFalke) Pull request description: Document the simple steps on how to set up ots git integration. Tree-SHA512: 1b9f99bfaa6cd9dc581243d3a3584301645e95450acc3b5898dcdb53849569de16bb8ef2676b18f6b8dd402de10aee80119e15c1b28cef36f17ad121cbba2ba3	2021-06-28 18:03:20 -05:00
MarcoFalke	a8ff3437d3	Merge #15258: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions ... ad5e5a105e Scripts and tools: Drop no-longer-relevant copyright holder names (Ben Woosley) 2434ab5c2a Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions (Ben Woosley) Pull request description: This script compared paths relative to the report directory to test for exclusion, meaning the `EXCLUDE_DIRS` directory exclusions did not work properly, as they were relative to the project root. Fix this by creating absolute paths through the combination of: 'git ls-files --full-name' and 'git rev-parse --show-toplevel' Once this is done, we can stop testing for the names that would otherwise appear when exclusion of leveldb, secp256k1, etc., did not work as intended. Tree-SHA512: 0fa9b0a627e8ddb2d899eedee927ea8a809cb2ceee87c0920c151e5ca2103f7d8c463e3b379d5e2eb925fc3d7d8003082ffd9cbc03907ca0c448e8238e3a2684	2021-06-28 13:40:59 -05:00
Jonas Schnelli	57813fa9a6	Merge #15175: build: Drop macports support ... 4e81438f6 build: Drop macports support (Ben Woosley) Pull request description: It's unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration. Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27	2021-06-28 13:40:56 -05:00
Wladimir J. van der Laan	1f537f32f7	Merge #13374: utils and libraries: checking for bitcoin address in translations ... 85f0135eaefe3d9f696689a7e83606c579da40a8 utils: checking for bitcoin addresses in translations (Max Kaplan) Pull request description: Closes #13363 Tree-SHA512: 8509b4ab004139942c847b93d7b44096a13df8e429dd05459b430a1cf7eaef16c4906ab9dc854f4e635312e1ebb064cfab1bad97fec914c7e926c83ad45cc99b	2021-06-28 02:31:49 +03:00
Wladimir J. van der Laan	8e23a74c36	Merge #13366: Docs: Rename “OS X” to the newer “macOS” convention ... 989c8990bb765eef45c8ee471f084ca81a0bead4 Rename “OS X” to the newer “macOS” convention (Giulio Lombardo) Pull request description: Since 2016, with [macOS 10.12 Sierra](https://en.wikipedia.org/wiki/MacOS_Sierra), Mac OS X has been renamed in macOS. It would be a nice if Bitcoin's macOS build instructions follow this naming convention to avoid misunderstandings. Tree-SHA512: 51b7d54bfc39a1a9d0773c64780817c7beca7094aded80481086287474dfa272bf0a1dfa6ef6e3cae91548aa127f65fa730003dddcb97147cdc8c249146aea22	2021-06-28 02:31:48 +03:00
Wladimir J. van der Laan	afad6f1931	Merge #14416: Fix OSX dmg issue (10.12 to 10.14) ... 43719e0a3411e6a08e04908332cb44adfa00c6a2 [macOS] Remove DS_Store WindowBounds bytes object (Jonas Schnelli) Pull request description: This seems to fix the macOS 10.12+ DMG issue in conjunction with Gitian on Bionic Tree-SHA512: 3cdad7aaebed2eb320015e2053954444b28802a60505225d7f6affdd83c523de8738ecb53a48ba8c30266315716e3782c681208e6e547e94adcac39797139247	2021-05-25 01:05:41 +03:00
dustinface	314844d330	contrib|src: Update hard coded seeds (#4152) ... * contrib: Update IPs in nodes_main.txt and nodes_test.txt Mainnet: 1469339 Testnet: 498026 * src: Update static seeds in chainparamsseeds.h	2021-05-13 12:31:45 +03:00
Wladimir J. van der Laan	c0db4fddf0	Merge #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python ... c8176b3cc7556d7bcec39a55ae4d6ba16453baaa Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python (practicalswift) 634bd970013eca90f4b4c1f9044eec8c97ba62c2 Explicitly specify encoding when opening text files in Python code (practicalswift) Pull request description: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python. As requested by @laanwj in #13440. Tree-SHA512: 1651c00fe220ceb273324abd6703aee504029b96c7ef0e3029145901762c733c9b9d24927da281394fd4681a5bff774336c04eed01fafea997bb32192c334c06	2021-05-06 12:06:09 +03:00
Wladimir J. van der Laan	9dac547275	Merge #13066: Migrate verify-commits script to python, run in travis ... e5b2cd8e7564b9fc2ed4f63fe49efb0af60b4460 Use python instead of slow shell script on verify-commits (Chun Kuan Lee) Pull request description: The cron job that runs every day would fail because of git checkout a single commit, not a branch. #12708 introduce a method to check whether merges are clean. However, there are four merges are not clean. So, I add a list of merges that are dirty and ignore them. Also, I modify the current shell script to python, it makes the script speed up a lot. The python code `tree_sha512sum` was copied from `github-merge.py` I've re-designed this. Now we verify all the things by default. - Add `--disable-tree-check` option, not to check SHA-512 tree - Add `--clean-merge NUMBER` option, only verify commits after &lt;NUMBER> days ago Travis running time: |option|time| |-|-| |verify-commits.py|[25m47.02s(1547.02s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| |verify-commits.py --disable-tree-check|[19m10.08s(1150.08s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| |verify-commits.py --clean-merge 30|[9m18.18s(558.18s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| |verify-commits.py --disable-tree-check --clean-merge 30|[1m16.51s(76.51s)](https://travis-ci.org/ken2812221/bitcoin/jobs/373321423)| Since the cron job always fail, I've created a respository to verify this daily. [](https://travis-ci.org/ken2812221/bitcoin-verify-commits) Tree-SHA512: 476bcf707d92ed3d431ca5642e013036df1506120d3dd2aa718f74240063ce856abd78f4c948336c2a6230dfe5c60c6f2d52d19bdb52d647a1c5f838eaa02e3b	2021-05-06 12:06:09 +03:00
Wladimir J. van der Laan	3637afddf0	Merge #12854: Add P2P, Network, and Qt categories to the desktop icon	2021-04-17 16:22:01 -04:00
dustinface	9c64708269	bls|depends: Upgrade to bls-signatures version 1.0.0 (#4027) ... * build: Add cmake as depends package (cmake.mk) The bls-signatures library requires cmake 3.14 * depends: Update chia_bls to version 1.0.0 of dashpay/bls-signatures * depends: Rename package chia_bls to bls-dash * depends: Disable blspy/tests/benchmarks build for chia_bls Note: Building with tests would require the following: depends: Fix macOS build for versions < 10.12 Seems like older versions of macOS pretend to support c++17 std libs but do not have/have issues with uncaught_exceptions. "Catch", the testing framework used in the bls lib wants those by default but setting `DCATCH_CONFIG_NO_CPP17_UNCAUGHT_EXCEPTIONS` disables them which should be just fine to do in all cases here. --- depends/packages/chia_bls.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/depends/packages/chia_bls.mk b/depends/packages/chia_bls.mk index e79a85844f..25749b74ab 100644 --- a/depends/packages/chia_bls.mk +++ b/depends/packages/chia_bls.mk @@ -28,6 +28,8 @@ define $(package)_set_vars $(package)_config_opts_darwin+= -DCMAKE_AR="$(host_prefix)/native/bin/$($(package)_ar)" $(package)_config_opts_darwin+= -DCMAKE_RANLIB="$(host_prefix)/native/bin/$($(package)_ranlib)" endif + + $(package)_cppflags+= -DCATCH_CONFIG_NO_CPP17_UNCAUGHT_EXCEPTIONS endef define $(package)_config_cmds -- * depends: Drop obsolete variable * bls: Integrate the upgraded version into the codebase * depends: Pre-fetch relic to fix gitian Can fetch apt packages only when building with lxc Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>	2021-03-26 15:32:31 +03:00
dustinface	ae506bae66	refactor: PrivateSend -> CoinJoin + Move the tab (#4038) ... * qt|wallet|privatesend: Rename PrivateSend to CoinJoin in GUI strings * qt: Move CoinJoin next to Transactions * qt: Adjust status tip of privateSendCoinsMenuAction Co-authored-by: thephez <thephez@users.noreply.github.com> * rename: privateSend -> coinJoin * rename: privatesend -> coinjoin * rename: PrivateSend -> CoinJoin * rename: use_ps -> use_cj * rename: PRIVATESEND -> COINJOIN * rename: privatesend -> coinjoin for files and folders * refactor: Re-order coinjoin files in cmake/make files * refactor: Re-order coinjoin includes where it makes sense * test: Update lint-circular-dependencies.sh * Few cleanups * test: test/coinjoin_tests.cpp -> wallet/test/coinjoin_test.cpp * s/AdvancedPSUI/AdvancedCJUI/g * s/privateSentAmountChanged/coinJoinAmountChanged/g * wallet: Rename "ps_salt" backwards compatible * Minimal PrivateSend -> CoinJoin migration for settings and cmd-line * wallet: Fix privatesendrounds -> coinjoinrounds migration * qt: Migrate nPrivateSendAmount -> nCoinJoinAmount * `-coinjoindenoms` never existed * Migrate all PS options/settings * rpc: Formatting only * qt: Make Send/CoinJoin tabs a bit more distinguishable Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>	2021-03-17 18:36:11 -04:00
fanquake	086bb0bae8	Merge #16408: depends: Prune X packages ... 0c55d8b58186ba69fffc147cd02b174450dac578 depends: qt: Patch to remove dep on libX11 (Carl Dong) 222e6cc52075cf6f866ce4a2e5900f0d6358f903 gitignore: Actually pay attention to depends patches (Carl Dong) 65f8da08df601ac98bad6f638392343fd564c0b9 symbol-check: Disallow libX11-*.so.* shared libraries (Carl Dong) 924569914e6079763fd1692bed372ded2c63d685 depends: libXext isn't needed by anyone (Carl Dong) 689d3b4a030675b6de87a55463a8e155843293fb build-aux: Remove check for x11-xcb (Carl Dong) aa53cb7a2f04a59a4722c662e67b7a6ec04e32b5 depends: libX11: Make package headers-only (Carl Dong) 9a01ab04e1125b37618266d7fd1c3a6e3bb7e3f8 depends: qt: Explicitly stop using Xlib/libX11 (Carl Dong) 1ec30b8fbe4a162d6e2e6a9711d83f1bafd9b645 depends: xproto is only directly needed by libXau (Carl Dong) Pull request description: Related to: #16150 We noticed that we could build QT without using XLib/libX11 as a library. XLib/libX11's headers are still used, and a minimal `configure.ac` has been added to eliminate overly-enthusiastic configure-time dependencies that aren't actually required to obtain the headers. This also means that we eliminate XLib/libX11 as required shared libraries at runtime, which is desirable. See commit messages for more details. --- Reviewers: I am least sure about the minimal `configure.ac`, as I'm not too familiar with the autoconf syntax. Any improvements w/re robustness would be welcome. ACKs for top commit: theuni: ACK 0c55d8b58186ba69fffc147cd02b174450dac578 fanquake: ACK 0c55d8b58186ba69fffc147cd02b174450dac578 Tree-SHA512: 41f653a0f91bc0e0faac49713c0c6dfd8cb605f9c4e34eb75a790dd808ebf3e5c160f1dd40bc8fbc911ee718ea319313b526d63733c98ff62d8dffecb58caa01	2021-02-18 16:24:11 +01:00
dustinface	52336be438	Revert "Merge bitcoin#13782: Fix osslsigncode compile issue in gitian-build" ... We use osslsigncode 2.0 already due to dashpay#3258 so this commit reverts backport of bitcoin#13782 (619f7fb862)	2020-12-26 18:59:22 -06:00
PastaPastaPasta	1c8f475a7f	Merge pull request #3882 from PastaPastaPasta/backports-0.17-pr25 ... Backports 0.17 pr25	2020-12-19 00:35:31 -06:00
UdjinM6	5e686c9c01	More of 13510	2020-12-18 12:55:45 -06:00
Wladimir J. van der Laan	be4345ce12	Merge #13510: Scripts and tools: Obsolete #!/bin/bash shebang ... 000000035b20402dea3e8168165cd4eefdc97539 Obsolete #!/bin/bash shebang (DesWurstes) Pull request description: > `#!/bin/bash` assumes it is always installed to `/bin/` which can cause issues > `#!/usr/bin/env bash` searches the user's `PATH` to find the `bash` binary Details: https://github.com/dylanaraps/pure-bash-bible#obsolete-syntax I'm open to comments: Should I also fix `#!/bin/sh`? Tree-SHA512: b47bb4828116aa119f1899c68fee081270d51a898535490b9c616bf0f3660ad953f29c361eafc759bc64cdd54ee6eeecb2d79e9fdb5291a996a515c719805476	2020-12-18 12:55:45 -06:00
MarcoFalke	39ff085409	Merge #13617: release: require macOS 10.10+ ... 3828a79711 scripted-diff: prefer MAC_OSX over __APPLE__ (fanquake) fa6e841e89 gui: remove macOS ProgressBar workaround (fanquake) 68c272527f gui: remove SubstituteFonts (fanquake) 6c6dbd8af5 doc: mention that macOS 10.10 is now required (fanquake) 84b0cfa8b6 release: bump minimum required macOS to 10.10 (fanquake) 26b15df99d depends: set OSX_MIN_VERSION to 10.10 (fanquake) Pull request description: Closes #13362 d99abfddb0c8f2111340a6127e77cc686e0043d8 This workaround should no longer be required, as it should have only been in use when compiled with the 10.7 SDK, which we haven't been building with for a while now. 5bc5ae30982a0f0f6a9804b05d99434af770c724 The bugreport linked with this code is for an unrelated? issue, however from what I can tell the correct QTBUG is this one https://bugreports.qt.io/browse/QTBUG-20880. Reading though the discussion there, it seems that the way progress bars are animated changed in macOS 10.10. Qt was patched [here (5.5+)](https://codereview.qt-project.org/#/c/112379/): > Disable progress bar animations on 10.10 Yosemite and higher - the native style does not animate them any more. Keep the indeterminate progress bar animation. Given all of that, I don't think this is worth keeping around, as it would seem to only be useful in the case that a macOS user is compiling with a Qt < 5.5. That should be pretty unlikely, as we don't support downloaded Qt binaries, and brew currently provides [5.11.1](571b46213c/Formula/qt.rb). Tree-SHA512: 4278cb30cc9bcb313e166129ecf032c808995f8b51a3123637c47860a0010ac88f86f82ec44792153b6b1e5cca595f25013b2eaeae80194647b9ce4f7eaf32c1	2020-12-18 01:14:34 +03:00
Fuzzbawls	bccd313d7f	Merge #13732: Depends: Fix Qt's rcc determinism ... Backport of https://bugreports.qt.io/browse/QTBUG-62511 to resolve locale determinism during the build process.	2020-12-18 01:06:07 +03:00
Wladimir J. van der Laan	2aee09c5ab	Merge #11881: Remove Python2 support ... 1874058 Make base58 python contrib code work with python3 (Evan Klitzke) bc6fdf2 Change all python files to use Python3 (John Newbery) Pull request description: Following discussion here: https://github.com/bitcoin/bitcoin/pull/11843#issuecomment-351033742 It's easier for maintainers if all python tools/scripts support only a single version of Python. There are only a few scripts that aren't explicitly python3 at this point, so this PR changes those remaining scripts to explicitly require python3. Tree-SHA512: 5d38eef6e0fc7d8515e23a1f4c75e8b4160fd0fe23cba52a1f41689b114e54a9e503e0724829e8b41982ef98f2d113df80d9e238213b74f09ceaed0344a19e24	2020-12-15 22:16:02 -06:00
dustinface	b1a1d1da66	contrib|src: Update hard coded seeds (#3791) ... * contrib: Update IPs in nodes_main.txt and nodes_test.txt Mainnet height: 1365640 Testnet height: 396230 * src: Update static seeds in chainparamsseeds.h	2020-11-08 17:45:56 +03:00
UdjinM6	d65dca574f	Fix header wrappers generated by generate-seeds.py (#3793)	2020-11-08 17:45:32 +03:00
dustinface	c37193fa82	contrib: Update makeseeds.py (#3790) ... * contrib: Update makeseeds.py The `dnspython` package complained about `dns.resolver.Resolver.query()` being deprecated and suggested to use `dns.resolver.Resolver.resolve()` instead. * contrib: Update dependency install instructions in seeds/README.md	2020-11-08 17:44:47 +03:00
MarcoFalke	7de10e4737	Merge #12284: Remove assigned but never used local variables. Enable Travis checking for unused local variables. ... ea04bf7862 Enable flake8 warning F841 ("local variable 'foo' is assigned to but never used") (practicalswift) 169f3e8637 Remove assigned but never used local variables (practicalswift) Pull request description: Remove assigned but never used local variables. Enable Travis checking for unused local variables. Tree-SHA512: d6052ec9044c5d1f03d874ea3c8addd5a156779213ef9200f89d3ae53230f2fd1691aff405c3dae14178e5ef09912c4432e92f606ef4a5220ed9daa140cdee81	2020-10-26 20:35:28 -04:00
Wladimir J. van der Laan	568b7e1c0c	Merge #12822: Revert 7deba93bdc and fix expired-key-sigs properly ... 9471576 [verify-commits] Add some additional useful documentation. (Matt Corallo) de7e931 Add Marco-expired-key-signed-commits to allow-revsig-commits (Matt Corallo) 99f6d48 Revert "test: Update trust git root". (Matt Corallo) Pull request description: 7deba93bdc was took the wrong approach to updating verify-commits for a key expiration. Namely, adding each commit to allow-revsig-commits should have been done instead, allowing them to still be validated, but with the expired key. Tree-SHA512: 9fdc67eda8f6daa95082f6c1a2af81beb730a9ff3f8cf930bb2311fe29b5f05e1f89259aba5f112153ca2e9c62577cf60d31b4c8e9ac1bf3f5506e78f8401378 Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # contrib/verify-commits/allow-revsig-commits	2020-10-22 11:36:39 -04:00
PastaPastaPasta	204df7bc6e	update public part of windows code signing certificate (#3749) ... * update public part of windows code signing certificate Signed-off-by: pasta <pasta@dashboost.org> * Fixing line-breaks Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>	2020-10-05 14:57:01 +03:00
UdjinM6	81ce9c451a	qt: More asset cleanup (#3735) ... * Drop icon sources (svg) we no longer use * Rename some icons to better match their content * Drop chevron/console prompt icon We do not show it in Dash specific themes and Traditional is just fine with a simple ">" label * bitcoin -> dash for icons * Adjust `contrib/debian/copyright` Dashify it + we no longer use icons mentioned there * `mogrify src/qt/res/*/*.png` * `python3 contrib/devtools/optimize-pngs.py` Total reduction: 68072 bytes	2020-09-30 16:08:11 +03:00
UdjinM6	1624c681df	Always harden osx binaries when creating detached sigs (#3752) ... This is required for macos app notarization https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution	2020-09-30 15:32:24 +03:00
thephez	73d8805dc9	contrib: Added thephez.pgp (#3750)	2020-09-30 15:30:55 +03:00
UdjinM6	f7218d1899	Make shellcheck happy	2020-07-29 11:20:12 -05:00
UdjinM6	6029f290b8	Add missing encoding="utf8"	2020-07-29 11:04:42 -05:00
UdjinM6	35fbb5992f	More of "export LC_ALL=C"	2020-07-29 11:04:30 -05:00
Wladimir J. van der Laan	7be2b2456a	Merge #13281: test: Move linters to test/lint, add readme ... fa3c910bfeab00703c947c5200a64c21225b50ef test: Move linters to test/lint, add readme (MarcoFalke) Pull request description: This moves the checks and linters from `devtools` to a subfolder in `test`. (Motivated by my opinion that the dev tools are mostly for generating code and updating the repo whereas the linters are read-only checks.) Also, adds a readme to clarify that checks and linters are only meant to prevent bugs and user facing issues, not merely stylistic preference or inconsistencies. (This is motivated by the diversity in developers and work flows as well as existing code styles. It would be too disruptive to change all existing code to a single style or too burdensome to force all developers to adhere to a single style. Also note that our style guide is changing, so locking in at the wrong style "too early" would only waste resources.) Tree-SHA512: 9b10e89f2aeaf0c8a9ae248aa891d74e0abf0569f8e5dfd266446efa8bfaf19f0ea0980abf0b0b22f0d8416ee90d7435d21a9f9285b66df43f370b7979173406	2020-07-29 10:59:04 -05:00
MarcoFalke	79999469e4	Merge #13214: Enable Travis checking for two Python linting rules we are currently not violating ... 506c5785fb Enable Travis checking for two Python linting rules we are currently not violating (practicalswift) Pull request description: Enable Travis checking for two Python linting rules we are currently not violating: * E101: indentation contains mixed spaces and tabs * E129: visually indented line with same indent as next logical line Tree-SHA512: 955ea5ce4576a5bdd561f9d2bbcfaa82f66a23391c84ddb806830ed15e321e4742457ccc801f457819f626d4a66a1ffcaecee28c3b9f3f907ab8401323743485	2020-07-29 10:57:27 -05:00
MarcoFalke	18eebe5251	Merge #13210: Enable W191 indentation contains tabs and W291 trailing whitespace flake8 checks for Python files ... 0d31ef4762 Enable W191 and W291 flake8 checks. Remove trailing whitespace from Python files. Convert tabs to spaces. (John Bampton) Pull request description: Tree-SHA512: d062434310d6232469d7ca8e5f2ddb7db7e85cb2a299e609d98bacc318368e43e0777c9f4966df03d50f526bbe27207faa87a7464e62e14671194459a06ad969	2020-07-29 10:57:08 -05:00
UdjinM6	d514668f5e	More of 13153 ("Continued")	2020-07-29 10:56:10 -05:00
Wladimir J. van der Laan	2af1c8d6e7	Merge #13153: Add missing newlines to debug logging ... 4b75dcf devtools: Make linter check LogPrint calls (MarcoFalke) ff2ad2d Add missing newlines to LogPrint debug logging (Wladimir J. van der Laan) Pull request description: ~~Don't we have a linter that should catch these?~~ Tree-SHA512: 1a58eca01ded9c1719e943c09447deeb59bb06dba00528cf460eefe857fdf95b42671fbdebc87cdd2f51e931e86942d06587ffd097cbb0d8dd9eb7a0ba17a8f0	2020-07-29 10:55:33 -05:00
MarcoFalke	a859ea12a9	Merge #13851: fix locale for lint-shell ... 83c48d9a1f fix locale for lint-shell (Julian Fleischer) Pull request description: A piece of code from https://github.com/bitcoin/bitcoin/pull/13816 which I am hereby splitting into smaller PRs. The `shellcheck` executable shipped with travis's trusty linux environment (contains shellcheck `0.3.1` in `/usr/local/bin` as opposed to the distros `0.3.3` in `/usr/bin`) segfaults when `LC_ALL=C`. This makes sure that in travis, no matter from where the script is called, `LC_ALL` is left unset. Comment changed accordingly. Tree-SHA512: 86afa9247f2adbeefa75bf3d56a94766f8e8e1839f40b73763ff7b893a09c848ee64648fc06ce3e6bd0f650127365f508b37fdefb48d61e49f5d551c074cb16e	2020-07-28 21:35:31 -05:00
Wladimir J. van der Laan	cb5d0d8b99	Merge #13454: Make sure LC_ALL=C is set in all shell scripts ... 47776a958b08382d76d69b5df7beed807af168b3 Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C" (practicalswift) 3352da8da1243c03fc83ba678d2f5d193bd5a0c2 Add "export LC_ALL=C" to all shell scripts (practicalswift) Pull request description: ~~Make sure `LC_ALL=C` is set when using `grep` range expressions.~~ Make sure `LC_ALL=C` is set in all shell scripts. From the `grep(1)` documentation: > Within a bracket expression, a range expression consists of two characters separated by a hyphen. It matches any single character that sorts between the two characters, inclusive, using the locale's collating sequence and character set. For example, in the default C locale, `[a-d]` is equivalent to `[abcd]`. Many locales sort characters in dictionary order, and in these locales `[a-d]` is typically not equivalent to `[abcd]`; it might be equivalent to `[aBbCcDd]`, for example. To obtain the traditional interpretation of bracket expressions, you can use the C locale by setting the `LC_ALL` environment variable to the value C. Context: [Locale issue found when reviewing #13450](https://github.com/bitcoin/bitcoin/pull/13450/files#r194877736) Tree-SHA512: fd74d2612998f9b49ef9be24410e505d8c842716f84d085157fc7f9799d40e8a7b4969de783afcf99b7fae4f91bbb4559651f7dd6578a6a081a50bdea29f0909	2020-07-28 21:35:31 -05:00
MarcoFalke	4a5dd0d80f	Merge #12871: Add shell script linting: Check for shellcheck warnings in shell scripts ... 1499fdc350 Add shell script linting: Check for shellcheck warnings in shell scripts (practicalswift) Pull request description: Add shell script linting: Check for `shellcheck` warnings in shell scripts. Tree-SHA512: c7f3f5ed9933415666d2a02f5658cdc62b959ce8112f46b6327ff5f77bb5a66710704c0cde5fd8e719d1fa1fc4f0375a0c115faced166b78e81b75dfb862f08e Signed-off-by: pasta <pasta@dashboost.org>	2020-07-28 21:35:31 -05:00
MarcoFalke	619f7fb862	Merge #13782: Fix osslsigncode compile issue in gitian-build ... 284f424d5a Fix osslsigncode compile issue in gitian-build (Chun Kuan Lee) Pull request description: Install libssl1.0-dev that is compatible with osslsigncode. Fixes #13762 Verifed that this gitian descriptor file can sign 0.16.2rc2. Tree-SHA512: 3029b86e77567a4e033b5ad95826e60df12a0486ac3c4afcac48218f5c76ba49e7f1c1307ce93ffc465ca2f24e12c401e4542929263688e4bd6521aeca3ff73b	2020-07-28 21:35:31 -05:00
Wladimir J. van der Laan	f0b1c562a1	Merge #13764: contrib: Fix test-security-check fail in Ubuntu 18.04 ... 1e60713a68296a0ff221befb48b2958fbf019ebf contrib: Fix test-security-check fail in Ubuntu 18.04 (Chun Kuan Lee) Pull request description: - Fix test-security-check fail in Ubuntu 18.04. Those flags are enabled by default, so we must specify `-no` to make the executable does 'not' have those attributes. - Drop HIGH_ENTROPY_VA. After update our gitian system to Bionic, the compiler should support HIGH_ENTROPY_VA Tree-SHA512: 78c1f2aae1253ddd52faa1af569b7151a503a217c7ccbe21b8004d8910c45d8a27ff04695eacbdadd7192d2c91c0d59941ca20c651dd2d5052b9999163a11ae4	2020-07-28 21:35:31 -05:00
MarcoFalke	fea0036e9f	Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency ... 5f019d5354 Removes the boost/algorithm/string/join dependency (251) Pull request description: This commit removes the `boost/algorithm/string/join` dependency from the project by replacing `boost::algorithm::join` with the helper function proposed by @MarcoFalke in https://github.com/bitcoin/bitcoin/pull/13726#discussion_r204159967 Tree-SHA512: d4ba3e7621b76bd5210aec9b8d6c320f7ee963d7f902e6d2d3fc0eadbee1cd77799e5c09be9c11452d2825f25740fc436cdec3a6b6c66ced674d771e4ed306ae Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # contrib/devtools/lint-includes.sh # src/validation.cpp	2020-07-26 19:39:13 -05:00
Wladimir J. van der Laan	3c18fd2cbd	Merge #13699: contrib: correct version check ... 066d2973a6fff0bf494c4a0000218fe72983808b contrib: correct version check (Karl-Johan Alm) Pull request description: [ not(major >= 3 and minor >= 4) ] fails for '4.0': ```Python >>> major=4 >>> minor=0 >>> if not (major >= 3 and minor >= 5): ... print('This example only works with Python 3.5 and greater') ... This example only works with Python 3.5 and greater ``` Tree-SHA512: 41cb8c5dabe0061ead37b0d6447b699c5d5e1a5551a75dd279bb2ec6d6afa51f8b27a48e01195093db7ec37b28ff6445d59646a4a2b6dcee37776afb60eac8dc	2020-07-26 19:39:13 -05:00
Wladimir J. van der Laan	c72e09442b	Merge #13647: Scripts and tools: Fix BIND_NOW check in security-check.py ... 37d363dd4acf7d41196d44b295593019add241c3 Tools: fix BIND_NOW check in security-check.py (Conrado Gouvea) Pull request description: Previously, the BIND_NOW check would work only if it was the first value in FLAGS. Tree-SHA512: 39cd83f673a6b521803be5585ada516f2db4eede718f0c5aea3377825ed1adcefed5bbb41dd9a5f24a26f7d27116cfc81bde7e26283232593b72768c5ae3d321	2020-07-26 19:39:13 -05:00
UdjinM6	fd63b936d0	Merge pull request #3622 from PastaPastaPasta/backport-rpcauth ... Backport rpcauth	2020-07-26 14:21:10 +03:00
dustinface	9774f46059	qt: Introduce appearance tab and setup dialog (#3568) ... * qt: Add "Appearance Tab" to OptionsDialog and move "Theme" into it * qt: Add "Font scale" settings to Appearance Tab of OptionsDialog Allows to scale the font in the same way like with -font-scale. * qt: Add font weight settings to Appearance tab of OptionsDialog Allows to set the weight for normal and bold text * qt: Add font family setting to Appearance tab of OptionsDialog Allows to choose between system default font or montserrat * qt: GUIUtil - Maintain a map with supported weights for all fonts. * qt: Introduce AppearanceWidget A widget which just wraps all appearance related settings. Also replaces Appearance settings in OptionsDialog with the introduced widget. * qt: Introduce initial appearance setup dialog This will pop up the first time the user starts the DashCore version with the new UI changes. * qt: Load font related settings in GUIUtil::loadFonts * qt: Make osDefaultFont global in GUIUtil to fix getFont() Before getFont(FontFamily, ...) wasn't always able to return the correct font without the requested font family beeing set as application font upfront. * qt: Improve supported weight helpers Add conversion helpers. and let all of them depend on the currently selected font. * qt: Default weights based on supported if not all weights are supported For SystemDefault only because Montserrat has all supported weights. * qt/test: Fix GUI tests * Store normal/bold font GUI settings as "pure" (not "supported") values * Rename supportedWeighti(To/From)Arg to supportedWeight(To/From)Index to better match the logic and avoid confusion with weight(To/From)Arg functions Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>	2020-07-26 14:19:11 +03:00
pasta	78e2a0082e	add new-line to lint-python.sh ... Signed-off-by: pasta <pasta@dashboost.org>	2020-07-22 12:17:47 -05:00
MarcoFalke	17acd6b472	Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis ... 643aad17fa Enable additional flake8 rules (practicalswift) f020aca297 Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift) Pull request description: Enabled rules: ``` * E242: tab after ',' * E266: too many leading '#' for block comment * E401: multiple imports on one line * E402: module level import not at top of file * E701: multiple statements on one line (colon) * E901: SyntaxError: invalid syntax * E902: TokenError: EOF in multi-line string * F821: undefined name 'Foo' * W293: blank line contains whitespace * W606: 'async' and 'await' are reserved keywords starting with Python 3.7 ``` Note to reviewers: * In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR. * Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes. Before this commit: ``` $ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 . 5 E266 too many leading '#' for block comment 4 E401 multiple imports on one line 6 E402 module level import not at top of file 5 E701 multiple statements on one line (colon) 1 F812 list comprehension redefines 'n' from line 159 4 F821 undefined name 'ConnectionRefusedError' 28 W293 blank line contains whitespace ``` After this commit: ``` $ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 . $ ``` Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a Signed-off-by: pasta <pasta@dashboost.org>	2020-07-22 12:12:46 -05:00
Wladimir J. van der Laan	6cd3050c7f	Merge #13340: doc: remove leftover check-doc documentation ... 93843f68918f234929cfddc62b507041ce06805e doc: remove leftover check-doc documentation (fanquake) Pull request description: Remove leftover check-doc.py documentation. Mentioned [here](https://github.com/bitcoin/bitcoin/pull/13281#issuecomment-392010168), it's now [here](https://github.com/bitcoin/bitcoin/tree/master/test/lint#check-docpy). Tree-SHA512: 95a0ac221ffae109c1d4baf18a9220cf993fc07c005920a0bd09abdf52e8fb298e3b5df31fa18887719c5080d8531d18b84b7bd9c7c664ee2501ccd9e0975eb6	2020-07-21 11:54:50 -05:00
MarcoFalke	7b091fb99f	Merge #12933: doc: Refine header include policy ... fad0fc3c9a Refine travis check for duplicate includes (MarcoFalke) Pull request description: Since there is no harm in having "duplicate" includes and it makes it obvious what are the dependencies of each file, without having to do static analysis or jumping between files, I'd suggest to revert the travis check for duplicate includes. Generally, I think that enforcing minor style preferences should not be done via travis. The cost of maintaining and the burden on other developers is too high. C.f discussion in https://github.com/bitcoin/bitcoin/pull/10973#discussion_r180142594 Tree-SHA512: 97ab0e769d457ccfb873fff6c99613f8b944cd7ef95bfdccb0e1bbe8f5df1f16548c658fa03af42516f806546e75646d338a061e7b057619490235d311ca21f1	2020-07-21 11:54:50 -05:00
UdjinM6	6e592cc691	Merge pull request #3618 from PastaPastaPasta/backports-0.17-pr16 ... Backports 0.17 pr16	2020-07-20 18:03:11 +03:00
pasta	a6cdb75b18	fix compilation in headers that contain 'dashes' and adjust linter ... Signed-off-by: pasta <pasta@dashboost.org>	2020-07-19 00:42:54 -05:00
MarcoFalke	db747ea384	Merge #12757: Clarify include guard naming convention ... 3bcc0059b8 Add lint-include-guards.sh which checks include guard consistency (practicalswift) 8fd6af89a0 Fix missing or inconsistent include guards (practicalswift) 8af65d96f4 Document include guard convention (practicalswift) Pull request description: * **Documentation**: Document include guard convention * **Fix**: Fix missing or inconsistent include guards * **Regression test**: Add `lint-include-guards.sh` which checks include guard consistency Tree-SHA512: 8171878f60fd08ccbea943a11e835195750592abb9d7ab74eaa4265ae7fac523b1da9d31ca13d6ab73dd596e49986bfb7593c696e5f39567c93e610165bc2acc Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # src/bech32.h # src/consensus/merkle.h # src/key_io.h # src/policy/fees.h # src/rpc/server.h # src/script/bitcoinconsensus.h # src/wallet/coinselection.h	2020-07-19 00:42:54 -05:00
MarcoFalke	5103888706	Merge #13228: Add script to detect circular dependencies between source modules ... a7b295e91e Add circular dependencies script (Pieter Wuille) Pull request description: This script finds dependencies between source code modules, treating the `.cpp` and `.h` file as one unit (so it will detect `A.cpp` depending on `B.h` where `B.cpp` depends on `A.h`). This can be used to find out which modules cannot be used independently from each other. It is very simplistic at this point, and assumes that a `.cpp` file's corresponding header has the exact same name, with `.cpp` replaced by `.h`. Furthermore, it assumes all `#include`s are relative to the `src/` directory. This is not a linter, and is not enforced through Travis or otherwise. This is the current output: ``` $ ../contrib/devtools/circular-dependencies.py {*,*/*,*/*/*}.{h,cpp} Circular dependency: chain -> pow -> chain Circular dependency: chainparamsbase -> util -> chainparamsbase Circular dependency: checkpoints -> validation -> checkpoints Circular dependency: init -> index/txindex -> init Circular dependency: init -> validation -> init Circular dependency: init -> net_processing -> init Circular dependency: init -> rpc/server -> init Circular dependency: init -> txdb -> init Circular dependency: init -> validationinterface -> init Circular dependency: random -> util -> random Circular dependency: sync -> util -> sync Circular dependency: txmempool -> validation -> txmempool Circular dependency: txmempool -> policy/fees -> txmempool Circular dependency: validation -> index/txindex -> validation Circular dependency: validation -> policy/policy -> validation Circular dependency: validation -> validationinterface -> validation Circular dependency: qt/addresstablemodel -> qt/walletmodel -> qt/addresstablemodel Circular dependency: qt/bantablemodel -> qt/clientmodel -> qt/bantablemodel Circular dependency: qt/bitcoingui -> qt/walletview -> qt/bitcoingui Circular dependency: qt/bitcoingui -> qt/walletframe -> qt/bitcoingui Circular dependency: qt/bitcoingui -> qt/utilitydialog -> qt/bitcoingui Circular dependency: qt/clientmodel -> qt/peertablemodel -> qt/clientmodel Circular dependency: qt/paymentserver -> qt/walletmodel -> qt/paymentserver Circular dependency: qt/recentrequeststablemodel -> qt/walletmodel -> qt/recentrequeststablemodel Circular dependency: qt/sendcoinsdialog -> qt/walletmodel -> qt/sendcoinsdialog Circular dependency: qt/transactiontablemodel -> qt/walletmodel -> qt/transactiontablemodel Circular dependency: qt/walletmodel -> qt/walletmodeltransaction -> qt/walletmodel Circular dependency: rpc/rawtransaction -> wallet/rpcwallet -> rpc/rawtransaction Circular dependency: wallet/coincontrol -> wallet/wallet -> wallet/coincontrol Circular dependency: wallet/fees -> wallet/wallet -> wallet/fees Circular dependency: wallet/rpcwallet -> wallet/wallet -> wallet/rpcwallet Circular dependency: wallet/walletdb -> wallet/wallet -> wallet/walletdb Circular dependency: txmempool -> validation -> policy/rbf -> txmempool Circular dependency: txmempool -> validation -> validationinterface -> txmempool Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/addressbookpage Circular dependency: qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/guiutil Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/signverifymessagedialog -> qt/addressbookpage Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/receivecoinsdialog -> qt/addressbookpage Circular dependency: qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/intro -> qt/guiutil Circular dependency: qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/sendcoinsdialog -> qt/sendcoinsentry -> qt/addressbookpage ``` Tree-SHA512: 29bc985b7a41699f4666b0aaa785ca63c2145e84c37458536f4dcf8e3de8f1312cf0323fe09cb8f348a9d363583f76eac2d5bee574bc6a9f9cc97a9b0aad406f	2020-07-18 03:08:13 -05:00
MarcoFalke	d26bcfa183	Merge #12820: contrib: Fix check-doc script regexes ... 0c17e27630 init: Remove help text for non-existent -fuzzmessagestest arg (MarcoFalke) 136084470c contrib: Fix check-doc script regexes (MarcoFalke) Pull request description: Fixup the regexes to properly find all used args. The regex should now match all of the getter and setter methods of the `ArgsManager`. See https://dev.visucore.com/bitcoin/doxygen/class_args_manager.html#pub-methods Before: ``` Args used : 159 Args documented : 188 Args undocumented: 0 Args unknown : 29 ``` After: ``` Args used : 183 Args documented : 188 Args undocumented: 0 Args unknown : 5 ``` Tree-SHA512: 1a7fb7ea55b2f6030358a1055d8f2c19b31f69d0603be0b009e6e603564014b4e2bb824357c9d43d0fba3ce7159b7c4e7eaa60b3f962053d94f73d0e626294fc	2020-07-17 15:42:51 -05:00
MarcoFalke	2829b4d3b9	Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency ... e3245f2e7b Removes Boost predicate.hpp dependency (251) Pull request description: This pull request removes the `boost/algorithm/string/predicate.hpp` dependency from the project. To replace the the `predicate.hpp` dependency from the project the function calls to `boost::algorithm::starts_with` and `boost::algorithm::ends_with` have been replaced with respectively C++11's `std::basic_string::front` and `std::basic_string::back` function calls. Refactors that were not required, but have been done anyways: - The Boost function `all` was implicitly made available via the `predicate.hpp` header. Instead of including the appropriate header, function calls to `all` have been replaced with function calls to `std::all_of`. - The `boost::algorithm::is_digit` predicate has been replaced with a custom `IsDigit` function that is locale independent and ASCII deterministic. Tree-SHA512: 22dda6adfb4d7ac0cabac8cc33e8fb8330c899805acc1ae4ede402c4b11ea75a399414b389dfaa3650d23b47f41351b4650077af9005d598fbe48d5277bdc320	2020-07-17 15:42:20 -05:00
PastaPastaPasta	95f83945b9	remove extra space at end line ... Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>	2020-07-08 19:16:32 +00:00
pasta	e6a1c6b5bb	scripted-diff: change all tabs to spaces in linearize-hashes.py and linearize-data.py ... It appears bitcoin has already done this previously(seemingly forever), however, we for some reason have tabs. This was causing the linter to fail because a backport touched lines which resulted in linter yelling at me for adding lines beginning with tabs. To fix this, replacing all tabs with spaces in these two files. -BEGIN VERIFY SCRIPT- sed -i 's/\t/ /g' contrib/linearize/linearize-*.py -END VERIFY SCRIPT- Signed-off-by: pasta <pasta@dashboost.org>	2020-07-07 16:03:07 -05:00
Wladimir J. van der Laan	d1200755f1	Merge #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python ... c8176b3cc7556d7bcec39a55ae4d6ba16453baaa Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python (practicalswift) 634bd970013eca90f4b4c1f9044eec8c97ba62c2 Explicitly specify encoding when opening text files in Python code (practicalswift) Pull request description: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python. As requested by @laanwj in #13440. Tree-SHA512: 1651c00fe220ceb273324abd6703aee504029b96c7ef0e3029145901762c733c9b9d24927da281394fd4681a5bff774336c04eed01fafea997bb32192c334c06 Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # contrib/devtools/circular-dependencies.py # contrib/linearize/linearize-data.py # contrib/linearize/linearize-hashes.py # contrib/seeds/generate-seeds.py # contrib/verify-commits/verify-commits.py # test/functional/multiwallet.py # test/functional/notifications.py # test/functional/test_runner.py # test/util/rpcauth-test.py	2020-07-07 11:50:56 -05:00
Wladimir J. van der Laan	3979f24d3f	Merge #13479: contrib: Fix CVE-2018-12356 by hardening the regex ... 9e2e5626dabb7208dafedcc9904940b666be1c3b Fix CVE-2018-12356 by hardening the regex. (Loganaden Velvindron) Pull request description: Detailed write-up here: https://neopg.io/blog/pass-signature-spoof/ Tree-SHA512: 2020474ff4c7b5e7f1bea932c63da62aca48d3dc6dcd04507afefad6c40f2977ed2d2916defe2e8e7936a2d498125c578077870147954a7af9b29b823cbb0b10	2020-07-07 11:48:28 -05:00
Wladimir J. van der Laan	6e5b3f3b9e	Merge #13230: Simplify include analysis by enforcing the developer guide's include syntax ... 16e3cd380af570fb2f656e0344bab88829a4bcda Clarify include recommendation (practicalswift) 6d10f43738d58bf623975e3124fd5735aac7d3e1 Enforce the use of bracket syntax includes ("#include <foo.h>") (practicalswift) 906bee8e5f474f8718d02e6f1938f20dcfe3d2cc Use bracket syntax includes ("#include <foo.h>") (practicalswift) Pull request description: When analysing includes in the project it is often assumed that the preferred bracket include syntax (`#include <foo.h>`) mentioned in `developer-docs.md` is used consistently. @sipa:s excellent circular dependencies script [`circular-dependencies.py`](50c69b7801/contrib/devtools/circular-dependencies.py) (#13228) is an example of a script making this reasonable assumption. This PR enables automatic Travis checking of the include syntax making sure that the bracket syntax includes (`#include <foo.h>`) is used consistently. Tree-SHA512: a414921aabe8e487ebed42f3f1cbd02fecd1add385065c1f2244cd602c31889e61fea5a801507ec501ef9bd309b05d3c999f915cec1c2b44f085bb0d2835c182 Signed-off-by: pasta <pasta@dashboost.org>	2020-07-01 20:12:03 -05:00
MarcoFalke	72b69a35a3	Merge #13301: lint: Add linter to error on #include <*.cpp> ... 9d6c9dbb88 lint: Add linter to error on #include <*.cpp> (Ben Woosley) Pull request description: Files should depend on one another by interface, not by implementation. This checks for quoted includes as well. Tree-SHA512: d36d468f48d538077f5f927b9561729fd7d76319f6b2e2cc10414a9f243588194e90ca1d85eca65019f9259268f555d25106eaaa56da28c58fa8d5837b469661	2020-07-01 20:12:03 -05:00
pasta	02085df48b	Adjust current boost includes present ... Signed-off-by: pasta <pasta@dashboost.org>	2020-07-01 20:12:03 -05:00
Wladimir J. van der Laan	9a9aa3f467	Merge #13385: build: Guard against accidental introduction of new Boost dependencies ... 81bbd32a2c755482c6e8ef049a59de672715b545 build: Guard against accidental introduction of new Boost dependencies (practicalswift) Pull request description: Guard against accidental introduction of new Boost dependencies. Context: #13383 – the usage of `boost::lexical_cast` was introduced in #11517 from December 2017 Tree-SHA512: 8d7b667ecf7ea62d84d9d41a71726f1e46c5a411b5a7db475c973ef364cac65609399afda7931e143a27d40c2947ff286e5e98ab263e8f0d225e2ae2c0872935	2020-07-01 20:12:03 -05:00
MarcoFalke	005d241fea	Merge #11878: Add Travis check for duplicate includes ... c36b720d00 Add Travis check for duplicate includes (practicalswift) 280023f31d Remove duplicate includes (practicalswift) Pull request description: This enforces parts of the project header include guidelines (added by @sipa in #10575). Example run: ``` $ git diff diff --git a/src/warnings.cpp b/src/warnings.cpp index c52a1fd..d8994dd 100644 --- a/src/warnings.cpp +++ b/src/warnings.cpp @@ -5,6 +5,8 @@ #include <sync.h> #include <clientversion.h> +#include <string> #include <util.h> #include <warnings.h> +#include <util.h> diff --git a/src/warnings.h b/src/warnings.h index e8e982c..8d2252e 100644 --- a/src/warnings.h +++ b/src/warnings.h @@ -7,6 +7,7 @@ #define BITCOIN_WARNINGS_H #include <stdlib.h> #include <string> +#include <stdlib.h> void SetMiscWarning(const std::string& strWarning); $ contrib/devtools/lint-includes.sh Duplicate include(s) in src/warnings.h: #include <stdlib.h> Include(s) from src/warnings.h duplicated in src/warnings.cpp: #include <string> Duplicate include(s) in src/warnings.cpp: #include <util.h> $ echo $? 1 $ git checkout . $ contrib/devtools/lint-includes.sh $ echo $? 0 ``` Tree-SHA512: f653d23c58ebc024dfc5b1fb8570698fd3c515c75b60b5cabbc43595548c488fca92349fa4c8b64460edbe61c879ff1d24f37f959e18552e202a7342460ddbf1	2020-07-01 20:12:03 -05:00
Wladimir J. van der Laan	8a09758298	Merge #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results ... ab3f4dd tests: Add test for 64-bit PE, modify 32-bit test results (Chun Kuan Lee) Pull request description: 9a75d29b6f change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one Tree-SHA512: 9d5643dadf4d9fc34ea32d94655bfb98eec2f7bc2820b4b0f525d5acf1cd22f3acf38bf8904dda4f50fd9ca5a5e56d566a392e6f804eea6e50e03cba40048621	2020-06-28 19:28:57 -05:00
pasta	15ca483893	fix lint failures ... Signed-off-by: pasta <pasta@dashboost.org>	2020-06-27 11:02:43 -05:00
Jonas Schnelli	5f5e295ab4	Merge #13119: Remove script to clean up datadirs ... fa85de9ff Remove script to clean up datadirs (MarcoFalke) Pull request description: This reverts commit 33c055c4f1. (#2295) Tree-SHA512: 0f0dceaf7912cbfa6e64ac55177592e39b99d2aa59d47609c853093ea2e93f5d80d0390f65f26535d5a94e576c55737fdb8c9e463679e9c790656b95b1b58b36	2020-06-27 10:43:32 -05:00
MarcoFalke	714beebe07	Merge #12972: Add python3 script shebang lint ... 2bff472992 [contrib] convert test-security-check to python3 (John Newbery) 958bf40489 add lint tool to check python3 shebang (practicalswift) Pull request description: base58.py can executed by python3 Tree-SHA512: 30511204feefd4ccd5b4bf698fb88e516633e692dc95d31fe957b1c0c4879de25906355b28a5a0522171887315c8464a611e601ff00540db172d5bd463ee13d9	2020-06-27 10:43:32 -05:00
UdjinM6	908c04f1e3	Merge pull request #3531 from PastaPastaPasta/backports-0.17-pr6 ... Backports 0.17 pr6	2020-06-27 14:49:35 +03:00
dustinface	f6e14ab57a	qt: Generalized css files, simple design changes, added scripts to keep track of color usage (#3508) ... * qt: Send tab - Generalized related CSS and some redesign - Removed grey boxes around labels of SendCoinEntry - Changed button styles for add/clear button - Removed padding for send button * qt: Overview tab - Generalized related CSS and some redesign - Removed grey boxes around balance labels * qt: Receive tab & QPushButton - Generalized related CSS and some redesign - Removed grey boxes around "Label", "Amount", "Message" and "Requested payment history" labels and increased their textsize - Changed the color of the "Requested payment history" label - Adjusted the style of the "Clear", "Remove" and "Show" buttons * qt: Transaction tab - Generalized related CSS and some redesign - Increased size of selected sum labels * qt: Masternode tab - Generalized related CSS and some redesign - Increased the size of the "Filter list" and "Node count" labels * qt: CoinControl dialog - Generalized related CSS and some redesign - Removed alternated coloring * qt: Sync overlay - Generalized related CSS and some redesign - Adjusted colors - Added rounded border * qt: About dialog - Generalized related CSS * qt: Edit address dialog - Generalized related CSS * qt: Help message dialog - Generalized related CSS * qt: RPC console - Generalized related CSS and some redesign - Changed colors for network activity legend (signal colors TBD in a code change commit) * qt: Options dialog - Generalized related CSS * qt: Ask passphrase dialog - Generalized related CSS * qt: Addressbook page - Generalized related CSS * qt: Sign/Verify dialog - Generalized related CSS * qt: Open URI dialog - Generalized related CSS * qt: Generalized remaining individual Qt classes * qt: Fixed indentation in css files * qt: Use newlines for multiple selector entries * qt: Formal cleanups in all css files * qt: Add copyright and file description to all css files * qt: Add update_colors.py, prepare css files for scripted color updates - update_colors.py is a python script which parses the css files and prints some details about their color usage into appropriate files in the css/colors directory. It also updates the <colors></colors> section for each css file. - Added <colors></colors> section to css files for automated color updates by update_colors.py * qt/contrib: Moved update_colors.py to update-css-files.py This also moves the file from src/qt/res/css to contrib/devtools * build: Remove files in src/qt/res/css/colors when running "make clean" * git: Add src/qt/res/css/colors/* to gitignore and remove the files from the repo * path -> css_folder_path * Resolve path and fail early * Create 'colors/' if it doesn't exist and fail if smth went wrong * Run git after all filesystem preparations are done * qt: Fix background-color of bgWidget in trad.css Its #AARRGGBB not #RRGGBBAA! Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * qt: Run update_colors.py * contrib: Use case insensitive regex for color matching * qt: Update colors in css files * contrib: Remove obsolete import in update-css-files.py Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>	2020-06-26 20:48:20 +03:00
dustinface	e015820d6a	contrib: Move dustinface.pgp into contrib/gitian-keys (#3547)	2020-06-23 08:31:49 +02:00
MarcoFalke	9475fe553d	Merge #12572: [script] lint-whitespace: find errors more easily ... 0fbed98e42 [script] lint-whitespace: improve print linenumber (Akio Nakamura) Pull request description: Before this PR, the linenumber infomaition is output if trailing-space or tab code was found, but the output occurence is only per a file. This PR separates the output timing of file name and line number. As a result, users will find where they need to fix more easily. example: 0) git diff ``` diff --git a/dummy.txt b/dummy.txt index c0ce4d776..aebbdb88d 100644 --- a/dummy.txt +++ b/dummy.txt @@ -1,2 +1,2 @@ -1 -2 +1 + 2 @@ -8,2 +8,2 @@ -8 -9 + 8 +9 ``` 1) before this PR - Is there "9 " in second line? It may lead to be misunderstood. ``` This diff appears to have added new lines with trailing whitespace. The following changes were suspected: diff --git a/dummy.txt b/dummy.txt @@ -1,2 +1,2 @@ +1 +9 ``` 2) after this PR ``` This diff appears to have added new lines with trailing whitespace. The following changes were suspected: diff --git a/dummy.txt b/dummy.txt @@ -1,2 +1,2 @@ +1 @@ -8,2 +8,2 @@ +9 ``` Tree-SHA512: 2fd52e3c982786f86cfe10aa2578589bc9c502bcad9b85111467840d726143330c23968cde5483ee0f563893c8381044b80e8c22a7c8eca56fc73c548b9a9496	2020-06-18 11:41:53 -05:00
Wladimir J. van der Laan	e9b42fd5c3	Merge #12098: [scripts] lint-whitespace: add param to check last N commits ... 8dbf740f8 [scripts] lint-whitespace: check last N commits or unstaged changes (Sjors Provoost) Pull request description: E.g. before you push three commits to Github and upset Travis, check if you didn't make any whitespace mistakes: ```sh contrib/devtools/lint-whitespace.sh 3 ``` This is slightly more convenient than doing: ```sh TRAVIS_COMMIT_RANGE=HEAD~3...HEAD contrib/devtools/lint-whitespace.sh ``` Tree-SHA512: 5d9c1ae978ccbe59477e8cf53391e9bd697d2da87f417a2519264af560d4768138e0b2d320dd497a1f1e704e18ab279d724f523b57c17a80ccd753133a5445bf	2020-06-18 11:41:53 -05:00
Wladimir J. van der Laan	a88ad9384f	Merge #12097: [scripts] lint-whitespace: use perl instead of grep -P ... 40b17f5f9 [scripts] lint-whitespace: use perl instead of grep -P (Sjors Provoost) Pull request description: MacOS does not support `grep -P` out of the box. This change makes it easier for developers to check for whitespace problems locally. Based on [this](https://stackoverflow.com/a/16658690) and [this](https://serverfault.com/a/504387) Stack Exchange answer. Tested with: ```sh export TRAVIS_COMMIT_RANGE='fe78c9a...62e0453' contrib/devtools/lint-whitespace.sh This diff appears to have added new lines with tab characters instead of spaces. The following changes were suspected: diff --git a/src/test/bignum_tests.cpp b/src/test/bignum_tests.cpp @@ -0,0 +1,110 @@ + num.setint64(n); ``` Tree-SHA512: 37c342a0ca2580289cf326a278a051a7c21ba918d6b2143fd9987f159fab85f1de3d770fcf532a642cd5d1957afc8595678128196e102dc473924758f133db7f	2020-06-18 11:41:53 -05:00
MarcoFalke	1cf2fff1c4	Merge #12308: contrib: Add support for out-of-tree builds in gen-manpages.sh ... 526e28220a contrib: Add support for out-of-tree builds in gen-manpages.sh (Wladimir J. van der Laan) Pull request description: This adds support for setting the environment variable `BUILDDIR` to point to executables that are outside the source directory. E.g. to invoke the tool when the build is in $PWD/build: ```bash BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh ``` This avoids having to manually copy the generated manpages after they end up in the build instead of source path, when setting TOPDIR instead. Tree-SHA512: 8dc6dd7a47a0c014ae7d27f0ac9d86f69238ec6bac8a3007b975bb88c9f37014755c716c5e62604dd91baad2f8a41fd1544cdca3ba4b59bc76602e6593f4a4a7	2020-06-17 14:29:55 -05:00
MarcoFalke	10a27192b1	Merge #12442: devtools: Exclude patches from lint-whitespace ... fafbf7f74e devtools: Exclude patches from lint-whitespace (MarcoFalke) Pull request description: By default, unified patches have trailing whitespace in all context lines. Thus, exclude patches from linting. Tree-SHA512: 8f89f1584581e94dd4e34bd522cba21602bafe7933b4631a3abc5da5a8f25568810862d696618fe63c15edf3e046869ad5077d09373f09792985503c6a415538	2020-06-17 14:29:55 -05:00
Wladimir J. van der Laan	9b0c1f7733	Merge #12393: Fix a-vs-an typos ... 11376b5 Fix a-vs-an typos (practicalswift) Pull request description: Fix a-vs-an typos. Tree-SHA512: 2cf74c15656a20ec13d2da7d86a39d14e634db368833d92da06a78d1266950accfc4fcc89cfecdaadd46e6b48b17e6fad29080428e564871e78482c53f3e855c	2020-06-17 14:29:55 -05:00
Pasta	b40dc8f1ec	fix lint-python.sh after 11835 and 12295 ... Signed-off-by: Pasta <pasta@dashboost.org>	2020-06-17 14:29:55 -05:00
MarcoFalke	89cf527e57	Merge #12295: Enable flake8 warnings for all currently non-violated rules ... a9d0ebc262 Enable flake8 warnings for all currently non-violated rules (practicalswift) 4cbab15e75 tests: Fix accidental redefinition of previously defined variable via list comprehension (practicalswift) 0b9207efbe Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812) (practicalswift) Pull request description: * Enable `flake8` warnings for all currently non-violated rules * Fix accidental redefinition via list comprehension Tree-SHA512: 738b87789e99d02abb2c6b8ff58f65c0cbfeb93e3bf320763e033e510ebd0a4f72861bc8faaf42c14a056a5d4659c33dc70a63730a32cc15159559427bf21193	2020-06-17 14:29:55 -05:00
MarcoFalke	cd1fdb5b01	Partial Merge #11835: Add Travis check for unused Python imports ... d60b32074 Add Travis check for unused Python imports (practicalswift) c7399e708 Remove unused Python imports (practicalswift) Pull request description: Add Travis check for unused Python imports. ``` $ contrib/devtools/lint-python.sh ./test/functional/example_test.py:18:1: F401 'test_framework.mininode.NODE_NETWORK' imported but unused ./test/functional/test_framework/messages.py:27:1: F401 'test_framework.util.wait_until' imported but unused ./test/functional/test_framework/test_framework.py:16:1: F401 'traceback' imported but unused ``` Tree-SHA512: 78e50fb1488abe3ebe365e766cb8d6d448cf1bd16c8691e102cb9bf7c202988bdf6e10b25ff772c62e05c72568168462e88cdc7ad98069d9eb3be727735b2d56	2020-06-17 14:29:55 -05:00
Wladimir J. van der Laan	337105e00f	Merge #12102: Apply hardening measures in bitcoind systemd service file ... 79ddfad Apply hardening measurements in bitcoind systemd service file (Florian Schmaus) Pull request description: Adds typical systemd hardening measurements for network services. Tree-SHA512: 63e54d5a2e3e625c123c91e4392474226ec26c48709f2627f4d9d257a59f6960dd53ba4faa10cd355a89cad37fe351e2dbe8db79e681645b59081cf83e940438	2020-06-13 14:50:11 -05:00
Wladimir J. van der Laan	101f73bb6d	Merge #12891: [logging] add lint-logs.sh to check for newline termination. ... d207207 [logging] add lint-logs.sh to check for newline termination. (John Newbery) 5c21e6c [logging] Comment all continuing logs. (John Newbery) Pull request description: Check that all calls to LogPrintf() are terminated by a newline, except those that are explicitly marked as 'continued' logs. Tree-SHA512: fe5162b2b2df1e8a4c807da87584fa9af97a6b8377e4090fe0caa136d90bf29a487a123cde94569bdce7101fee3478196d99aa13f1212e24bfe5f41c773604fc	2020-06-11 23:20:48 -05:00
Wladimir J. van der Laan	9b9005e395	Merge #12895: tests: Add note about test suite name uniqueness requirement to developer notes ... d1b622b tests: Add check for test suite name uniqueness in lint-tests.sh (practicalswift) dc8067b tests: Add note about uniqueness requirement for test suite names (practicalswift) 3ebfb2d tests: Avoid test suite name collision in wallet crypto_tests (MarcoFalke) Pull request description: * Add documentation: Add note about test suite name uniqueness requirement in developer notes * Add regression test: Update `lint-tests.sh` to make it check also for test suite name uniqueness Context: #12894 (`tests: Avoid test suite name collision in wallet crypto_tests`) Tree-SHA512: 3c8502db069ef3d753f534976a86a997b12bac539e808a7285193bf81c9dd8c1b06821c3dd1bdf870ab87722b02c8aa9574c62ace70c2a1b8091785cb8c9aace	2020-06-11 23:20:48 -05:00
MarcoFalke	c1c84d6987	Merge #12719: tests: Add note about test suite naming convention in developer-notes.md ... db983beba6 tests: Add lint-tests.sh which checks the test suite naming convention (practicalswift) 5fd864fe8a tests: Rename test suits not following the test suite naming convention (practicalswift) 7b4a296a71 tests: Add note about test suite naming convention (practicalswift) Pull request description: Changes: * Add note about test suite naming convention * Fix exceptions * Add regression test Rationale: * Consistent naming of test suites makes programmatic test running of specific tests/subsets of tests easier * Explicit is better than implicit Before this commit: ``` $ contrib/devtools/lint-tests.sh The test suite in file src/test/foo_tests.cpp should be named "foo_tests". Please make sure the following test suites follow that convention: src/test/blockchain_tests.cpp:BOOST_FIXTURE_TEST_SUITE(blockchain_difficulty_tests, BasicTestingSetup) src/test/prevector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(PrevectorTests, TestingSetup) src/wallet/test/coinselector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(coin_selection_tests, WalletTestingSetup) src/wallet/test/crypto_tests.cpp:BOOST_FIXTURE_TEST_SUITE(wallet_crypto, BasicTestingSetup) $ ``` After this commit: ``` $ contrib/devtools/lint-tests.sh $ ``` Tree-SHA512: 7258ab9a6b9b8fc1939efadc619e2f2f02cfce8034c7f2e5dc5ecc769aa12e17f6fb8e363817feaf15c026c5b958b2574525b8d2d3f6be69658679bf8ceea9e9	2020-06-11 23:20:48 -05:00
UdjinM6	469d6aa737	Some Dashification (#3513) ... * Trivial Dashification * Tweak getnetworkinfo and dumpwallet help text We don't have RBF and Segwit * CopyrightHolders should also check for missing "Dash Core" copyright	2020-06-11 11:39:04 +03:00
UdjinM6	5b36122bc9	Bump develop 0.17 (#3512) ... * Bump version in README.md, configure.ac and gitian descriptors * Partial gen-manpages.sh (changes for the version bump only)	2020-06-11 11:34:42 +03:00
dustinface	9b47883884	contrib: Added dustinface.pgp (#3502)	2020-06-04 14:43:33 +03:00
MarcoFalke	bf7cb2dfcc	Merge #12075: [scripts] Add missing univalue file to copyright_header.py ... 415f86c6ae [scripts] Add missing univalue file to copyright_header.py (fanquake) Pull request description: This needs to be added so that PRs like #12062 don't modify the subtree. Tree-SHA512: 3642bdb0c8271ae700857a79fa5800b0c26c4b3f126d4406f224293817fb74d498fa1fc581d576ae747fbbb6952d4369fc4ab823ab48fd0946c1e8ccbe93cee6	2020-04-03 05:06:59 -05:00
UdjinM6	7d75dbda22	More of 10773	2020-04-01 12:43:18 -05:00
Pieter Wuille	a7a3ecc354	Merge #10773: Shell script cleanups ... 13a81b19d Add quotes to variable assignment (as requested by @TheBlueMatt) (practicalswift) 683b9d280 Fix valid path output (practicalswift) 193c2fb4c Use bash instead of POSIX sh. POSIX sh does not support arrays. (practicalswift) 80f5f28d3 Fix incorrect quoting of quotes (the previous quotes had no effect beyond unquoting) (practicalswift) 564a172df Add required space to [[ -n "$1" ]] (previously [[ -n"$1" ]]) (practicalswift) 1e44ae0e1 Add error handling: exit if cd fails (practicalswift) b9e79ab41 Remove "\n" from echo argument. echo does not support escape sequences. (practicalswift) f6b3382fa Remove unused variables (practicalswift) Pull request description: Shell script cleanups: * Add required space to `[ -n ]`. * Avoid quote within quote. * Exit if `cd` fails. * Remove `\n` which is not handled by `echo`. * ~~Remove redundant `$` in arithmetic variable expression.~~ * ~~Use `$(command)` instead of legacy form `` `command` ``.~~ * Arrays are not supported in POSIX `sh`. Use `bash` when arrays are used. * ~~`[ foo -a bar ]` is not well defined, use `[ foo ] && [ bar ]` instead.~~ * ~~`[ foo -o bar ]` is not well defined, use `[ foo ] || [ bar ]` instead.~~ Tree-SHA512: 80f6ded58bce625b15b4da30d69d2714c633e184e62b21ed67d2c58e2ebaa08b4147593324012694d02bf4f1f252844cdff2fd1cf5e817ddb07e2777db7a6390	2020-04-01 12:43:18 -05:00
MarcoFalke	1587728345	Merge #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it ... b077fe908 fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (Evan Klitzke) Pull request description: I spent some time trying to figure out how to get the provided `.desktop` file to work correctly in GNOME. When a non-absolute path is used in the desktop file, you need to specify `StartupWMClass` in order for gnome-shell to know that a running application matches one in its desktop database. I also set a version and removed the deprecated `Encoding` field. With these changes, the desktop file passes `desktop-file-validate` cleanly. P.S. I found this while working on a new spec file for Bitcoin, which you can find here: https://github.com/eklitzke/bitcoin-copr/blob/master/bitcoin.spec . I plan to contribute this work back upstream as well, once I've figured out more of these packaging issues (desktop files being one of them!). Tree-SHA512: cb290dd2c2fbcf7f08d838cf911d516d09a4e978d939e719a21a84db7232d1f534043616d7fbb52edd2b7d12389e5f0f8e53d29ac59d7282bdebde8224a2db7f Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # contrib/debian/bitcoin-qt.desktop	2020-04-01 12:43:17 -05:00
Wladimir J. van der Laan	dbbeb0aee4	Merge #10657: Utils: Improvements to ECDSA key-handling code ... 63179d0 Scope the ECDSA constant sizes to CPubKey / CKey classes (Jack Grigg) 1ce9f0a Ensure that ECDSA constant sizes are correctly-sized (Jack Grigg) 48abe78 Remove redundant `= 0` initialisations (Jack Grigg) 17fa391 Specify ECDSA constant sizes as constants (Jack Grigg) e4a1086 Update Debian copyright list (Jack Grigg) e181dbe Add comments (Jack Grigg) a3603ac Fix potential overflows in ECDSA DER parsers (Jack Grigg) Pull request description: Mostly trivial, but includes fixes to potential overflows in the ECDSA DER parsers. Cherry-picked from Zcash PR https://github.com/zcash/zcash/pull/2335 Tree-SHA512: 8fcbd51b0bd6723e5d33fa5d592f7cb68ed182796a9b837ecc8217991ad69d6c970258617dc00eb378c8caa4cec5d6b304d9d2c066acd40cda98e4da68e0caa4	2020-02-27 10:36:04 -06:00
Wladimir J. van der Laan	07316dda2c	Merge #11836: Rename rpcuser.py to rpcauth.py ... 3121d76 doc: Update release notes for share/rpcauth/rpcauth.py rename (Henrik Jonsson) 3fdb297 Rename rpcuser.py to rpcauth.py (Henrik Jonsson) Pull request description: This script creates `rpcauth` entries for bitcoin.conf, not the deprecated `rpcuser` entry, so this changes the name of the script to match. As discussed in #11830. Tree-SHA512: cd71c2a4043ef1381d3810b057cc83be3fac612df576b91b683ef91fdb7998c534b3b97a3313845eb867dc4bf7cc42a1250474d2261ab3f9ed2f884ca8ebd9f4	2020-02-27 09:50:41 -06:00
Wladimir J. van der Laan	fb18f2664f	Merge #11443: [qa] Allow "make cov" out-of-tree; Fix rpc mapping check ... fae60e3 qa: Fix lcov for out-of-tree builds (MarcoFalke) fae2673 qa: check-rpc-mapping must not run on empty lists (MarcoFalke) Pull request description: Random qa fixups: * `make cov` should work for out-of-tree builds * `check-rpc-mappings.py` should assert that it is actually checking something and the lists are not empty. Tree-SHA512: 2b66f69d6a1ae035c772f8ceb1d58dce904d98058330dad6ccb1421941e167aa748fe1c12126b87f43b0843f51fa85d89de079d586629fcaf8261c44a8dc6053	2020-02-08 23:33:25 -06:00
Jonas Schnelli	1017bbb84e	Merge #11419: Utils: Fix launchctl not being able to stop bitcoind ... ab5bba778 Fix launchctl not being able to stop bitcoind (Alejandro Avilés) Pull request description: `bitcoind` should not be launched as daemon from the Launch Agent. Otherwise, the process cannot be stopped from `launchctl stop`/`launchctl unload`. To reproduce the issue: ```console $ launchctl load ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist $ pgrep -fla bitcoin 60225 /usr/local/opt/bitcoin/bin/bitcoind $ launchctl unload ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist ``` Wait a few seconds and then run `pgrep` again: ```console $ pgrep -fla bitcoin 60225 /usr/local/opt/bitcoin/bin/bitcoind ``` The node is still running. This happens because Launch Agent is not supposed to run programs as daemons, since the agent makes sure they run in the background. Running them as daemons makes the Launch Agent lose control of the process and, so, it cannot be stopped. Tree-SHA512: 5342e1a858e478a226a1db292f1b8f8666bb252ee951753b131902c325ea3d47592cf245298decb423ac658a3175761b54dc2e7df6feea5343d65ba255613f67	2020-02-08 23:33:25 -06:00
UdjinM6	0fee42effa	Merge pull request #3312 from PastaPastaPasta/backports-0.16-pr6 ... Backports 0.16 pr6	2020-01-31 14:05:32 +03:00
UdjinM6	015a2a2f57	Merge pull request #3300 from PastaPastaPasta/backports-0.16-pr5 ... Backports 0.16 pr5	2020-01-31 13:53:29 +03:00
Pasta	f16a0f79aa	bitcoin -> Dash ... Signed-off-by: Pasta <pasta@dashboost.org>	2020-01-30 07:37:50 -06:00
Pieter Wuille	f32949fa91	Merge #11834: [verify-commits] Fix gpg.sh's echoing for commits with '\n' ... a38686cea [verify-commits] Fix gpg.sh's echoing for commits with '\n' (Matt Corallo) Pull request description: Should fix master travis failures Tree-SHA512: 1e96476e4db0474f1dc2c6973cdb1154316b7cec13d3fe46f3383cfe4f1ed30c2eee08a0d047931f20b2fa83baaacb4687f39e1cab6f264009cd0292134facdd	2020-01-30 07:32:32 -06:00
Wladimir J. van der Laan	46d2cc6159	Merge #11035: [contrib] Add Valgrind suppressions file ... 4a426d8 Add note about Valgrind suppressions file in developer-notes.md (practicalswift) 84e2462 contrib: Add Valgrind suppressions file (practicalswift) Pull request description: Includes known Valgrind warnings in our dependencies that cannot be fixed in-tree. Example use: ``` $ valgrind --suppressions=contrib/valgrind.supp src/test/test_bitcoin $ valgrind --suppressions=contrib/valgrind.supp --leak-check=full \ --show-leak-kinds=all src/test/test_bitcoin --log_level=test_suite ``` Running with the suppressions file under Ubuntu 16.04: ``` $ valgrind --suppressions=contrib/valgrind.supp --leak-check=full --show-leak-kinds=all src/test/test_bitcoin --log_level=test_suite --run_test=wallet_crypto … ==10769== LEAK SUMMARY: ==10769== definitely lost: 0 bytes in 0 blocks ==10769== indirectly lost: 0 bytes in 0 blocks ==10769== possibly lost: 0 bytes in 0 blocks ==10769== still reachable: 0 bytes in 0 blocks ==10769== suppressed: 72,704 bytes in 1 blocks ``` Running without the suppressions file under Ubuntu 16.04: ``` $ valgrind --leak-check=full --show-leak-kinds=all src/test/test_bitcoin --log_level=test_suite --run_test=wallet_crypto … ==10724== 72,704 bytes in 1 blocks are still reachable in loss record 1 of 1 ==10724== at 0x4C2DBF6: malloc (vg_replace_malloc.c:299) ==10724== by 0x6F74EFF: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21) ==10724== by 0x40106B9: call_init.part.0 (dl-init.c:72) ==10724== by 0x40107CA: call_init (dl-init.c:30) ==10724== by 0x40107CA: _dl_init (dl-init.c:120) ==10724== by 0x4000C69: ??? (in /lib/x86_64-linux-gnu/ld-2.23.so) ==10724== by 0x2: ??? ==10724== by 0x1FFF0006D2: ??? ==10724== by 0x1FFF0006E8: ??? ==10724== by 0x1FFF0006FF: ??? ==10724== ==10724== LEAK SUMMARY: ==10724== definitely lost: 0 bytes in 0 blocks ==10724== indirectly lost: 0 bytes in 0 blocks ==10724== possibly lost: 0 bytes in 0 blocks ==10724== still reachable: 72,704 bytes in 1 blocks ==10724== suppressed: 0 bytes in 0 blocks ``` Tree-SHA512: 9c92079fc61313ea678deb6aaa16a3a71c3154c757459793eb9ca0d90a9a74c6faebfb04c9135e1b398ca34224fb7f03bd9c488ea0e8debf6894f69f030a31d3	2020-01-29 16:23:57 -06:00
UdjinM6	9166ecdbcf	Add automake package to dash-win-signer's packages list (#3307)	2020-01-29 09:26:01 +01:00
Pasta	9c914a1c14	Merge #10529: Improve bitcoind systemd service file ... 16be7dd Improve bitcoind systemd service file (Florian Schmaus) Pull request description: Add comment how further options can be added or existing ones modified. Use /run/${RuntimeDirectory} for PID file. Remove TimeoutStopSec, TimeoutStartSec, StartLimitInterval, StartLimitBurst directives as those should be set indivdually. Remove Group to user the bitcoin user's default group. Changed Restart from 'always' to 'on-failure' (can also be overwritten individually). Tree-SHA512: f76674c11fd6e3faaf786aa05686926523d9c875aad6b776337f800108fdb716470286805c532b494f8cf713cb5eea6b735e1c7c238ffb407a5cc909dda41aa4	2020-01-22 09:11:34 -06:00
Wladimir J. van der Laan	e357bda75b	Merge #11467: Fix typos. Use nullptr instead of NULL. ... 0aacfa4 Remove accidental stray semicolon (practicalswift) 68feb49 Use nullptr instead of NULL (practicalswift) c6b07fd Fix a vs. an typo (practicalswift) Pull request description: Minor cleanups: * Typo: Fix a vs. an typo * Typo: Remove accidental stray semicolon (only remaining instance in repo) * Correctness/consistency: Use `nullptr` instead of `NULL` (only remaining instance in repo) Tree-SHA512: 47142e557da9d3fa0b532c46edeb7f356a1f6dc5973e60b0e496badff3581ff696eade542d49da777ac7f2e895129cc8487ccdb1984ff828434fa86f9a56dad0	2020-01-16 09:22:46 -06:00
UdjinM6	ffcb2f63a1	More of 11300	2020-01-10 10:34:04 -06:00
UdjinM6	66dd61d54d	More of 10753	2020-01-10 10:34:03 -06:00
UdjinM6	0b15551e3d	More of 10680	2020-01-10 10:34:02 -06:00
MarcoFalke	b1774d8735	Merge #11246: github-merge: Coalesce git fetches ... dabee00ef github-merge: Coalesce git fetches (Wladimir J. van der Laan) Pull request description: Fetch the destination branch as well as PR in one go. Saves a few seconds (as well as one ssh authentication, when using a yubikey) when using github-merge.py. Tree-SHA512: 618fcc07f60b63de3b7818094c5a307933324b76418aa02c509209bb7b540b3da0abe312bbfd0ca843469ed82228b2c43c2361180ba81bee13038aafac4a14b3	2020-01-10 10:33:58 -06:00
Wladimir J. van der Laan	b5e2f73fee	contrib: Ignore historical release notes for whitespace check ... Lint checks should not test these, they are historical documents, and we don't want to encourage silly changes to them to satisfy a checker. Hopefully makes travis pass again on master. Tree-SHA512: 37e6716c4fd5e8a4e579f9b84042e6b0ac224836b6c851cd1ca3f7d46611ffd3003bed0ae08dd0457f69d6eaa485a0d21c631e7ef16b14bdb0f2f78ea700332d	2020-01-10 10:33:56 -06:00
MarcoFalke	80f4de55fd	Merge #11300: Tests: Add a lint check for trailing whitespace *dash* no travis ... *DASH* doesn't implement this check into travis 1f379b1f0 Add tab char lint check and exclude imported dependencies (MeshCollider) dd365612f Add a lint check for trailing whitespace. (Evan Klitzke) Pull request description: This is a new attempt at #11005 Addressed nits, excluded imported dependencies, squashed the original commits, and added a test for tab characters in the *.cpp *.h *.md *.py *.sh files too as per @practicalswift suggestion Tree-SHA512: d2dfbedc8469026f39b0c63d9a71d8b8e2ed3815d69fecaabad10304d977d6345728c4c865ec7600ed539b1f7cabaa826b50312f4d2eef0a1583d4ff9024c36d	2020-01-10 10:33:56 -06:00
MarcoFalke	3ca3c65897	Merge #10753: test: Check RPC argument mapping *dash* no travis ... *DASH* DOES NOT IMPLEMENT RUNNING THIS IN TRAVIS 77aa9e59e test: Check RPC argument mapping (Wladimir J. van der Laan) Pull request description: Parse the dispatch tables from the server implementation files, and the conversion table from the client (see #10751). Perform the following consistency checks: - Arguments defined in conversion table, must be present in dispatch table. If not, it was probably forgotten to add them to the dispatch table, and they will not work. - Arguments defined in conversion table must have the same names as in the dispatch table. If not, they will not work. - All aliases for an argument must either be present in the conversion table, or not. Anything in between means an oversight and some aliases won't work. Any of these results in an error. It also performs a consistency check to see if the same named argument is sometimes converted, and sometimes not. E.g. one RPC call might have a 'verbose' argument that is converted, another RPC call might have one that is not converted. This is not necessarily wrong, but points at a possible error (as well as makes the API harder to memorize) - so it is emitted as a warning (could upgrade this to error). This test is added to travis and run when `CHECK_DOC`. Currently fails with the following output: ``` * Checking consistency between dispatch tables and vRPCConvertParams ERROR: createrawtransaction argument 3 (named optintorbf in vRPCConvertParams) is not defined in dispatch table ERROR: getblock argument ['verbosity', 'verbose'] has conflicts in vRPCConvertParams conversion specifier [True, False] WARNING: conversion mismatch for argument named verbose ([('getblock', False), ('getblockheader', True), ('getmempoolancestors', True), ('getmempooldescendants', True), ('getrawmempool', True), ('getrawtransaction', True)]) ``` - ~#10698 fixes the first ERROR~ - #10747 fixes the second ERROR, as well as the WARNING Update: #10698 was merged, leaving: ``` * Checking consistency between dispatch tables and vRPCConvertParams ERROR: getblock argument ['verbosity', 'verbose'] has conflicts in vRPCConvertParams conversion specifier [True, False] WARNING: conversion mismatch for argument named verbose ([('getblock', False), ('getblockheader', True), ('getmempoolancestors', True), ('getmempooldescendants', True), ('getrawmempool', True), ('getrawtransaction', True)]) ``` Tree-SHA512: feabebfbeda5d4613b2b9d5265aa6bde4e1a0235297ffd48fa415ad7edc531d9ed7913fe76d191ac60d481a915a326f216bc93de3c671e45e1d14e97d07dea7a	2020-01-10 10:33:56 -06:00
MarcoFalke	b1af3b8db9	Merge #10680: Fix inconsistencies and grammar in various files ... 1d8df0141 Fix MD formatting in REST-interface.md and spelling mistake in test_runner.py (MeshCollider) 41f3e84aa Fix inconsistencies and grammar in various files (MeshCollider) Pull request description: Just a simple fix of some inconsistent capitalization, formatting and grammar in a few files (no code changes) Tree-SHA512: 60b12a5a5c69a1af4a25b7db0b32ed806ed62ad2966cee08b3792a7cfa7f51848fd485349b4c09e60a7eedfdf55ee730c51daa066d6e226ae404c93342bf3e13 Without RPM stuff	2020-01-10 10:33:53 -06:00
MarcoFalke	561ec27683	Merge #10781: Python cleanups ... 78214588d Use for-loop instead of list comprehension (practicalswift) 823979436 Use the variable name _ for unused return values (practicalswift) 2e6080bbf Remove unused variables and/or function calls (practicalswift) 9b94054b7 Avoid reference to undefined name: stderr does not exist, sys.stderr does (practicalswift) 51cb6b822 Use print(...) instead of undefined printf(...) (practicalswift) 25cd520fc Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs (practicalswift) Pull request description: Python cleanups: * Avoid reference to undefined name: `stderr` does not exist, `sys.stderr` does * Use `print(...)` instead of undefined `printf(...)` * Avoid redefinition of variable (`tx`) in list comprehension * Remove unused variables and/or function calls * Use `sys.exit(...)` instead of `exit(...)`: [`exit(...)` should not be used in programs](https://github.com/bitcoin/bitcoin/pull/10753#discussion_r125935027) Tree-SHA512: 1238dfbc1d20f7edadea5e5406a589f293065638f6234809f0d5b6ba746dffe3d276bc5884c7af388a6c798c61a8759faaccf57f381225644754c0f61914eb4b	2020-01-02 22:01:29 -06:00
MarcoFalke	c9b20f027f	Merge #10956: Fix typos ... 9d5e98ff8 Fix typos. (practicalswift) Pull request description: Fix some typos not covered by #10705. Tree-SHA512: f06e9541f6ae13ef5d6731399b61795997b21a8816abeb1749c93e99a5c47354e6cbd4a3d145f4dc6ef8a13db179799a3121ecbb7288abf3e8d81cdf81500d37	2020-01-01 21:31:39 -06:00
MarcoFalke	1ba944c55e	Merge #10705: Trivial: spelling fixes ... f42fc1d50 doc: spelling fixes (klemens) Pull request description: patch contains some spelling fixes ( just in comments ) as found by a bot ( http://www.misfix.org, https://github.com/ka7/misspell_fixer ). Tree-SHA512: ba6046cfcd81b0783420daae7d776be92dd7b85a593e212f8f1b4403aca9b1b6af12cef7080d4ea5ed4a14952fd25e4300109a59c414e08f5395cdb9947bb750	2020-01-01 21:31:29 -06:00
-k	7f8b8b31e4	Backport osslsigncode 2.0 - bitcoin#16669 and bitcoin#17671 (#3258) ... * build: use osslsigncode 2.0 in gitian The original osslsigncode project (https://sourceforge.net/projects/osslsigncode/) has been marked as abandonware, "This is now - and has been for a long while - abandonware. Feel free to create your own forks etc.". However, a fork at https://github.com/mtrojnar/osslsigncode has emerged that has incorporated theuni's patches, updated the tool to work with OpenSSL 1.1 and made other improvements. This commit switches the windows signer descriptor to use this new version of osslsigncode. * Fixed wget call in gitian-build.py Co-authored-by: Michael <fanquake@gmail.com> Co-authored-by: willyk <k.o.willy@gmail.com>	2020-01-01 17:15:08 +03:00
Alexander Block	dc656e3236	Bump version to 0.16 on develop (#3239) ... * Bump version to 0.16 * Run gen-manpages.sh * Bump versions in gitian descriptors	2019-12-13 18:52:52 +01:00
UdjinM6	0c9c27c6fd	Add ccache to gitian packages lists (#3237)	2019-12-12 11:47:04 +01:00
UdjinM6	dad102669b	Update static and dns seeds for mainnet and testnet (#3234) ... * Drop (test.)dnsseed.masternode.io * makeseeds.py mainnet 1185193, testnet 225964 * generate-seeds.py * Update tor.md with live onion nodes All old nodes are down	2019-12-11 12:30:38 +01:00
Alexander Block	9378c271b6	Modify makesseeds.py to work with "protx list valid 1" instead of "masternode list (#3235) ... * Modify makesseeds.py to work with "protx list valid 1" instead of "masternode list" This allows better filtering for MN owners with multiple MNs. This commit also removes some unsupported fields, e.g. "protocol", "lastseen", ... * Update contrib/seeds/README.md with new instructions	2019-12-10 18:18:44 +03:00
UdjinM6	37f96f5a3a	Bump version to 0.15 and update few const-s/chainparams (#3204) ... * Bump const-s * Bump version to 0.15 * Run gen-manpages.sh	2019-11-21 23:52:35 +03:00
strophy	9de994988b	Compliance changes to terminology (#3211) ... Replace inaccurate user-facing descriptions of PS as anonymous to mixed or private, since Dash is a transparent blockchain.	2019-11-21 23:49:35 +03:00
Nathan Marley	d3ce0964b2	Add Qt GUI refresh w/branding updates (#3000) ... * Update Dash app and toolbar icons * Update icons and images * Remove menubar icons * Add Dash logo to top-right of menubar * Remove the small PrivateSend buttons * Remove image entirely from About modal * Update CSS for new theme changes * Restore splash testnet image * Make entire toolbar button clickable * Fix address book and shrink transaction icons * Revert "Restore splash testnet image" This reverts commit 2df07ff7d3. * Restore original direction for tx in/out arrows * Add transparency to icons * Remove unused icons * Resize way too small icons * `mogrify src/qt/res/*/*.png` * Drop `light` from `optimize-pngs.py` * `python3 contrib/devtools/optimize-pngs.py` "Total reduction: 42507 bytes" * Restore old remove icon as console_remove	2019-10-31 20:30:21 +03:00
PastaPastaPasta	3c21d2577f	Slightly adjust some README.md files (#3175) ... Signed-off-by: Pasta <pasta@dashboost.org>	2019-10-29 21:37:18 +03:00
Nathan Marley	1cbe280ada	Qt: Remove old themes (#3141) ... * Remove crownium files * Remove trad theme files * Remove drkblue theme files * Remove light-retro theme files * Remove old themes from optimize-pngs script * Remove refs to old themes in Makefile.qt * Remove more old theme file references * Remove old themes from options dialog * No need to care about themes for images and icons anymore * Bring `trad` back * Drop remaining `drkblue` references Rename files that are actually used and drop no longer needed ones	2019-10-10 14:53:00 +03:00
MarcoFalke	f38caa9884	Merge #11676: contrib/init: Update openrc-run filename ... 2f041f0e7 contrib/init: Update openrc-run filename (Luke Dashjr) Pull request description: OpenRC changed their program binary names in 2014 (3 years ago), and using the old names has loud warnings now Tree-SHA512: 2b81802b21c32b8df6010142f9593c0b6cc814a052f83b7f5654f6885566e8dbcaf4da772145fa2cf5d94c16c2fb488c5d4879f71021407c4d7b3a3b7e7ed21e	2019-09-30 08:33:34 +02:00
Wladimir J. van der Laan	7919c96818	Merge #11539: [verify-commits] Allow revoked keys to expire ... d23be30 [verify-commits] Allow revoked keys to expire (Matt Corallo) Pull request description: This should fix verify-commits on master. Tree-SHA512: 9bfca41fdfcdb11f6d07fcbc80a7b2de37706051e963292e0fbb4c608f146c87b65ab1e8395792197b4a7099e89fa045f278a60276672f6540b68d5e15b5a4a7	2019-09-30 08:33:16 +02:00
Wladimir J. van der Laan	7e8d1fcc1b	Merge #11097: gitian: quick hack to fix version string in releases ... 4452829 gitian: quick hack to fix version string in releases (Cory Fields) Pull request description: Credit: @luke-jr Release version strings were broken in Gitian by #7522. This is a minimal fix suitable for 0.15. After this, we should fix up version handling for good so that gitian packages the correct string in the release tarball, so that git is not required to get the tag name. Tree-SHA512: fa609a744c46306b0809f08fed6e96eff41b13e82f3e213711e4abef370558b64a68972f283a038330882cb6c40b32547fbb0f89b8058cc2c6025bff134473c3	2019-09-23 20:49:54 +02:00
UdjinM6	becca24fcc	Few fixes in docs/comments (#3068) ... * Few fixes in docs/comments * Add descriptions	2019-08-28 10:54:19 +03:00
PastaPastaPasta	a78dcfdec2	Add the public GPG key for Pasta for Gitian building (#3057) ... * Add the public GPG key for Pasta for Gitain building * change file ending from gpg to pgp	2019-08-16 14:52:41 +03:00
Wladimir J. van der Laan	cfc6975271	Merge #10985: Add undocumented -forcecompactdb to force LevelDB compactions ... 8842d1a Add undocumented -forcecompactdb to force LevelDB compactions (Pieter Wuille) Pull request description: Tree-SHA512: de91f3f574f75248fa6e5091089c840957fae5a972ebcd2b89493f7d777d4658560a6f5a3b43ab0c9b2c333ad98f9f185ae224c9caffc1a5e8df369cc414f123	2019-08-12 09:07:03 -05:00
Wladimir J. van der Laan	453d756571	Merge #10148: Use non-atomic flushing with block replay ... 176c021 [qa] Test non-atomic chainstate writes (Suhas Daftuar) d6af06d Dont create pcoinsTip until after ReplayBlocks. (Matt Corallo) eaca1b7 Random db flush crash simulator (Pieter Wuille) 0580ee0 Adapt memory usage estimation for flushing (Pieter Wuille) 013a56a Non-atomic flushing using the blockchain as replay journal (Pieter Wuille) b3a279c [MOVEONLY] Move LastCommonAncestor to chain (Pieter Wuille) Tree-SHA512: 47ccc62303f9075c44d2a914be75bd6969ff881a857a2ff1227f05ec7def6f4c71c46680c5a28cb150c814999526797dc05cf2701fde1369c06169f46eccddee	2019-08-01 14:57:28 -05:00
Wladimir J. van der Laan	ec01825ba5	Merge #10786: Add PR description to merge commit in github-merge.py ... 475c08c Add PR description to merge commit in github-merge.py (Pieter Wuille) Pull request description: There is often some context given in PR descriptions that is missing from commits, and it may be worthwhile to retain that information in our history in git. This PR adds that information to the merge commit when created through `github-merge.py`. We should also encourage people to provide as much information as possible in the PR commits themselves, but I believe that is an orthogonal issue. Individual commits don't need to have a description of the overall goal of a PR. Tree-SHA512: cbae46ec24ce911744e11a07e5d51895d3acc79659db306d8124304ef8e422bba99001ee2a741b08c92a5eb39d9c3f6b723622b20d6553ca5cfa0a8de866194c	2019-07-17 19:01:41 -05:00
Wladimir J. van der Laan	b195cbb5e7	Merge #10651: Verify binaries from bitcoincore.org and bitcoin.org ... 6270d62 Verify binaries from bitcoincore.org and bitcoin.org (Matt Corallo) Tree-SHA512: 39e99ce9be3e7c99d17b296749c0af53c867039bc95fd5b03572593c812817decea75e7296bb66e89ba460518210d84114b7bdc22465df621340319b47bd4303	2019-07-17 19:01:41 -05:00
UdjinM6	9d49fbff69	Merge pull request #3025 from PastaPastaPasta/backports-0.15-pr20 ... Backports 0.15 pr20	2019-07-17 12:35:54 +03:00
Nathan Marley	acab8c552f	Add Dash Core Group codesign certificate (#3027)	2019-07-16 12:38:17 +03:00
UdjinM6	9041364b52	Merge pull request #3028 from PastaPastaPasta/backport-12588 ... Backport a couple of ZMQ fixes	2019-07-15 14:39:43 +03:00
Nathan Marley	a1c4321e9e	Fix osslsigncode compile issue in gitian-build (#3026)	2019-07-15 14:39:14 +03:00
Jonas Schnelli	216cbfdd9c	Merge #11792: Trivial: fix comments for ZeroMQ bitcoind args ... 33698c94b Trivial: fix comments for ZeroMQ bitcoind args (aaron-hanson) Pull request description: The ZeroMQ command-line args suggested here had the "-zmqpubhashblock" arg duplicated and the "-zmqpubrawblock" arg missing. Tree-SHA512: ef3a90f6d82367104aa751778074f6f56d2aaa9cbbf980731f60ee77393db256551423f5414c5b41f09707d08828afc663d06661152ef504a690ceb13c80bc0d Signed-off-by: Pasta <pasta@dashboost.org> # Conflicts: # contrib/zmq/zmq_sub.py # contrib/zmq/zmq_sub3.4.py	2019-07-12 19:14:12 -05:00
Wladimir J. van der Laan	a38648c911	Merge #12588: [Utils] Remove deprecated PyZMQ call from Python ZMQ example ... 6058766de Remove deprecated PyZMQ call from Python ZMQ example (Michał Zabielski) Pull request description: PyZMQ 17.0.0 has deprecated and removed zmq.asyncio.install() call with advice to use asyncio native run-loop instead of zmq specific. This caused exception when running the contrib/zmq/zmq_sub*.py examples. This commit simply follows the advice and fixes mentioned examples. Tree-SHA512: af357aafa5eb9506cfa3f513f06979bbc49f6132fddc1e96fbcea175da4f8e2ea298be7c7055e7d3377f0814364e13bb88b5c195f6a07898cd28c341d23a93c5	2019-07-12 19:08:48 -05:00
Wladimir J. van der Laan	f68c7bc5c8	Merge #10626: doc: Remove outdated minrelaytxfee comment ... fab9b60 doc: Remove outdated minrelaytxfee comment (MarcoFalke) Tree-SHA512: e36c5a554a9773f034c2d358c52a772688009a5a71dfd3f664d9b5566c98378f44ef7c6dc0902b42d69ab5fd54b60d4850a2903823d0b2309c7ae063d1923f7f	2019-07-11 10:34:46 -05:00
Wladimir J. van der Laan	3f4d08d36a	Merge #10565: [coverage] Remove subtrees and benchmarks from coverage report ... d5711f4 Filter subtrees and and benchmarks from coverage report (Andrew Chow) 405b86a Replace lcov -r commands with faster way (Andrew Chow) c8914b9 Have `make cov` optionally include branch coverage statistics (Andrew Chow) Tree-SHA512: 9c349a7baeb7430ea586617c52f91177df58e3546d6dc573e26815ddb79e30ab1873542d85ac1daca5e1fb2c6d6c8965824b42d027b6b0496a744af57b095852	2019-07-11 10:34:46 -05:00
Wladimir J. van der Laan	2116e93019	Merge #10276: contrib/verifybinaries: allow filtering by platform ... 8d4dafd contrib/verifybinaries: allow filtering by platform (Andres G. Aragoneses) Tree-SHA512: 5c117d18fd6e73cdbbf39c610f521bccb32ca7100eb8d5d5ed9c664514c37b32bd2f94f357b64c34f7c093e0c09312ecff330b7f5c708700d4b48643780ebac5	2019-07-11 10:34:46 -05:00
Wladimir J. van der Laan	a0bc91a578	Merge #10480: Improve commit-check-script.sh ... 5432fc3 Fail on commit with VERIFY SCRIPT but no scripted-diff (Pieter Wuille) Tree-SHA512: 687b6c825f6f882f9c8e9d301bc893383710bad70216fa40b95f7e24d83a7148f9c759c3e4bd905a6cd26960829f8f6bd03106dc6c83ac312bf34ad239917018	2019-07-09 13:08:20 -05:00
Alexander Block	780bffeb78	Enable stacktrace support in gitian builds (#3006) ... * Remove use of -rdynamic This causes check-symbols to fail horribly and also turned out to be not required when using libbacktrace. It was only required when using "backtrace()" from "<execinfo.h>" * Remove spurious ], from configure.ac * Add -DENABLE_STACKTRACES=1 to CMakeLists.txt * Remove unused method my_backtrace_simple_callback * Use fs::path().filename() instead of basename() * Add static g_exeFileName and g_exeFileBaseName * Use .exe.dbg file when available * Use uint64_t instead of uintptr_t * Implement GetBaseAddress() for unix and win32 * Implement unified crash_info and use it everywhere before printing crash info * Print a serialized version of crash_info when there is no debug info * Implement "-printcrashinfo" command line option * Compile stacktrace support unconditionally and only make crash hooks conditional This also renames the --enable-stacktraces option to --enable-crash-hooks * Enable crash hooks in win/linux Gitian builds * Try to load .debug file on MacOS and enable crash hooks for osx Gitian builds * Check for dsymutil and if it needs --flat * Create .debug files in osx Gitian build * Handle review comments * Also print crash description when no stacktrace is available * Unconditionally add -g1 debug information Instead of making it dependent on "--enable-crash-hooks". We will need the debug info every time now, even in release builds. * Put MacOS debug info into dSYM symbols instead of plain .debug files * Implement MacOS specific GetBaseAddress	2019-07-02 07:16:11 +03:00
Wladimir J. van der Laan	11dbe39b48	Merge #10317: Remove unused Python imports ... 0c60c63 Remove unused Python imports (practicalswift) Tree-SHA512: c7ae6a8ae2c751b771804960498bf270ab022c80fa9e1b39118d5986d890c8cdfc27a3cc24bf28c080d8088ddc11facd1f2881ba2c209cdd819675fda4689d83	2019-06-24 11:39:34 -05:00
Wladimir J. van der Laan	d84660729e	Merge #7522: Bugfix: Only use git for build info if the repository is actually the right one ... ed1fcdc Bugfix: Detect genbuild.sh in repo correctly (Luke Dashjr) e98e3dd Bugfix: Only use git for build info if the repository is actually the right one (Luke Dashjr) Tree-SHA512: 510d7ec8cfeff4e8e0c7ac53631eb32c7acaada7017e7f8cc2e6f60d86afe1cd131870582e01022f961c85a783a130bcb8fef971f8b110070c9c02afda020726	2019-06-24 11:39:34 -05:00
Wladimir J. van der Laan	2edd094a21	Merge #10189: devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. ... 0f3471f net: make CNode's id private (Cory Fields) 9ff0a51 scripted-diff: net: Use accessor rather than node's id directly (Cory Fields) e50c33e devtools: add script to verify scriptable changes (Cory Fields) skipped travis changes Tree-SHA512: a0ff50f4e1d38a2b63109b4996546c91b3e02e00d92c0bf04f48792948f78b1f6d9227a15d25c823fd4723a0277fc6a32c2c1287c7abbb7e50fd82ffb0f8d994 pnode->id to pnode->GetId() Signed-off-by: Pasta <pasta@dashboost.org>	2019-06-19 08:20:15 -05:00
Pasta	282d1554df	adjust examples/dash.conf ... Signed-off-by: Pasta <Pasta@dash.org>	2019-05-27 09:03:19 -05:00
Wladimir J. van der Laan	5153439633	Merge #10036: Fix init README format to render correctly on github ... b99fbad Fix init README format to render correctly on github (Jameson Lopp) Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da	2019-05-23 09:32:05 -05:00
MarcoFalke	c8a565d6e6	Merge #10090: Update bitcoin.conf with example for pruning ... c0651cc Update bitcoin.conf with example for pruning (Kyle Honeycutt) Tree-SHA512: f27180ac5d5a4bd32c7a63de156ca14eb8068509e64d386ca84ee16d0dacfa8e1bab9a8e7b88175fae12c8d823f71f8705d413f224a15d5aa7cf059f416fa023	2019-05-23 07:58:32 -05:00
UdjinM6	428f304506	Implement rawchainlocksig and rawtxlocksig (#2930) ... * Pass is-lock into `CInstantSendManager::UpdateWalletTransaction()` * Implement `rawtxlocksig` which pushes tx+islock * Implement `rawchainlocksig` which pushes block+clsig * fix log category	2019-05-23 12:13:58 +03:00
UdjinM6	92e5a38314	Merge pull request #2911 from PastaPastaPasta/backports-0.15-pr10 ... Backports 0.15 pr10	2019-05-22 17:50:44 +03:00
MarcoFalke	94aa904c06	Merge #10107: Remove unused variable. Remove accidental trailing semicolons in Python code ... 85de9d4 Remove call to gettransaction(...) where the result is unused (practicalswift) bd02422 Remove accidental trailing semicolons in Python code (practicalswift) Tree-SHA512: 23ffb1ccc29bf73b334d62b274ab614cb40e2969147adccacbaecc69a410a661a9f2dd9e9cbc8a70bd2c7f345095efc68743f288eb866315e0e8731441ba01d0	2019-05-21 08:52:47 -05:00
MarcoFalke	9f07f489de	Merge #10047: [tests] Remove unused variables and imports ... 3897459 [tests] Remove unused variables (practicalswift) 72163d4 [tests] Remove unused and duplicate imports (practicalswift) Tree-SHA512: 926af14b844bfca3bdd08b3cfdcb0edd3652efb4612d5571fee9abb917a6ce4e7d11d3601ff9c3d017e943ebe1e9ebdfccaf0af3db84d201b61941e9c1c9146a	2019-05-21 08:52:44 -05:00
Wladimir J. van der Laan	55dc3dae52	Merge #10486: devtools: Retry after signing fails in github-merge ... 1983c87 devtools: Retry after signing fails in github-merge (Wladimir J. van der Laan) Tree-SHA512: f5ef91c93f4e53c9b234e7dc3ac398c6715144021d92c8592174d02c672ae99d27e88faefd52239c2a74c8e49cfd3a979e0229580016ce9a74829bdb0af206ec	2019-05-19 20:43:02 -05:00
Wladimir J. van der Laan	0d2f2b3617	Merge #10273: [scripts] Minor improvements to macdeployqtplus script. ... e8babc4 Use `with` in `macdeployqtplus` script. (Chris Gavin) 4f3ac7d Remove unused variable from `macdeployqtplus` script. (Chris Gavin) Tree-SHA512: 0259506b36f3bfcc64ada951dcd4fdab1611ef76a39f92effd1163b6d8fab06bdbf50784b4b22f8b1483697c3029c12cfee5372b442ab445887ac4f928f6de80	2019-05-19 20:43:02 -05:00
Wladimir J. van der Laan	317b797e2a	Merge #9670: contrib: github-merge improvements ... b508424 contrib: github-merge improvements (Wladimir J. van der Laan) Tree-SHA512: 56a34e887716bf6bfcd1b6520f6b9a1bb742e1ad17e75618caf982af71fceb75d50caec1bf4279cb9a2f7a74319f1bcec4c824682841bd6e994acc0991616451	2019-05-19 20:43:02 -05:00
Wladimir J. van der Laan	13cdff4989	Merge #10104: linearize script: Option to use RPC cookie ... bd41d98 Datadir option in linearize scripts (Andrew Chow) Tree-SHA512: 0d11866b574986c087ec962a8a9fc0b6dfee8175ae20ef827f8b4a143f657c5bffc9f9696e9dabf29b68002003a5b6a7d8ac473231b5c9c81c3a4fa0318f5bd0	2019-05-19 20:43:00 -05:00
PastaPastaPasta	6edbc9cebd	Merge bitcoin#9956: Reorganise qa directory (#2912) ... * Merge #9956: Reorganise qa directory 63d66ba Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py (John Newbery) 5b0bff4 Rename --enable-extended-rpc-tests to --enable-extended-functional-tests (John Newbery) a9bd622 Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py (John Newbery) c28ee91 Rename rpc-tests directory to functional (John Newbery) 00902c4 Rename qa directory to test (John Newbery) Tree-SHA512: ee7125c0c647d81590177beef2c8852c4ef76fdcf888096d9d4d360562a01d8d3b453345c3040487b2a043935bd1e7e80018f34462d6e02262bedbe23edcc576 resolve build errors Signed-off-by: Pasta <Pasta@dash.org> update test_runner.py in testintegrations.sh Signed-off-by: Pasta <Pasta@dash.org> * moved dash specific tests Signed-off-by: Pasta <Pasta@dash.org> * dashify README.md Signed-off-by: Pasta <Pasta@dash.org> * removed autoix*.py Signed-off-by: Pasta <Pasta@dash.org> * change back file perms * dedashify Signed-off-by: Pasta <Pasta@dash.org>	2019-05-19 23:20:34 +03:00
UdjinM6	89f6f75910	Implement zmq notifications for chainlocked blocks (#2899) ... * Unify zmq message order * Implement `zmqpubhashchainlock` and `zmqpubrawchainlock`	2019-05-08 12:12:54 +03:00
UdjinM6	9df6acdc2b	Disable in-wallet miner for win/macos Travis/Gitian builds (#2778) ... * Add new configure option to disable in-wallet miner * Use new option to disable in-wallet miner for win/macos Travis/Gitian builds	2019-03-19 10:43:37 +03:00
PastaPastaPasta	6f90cf7a17	Merge bitcoin#9602: Remove coin age priority and free transactions - implementation (#2768) ... b421e6d Update example bitcoin.conf (Alex Morcos) 7d4e950 Allow setting minrelaytxfee to 0 (Alex Morcos) 359e8a0 [cleanup] Remove coin age priority completely. (Alex Morcos) f9b9371 [rpc] Remove priorityDelta from prioritisetransaction (Alex Morcos) 49be7e1 [rpc] Remove priority information from mempool RPC calls (Alex Morcos) 0315888 [test] Remove priority from tests (Alex Morcos) f838005 No longer allow "free" transactions (Alex Morcos) ad727f4 [rpc] sendrawtransaction no longer bypasses minRelayTxFee (Alex Morcos) fe282ac [cleanup] Remove estimatePriority and estimateSmartPriority (Alex Morcos) 400b151 [debug] Change -printpriority option (Alex Morcos) 272b25a [mining] Remove -blockprioritysize. (Alex Morcos) 12839cd [rpc] Remove estimatepriority and estimatesmartpriority. (Alex Morcos) ddf58c7 wallet: Remove sendfree (MarcoFalke) Tree-SHA512: a9a4499405923ce794ef18f9e334dbbd59dfc73a3dc2df6f85cc9c62af6f353ec2eed9c2d5e58e904f918d0d7ab738f403dd4939d9bc2276136864fe63710782 Signed-off-by: Pasta <Pasta@dash.org> Fix backport and fix dash specific priority code	2019-03-14 17:44:42 +03:00
Pasta	0db2d1596a	code review and reset file perms	2019-03-03 20:50:39 -06:00
Pasta	c3eb0c7887	reset file perms	2019-02-26 16:50:25 -06:00
Wladimir J. van der Laan	e8df27f8ee	Merge #9984: devtools: Make github-merge compute SHA512 from git, instead of worktree ... a327e8e devtools: Make github-merge compute SHA512 from git, instead of worktree (Wladimir J. van der Laan) Tree-SHA512: 22ec7712876be4ab361015a2dd75a09628ec59105ffe3260126f899d8f3ff8666351b65b9a4dfe83f78eb777730442cd0352b155d7f573424f7fc1c4dbc0ddd2	2019-02-26 16:41:07 -06:00
Wladimir J. van der Laan	c55e019bf7	Merge #9940: Fix verify-commits on OSX, update for new bad Tree-SHA512, point travis to different keyservers ... df5bae2 Update trusted-sha512-root-commit for new bad tree hash (Matt Corallo) efc06c2 If GNU sha512sum is missing, try perl shasum in verify-commits (Matt Corallo) 8ed849f Fix travis failing to fetch keys from the sks keyserver pool (Matt Corallo) fd5e905 Make verify-commits.sh non-recursive (Matt Corallo) Tree-SHA512: 457cc81d6e0a77ab32d030ecd058c59857f22cb998a1394593e115639081f3fdc74a6376035b77be0712ad5cb9143bc3f498b77e99eb66034492dbbb38c39bc6	2019-02-26 16:41:05 -06:00
Wladimir J. van der Laan	f9a2e4c4fc	Merge #9514: release: Windows signing script ... 09fe2d9 release: update docs to show basic codesigning procedure (Cory Fields) f642753 release: create a bundle for the new signing script (Cory Fields) 0068361 release: add win detached sig creator and our cert chain (Cory Fields) Tree-SHA512: 032ad84697c70faaf857b9187f548282722cffca95d658e36413dc048ff02d9183253373254ffcc1158afb71140753f35abfc9fc8781ea5329c04d13c98759c0	2019-02-26 16:41:04 -06:00
UdjinM6	0b552be20b	Fix file permissions broken in 2682 (#2717)	2019-02-20 12:03:48 +03:00
UdjinM6	a79b928532	Merge pull request #2682 from PastaPastaPasta/backports-0.15-pr6 ... Backports 0.15 pr6	2019-02-19 13:04:49 +03:00
UdjinM6	86fc050495	Drop no longer used code and bump min protos (#2697) ... * Drop registry deletion of the old key * Drop no longer used CGovernanceObjectVoteFile::RemoveOldVotes() * Drop temporary disconnect code and bump min protos to 70213 * drop comment * fix	2019-02-12 22:51:21 +03:00
Wladimir J. van der Laan	9c8c12ed47	devtools: Fix a syntax error typo ... Fix a typo introduced in #9880 causing the script to not even parse.	2019-02-04 19:58:17 -06:00
Wladimir J. van der Laan	8a436ec36a	Merge #9932: Fix verify-commits on travis and always check top commit's tree ... b3ec305 Fix bashisms in verify-commits and always check top commit's tree (Matt Corallo) f20e664 Check gpg version before setting --weak-digest (Matt Corallo) Tree-SHA512: f87247008ae6a265e3fd371f00aec0e84f1feb713bf5859eab139a88a4e205e1f26de7b510bcc2c3ab538d5443978a48ec920d25b52b9601e625d198fa2d725f	2019-02-04 19:58:15 -06:00
Wladimir J. van der Laan	6addbe0747	Merge #9880: Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 ... bbd7579 Fix regsig checking for subkey sigs in verify-commits (Matt Corallo) d025bc7 Allow any subkey in verify-commits (Matt Corallo) eddc77a Add comment re: why SHA1 is disabled (Peter Todd) d9c450f Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 (Matt Corallo) be908a6 Fail merge if there are any symlinks (Matt Corallo) Tree-SHA512: bb66c59cc1c6b1c86d7d8be7adb0769c6598c0e28ad927409941f30af87d390521e82fc13700ee22e92db1bd571db3e19a152ec7b2c0349c6e06f5de62c0b65f	2019-02-04 19:58:07 -06:00
Wladimir J. van der Laan	8944b5a784	Merge #9905: [contrib] gh-merge: Move second sha512 check to the end ... fa7da3f [contrib] gh-merge: Move second sha512 check to before signing (MarcoFalke) Tree-SHA512: b3d96f928a013f6fdc416035b8ef5cd7c750ab0922156e1fd712cd27ec75847497109f43a96559b945ba11ad43b5644ed9c1de695590ff608658628fb57b1571	2019-02-01 00:41:21 -06:00
Wladimir J. van der Laan	3d1a0b3abc	Merge #9871: Add a tree sha512 hash to merge commits ... fa89670 Add SHA512 tree hash to merge commits (Pieter Wuille) Tree-SHA512: 72321597336d3c4957719c8b907f258814b01499a82d2bc1e8c678b8825461d95f23b42ff6868a25725f4bfc3da24f7b12c058b45cbc7a7dfbf668888b68274e	2019-01-22 22:56:01 -06:00
PastaPastaPasta	896733223e	Dashify copyright_header.py (#2598) ... * dashify copyright_headers.py * copyright for copyright_header.py * dash -> Dash Core Co-Authored-By: PastaPastaPasta <pasta@dashboost.org> * dashify readme	2019-01-03 12:20:22 +03:00
PastaPastaPasta	a49f4123e5	Backports 0.15 pr1 (#2590) ... * Merge #9744: Remove unused module from rpc-tests a432aa0 Remove unused module from rpc-tests (Takashi Mitsuta) * Merge #9696: [trivial] Fix recently introduced typos in comments 0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift) * Merge #9657: Improve rpc-tests.py a6a3e58 Various review markups for rpc-tests.py improvements (John Newbery) 3de3ccd Refactor rpc-tests.py (John Newbery) afd38e7 Improve rpc-tests.py arguments (John Newbery) 91bffff Use argparse in rpc_tests.py (John Newbery) 1581ecb Use configparser in rpc-tests.py (John Newbery) * Merge #9724: Qt/Intro: Add explanation of IBD process f6d18f5 Qt/Intro: Explain a bit more what will happen first time (Luke Dashjr) 50c5657 Qt/Intro: Storage shouldn't grow significantly with pruning enabled (Luke Dashjr) 9adb694 Qt/Intro: Move sizeWarningLabel text into C++ code (Luke Dashjr) * Merge #9794: Minor update to qrencode package builder 1bfe6b4 Use package name variable inside $(package)_file_name variable (Mitchell Cash) * Merge #9726: netbase: Do not print an error on connection timeouts through proxy 3ddfe29 netbase: Do not print an error on connection timeouts through proxy (Wladimir J. van der Laan) 13f6085 netbase: Make InterruptibleRecv return an error code instead of bool (Wladimir J. van der Laan) * Merge #9727: Remove fallbacks for boost_filesystem < v3 056aba2 Remove fallbacks for boost_filesystem < v3 (Wladimir J. van der Laan) * Merge #9485: ZMQ example using python3 and asyncio b471daf Adddress nits, use asyncio signal handling, create_task (Bob McElrath) 4bb7d1b Add python version checks and 3.4 example (Bob McElrath) 5406d51 Rewrite to not use Polling wrapper for asyncio, link to python2.7 example (Bob McElrath) 5ea5368 ZMQ example using python3 and asyncio (Bob McElrath) * Merge #9807: RPC doc fix-ups. 851f6a3 [qa][doc] Correct rpc test options in readme (fanquake) 41e7219 [trivial] Add tests_config.ini to .gitignore (fanquake) * Dashify Co-Authored-By: PastaPastaPasta <pasta@dashboost.org> * Change file permissions * update travis.yml -parallel -> --jobs	2019-01-03 12:18:47 +03:00
UdjinM6	361900e461	Bump version to 0.14 (#2589)	2018-12-28 19:12:52 +03:00
Alexander Block	552d9089e7	Update testnet seeds to point to MNs that are on the new chain (#2558)	2018-12-14 16:34:11 +01:00
UdjinM6	6c190d1bb3	Fix make deploy error on macos (#2475)	2018-11-23 15:41:39 +01:00
Alexander Block	614ff70b4c	Let ccache compress the cache by itself instead of compressing ccache.tar (#2456) ... The cache can become quite large and uncompressing/recompressing it is slow. Better to let ccache handle compression as it will then only perform it on files which are actually used.	2018-11-19 07:31:13 +01:00
Alexander Block	52bf5a6b0f	Install libxkbcommon0 in gitian-linux.yml ... This fixes an issue reported by users on Ubuntu 18.04 LTS. They got the following error message when starting dash-qt: xkbcommon: ERROR: failed to add default include path auto Qt: Failed to create XKB context! Use QT_XKB_CONFIG_ROOT environmental variable to provide an additional search path, add ':' as separator to provide several search paths and/or make sure that XKB configuration data directory contains recent enough contents, to update please see http://cgit.freedesktop.org/xkeyboard-config/ . Dash-qt starts then, but does not accept any input from the keyboard. The reason is that qt tries to find the xkb config root in the configure phase, but fails to find it. To make this detection work, libxkbcommon has to be installed on the host system, even though it is then never used.	2018-11-16 15:51:37 +01:00
Alexander Block	5fc4072ca0	Parallel ASN resolve and allow passing of input file names to makeseeds.py (#2432) ... * Resolve ASNs in parallel * Allow passing of filename to makeseeds.py	2018-11-10 17:00:24 +01:00
Alexander Block	0e9ad207ae	Update hardcoded seeds (#2429) ... * Update seeds for mainnet * Update seeds for testnet	2018-11-10 06:29:14 +01:00
Alexander Block	9eb9c99d59	Bump version to 0.13.0 (#2386)	2018-10-26 19:43:08 +03:00
gladcow	1c9ed7806a	GDB automation with Python script to measure memory usage in dashd (#1609) ... * standart STL containers and Masternode-related classes processing * masternode-related classes * fix st containers processing, use reflection to process simple classes * Content descrioption in README.md * Increase python scripts performance Use gdb objects instead strings and type info for creating Pyton wrappers * fixed simple classes list * addition to README * fix nits * missed `the` Co-Authored-By: gladcow <sergey@dash.org> * fix nits Co-Authored-By: gladcow <sergey@dash.org> * fixed grammatical issues Co-Authored-By: gladcow <sergey@dash.org> * fixed phrase construction Co-Authored-By: gladcow <sergey@dash.org> * missed point Co-Authored-By: gladcow <sergey@dash.org> * fixed grammatical issues Co-Authored-By: gladcow <sergey@dash.org> * remove double space Co-Authored-By: gladcow <sergey@dash.org> * fixed grammatical issues Co-Authored-By: gladcow <sergey@dash.org>	2018-10-23 14:15:08 +03:00
Alexander Block	d998dc13ed	Add cmake to non-mac gitian descriptors (#2360) ... Needed since we added Chia bls-signatures	2018-10-23 10:23:14 +02:00
-k	3313bbd515	Backport bitcoin #13623 Migrate gitian-build.sh to python (#2319) ... * backport python version of gitian-build from bitcoin rename gitian-build script fix release notes typo 0.12.3-backports * change gitian host IP address * docker/etc fixes * use docker as default virtualization tech * add checksum to depends download stage * add SDK download checksum added * remove SDK check * fix verification	2018-10-21 22:39:05 +03:00
PastaPastaPasta	1e74bcace9	[ZMQ] Notify when an IS double spend is attempted (#2262) ... * Implement IS Double spend notifications in zmq * copy/paste error * typo * Send both conflicting and conflicts against as ZMQ notifications * CTransaction based not hash based * @UdjinM6 requested changes	2018-09-12 14:12:44 +03:00
Alexander Block	cb37c39725	Bump PROTOCOL_VERSION to 70211, bump MIN_* protocols to 70210 (#2256) ... Bump PROTOCOL_VERSION to 70211, bump MIN_* protocols to 70210	2018-09-05 19:34:56 +03:00
Alexander Block	3d654b9814	Build bionic base image in Jenkinsfile.gitian & update docs (#2226) ... * Build bionic base image in Jenkinsfile.gitian We updated gitian builds to use bionic, so we should also update the Jenkinsfile * Update docs	2018-08-14 22:36:15 +03:00
Alexander Block	c09f57bd78	Backport move to Ubuntu Bionic and GCC7 in Gitian builds (#2225) ... * Add stdin, stdout, stderr to ignored export list * Merge #13171: Change gitian-descriptors to use bionic instead c1afe3232fa10e290fb355cf37ea4c7bc1084065 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before #13177 devrandom/gitian-builder#178 Close #12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as fc6a9f2ab1 Couldn't backport the original commit as we are missing some refactorings.	2018-08-13 23:21:42 +03:00
Alexander Block	7cf9572c26	Backport Bitcoin #11881: Remove Python2 support (#2224) ... * Merge #11881: Remove Python2 support 1874058 Make base58 python contrib code work with python3 (Evan Klitzke) bc6fdf2 Change all python files to use Python3 (John Newbery) Pull request description: Following discussion here: https://github.com/bitcoin/bitcoin/pull/11843#issuecomment-351033742 It's easier for maintainers if all python tools/scripts support only a single version of Python. There are only a few scripts that aren't explicitly python3 at this point, so this PR changes those remaining scripts to explicitly require python3. Tree-SHA512: 5d38eef6e0fc7d8515e23a1f4c75e8b4160fd0fe23cba52a1f41689b114e54a9e503e0724829e8b41982ef98f2d113df80d9e238213b74f09ceaed0344a19e24 * Merge #12829: Python3 fixup f50975b [contrib] fixup symbol-check.py Python3 support (John Newbery) 5de2b18 [contrib] fixup security-check.py Python3 support (John Newbery) Pull request description: security-check.py and symbol-check.py were broken by #11881. Fix them. Tree-SHA512: 86de3d6dc3292b1ae4cc04c2d7d7dbbf39c9270551d7b224b8d8b19e3184c30c897dbf823200403706d06bb405c0decad5cfd690cb2c0312992a235a4ffcf6bf	2018-08-13 19:07:52 +03:00
Alexander Block	eb202e812f	Use ccache in gitian builds (#2185) ... * Use subdirectory for depends cache in gitian builds * Make timestamps of wrappers deterministic * Use ccache in gitian builds * Upgrade ccache to latest version (3.4.2) * Build the branch that belongs to the Jenkins build instead of develop	2018-07-20 16:33:02 +03:00
Alexander Block	b476173258	Install python3 in gitian builds (#2182) ... We mostly switched to python3, so we should also install it in gitian builds. Especially the osx build needs as it otherwise fails due to missing setuptools.	2018-07-16 15:49:23 +03:00
Alexander Block	7a85e24c37	Remove deprecated gitian-rpi2.yml descriptor (#2183) ... Since backporting Bitcoin 0.14 code, we have the arm-linux-gnueabihf and aarch64-linux-gnu hosts in gitian-linux.yml	2018-07-16 15:48:47 +03:00
Alexander Block	f3e380659a	Move to in-docker CI builds and add Jenkins support (#2178) ... * GCC-7 and glibc-2.27 compat code * Statically link libstdc++ for GCC based builds Makes sure binaries which are built on a newer build host still work on older distros. * Use python3 when installing MacOS native tools * Move actual build logic out of Travis and upgrade to gcc-7 Travis will now simply call a few scripts which do the actual work. These scripts will first create a "builder image" which contains the necessary environment for the actual build. Then scripts are called inside this builder image to do the build. This should make us more independant from Travis and also allows us to do local CI testing. The build matrix is also moved out of .travis.yml and instead moved into ci/matrix.sh. This script is sourced with only "BUILD_TARGET" being set so that it internally can figure out which other environment variables need to be set. This commit also upgrades the used GCC version to 7. This is due to the use of ubuntu:bionic as base image for the builder image. * Add Jenkinsfiles for regular CI and nightly gitian builds * Automatically download OSX SDK in gitian-build.sh * Remove bogus "export MAKEJOBS=-j5" * Forward cache/src dirs into builder container Fixes caching issues on Travis. * fix * Fail build immediately when building depends took too long	2018-07-12 16:28:59 +03:00
PaulieD	0e689341d2	Implement Governance ZMQ notification messages (#2160) ... * fix whitespace * added zmq stuff for governance objects and votes it seems that zmq is currently not in a working state, need to figure that out. Need to: plug in the new methods added possibly plug in the old methods, as it doesn't look like they are. * formatting fix. Will probably need to revert for this PR * continue linking new zmq messages in * added comment, might need to revert * fixes error of it not knowing about the classes * Actually link in, all new govobjects and govvotes should be broadcast over zmq now. * fix compile error, forgot to change params when copying * fix compile error * add imports to the header files in zmqconfig.h * fixing linking(i think) error * Revert "added comment, might need to revert" This reverts commit 2918ea40fe. * Revert "formatting fix. Will probably need to revert for this PR" This reverts commit ca10558866. * fix tabs etc * EOL added * optimization of hash.begin() @nmarley thoughts? * remove formatting changes * iterator i -> it and removal of notifier * typo in df879f57 * use auto for the iterators * introduce hash prefix * implement changes in zmq_sub.py, update the doc, and change argument name to fix typo * deref iterators before calling methods * continued e8a4c505 * missed one... continued e8a4c505 * killing some tabs * fix spacing for setting or comparing iterators * change order of new variables to match current setup * re-add elif's I didn't realize got removed * Revert "fix spacing for setting or comparing iterators" This reverts commit 8ce2068148. * Revert "use auto for the iterators" This reverts commit cb16cf0760. * Revert "missed one... continued e8a4c505" This reverts commit 2087cf894f. * Revert "continued e8a4c505" This reverts commit a78c8ad2c9. * Revert "deref iterators before calling methods" This reverts commit e8a4c505d1. * Revert "iterator i -> it and removal of notifier" This reverts commit 29574248b1. * Revert "fix whitespace" This reverts commit 612be48d96. * Revert "typo in df879f5" * Revert "Optimization of hash.begin()" * fixes problem with revert * Udjin complain's a lot ;) * help text, init.cpp * add signals in validationinterface.cpp * Change location of vote notification call. * remain consistent * remove unneeded include due to change of notification location * implement raw notifications	2018-07-12 12:06:30 +03:00
UdjinM6	3c89983db6	Remove DarksendConfig (#2132)	2018-07-12 12:03:26 +03:00
UdjinM6	7ab5b4a28e	Update/optimize images (#2147) ... * update optimize-pngs.py with new paths * `python contrib/devtools/optimize-pngs.py` Total reduction: 22025 bytes * update share/pixmaps/*	2018-06-29 01:22:48 +03:00
UdjinM6	1c9917e227	Fix CVE-2018-12356 by hardening the regex (#2126)	2018-06-18 19:08:27 +03:00
Alexander Block	7b43720f05	Fix copying of final binaries into dashcore-binaries (#2090) ... * Fix copying of final binaries into dashcore-binaries * Fix binary names in gitian-osx-signer.yml and gitian-win-signer.yml	2018-05-31 17:31:00 +02:00
Alexander Block	2129ee4d8c	Add docker support when doing Gitian builds (#2084) ... * gitian-build.sh: fix signProg being recognized as two parameters * Support docker based Gitian builds Requires a gitian-builder version with https://github.com/devrandom/gitian-builder/pull/181 This will also switch to use Docker by default. * Switch back to using lxc as default until upstream gitian-builder is ready	2018-05-30 13:48:30 +03:00
Alexander Block	6a1456ef4c	Update gitian key for codablock (#2085) ... https://keybase.io/codablock Old key was using default gpg settings with 2048 bits.	2018-05-29 18:13:47 +03:00
Alexander Block	ab96a6af63	Update gitian keys, script and doc (#2082) ... * Remove Bitcoin Gitian keys * Update gitian-build.sh and gitian-building.md gitian-building.md referenced "br0" but "lxcbr0" was used in the script. gitian-build.sh used 10.0.2.2 as IP for the bridge but this conflicts with VirtualBox networking. * Add gitian key for codablock https://keybase.io/codablock * Add gitian key for schinzelh https://keybase.io/schinzelh * Add gitian key for gladcow https://keybase.io/gladcow * Add gitian key for nmarley https://keybase.io/nmarley * Add gitian key for udjinm6 https://keybase.io/UdjinM6 * Add EOL chars	2018-05-26 21:04:07 +03:00
crowning-	118eeded6d	[GUI] Create QR-code for Masternode private key (#1970)	2018-03-08 15:17:34 +03:00
Alexander Block	a6ba82ac9a	Use masternode list to generate hardcoded seeds (#1892) ... * Change makeseeds.py to use masternode list as input instead of DNS seed dump * Allow 4 nodes per ASN Lift the limitation a bit so we get more entries * Update nodes_main.txt and nodes_test.txt Generated with makeseeds.py based on current masternode lists * Fix comment about the source of the seed nodes and use masternodelist rpc * Use fixed OpenDNS servers for ASN filtering	2018-02-05 18:39:26 +03:00
Wladimir J. van der Laan	e9976d20f1	Merge #10495: contrib: Update location of seeds.txt ... ac9cd95 contrib: Update location of seeds.txt (Wladimir J. van der Laan) Tree-SHA512: c12a75787ba87f03707c21731da083b466762a7e0af9ca501107695ea1074025907cc24805c7c87f4a66daa7f4f13e574da16be1681e61deaf1acbd72176b3ff	2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan	294228afcc	Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default ... afc693d contrib/init/bitcoind.openrcconf: Don't disable wallet by default (Luke Dashjr) Tree-SHA512: 1763a9e91788485b079b96239cf09f1557b338e5045aa4ffbad3908f88c4e362b9b5d86a8a0f33734899de244e76e7ced02a6be8e52b3fb69258a5101d6445ef	2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan	24be65e87a	Merge #10328: Update contrib/debian to latest Ubuntu PPA upload. ... 91700aa Re-enable upnp support in contrib/debian (Matt Corallo) c5071e1 Build with QT5 on Debian-based systems using contrib/debian (Matt Corallo) a8e9286 Bump minimum boost version in contrib/debian (Matt Corallo) 9970219 Update contrib/debian to latest Ubuntu PPA upload. (Matt Corallo) Tree-SHA512: ee4d3c5927a9cfb2794672eaca883c4af5df541383afbdbc6500714ee17518e78b58f509b2e9805bbc424ef97a5e64be0b9a977212c5002cb682f0569d28099b	2018-01-26 12:59:29 +01:00
Alexander Block	11a5f2e6a6	Rename and Dashify .manpages files	2018-01-23 16:08:56 +01:00
Wladimir J. van der Laan	c5fdd27d40	Merge #8743: Remove old manpages from contrib/debian in favour of doc/man ... b194872 Remove old manpages from contrib/debian (fanquake)	2018-01-23 09:24:29 +01:00
Wladimir J. van der Laan	5f88c6451d	Merge #9675: Fix typo and spelling inconsistency in CONTRIBUTING.md ... 36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)	2018-01-23 09:24:29 +01:00
Wladimir J. van der Laan	b183a1f2a3	Merge #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py ... 7179e7c qt: Periodic translations update (Wladimir J. van der Laan) 5e903a5 devtools: Handle Qt formatting characters edge-case in update-translations.py (Wladimir J. van der Laan)	2018-01-23 09:24:28 +01:00
Wladimir J. van der Laan	7cc218dd72	Merge #9736: Pre-0.14.0 hardcoded seeds update ... a60677e Pre-0.14.0 hardcoded seeds update (Wladimir J. van der Laan) bfa9393 contrib/seeds: Update PATTERN_AGENT (Wladimir J. van der Laan) 4dfac2c Update seeds tooling to Python 3 (Wladimir J. van der Laan)	2018-01-23 09:24:28 +01:00
Wladimir J. van der Laan	767f5e436b	Merge #9532: Remove unused variables ... 90fd29b Remove unused int64_t nSinceLastSeen (practicalswift) ac4a095 Remove unused Python variables (practicalswift)	2018-01-23 09:24:27 +01:00
Wladimir J. van der Laan	81eeb0dee7	Merge #9651: Fix typos ... 5f62e3e Fix typos (practicalswift)	2018-01-23 09:24:27 +01:00
Wladimir J. van der Laan	3dcbfc744a	Merge #9580: Fix various minor linearization script issues ... b9d95bd Fix various minor linearization script issues (Douglas Roark)	2018-01-23 09:24:27 +01:00
MarcoFalke	e24b8ae50e	Merge #9649: [doc] Remove unused clang format dev script ... fa5137c [doc] Remove unused clang format dev script (MarcoFalke)	2018-01-23 09:24:26 +01:00