Commit Graph

19394 Commits

Author SHA1 Message Date
UdjinM6
8b831eeb7e
instantsend: Postpone mempool related cleanup fixes until dip0020 activation (#4159)
* instantsend: Upgrade IS db on dip0020 activation

* instantsend: Do not remove islocks for txes removed from mempool until dip0020 is activated

* refactor: introduce fUpgradedDB to avoid excessive locking and checking the state

* llmq: Decouple `fUpgradedDB` from `cs`

* Update src/llmq/quorums_instantsend.cpp

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

* Fix deadlock

Upgrade locks cs_main via GetTransaction

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
2021-05-19 00:49:45 +03:00
UdjinM6
a02f8302d9
instantsend: Postpone mempool related cleanup fixes until dip0020 activation (#4159)
* instantsend: Upgrade IS db on dip0020 activation

* instantsend: Do not remove islocks for txes removed from mempool until dip0020 is activated

* refactor: introduce fUpgradedDB to avoid excessive locking and checking the state

* llmq: Decouple `fUpgradedDB` from `cs`

* Update src/llmq/quorums_instantsend.cpp

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

* Fix deadlock

Upgrade locks cs_main via GetTransaction

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
2021-05-18 15:29:51 -05:00
Kittywhiskers Van Gogh
6a25151bbd Merge #16730: Support serialization of std::vector<bool> 2021-05-18 22:31:54 +05:30
PastaPastaPasta
0e3aea8c4e
Update CLIENT_VERSION_IS_TRUE in configure.ac (#4148) 2021-05-18 01:02:18 +03:00
UdjinM6
876173241f
doc: Archive v0.16.1.1 release notes, draft v0.17 release notes (#4156)
* doc: Archive 0.16.1.1 release notes

* doc: Draft v0.17 release notes

* Apply suggestions from code review

Co-authored-by: thephez <thephez@users.noreply.github.com>

* tweak downgrade note

* move PS->CJ section down

* Statoshi

* Update doc/release-notes.md

Co-authored-by: thephez <thephez@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

* Add more details about upgrades/downgrades

* 0.17 -> 0.17.0.0

Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
2021-05-18 01:01:55 +03:00
UdjinM6
8b1350962d
Merge pull request #4157 from PastaPastaPasta/more-backports
v0.17: additional backports
2021-05-18 00:58:53 +03:00
UdjinM6
d34286fa3e
build: Fix cmake prefix for bls-dash package (#4158) 2021-05-17 16:29:24 -04:00
UdjinM6
288f5976a8
build: Fix cmake prefix for bls-dash package (#4158) 2021-05-17 23:22:48 +03:00
UdjinM6
598932748c qt: Transaltions202105 (#4137)
* Abstract some error specifics away

* `make translate`

* ru

* fi
2021-05-15 20:14:54 -05:00
UdjinM6
45420739c9
Merge pull request #4151 from PastaPastaPasta/0.17-backport-candidates
v17: backport candidates
2021-05-15 23:50:29 +03:00
UdjinM6
f18d4e1d1c instantsend: Remove islocks for rejected/removed txes (#4155)
* instantsend: Resolve block conflicts first and take care of mempool ones later

* refactor: Rename RemoveChainLockConflictingLock -> RemoveConflictingLock

* instantsend: Handle transaction removal from mempool (for all reasons besides inclusion in blocks)

* instantsend: Remove old islocks with no known txes from db (once)

* refactor: Replace magic number with CURRENT_VERSION

* fix: Do not remove islocks for (yet) valid orphans

* Apply suggestions from code review

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
2021-05-14 19:17:50 -05:00
UdjinM6
a89202726f
instantsend: Remove islocks for rejected/removed txes (#4155)
* instantsend: Resolve block conflicts first and take care of mempool ones later

* refactor: Rename RemoveChainLockConflictingLock -> RemoveConflictingLock

* instantsend: Handle transaction removal from mempool (for all reasons besides inclusion in blocks)

* instantsend: Remove old islocks with no known txes from db (once)

* refactor: Replace magic number with CURRENT_VERSION

* fix: Do not remove islocks for (yet) valid orphans

* Apply suggestions from code review

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
2021-05-14 19:17:16 -05:00
UdjinM6
20b71700dc
Merge pull request #4037 from kittywhiskers/serialize
merge #12752, #10785, #17896, #17957, #18021, #18112: serialization improvements
2021-05-15 02:06:43 +03:00
UdjinM6
9f9a08ae80 evo: Fix two mempool issues (#4154)
* evo: Remove all protx-es that refer to a ProRegTx removed from mempool

* tests: Check that removal of ProRegTx causes removal of other protx-es that refer to it

* evo: Consider tx itself a collateral in mempool maps when payload collateral hash is null

* tests: Should not allow a ProRegTx which uses another ProRegTx as an external collateral to enter mempool

Signed-off-by: pasta <pasta@dashboost.org>
2021-05-14 15:00:26 -05:00
Kittywhiskers Van Gogh
027c4653ba depends: update Qt 5.9 source url (#4153) 2021-05-14 13:19:13 -05:00
dustinface
8bd3fd32ca contrib|src: Update hard coded seeds (#4152)
* contrib: Update IPs in nodes_main.txt and nodes_test.txt

Mainnet: 1469339
Testnet: 498026

* src: Update static seeds in chainparamsseeds.h
2021-05-14 13:19:04 -05:00
PastaPastaPasta
5f79a02d26 increase BLOCK_CHAIN_SIZE marginally (#4150) 2021-05-14 13:18:52 -05:00
thephez
b7c47b5729 docs: update bips.md for v0.17 (#4149) 2021-05-14 13:17:40 -05:00
UdjinM6
ad7d23c606 instantsend: Partially revert 3987, add more tests for CL vs IS conflicts (#4146)
* tests: Check that CLs override ISes which invalidated non-CLed blocks earlier

* partial revert 3987: Do not mark blocks which conflict with ISes as "conflicting"
2021-05-14 13:17:40 -05:00
UdjinM6
1f2ad2e69a build: Bump relic to 3a23142be0a5510a3aa93cd6c76fc59d3fc732a5 (#4144) 2021-05-14 13:17:40 -05:00
UdjinM6
2640e25e70 Rename bit 6 from "v17" to "dip0020" (#4142) 2021-05-14 13:17:40 -05:00
Kittywhiskers Van Gogh
6c53843b1e Merge #21662: build: update Boost download URL (#4140)
See 36c10b9f4b from https://github.com/bitcoin/bitcoin/pull/21662/commits
2021-05-14 13:17:40 -05:00
UdjinM6
c9ed39ac71 qt: Fix recent txes list not shoing up initially when CJ is disabled (#4136) 2021-05-14 13:17:40 -05:00
UdjinM6
392828bb51 qt: Drop custom migration logic (#4135)
Use OptionsModel::checkAndMigrate() instead and clean up the mess one more time.

Also fixes `-resetguisettings`.
2021-05-14 13:17:40 -05:00
UdjinM6
645e59205e instantsend: Push matching islocks when replying to merkleblock inv in getdata only when all txes are pushed (#4134) 2021-05-14 13:17:40 -05:00
UdjinM6
4b93ea2e9a llmq: Bump llmq leveldb cache size to 8 MiB (#4133) 2021-05-14 13:17:40 -05:00
UdjinM6
286fa1101b evo: Refactor (Add/Update/Remove)MNs to do the job in one go (#4132)
* evo: Refactor (Add/Update/Remove)MNs to do the job in one go

Instead of hashing the value and querying `mnUniquePropertyMap` both 2 or 3 times per property.

Also unify their error messages while at it.

* evo: Align nullValue checks with others in {Add|Delete}UniqueProperty

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
2021-05-14 13:17:40 -05:00
dustinface
b3c6d09b80 qt: Fix some font weight related issues (#4131)
* qt: Add missing -font-family overridden check

* qt: Add missing `QFont::ExtraBold`

* qt: Remove settings depencency from GUIUtil::loadFonts and load earlier

* qt: Modify supportedWeightToIndex

Return -1 in case of failure

* qt: Add GUIUtil::isSupportedWeight

* qt: Make sure there are always supported weights in the settings

* qt: Add "supported defaults" + store weights based on font family

* qt: Use supported defaults in update weight sliders

* qt: Use supported defaults when updating weight sliders

* qt: Fix tests
2021-05-14 13:17:40 -05:00
UdjinM6
b4a0d0120b rpc: Bail out early when no wallet is available in rpcs that require it, even on help <cmd> (#4123) 2021-05-14 13:17:40 -05:00
dustinface
97e75f0147 rpc|llmq|test: Implement verifychainlock (#4119)
* llmq: Make CLSIG_REQUESTID_PREFIX available outside of quorums_chainlocks.cpp

* rpc: Implement `verifychainlock`

* test: Add rpc_verifychainlock.py

* rpc: Fix help text

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2021-05-14 13:17:40 -05:00
PastaPastaPasta
5f3c580b4d Update copyright (#4115)
* run: `python3 contrib/devtools/copyright_header.py update .`

* bump copyright year
2021-05-14 13:17:39 -05:00
UdjinM6
73b5359532
evo: Fix two mempool issues (#4154)
* evo: Remove all protx-es that refer to a ProRegTx removed from mempool

* tests: Check that removal of ProRegTx causes removal of other protx-es that refer to it

* evo: Consider tx itself a collateral in mempool maps when payload collateral hash is null

* tests: Should not allow a ProRegTx which uses another ProRegTx as an external collateral to enter mempool
2021-05-14 12:55:03 -05:00
Kittywhiskers Van Gogh
748e175680
depends: update Qt 5.9 source url (#4153) 2021-05-13 12:32:12 +03:00
dustinface
314844d330
contrib|src: Update hard coded seeds (#4152)
* contrib: Update IPs in nodes_main.txt and nodes_test.txt

Mainnet: 1469339
Testnet: 498026

* src: Update static seeds in chainparamsseeds.h
2021-05-13 12:31:45 +03:00
PastaPastaPasta
1072e23ff5
increase BLOCK_CHAIN_SIZE marginally (#4150) 2021-05-12 11:49:12 -05:00
UdjinM6
a02e754fd9
qt: Transaltions202105 (#4137)
* Abstract some error specifics away

* `make translate`

* ru

* fi
2021-05-12 00:56:24 +02:00
PastaPastaPasta
bc4e6fc538 llmq/rpc: Adjust verify islock, don't err when transaction isn't known locally (#4106)
* llmq/rpc: Adjust verify islock, don't err when transaction isn't known locally

* combine two ifs

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

* tests: Verify islocks for unknown txes

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2021-05-11 16:52:44 -05:00
strophy
6badaaafab Update docker tags (#4103)
* feat: use github actions

* use v2 meta action

* adjust indentation

* try conditional versions

* try to remove flavor

* try different order

* manual suffix

* manual latest

* dev suffix on latest

* raw latest-dev

* typo

* workaround latest bug

* manual latest

* enable build

* add space

* revert Dockerfile changes

* use dashpay target repo
2021-05-11 16:52:16 -05:00
UdjinM6
4a883a7307 rpc: Tweak getaddressbalance to also show spendable and immature balances (#4098)
* rpc: Tweak getaddressbalance to also show spendable and immature balances

* tests: Check `balance_immature` and `balance_spendable`
2021-05-11 16:51:55 -05:00
thephez
79f1f96603
docs: update bips.md for v0.17 (#4149) 2021-05-11 16:31:48 -05:00
dustinface
b06c69a48c
llmq: Drop quorumHeight in CDKGSessionHandler (#4128)
* llmq: Drop unused quorumHeight

* llmq: Adjust variable name in log

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
2021-05-11 16:28:58 -05:00
UdjinM6
5cdd67ed53
tests: Use wait_for_chainlocked_block_all_nodes in more places (#4139) 2021-05-11 18:55:40 +02:00
dustinface
5285bd801c
Merge pull request #4138 from UdjinM6/make_shellcheck_0.7.2_happy
Backport 13066, 13448 and fix `commit-script-check.sh` to make shellcheck 0.7.2 happy
2021-05-11 18:54:55 +02:00
UdjinM6
1a31669cf1
build: Bump relic to 3a23142be0a5510a3aa93cd6c76fc59d3fc732a5 (#4144) 2021-05-11 18:50:44 +02:00
UdjinM6
90d7e1f370
instantsend: Partially revert 3987, add more tests for CL vs IS conflicts (#4146)
* tests: Check that CLs override ISes which invalidated non-CLed blocks earlier

* partial revert 3987: Do not mark blocks which conflict with ISes as "conflicting"
2021-05-11 18:50:14 +02:00
UdjinM6
721db5bbeb
qt: Fix recent txes list not shoing up initially when CJ is disabled (#4136) 2021-05-07 18:41:32 +02:00
UdjinM6
3ebef510bc
Improve CHDChain (#4125)
* Protect all CHDChain's internals

* Do not create default HD chain account in CHDChain's ctor
2021-05-07 18:40:50 +02:00
UdjinM6
7616b04cb2
Rename bit 6 from "v17" to "dip0020" (#4142) 2021-05-07 18:36:30 +02:00
UdjinM6
1fde524ccb
llmq: Bump llmq leveldb cache size to 8 MiB (#4133) 2021-05-06 13:43:33 -04:00
dustinface
3a1d168a33
qt: Fix some font weight related issues (#4131)
* qt: Add missing -font-family overridden check

* qt: Add missing `QFont::ExtraBold`

* qt: Remove settings depencency from GUIUtil::loadFonts and load earlier

* qt: Modify supportedWeightToIndex

Return -1 in case of failure

* qt: Add GUIUtil::isSupportedWeight

* qt: Make sure there are always supported weights in the settings

* qt: Add "supported defaults" + store weights based on font family

* qt: Use supported defaults in update weight sliders

* qt: Use supported defaults when updating weight sliders

* qt: Fix tests
2021-05-06 13:15:47 -04:00