Matt Corallo
b55b416346
Add extra_count lower bound to compact reconstruction debug print
2017-01-12 12:19:14 -08:00
Matt Corallo
73666ad059
Add comment to describe callers to ActivateBestChain
2017-01-12 12:15:17 -08:00
Pieter Wuille
82e8baab3c
Avoid boost dynamic_bitset in rest_getutxos
2017-01-12 12:06:32 -08:00
Pieter Wuille
99f001eb52
Fix memory leak in multiUserAuthorized
2017-01-12 11:52:53 -08:00
Pieter Wuille
5a0b7e4106
Fix memory leak in net_tests
2017-01-12 11:52:53 -08:00
Pieter Wuille
6b03bfb840
Fix memory leak in wallet tests
2017-01-12 11:52:53 -08:00
Pieter Wuille
f94f3e0df8
Avoid integer overflows in scriptnum tests
2017-01-12 11:52:53 -08:00
Pieter Wuille
843c560003
Avoid unaligned access in crypto i/o
2017-01-12 11:52:45 -08:00
Alex Morcos
34ede124af
Document fee estimation changes
2017-01-12 12:19:08 -05:00
Alex Morcos
b348287b79
Clarify that prioritisetransaction remains supported
2017-01-12 12:09:15 -05:00
Suhas Daftuar
4b06e41c30
Add unit test for FindEarliestAtLeast
2017-01-12 14:22:15 +00:00
Gregory Maxwell
997a98a674
Replace FindLatestBefore used by importmuti with FindEarliestAtLeast.
...
In spite of the name FindLatestBefore used std::lower_bound to try
to find the earliest block with a nTime greater or equal to the
the requested value. But lower_bound uses bisection and requires
the input to be ordered with respect to the comparison operation.
Block times are not well ordered.
I don't know what lower_bound is permitted to do when the data
is not sufficiently ordered, but it's probably not good.
(I could construct an implementation which would infinite loop...)
To resolve the issue this commit introduces a maximum-so-far to the
block indexes and searches that.
For clarity the function is renamed to reflect what it actually does.
An issue that remains is that there is no grace period in importmulti:
If a address is created at time T and a send is immediately broadcast
and included by a miner with a slow clock there may not yet have been
any block with at least time T.
The normal rescan has a grace period of 7200 seconds, but importmulti
does not.
2017-01-12 14:21:43 +00:00
MarcoFalke
02e5308c1b
Merge #9525 : test: Include tx data in EXTRA_DIST
...
fa29736
2017-01-12 13:41:32 +01:00
MarcoFalke
fa2973678e
test: Include tx data in EXTRA_DIST
2017-01-12 13:13:07 +01:00
Wladimir J. van der Laan
7cb024eba6
Merge #9222 : Add 'subtractFeeFromAmount' option to 'fundrawtransaction'.
...
453bda6
2017-01-12 12:49:10 +01:00
Wladimir J. van der Laan
f9117f2047
Merge #9468 : [Depends] Dependency updates for 0.14.0
...
7f1fa99c6347aea4c6da06019d214ed6faf8ac1830
2017-01-12 12:46:30 +01:00
Wladimir J. van der Laan
2742568a00
Merge #9261 : Add unstored orphans with rejected parents to recentRejects
...
dfbe0d5
2017-01-12 12:34:44 +01:00
Wladimir J. van der Laan
d5d4ad87af
Merge #8883 : Add all standard TXO types to bitcoin-tx
...
0c50909b7e144b61a15341814b08
2017-01-12 12:24:35 +01:00
Wladimir J. van der Laan
fac0f30482
Merge #9472 : Disentangle progress estimation from checkpoints and update it
...
df36371e356d9a6dd81163641141a4bac66
2017-01-12 12:13:14 +01:00
MarcoFalke
a65ced1a66
Merge #9518 : Return height of last block pruned by pruneblockchain RPC
...
918d1fb
2017-01-12 11:50:14 +01:00
MarcoFalke
2456a835f0
Merge #9520 : Deprecate non-txindex getrawtransaction and better warning
...
db904db
2017-01-12 10:52:32 +01:00
Matt Corallo
962f7f054f
Call ActivateBestChain without cs_main/with most_recent_block
...
There is still a call to ActivateBestChain with cs_main if a peer
requests the block prior to it being validated, but this one is
more specifically-gated, so should be less of an issue.
2017-01-11 21:18:48 -08:00
MarcoFalke
9ec1330b45
Merge #9416 : travis: make distdir before make
...
faaf3ca
2017-01-12 02:14:51 +01:00
MarcoFalke
0b738075bd
Merge #9297 : Various RPC help outputs updated
...
54ee3fc
2017-01-12 02:11:04 +01:00
Pieter Wuille
db904db7e6
Deprecate non-txindex getrawtransaction and better warning
2017-01-11 15:34:13 -08:00
Matt Corallo
0df777db6d
Use a temp pindex to avoid a const_cast in ProcessNewBlockHeaders
2017-01-11 14:47:52 -08:00
Jeremy Rubin
aad4cb5059
Address ryanofsky feedback on CCheckQueue benchmarks. Eliminated magic numbers, fixed scoping of vectors (and memory movement component of benchmark).
2017-01-11 17:05:06 -05:00
Pieter Wuille
05950427d3
Merge #9507 : Fix use-after-free in CTxMemPool::removeConflicts()
...
fe7e593
2017-01-11 13:59:00 -08:00
Michael Rotarius
54ee3fcb8f
RPC help updated
2017-01-11 22:05:23 +01:00
Russell Yanofsky
918d1fb86b
Return height of last block pruned by pruneblockchain RPC
...
Change suggested by Jonas Schnelli <dev@jonasschnelli.ch> in
https://github.com/bitcoin/bitcoin/pull/7871#discussion_r95577623
2017-01-11 14:25:32 -05:00
Pieter Wuille
df3637177a
Update estimated transaction count data
2017-01-11 08:21:40 -08:00
Pieter Wuille
e356d9a758
Shorten variable names and switch to tx/s
2017-01-11 08:21:37 -08:00
Wladimir J. van der Laan
e2e624d9ce
Merge #7871 : Manual block file pruning.
...
afffeea1fc4ec7
2017-01-11 14:26:00 +01:00
Wladimir J. van der Laan
ca615e6c05
Merge #9471 : [depends] libevent 2.1.7rc
...
8217bd1
2017-01-11 13:56:13 +01:00
Wladimir J. van der Laan
593a00ce19
Merge #9506 : RFC: Improve style for if indentation
...
74994c6
2017-01-11 13:52:15 +01:00
Wladimir J. van der Laan
bbf193fef0
Merge #9513 : build: fix qt distdir builds (retry)
...
67ca130
2017-01-11 13:45:28 +01:00
MarcoFalke
faaf3ca0af
travis: make distdir before make
2017-01-11 12:25:05 +01:00
fanquake
7f1fa99a21
[depends] native_ds_store 1.1.0
2017-01-11 17:34:13 +08:00
Cory Fields
67ca130f73
build: fix for out-of-tree/distdir qt builds
2017-01-10 20:03:38 -05:00
fanquake
c6347aec6c
[depends] dbus 1.10.14
2017-01-11 08:44:23 +08:00
fanquake
a4c6da085b
[depends] ccache 3.3.3
2017-01-11 08:44:23 +08:00
fanquake
6019d21a43
[depends] FreeType 2.7.1
2017-01-11 08:44:23 +08:00
fanquake
4ed6faf381
[depends] Boost 1.63.0
2017-01-11 08:44:22 +08:00
fanquake
8ac18303da
[depends] Latest config.guess and config.sub
2017-01-11 08:44:01 +08:00
Alex Morcos
116419e58d
Don't overwrite validation state with corruption check
...
AcceptToMemoryPool has several classes of return false statements.
- return state.Invalid or state.DoS directly itself
- return false and set fMissingInputs (state is valid)
- return false and state is set by failed CheckTransaction
- return false and state is set by failed CheckInputs.
This commit patches the last case where the state variable was reused for additional calls to CheckInputs to identify witness stripping as cause of validation failure. After this commit, it should be the case that if !fMissingInputs, state is always Invalid if AcceptToMemoryPool returns false.
2017-01-10 16:53:10 -05:00
Suhas Daftuar
fe7e593b24
Fix use-after-free in CTxMemPool::removeConflicts()
2017-01-10 15:21:21 -05:00
Pieter Wuille
74994c6577
Improve style w.r.t. if
2017-01-10 11:58:27 -08:00
Matt Corallo
863edb45b9
Consider all (<100k memusage) txn for compact-block-extra-txn cache
2017-01-10 14:48:42 -05:00
Matt Corallo
7f8c8cab1e
Consider all orphan txn for compact-block-extra-txn cache
2017-01-10 14:48:42 -05:00
Matt Corallo
93380c5247
Use replaced transactions in compact block reconstruction
2017-01-10 14:48:42 -05:00
