Ryan Havar
4b89f01d72
Default fPayAtLeastCustomFee to false
...
This allows for much finer control of the transaction fees per kilobyte
as it prevent small transactions using a fee that is more appropriate
for one that is of a kilobyte.
This also allows controlling the fee per kilobyte over rpc such that:
bitcoin-cli settxfee `bitcoin-cli estimatefee 2`
would make sense, while currently it grossly fails often by a factor of x3
2015-11-28 22:51:41 +01:00
Luke Dashjr
a6cbc02b6b
Bugfix: Default -uiplatform is not actually the platform this build was compiled on
2015-11-28 21:48:17 +00:00
Pieter Wuille
61457c29d7
Merge pull request #6508
...
eece63f
Switch blocks to a constant-space Merkle root/branch algorithm. (Pieter Wuille)
ee60e56
Add merkle.{h,cpp}, generic merkle root/branch algorithm (Pieter Wuille)
2015-11-28 22:27:38 +01:00
MarcoFalke
fa4b627269
Move blocksonly parameter interaction to InitParameterInteraction()
2015-11-28 22:26:50 +01:00
Pieter Wuille
8d26289c9a
Merge pull request #6961
...
fa41d4c
[qt] Move GUI related HelpMessage() part downstream (MarcoFalke)
faf93f3
[trivial] Reuse translation and cleanup DEFAULT_* values (MarcoFalke)
3307bdb
Bugfix: Omit wallet-related options from -help when wallet is not supported (Luke Dashjr)
b966aa8
Constrain constant values to a single location in code (Luke Dashjr)
2015-11-28 22:15:23 +01:00
MarcoFalke
fa41d4c8c6
[qt] Move GUI related HelpMessage() part downstream
2015-11-28 19:01:26 +01:00
MarcoFalke
faf93f37fe
[trivial] Reuse translation and cleanup DEFAULT_* values
...
* DEFAULT_DISABLE_SAFEMODE = false
* Use DEFAULT_* constants for extern bools
2015-11-28 19:01:11 +01:00
Luke Dashjr
3307bdb333
Bugfix: Omit wallet-related options from -help when wallet is not supported
2015-11-28 18:47:29 +01:00
Luke Dashjr
b966aa836a
Constrain constant values to a single location in code
2015-11-28 18:47:29 +01:00
Nick
996d3117c7
[RPC] Add transaction size to JSON output
...
This may be useful for blockchain explorers.
2015-11-28 17:06:56 +03:00
Pieter Wuille
92aa7311d6
Merge pull request #6942
...
e482a7f
Fix CCoins serialization documentation (Peter Josling)
2015-11-28 14:17:50 +01:00
Pieter Wuille
8332457e95
Merge pull request #7003
...
b8c06ef
doc: Add non-style-related development guidelines (Wladimir J. van der Laan)
2015-11-28 14:15:04 +01:00
Wladimir J. van der Laan
8284feb3c9
Merge pull request #7117
...
a64d7b4
Print correct minimum mempool size in MB (paveljanik)
2015-11-27 16:59:44 +01:00
paveljanik
a64d7b4e42
Print correct minimum mempool size in MB
2015-11-27 16:44:30 +01:00
Pieter Wuille
eece63fa72
Switch blocks to a constant-space Merkle root/branch algorithm.
...
This switches the Merkle tree logic for blocks to one that runs in constant (small) space.
The old code is moved to tests, and a new test is added that for various combinations of
block sizes, transaction positions to compute a branch for, and mutations:
* Verifies that the old code and new code agree for the Merkle root.
* Verifies that the old code and new code agree for the Merkle branch.
* Verifies that the computed Merkle branch is valid.
* Verifies that mutations don't change the Merkle root.
* Verifies that mutations are correctly detected.
2015-11-27 15:36:52 +01:00
Pieter Wuille
ee60e5625b
Add merkle.{h,cpp}, generic merkle root/branch algorithm
2015-11-27 15:31:01 +01:00
Wladimir J. van der Laan
93e0514fd0
Merge pull request #7078
...
c434940
uint256::GetCheapHash bigendian compatibility (daniel)
2015-11-27 15:24:41 +01:00
Wladimir J. van der Laan
f3d0fdd392
Merge pull request #7114
...
9b63758
util: Don't set strMiscWarning on every exception (Wladimir J. van der Laan)
2015-11-27 15:11:36 +01:00
Wladimir J. van der Laan
d6454f6cb2
Merge pull request #7090
...
cde857f
Connect to Tor hidden services by default (Peter Todd)
2015-11-27 15:07:49 +01:00
Wladimir J. van der Laan
d8368a07ba
Merge pull request #7095
...
4ec3561
Replace scriptnum_test's normative ScriptNum implementation (Wladimir J. van der Laan)
2015-11-27 14:16:55 +01:00
Wladimir J. van der Laan
9502b7f634
Merge pull request #7083
...
faf12bc
OpenSSL 1.1.0: Fix text variant of the version number (MarcoFalke)
2015-11-27 14:08:40 +01:00
Wladimir J. van der Laan
2a94cd67e8
Merge pull request #6780
...
a46f87f
Initialize logging before we do parameter interaction (Jonas Schnelli)
df66147
Move -blocksonly parameter interaction to the new ParameterInteraction() function (Jonas Schnelli)
68354e7
[QT] Call inits parameter interaction before we create the options model (Jonas Schnelli)
411b05a
Refactor parameter interaction, call it before AppInit2() (Jonas Schnelli)
2015-11-27 13:45:14 +01:00
Wladimir J. van der Laan
9b63758974
util: Don't set strMiscWarning on every exception
...
Fixes #6809 - run-of-the-mill exceptions should not get into
strMiscWarning (which is reported by `getinfo`).
2015-11-27 13:36:11 +01:00
Wladimir J. van der Laan
5ca149a3db
Merge pull request #7053
...
2e29e7e
Globals: Remove a bunch of Params() calls from main.cpp: (Jorge Timón)
2015-11-27 13:29:54 +01:00
Jonas Schnelli
a46f87f0c1
Initialize logging before we do parameter interaction
2015-11-27 13:26:28 +01:00
Jonas Schnelli
df66147613
Move -blocksonly parameter interaction to the new ParameterInteraction() function
2015-11-27 13:26:28 +01:00
Jonas Schnelli
68354e75e9
[QT] Call inits parameter interaction before we create the options model
2015-11-27 13:26:01 +01:00
Jonas Schnelli
411b05ac95
Refactor parameter interaction, call it before AppInit2()
2015-11-27 13:26:00 +01:00
Wladimir J. van der Laan
0e935865b9
Merge pull request #6871
...
63b5840
Fix usage of local python-bitcoinlib (Peter Todd)
16a2f93
Fix incorrect locking of mempool during RBF replacement (Peter Todd)
97203f5
Port test to rpc-test framework (Suhas Daftuar)
20367d8
Add test for max replacement limit (Suhas Daftuar)
73d9040
Improve RBF replacement criteria (Suhas Daftuar)
b272ecf
Reject replacements that add new unconfirmed inputs (Peter Todd)
fc8c19a
Prevent low feerate txs from (directly) replacing high feerate txs (Peter Todd)
0137e6f
Add tests for transaction replacement (Peter Todd)
5891f87
Add opt-in full-RBF to mempool (Peter Todd)
2015-11-27 13:20:39 +01:00
Wladimir J. van der Laan
e92377fa7f
Merge pull request #6134
...
e304432
Pass reference to estimateSmartFee and cleanup whitespace (Suhas Daftuar)
56106a3
Expose RPC calls for estimatesmart functions (Alex Morcos)
e93a236
add estimateSmartFee to the unit test (Alex Morcos)
6303051
EstimateSmart functions consider mempool min fee (Alex Morcos)
f22ac4a
Increase success threshold for fee estimation to 95% (Alex Morcos)
4fe2823
Change wallet and GUI code to use new smart fee estimation calls. (Alex Morcos)
22eca7d
Add smart fee estimation functions (Alex Morcos)
2015-11-27 12:59:37 +01:00
Wladimir J. van der Laan
05d591839f
Merge pull request #5967
...
072e2f8
Alter assumptions in CCoinsViewCache::BatchWrite (Alex Morcos)
2015-11-27 12:44:00 +01:00
Wladimir J. van der Laan
9a3e1a59df
Merge pull request #7058
...
ffacd27
zmq: prepend zmq to debug messages (Daniel Cousens)
14075b1
init: add zmq to debug categories (Daniel Cousens)
cdcd816
init: amend ZMQ flag names (Daniel Cousens)
2015-11-27 10:12:43 +01:00
Pieter Wuille
a9f3d3db5c
Fix and improve relay from whitelisted peers
...
This makes sure that retransmits by a whitelisted peer also actually
result in a retransmit.
Further, this changes the logic to never relay in case we would assign
a DoS score, as we expect to get DoS banned ourselves as a result.
2015-11-26 23:44:57 +01:00
Wladimir J. van der Laan
f8a8e27a6a
Merge pull request #7069
...
fa472f3
[trivial] Fix -maxmempool InitError (MarcoFalke)
2015-11-26 11:18:31 +01:00
Peter Todd
cde857f2d9
Connect to Tor hidden services by default
...
Adds 127.0.0.1:9050 for the .onion proxy if we can succesfully connect
to the control port.
Natural followup to creating hidden services automatically.
2015-11-26 05:14:31 -05:00
Wladimir J. van der Laan
be281d8a83
Merge pull request #7087
...
9cf6688
Document both the peerbloomfilters and enforcenodebloom options. (Patick Strateman)
0f4dc53
Add enforcenodebloom option. (Patick Strateman)
b3caa9b
Move bloom filter filtering logic outside of command "switch" (giant if/else). (Patick Strateman)
2015-11-26 08:43:21 +01:00
Wladimir J. van der Laan
4ec3561eb3
Replace scriptnum_test's normative ScriptNum implementation
...
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes #7086 .
2015-11-25 13:59:49 +01:00
Wladimir J. van der Laan
2b2ddc558e
Merge pull request #7088
...
5ad5463
Squashed 'src/secp256k1/' changes from 2bfb82b..6c527ec (MarcoFalke)
2015-11-25 11:31:59 +01:00
Wladimir J. van der Laan
348b281f8a
Merge pull request #7092
...
392d3c5
build: Set osx permissions in the dmg to make Gatekeeper happy (Cory Fields)
2015-11-25 10:01:58 +01:00
daniel
c434940e83
uint256::GetCheapHash bigendian compatibility
2015-11-25 16:19:24 +08:00
Jonas Schnelli
26af1ac7cb
Merge pull request #7006
...
f71bfef
add UI help for -resetguisettings (Jonas Schnelli)
ae98388
[Qt] add startup option to reset Qt settings (Jonas Schnelli)
2015-11-25 09:05:19 +01:00
Patick Strateman
1bb289fe1b
Assert now > 0 in GetTime GetTimeMillis GetTimeMicros
...
Previously all of these functions could return negative values (for different
readons). Large portions of the codebase currently assume that these
functions return positive values.
2015-11-24 18:39:19 -08:00
Cory Fields
392d3c5846
build: Set osx permissions in the dmg to make Gatekeeper happy
2015-11-24 16:22:24 -05:00
Wladimir J. van der Laan
b19fe277dd
Merge pull request #7075
...
4846543
Move time data log print to 'net' category to reduce log noise (tulip)
2015-11-24 16:02:02 +01:00
Suhas Daftuar
e30443244a
Pass reference to estimateSmartFee and cleanup whitespace
2015-11-24 08:53:14 -05:00
MarcoFalke
fa472f330f
[trivial] Fix -maxmempool InitError
2015-11-24 12:40:59 +01:00
Patick Strateman
9cf668844e
Document both the peerbloomfilters and enforcenodebloom options.
2015-11-24 02:08:00 -08:00
Patick Strateman
0f4dc53fd6
Add enforcenodebloom option.
...
Previously peers which implement a protocol version less than NO_BLOOM_VERSION
would not be disconnected for sending a filter command, regardless of the
peerbloomfilter option.
Many node operators do not wish to provide expensive bloom filtering for SPV
clients, previously they had to cherry pick the commit which enabled the
disconnect logic.
The default should remain false until a sufficient percent of SPV clients
have updated.
2015-11-24 02:08:00 -08:00
Wladimir J. van der Laan
02a0f348c2
Merge pull request #7066
...
5c2fd38
Add missing "blocktime" description to listtransactions help, fix formatting. (Pavel Janík)
2015-11-24 10:55:36 +01:00
Patick Strateman
b3caa9b7fa
Move bloom filter filtering logic outside of command "switch" (giant if/else).
...
Moving this logic outside of the "switch" makes it far simpler to
enable the forced disconnect by a parameter.
2015-11-24 01:50:53 -08:00