Commit Graph

16245 Commits

Author SHA1 Message Date
Alexander Block
ee7cebb2b0 Temporary fix for race condition 2019-06-24 00:10:46 +02:00
MarcoFalke
c7cafe5def Merge #11345: [tests] Check connectivity before sending in assumevalid.py
e9e939108 [tests] Check connectivity before sending in assumevalid.py (John Newbery)

Pull request description:

  assumevalid.py would try to send over a closed P2P connection in a loop,
  hitting the following failure many times:

  `TestFramework.mininode (ERROR): Cannot send message. No connection to node!`

  The test still passed, but this is a lot of noise in the test log.

  Just check that the connection is open before trying to send.

Tree-SHA512: 6faf2ce5717de976fed1b5c863bc8d17e785928690f833d5bf175178f95d39f455635a844fe7e0dfdad83ae779dd45bc6e4ed89a9467d8482c5be73b55095c8d
2019-06-24 00:10:46 +02:00
Alexander Block
38d37ae5ab Don't check block indexes in assumevalid.py
CheckBlockIndex slows down header processing a lot, so that this test even
fails on Travis.
2019-06-24 00:10:46 +02:00
MarcoFalke
2b66fc6641 Merge #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework
4ed3653 [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (Suhas Daftuar)

Tree-SHA512: d8f724b3324aad73a7b15cf87ff394e8d615bf3cd5a394d5715347d833f2ae9ac745a944202986866255eca5fc105ea06ab3abe12e168b67de34482f751c68e2
2019-06-23 10:44:53 +02:00
Alexander Block
a7f9f14d36 Give syncing in assumevalid.py more time 2019-06-22 14:15:12 +02:00
Alexander Block
a05d163036 Remove unnecessary and forever-blocking wait_to_sync calls 2019-06-22 14:14:01 +02:00
Alexander Block
c77c4330c7 Send less blocks to node1
We only want to verify that assumevalid causes block 102 to be accepted
even though it contains an invalid script, so there is no need to send
more blocks.
2019-06-22 14:14:01 +02:00
Alexander Block
d03bc6d023 No need to send so many headers to node0
We're only interested in node0 processing up to block 102, so we don't need
so many of the headers.
2019-06-22 14:14:01 +02:00
Alexander Block
c2ac477a11 Use 4x as much headers in assumevalid.py
Dash has only 1/4 of block time compared to Bitcoin, which requires 4 times
the amount of headers so that the assumevalid check in ConnectBlock results
in skipping of script checks.

Using so many headers now causes block time validation to fail (too far in
the future), so we need to adjust mock time as well.
2019-06-22 14:14:01 +02:00
Alexander Block
c44dece486 Disable DIP3 in multiple tests 2019-06-22 14:14:01 +02:00
Wladimir J. van der Laan
0e556be703 Merge #9494: Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs
78da882 Util: Small improvements in gArgs usage (Jorge Timón)
5292245 Util: Put mapMultiArgs inside ArgsManager (Jorge Timón)
b3cbd55 scripted-diff: Util: Encapsulate mapMultiArgs behind gArgs (Jorge Timón)
f2957ce Util: Create ArgsManager class... (Jorge Timón)

Tree-SHA512: 7d58250da440ad0f41745f46ab6021d6ecbb292035cab3d86fb08ce6bd822df604ac31b3ded6fd6914f7cfd12ba531cbc06a76eb500f629627f47ae6ac8350a7

add ForceRemoveArg and ForceSetMultiArg to ArgsManager class

Signed-off-by: Pasta <pasta@dashboost.org>

add static inlines for ForceSetMultiArgs and ForceRemoveArg

Signed-off-by: Pasta <pasta@dashboost.org>

both void

Signed-off-by: Pasta <pasta@dashboost.org>

use gArgs, dash code

Signed-off-by: Pasta <pasta@dashboost.org>

revert a bit

Signed-off-by: Pasta <pasta@dashboost.org>

adj

Signed-off-by: Pasta <pasta@dashboost.org>

use gArgs

Signed-off-by: Pasta <pasta@dashboost.org>

remove '_'

Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-21 20:34:25 -05:00
UdjinM6
a363e5bf72
Merge pull request #2987 from PastaPastaPasta/backport-7692
Remove p2p alert system
2019-06-22 03:43:59 +03:00
Pasta
26ec979fa3 remove TheadSendAlert in init.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-21 19:33:53 -05:00
Wladimir J. van der Laan
ce6623eba8 Remove stale code, delete alert_tests.cpp 2019-06-21 19:33:53 -05:00
Pasta
c6b926547c Merge #7958: Remove useless argument to AlertNotify.
b02119e Remove useless argument to AlertNotify. (Pavel Janík)

Signed-off-by: Pasta <pasta@dashboost.org>

# Conflicts:
#	src/main.cpp
2019-06-21 19:33:53 -05:00
Wladimir J. van der Laan
a1770b0c25 Merge #7692: Remove p2p alert system
cfd519e Add release note documentation (BtcDrak)
6601ce5 protocol.h/cpp: Removes NetMsgType::ALERT (Thomas Kerin)
ad72104 Formatting (BtcDrak)
1b77471 Remove alert keys (BtcDrak)
01fdfef Remove `-alerts` option (BtcDrak)
9206634 Update alert notification and GUI (BtcDrak)
bbb9d1d Remove p2p alert handling (BtcDrak)

manual fixes

Signed-off-by: Pasta <pasta@dashboost.org>

remove sendalert.cpp

Signed-off-by: Pasta <pasta@dashboost.org>

CAlertNotify -> AlertNotify

Signed-off-by: Pasta <pasta@dashboost.org>

remove alert.h

Signed-off-by: Pasta <pasta@dashboost.org>

remove vAlertPubKey for DevNet

Signed-off-by: Pasta <pasta@dashboost.org>

remove src/main.cpp
2019-06-21 19:33:53 -05:00
PastaPastaPasta
1f6e0435b4 [Trivial] Fix a typo in a comment in mnauth.h (#2988)
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-22 03:24:32 +03:00
UdjinM6
e29cb15e25
Merge pull request #2986 from PastaPastaPasta/backports-0.15-pr15
Backports 0.15 pr15
2019-06-22 03:23:14 +03:00
UdjinM6
f02bf18eec
Other fixes 2019-06-21 09:33:27 -05:00
UdjinM6
23114cdb20
Drop redirect_stderr and pass stderr instead 2019-06-21 09:33:27 -05:00
UdjinM6
badfdb451c
Fix rpc param names
And corresponding locall variables too
2019-06-21 09:33:14 -05:00
UdjinM6
3dcbb2e599
fix bip68-112-113-p2p.py 2019-06-21 09:26:41 -05:00
Pasta
867d3449a6
adjust networkhashps test for dash block time
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 13:05:39 -05:00
Pasta
3b3132539f
update python tests
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 13:01:39 -05:00
Pasta
577a4ce4b8
use uint64_t
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 13:01:12 -05:00
Pasta
5df0a96f7e
adjust build_src.sh 10189
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 12:44:42 -05:00
Pasta
d523ed81ee
drop segwit 10318
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 12:44:17 -05:00
Pasta
823f858f4f
apply concepts in 10198 to dash specific tests
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 08:20:15 -05:00
MarcoFalke
65d0fbf3c2
Merge #10253: [test] Add test for getnetworkhashps
de487b7 Tests: Add test for getnetworkhashps (Jimmy Song)

Tree-SHA512: b1418ad904618f639ffa34dd40906692aff1fdf1a0d13a9af00039e7a6a2b758091734b89c0c91e8d455da6b15a0e435a9a9ca97a41d97bf395b844c761ffa27
2019-06-19 08:20:15 -05:00
Pasta
4b376794c0
use uint64 for flags
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 08:20:15 -05:00
Pasta
b9e10fb42e
use new string method
Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
70a164fd8a
Merge #10150: [rpc] Add logging rpc
7fd50c3 allow libevent logging to be updated during runtime (John Newbery)
5255aca [rpc] Add logging RPC (John Newbery)
4d9950d Set BCLog::LIBEVENT correctly for old libevent versions. (John Newbery)

Tree-SHA512: d6788a7205372c0528da71eca052910dfb055f2940ca884f422ff3db66e23a2b49c6a15b8f27d5255554fe5c5a928f5dd903fdc63b0bd6c8fa7783e77bb30fe8
2019-06-19 08:20:15 -05:00
MarcoFalke
6b9e864a08
Merge #10187: tests: Fix test_runner return value in case of skipped test
e96462f tests: Fix test_runner return value in case of skipped test (Wladimir J. van der Laan)

Tree-SHA512: 99434ce3e0b5376268d33cdbae46d48786feb9820c7f8acccdd50f6674e315abffc84ba1feda441332d140a7480070eba732abae8f07293984d4daa9352ee8ee
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
5e796e95fd
Merge #10381: Shadowing warnings are not enabled by default, update doc accordingly
f203ecc Shadowing is not enabled by default, update doc accordingly. (Pavel Janík)

Tree-SHA512: a7170827caa9d35457356808445ef2387fd2edde72fb76c6241cfd5decad218558b307d223e86bb66041576b638f90f6efa8a46ea6208d43da275a993617c997
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
32c0e0f9b1
Merge #10325: 0.15.0 Depends Updates
355c116 [depends] dbus 1.10.18 (fanquake)
a8d7474 [depends] ccache 3.3.4 (fanquake)
daeb767 [depends] libevent 2.1.8-stable (fanquake)
d78269a [depends] Boost 1.64.0 (fanquake)
7d92c6f [depends] Latest config.guess and config.sub (fanquake)

Tree-SHA512: c63cdffabb1f57b7efd71c85f845c30ce00cda56f6d665f935674f3324563a7364f3bc30c105a1ee1064f1d24eb7345d7e44791cd471094dcc5e20f307fec4cb
2019-06-19 08:20:15 -05:00
MarcoFalke
cbb7a8ecc0
Merge #10371: [tests] Clean up addrman_tests.cpp
a80f295 [tests] Clean up addrman_tests.cpp (Jimmy Song)

Tree-SHA512: c745ebb0b8867e8abacfab62561a883ee5219176951e9ad4821fdc1e6152c9548663824ad624bfce1294760284fc6bd2a598749d66e62af55f39c59a1ea357ce
2019-06-19 08:20:15 -05:00
MarcoFalke
1c7ec5f4ad
Merge #10361: qa: disablewallet: Check that wallet is really disabled
fa7396d qa: disablewallet: Check that wallet is really disabled (MarcoFalke)

Tree-SHA512: 8c999ae0763fad389ba06f23cca3f589edaaf6dabd29ea8493413eee574ef2c1d49a69cb1158d8b28254cf922277a86b45747e50f44ebc9b0545297c3987289d
2019-06-19 08:20:15 -05:00
Pieter Wuille
31cc65c2ed
Merge #10338: Maintain state across GetStrongRandBytes calls
97477c5 Maintain state across GetStrongRandBytes calls (Pieter Wuille)

Tree-SHA512: 77e9b1f3c6eeb0c2a3e0c64358150767222ff0b7120ccd5f4ae0276cea0e4fa275c1b757e3f20be07dc0b4ef07f70ab0b70112080c8d3d0cb6ed703db8a59168
2019-06-19 08:20:15 -05:00
Pieter Wuille
b13d92079d
Merge #10322: Use hardware timestamps in RNG seeding
2c0a6f1 Use sanity check timestamps as entropy (Pieter Wuille)
33f853d Test that GetPerformanceCounter() increments (Pieter Wuille)
f544094 Use hardware timestamps in RNG seeding (Pieter Wuille)

Tree-SHA512: ea96ff56d425b5dc693b4dd35c8aa64ba20a01b9bd7d2d65298ece623f434e8cfa190f9c0f9b76df8aa496547bfa64533eb751edec8401d09bd5ee3478928a59
2019-06-19 08:20:15 -05:00
MarcoFalke
15f7f9c850
Merge #10287: [tests] Update Unit Test for addrman.h/addrman.cpp
ed36de5 [tests] Update Unit Test for addrman.h/addrman.cpp (Jimmy Song)

Tree-SHA512: e7c08c19e227c34c230900e14a176b2290022b78b0ece387452e673662491c11f26249cbf1711235276c07a964c339e27b4cda9a2730ded5c0e23a650e0d72db
2019-06-19 08:20:15 -05:00
MarcoFalke
5b99bfc6fa
Merge #10342: [tests] Improve mempool_persist test
329ac3b [tests] use wait_until in mempool_persist.py (John Newbery)

Tree-SHA512: 3f5fe3dcdb5da3b10a41f7b88d29c15b79c02fbb037914b4342b77428f2afe8b342f6adacb28a9eb5549aa156cd146175389bd61909a20df3fecb88361c4779f
2019-06-19 08:20:15 -05:00
MarcoFalke
07752f63ea
Merge #10352: test: Add elapsed time to RPC tracing
20187e4 test: Add elapsed time to RPC tracing (Wladimir J. van der Laan)

Tree-SHA512: f271acedd14020cf911711577f6dd940850fa84d2577618af06a2247c940fcc5b339a86c1c7a179899c556d217a6c967c785fb311bba43a9b6073cbe470b6737
2019-06-19 08:20:15 -05:00
MarcoFalke
7773cf9a87
Merge #10171: [tests] Add node methods to test framework
4550049 Reorganize BitcoinTestFramework class (John Newbery)
b7dd44c Add start and stop node methods to BitcoinTestFramework (John Newbery)
b111324 move initialize_chain() and initialize_chain_clean() to be methods of BitcoinTestFramework (John Newbery)

Tree-SHA512: 17e541aea8ca4c0d1189701499384e26239e2d5905de8adb0f042d3cf4c0bbed79fcaad61d563e1743bf4c62ad4915cebb4714783db839d9c53dfbbedcae6e9a
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
2edd094a21
Merge #10189: devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private.
0f3471f net: make CNode's id private (Cory Fields)
9ff0a51 scripted-diff: net: Use accessor rather than node's id directly (Cory Fields)
e50c33e devtools: add script to verify scriptable changes (Cory Fields)

skipped travis changes

Tree-SHA512: a0ff50f4e1d38a2b63109b4996546c91b3e02e00d92c0bf04f48792948f78b1f6d9227a15d25c823fd4723a0277fc6a32c2c1287c7abbb7e50fd82ffb0f8d994

pnode->id to pnode->GetId()

Signed-off-by: Pasta <pasta@dashboost.org>
2019-06-19 08:20:15 -05:00
MarcoFalke
d6e83980da
Merge #10318: [tests] fix wait_for_inv()
3e3c22f [tests] fix wait_for_inv() (John Newbery)

Tree-SHA512: b8070b8461e9c792cc3d9c17fd9d3faf87f550c7c0fc1788e0cd382f0794932b70cc87d480805a3b3c1ca2fdca9f8f1bcb9759300d777d9aaa8d41c016260d93
2019-06-19 08:20:15 -05:00
MarcoFalke
8c420c2983
Merge #10344: [tests] Fix abandonconflict.py intermittency
965a124 [tests] Fix abandonconflict.py intermittency (John Newbery)

Tree-SHA512: e0aeeaa2713fb842b92d8c474823b4ed4b7adb840c59141c99216f6611998339776afe0be17a53da9e85137fd53fd8d4985e11a65476765ee1c97df36e237142
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
14fbe9954a
Merge #10327: [tests] remove import-abort-rescan.py
981e586 [tests] remove import-abort-rescan.py (John Newbery)

Tree-SHA512: 8658d42b5ecdefbb71c55849036ee4e8e113abbc9c549730524009fb6eacc50340ffb7ef99fb35809d4abd6b304d491a618e45ff6ded1990f01f18cbcebf2b12
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
d4e6ab341b
Merge #10302: [Makefile] Alphabetically Reorder addrdb.cpp
56f09df [Makefile] Alphabetically Reorder addrdb.cpp (Spencer Lievens)

Tree-SHA512: cedf64f5b4a6b20c07881f7e9c1c36421ee04a1ba17319946bae0197f9475dba6d5bda05f8f5d72539fbffcaa0adf8f474ecb2089106215c996576ab1235e8e1
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
80f8bb17dd
Merge #9966: Control mempool persistence using a command line parameter
a750d77 Add tests for mempool persistence (John Newbery)
91c91e1 Control mempool persistence using a command line parameter. (John Newbery)

Tree-SHA512: 157d01cefd1903b8bfc5cbab42a3cc5e9c1094179bf4b64b3d34c0d4d9b976d593755bfea5c41c631cb758e1de17c6c2058c130d487d20560b7c0bafcddfa520
2019-06-19 08:20:15 -05:00
Wladimir J. van der Laan
3d87faff5e
Merge #10307: [tests] allow zmq test to be run in out-of-tree builds
b8251f6 [tests] allow zmq test to be run in out-of-tree builds (John Newbery)

Tree-SHA512: 6946d23bc8a0b57e841a6811989182732d0534989e0e3b94421387f7971379b25a25d238cad22272e04076293275f6e980c8a713fce87ba48c1c4463d9243051
2019-06-19 08:20:15 -05:00