Commit Graph

9230 Commits

Author SHA1 Message Date
Holger Schinzel
960864790f Merge pull request #797 from UdjinM6/fixDSIXRelay
fix RelayTransaction to relay correct message (dstx/ix)
2016-05-24 07:20:39 +02:00
UdjinM6
5c5ddfe71e Move DS qt options to Wallet tab in Options dialog 2016-05-24 05:21:36 +03:00
UdjinM6
87ad368643 Optimize processing of a (potentially) new MN:
- Move heavy `IsVinAssociatedWithPubkey` deep inside of `CheckInputsAndAdd` to be actually executed only once per masternode and only after much simpler checks were executed;
- Verify `GetInputAge` (it uses cache) before trying to enter `AcceptToMemoryPool` (which hash many ifs and checks inside).
2016-05-24 03:15:53 +03:00
UdjinM6
d82680af1b fixes for Masternode Tab, issues #790, #795, #796 2016-05-24 02:51:37 +03:00
UdjinM6
519577d4f4 Fix final dstx signing:
- Should fail if at least one AddScriptSig() fails (currently will pass if at least one is ok, which is no good)
- Should log this accordingly
2016-05-24 02:40:12 +03:00
UdjinM6
c845e5922f fix RelayTransaction to relay correct message (dstx/ix) 2016-05-24 02:06:09 +03:00
Evan Duffield
869ff89d3b update gethash() 2016-05-23 15:52:10 -07:00
Evan Duffield
528c5edb19 fix fValid caching engine 2016-05-23 14:39:10 -07:00
Evan Duffield
18e9a33e2a changed fee to 0.1D for govobj submission 2016-05-23 11:16:46 -07:00
Evan Duffield
39d9ad87fb more refactoring 2016-05-23 11:10:20 -07:00
Evan Duffield
623ac049e2 More cleanup
- AddProposal -> AddGovernanceObject
- mapOrphanMasternodeBudgetVotes -> mapOrphanVotes
- UpdateProposal -> UpdateGovernanceObject
2016-05-23 10:58:39 -07:00
Evan Duffield
860d29f9c4 Budget system -> Governance System
- Changed Action -> Signal for clarity
- CBudgetVote -> CGovernanceVote
2016-05-23 10:53:05 -07:00
Holger Schinzel
06b84a4e4a Merge pull request #787 from UdjinM6/lightTheme
fix tab text truncation
2016-05-21 10:45:24 +02:00
UdjinM6
d7cf3393c0 fix tab text truncation 2016-05-20 21:34:52 +03:00
UdjinM6
f89635f73a fix flat-db:
- no reason to read twice on load
- should read using temp object instead the one we want to save on dump
2016-05-20 20:46:34 +03:00
Evan Duffield
2c3e480681 Merge pull request #786 from UdjinM6/rightClickStartAlias
right-click to start alias in "My Masternodes" sub-tab
2016-05-20 10:21:22 -07:00
Evan Duffield
35aa7668a5 Merge branch 'v0.12.1.x' of https://www.github.com/dashpay/dash into v0.12.1.x 2016-05-20 10:19:19 -07:00
UdjinM6
16c20006ca right-click to start alias in "My Masternodes" sub-tab 2016-05-20 16:15:02 +03:00
Holger Schinzel
43cd805282 Merge pull request #781 from UdjinM6/fixLibpngWarning
fix libpng warning
2016-05-20 07:43:57 +02:00
Holger Schinzel
95224abf8e Merge pull request #784 from UdjinM6/fixMasternodeConfRead
fix CMasternodeConfig::read()
2016-05-20 06:01:32 +02:00
Holger Schinzel
bc1f83c02c Merge pull request #779 from evan82/v0.12.1.x
Use chainparams instead of standalone func for mn confirms
2016-05-20 06:01:23 +02:00
UdjinM6
6fb9962424 fix CMasternodeConfig::read() 2016-05-20 01:29:34 +03:00
Evan Duffield
49b8123ae1 commenting out part of flatfile.dump, which is causing data corruption 2016-05-19 14:27:09 -07:00
Evan Duffield
deb0f0ca14 fixed vote casting 2016-05-19 14:08:57 -07:00
Evan Duffield
d8453bb92b Use chainparams instead of standalone func for mn confirms
- Use function instead of chainparams directly
2016-05-19 13:54:23 -07:00
UdjinM6
5d775240b0 fix "GUI: libpng warning: iCCP: known incorrect sRGB profile" using mogrify 2016-05-19 23:14:56 +03:00
Holger Schinzel
cbfbc096d1 Update masternodeconfig.h
removing printf - breaks the build https://travis-ci.org/dashpay/dash/jobs/131496337#L1485
2016-05-19 22:05:58 +02:00
Evan Duffield
a3116768ab Use chainparams instead of standalone func for mn confirms
- Use function instead of chainparams directly
2016-05-19 12:18:16 -07:00
Evan Duffield
22661ad60d Merge pull request #778 from UdjinM6/lightTheme
Fixing light theme
2016-05-19 11:37:08 -07:00
Evan Duffield
a69a643c6e Merge pull request #777 from crowning-/UI_Enhancements
[UI] Change default theme to "DASH-light"
2016-05-19 11:36:47 -07:00
Evan Duffield
1376208c61 Merge pull request #776 from UdjinM6/masternodeTab
Add masternode tab in qt wallet
2016-05-19 11:36:26 -07:00
Evan Duffield
2ca8c85820 fixed voting errors 2016-05-19 11:34:43 -07:00
UdjinM6
86bca13e1e fix dumb bug in signal connection 2016-05-16 22:27:43 +03:00
UdjinM6
c5c0aa78fc moved "Show Masternodes Tab" to Expert features 2016-05-16 15:43:45 +03:00
UdjinM6
050b707d9f Icon update (thanks @salmion) 2016-05-16 02:05:42 +03:00
UdjinM6
020ecebb3e Use options to choose whether to show Masternodes tab or not. Should be set to true at first run for those who have masternodes in their masternode.conf and false for others. 2016-05-16 01:55:20 +03:00
UdjinM6
843453fb66 More fixes for Masternodes tab:
- set initial columns size
- use resizable columns
- use theme-dependent masternodes icon (placeholder, should be replaced)
- removed unused event binding
- capitalization, more verbose ui element names
2016-05-15 19:43:22 +03:00
Evan Duffield
2cec48631e Merge branch 'v0.12.1.x' of https://www.github.com/dashpay/dash into v0.12.1.x 2016-05-13 09:03:35 -07:00
Evan Duffield
9031c5e3cb Update some governance logic 2016-05-13 09:03:01 -07:00
UdjinM6
12239be138 Fix tx icons for light theme (thanks @snogcel) 2016-05-13 12:42:51 +03:00
UdjinM6
9101c54d30 Fixing light theme:
- colorized few images/icons to use “Strong blue” #1c75bc
- replaced "smile" icon with pick-axe
- fixed ds status overlap
- trying to make theme less "heavy" - fewer bold labels, lighter colors for labels
- removed unused files
2016-05-12 16:59:33 +03:00
crowning-
4584201d9b [UI] Change default theme to "DASH-light" 2016-05-11 20:42:38 +02:00
UdjinM6
3764e6869a Add masternode tab in qt wallet 2016-05-11 15:50:04 +03:00
Holger Schinzel
25c4341311 Merge pull request #775 from UdjinM6/fixPid
fix pid dash.pid -> dashd.pid
2016-05-11 11:37:54 +02:00
Holger Schinzel
c77d9830ae Merge pull request #774 from thelazier/patch-2
Fix Hot Masternode
2016-05-11 11:37:46 +02:00
Holger Schinzel
28fc3bae6e Merge pull request #762 from crowning-/patch-3
[UI] Enable themed *.png icons again for Linux
2016-05-11 11:37:41 +02:00
UdjinM6
12317fa13e fix pid dash.pid -> dashd.pid 2016-05-11 12:30:52 +03:00
TheLazieR Yip
fe66b5acd0 Fix Hot Masternode
Add Update Masternode List from created masternode broadcast before relay.
2016-05-11 03:45:11 +07:00
Holger Schinzel
e5bcd0598b Merge pull request #773 from thelazier/patch-1
Fix Hot Masternode
2016-05-10 19:39:33 +02:00
Holger Schinzel
feabb140a3 Merge pull request #772 from UdjinM6/fixTests
Fix tests
2016-05-10 19:39:08 +02:00
TheLazieR Yip
56adee2de2 Fix Hot Masternode
Revert to master branch
2016-05-10 21:53:08 +07:00
UdjinM6
a4c098141a fix tests to follow #767 2016-05-10 16:12:21 +03:00
Evan Duffield
0c6c21f099 Merge pull request #768 from UdjinM6/unifySubsidy
Unify subsidy formulas for different networks, add few comments
2016-05-10 06:11:17 -07:00
Holger Schinzel
8a03d1630d Merge pull request #770 from crowning-/patch-5
[UI] Rebranding: PrivateSend/InstantSend (update)
2016-05-10 13:36:02 +02:00
UdjinM6
b9ad319d00 Unify subsidy formulas for different networks, add few comments 2016-05-10 12:50:57 +03:00
Holger Schinzel
05661617a6 Some houskeeping:
- fixed testnet checkpoints
- revert testnet mining patch
2016-05-10 09:57:05 +02:00
crowning-
5091ac939b [UI] Rebranding: PrivateSend/InstantSend (update)
Accidentally overwrote my final version locally, so the change of the (unfortunately most prominent) InstantX label on the sendcoins page got lost. 

Sorry  :-/
2016-05-10 05:39:36 +02:00
Holger Schinzel
d61edf8452 Remove log spam 2016-05-10 00:28:36 +02:00
Evan Duffield
e0a4c6ec19 Merge pull request #760 from crowning-/UI_Enhancements
[UI] Rebranding: Darksend/InstantX changed to PrivateSend/InstantSend (UI+log)
2016-05-09 13:54:21 -07:00
Evan Duffield
bfaa5b6970 Merge pull request #761 from UdjinM6/fixStyling
Assign app name in NetworkStyle::NetworkStyle()
2016-05-09 13:52:37 -07:00
Evan Duffield
684994ca4e Merge pull request #764 from crowning-/UI_Icons
[UI] Some standard Bitcoin icons beautified
2016-05-09 13:51:33 -07:00
Evan Duffield
f13b9ad418 Merge pull request #767 from moocowmoo/v0.12.1.x
config - changed network bip32 values, testnet/regtest pubkey
2016-05-09 13:51:03 -07:00
Evan Duffield
736d22262f fixed mining 2016-05-09 12:51:23 -07:00
moocowmoo
c5004ce308 config - changed network bip32 values, testnet/regtest pubkey
mainnet bip32 seeds start with dpub/dprv
testnet/regtest  bip32 seeds start with DPUB/DPRV
only create public testnet/regtest addresses starting with y
2016-05-09 19:13:22 +00:00
crowning-
243067c0ee [UI] Rebranding: Darksend/InstantX changed to PrivateSend/InstantSend 2016-05-09 21:08:13 +02:00
Evan Duffield
60e048071f added budget item func 2016-05-09 09:31:11 -07:00
Evan Duffield
8c48d9dbb9 fixed endian issues 2016-05-09 08:58:17 -07:00
Evan Duffield
4caf64569f merged 2016-05-09 08:39:31 -07:00
Evan Duffield
358be66084 reset testnet 2016-05-09 08:32:47 -07:00
Evan Duffield
9b7504cb32 Fix dumb errors on ubuntu 2016-05-06 18:36:11 -04:00
Evan Duffield
e6d7f4ed7f fixing more errors 2016-05-05 10:44:46 -07:00
Evan Duffield
aee86618cd fixed greedy find/replace (opps) 2016-05-05 10:30:28 -07:00
Pieter Wuille
e3a9ce9c94 Refactor script tests
Github-Pull: #7818
Rebased-From: c7c664191f 269281b7cc d03e46625a 76da761351 009b503792 dde46d3ae1
2016-05-04 13:01:59 +02:00
Wladimir J. van der Laan
87129b24e1 test: script_error checking in script_invalid tests
Github-Pull: #7517
Rebased-From: b0ff8572ae 2317ad7c56 0ecb3401fe
2016-05-04 13:01:55 +02:00
Suhas Daftuar
43c14acf14 Fix headers announcements edge case
Previously we would assert that if every block in vBlockHashesToAnnounce is in
chainActive, then the blocks to be announced must connect.  However, there are
edge cases where this assumption could be violated (eg using invalidateblock /
reconsiderblock), so just check for this case and revert to inv-announcement
instead.

Github-Pull: #7919
Rebased-From: 3a99fb2cb1
2016-04-27 22:34:48 +02:00
Alexander Regueiro
06c73a1751 Removed call to TryCreateDirectory from GetDefaultDataDir in src/util.cpp.
See https://github.com/bitcoin/bitcoin/issues/7845#issuecomment-207684728.
Also refactored `GetDefaultDataDir` function to return path for Mac in one expression.

Github-Pull: #7850
Rebased-From: 41dbc4849e
2016-04-27 22:34:48 +02:00
Suhas Daftuar
7e71785c40 Use txid as key in mapAlreadyAskedFor
Previously we used the CInv that would be sent to the peer announcing the
transaction as the key, but using the txid instead allows us to decouple the
p2p layer from the application logic (which relies on this map to avoid
duplicate tx requests).

Github-Pull: #7862
Rebased-From: 7e91f632c7
2016-04-27 22:34:48 +02:00
R E Broadley
d3ead9bcb6 Avoid "Unknown command" messages when receiving getaddr on outbound connections.
Github-Pull: #7642
Rebased-From: d84ea1a59ce3704457a162f1fd8a7353047156de
2016-04-27 22:34:48 +02:00
Patrick Strateman
a5bc6a1bc4 Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f069
2016-04-27 22:34:48 +02:00
Matthew Zipkin
52c101158f Clarify description of blockindex
see issues:

https://github.com/bitcoin-dot-org/bitcoin.org/issues/1237

https://github.com/bitcoin/bitcoin/issues/7532

Github-Pull: #7541
Rebased-From: 7eef1d0dad
2016-04-27 22:34:48 +02:00
Alex Morcos
21b2f82eb7 Don't resend wallet txs that aren't in our own mempool
Github-Pull: #7521
Rebased-From: 5a2b1c0c8b
2016-04-27 22:34:48 +02:00
Wladimir J. van der Laan
66d5408559 Fix memleak in TorController [rework]
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Github-Pull: #7637
Rebased-From: e219503711
2016-04-27 22:34:48 +02:00
jloughry
64fd0ce1d9 fix spelling of advertise in src and doc
Github-Pull: #7526
Rebased-From: 37767fd46f
2016-04-27 22:34:48 +02:00
instagibbs
a9e73f71d4 Fix and cleanup listreceivedbyX documentation
Github-Pull: #7527
Rebased-From: c372572595
2016-04-27 22:34:48 +02:00
ptschip
90955940d5 Do not download transactions during inital sync
Github-Pull: #7164
Rebased-From: 39a525c21f
2016-04-27 22:34:47 +02:00
Evan Duffield
f2de437f05 mixed up actions/outcomes 2016-04-26 11:36:07 -07:00
Evan Duffield
7e742d2e7d cleaned up couple bugs 2016-04-26 11:34:53 -07:00
Evan Duffield
ad5d48dae4 Created nice interface for converting between:
- vote outcomes between string and int
- vote actions between string and int
2016-04-26 11:27:22 -07:00
Evan Duffield
d9d72dd7af enable governance cache 2016-04-26 10:48:09 -07:00
Evan Duffield
2df4059f4e Fix masternode voting object 2016-04-26 10:45:06 -07:00
UdjinM6
26b8d99be2 fix CGovernanceObject step1.5: not really a fix, just commented out simple broken parts (undeclared vars and functions, wrong number of arguments etc) to prove that it compiles now, needs to be actually fixed 2016-04-26 10:31:14 -07:00
UdjinM6
71bdc09470 fix CGovernanceObject step1: make, copy constructor, uint256, rpc 2016-04-26 10:31:00 -07:00
Evan Duffield
3fe02f4777 any help? 2016-04-25 21:08:36 -07:00
MarcoFalke
89ae85484c
Merge #7811: [0.12.2] qa Backports
6862627 Add listunspent() test for spendable/unspendable UTXO (Joao Fonseca)
28ba22c [qa] Remove misleading "errorString syntax" (MarcoFalke)
f1f1b82 [qa] py2: Unfiddle strings into bytes explicitly (MarcoFalke)
c0d9e31 Tests: make prioritise_transaction.py more robust (Suhas Daftuar)
ff9b436 [qa] Bug fixes and refactor (MarcoFalke)
b1dd64b [qa] wallet: Wait for reindex to catch up (MarcoFalke)
f23cb7c [qa] Add tests verifychain, lockunspent, getbalance, listsinceblock (MarcoFalke)
3316552 [qa] Test walletpassphrase timeout (MarcoFalke)
6aae129 [qa] wallet: Print maintenance (MarcoFalke)
ad8c743 [qa] Extend tests (MarcoFalke)
d89fbfe [qa] rpc-test: Normalize assert() (MarcoFalke)
2016-04-25 14:59:52 +02:00
crowning-
ddfc3e98f0 [UI] Obsolete icons (+references) removed 2016-04-24 23:03:27 +02:00
crowning-
d439375e3a [UI] Some standard (old) Bitcoin icons beautified (comment removed) 2016-04-20 22:39:21 +02:00
crowning-
00266a876f [UI] Some standard (old) Bitcoin icons beautified 2016-04-20 22:35:24 +02:00
crowning-
c755c45a93 [UI] Enable themed *.png icons again for Linux
Reference: my first comment here: https://github.com/dashpay/dash/pull/761
2016-04-20 17:35:53 +02:00
UdjinM6
b8109eb06b Assign app name in NetworkStyle::NetworkStyle(), fixes splash screen 2016-04-20 17:03:22 +03:00
crowning-
67214d9971 [UI] Parts of PR612 re-added 2016-04-20 08:04:46 +02:00
Evan Duffield
421678ac1d comment 2016-04-19 13:24:00 -07:00
Evan Duffield
73c430e4ca merged 2016-04-19 13:22:04 -07:00
Evan Duffield
378582fce5 update vote types 2016-04-19 12:08:01 -07:00
crowning-
b61849c697 [UI] Rebranding: removed PrivacyProtect from mixing button 2016-04-19 20:49:19 +02:00
Evan Duffield
fe5c4dd811 Converting governance system
- Generic usage of governance objects
- Added different voting types of signaling
- Removed budget commands (projection, mesc -- see sentinel https://github.com/evan82/sentinel/blob/master/docs/example4.md)
- Added various voting signaling mechanisms (origin funding, remove, valid, endorsed, milestones, outerstorage)
2016-04-19 09:51:15 -07:00
crowning-
e44dab084a [UI] Darksend changed to PrivacyProtect (UI+log) 2016-04-18 23:46:51 +02:00
Evan Duffield
94f448d6fa update gitignore 2016-04-16 17:29:41 -07:00
Evan Duffield
c981f296e1 update code to correctly use governance objects 2016-04-16 14:42:27 -07:00
Evan Duffield
59ddc0d71e added dynamic registers 2016-04-16 10:19:17 -07:00
Evan Duffield
31d8a4d16f clean up local mods 2016-04-15 09:39:33 -07:00
Evan Duffield
fe2b606f67 register notes 2016-04-15 02:10:38 -07:00
MarcoFalke
f1f1b82033 [qa] py2: Unfiddle strings into bytes explicitly
Github-Pull: #7853
Rebased-From: faa41ee204, fa7abe0a00

 Conflicts:
	qa/rpc-tests/invalidtxrequest.py
	qa/rpc-tests/p2p-feefilter.py
	qa/rpc-tests/proxy_test.py
	qa/rpc-tests/test_framework/mininode.py
	qa/rpc-tests/test_framework/netutil.py
	src/test/bctest.py
2016-04-15 09:55:12 +02:00
Evan Duffield
6a68aea461 cleanup 2016-04-14 19:54:11 -07:00
Evan Duffield
e37ef5b386 fixing more errors 2016-04-14 19:14:27 -07:00
Evan Duffield
59976f3ee1 fixing more issues 2016-04-14 14:28:33 -07:00
Evan Duffield
8f0f5343ce added vote types and outcomes 2016-04-14 13:01:15 -07:00
Evan Duffield
b5476ca60a progress 2016-04-14 11:53:46 -07:00
Evan Duffield
f69d282256 cleaning up errors 2016-04-14 11:07:59 -07:00
Evan Duffield
7f64ed42ae clean up 2016-04-13 18:52:26 -07:00
Evan Duffield
3c8a3f6814 governance progress 2016-04-13 15:41:40 -07:00
UdjinM6
30dc6f4c97 fix flat database compiling 2016-04-13 10:53:13 -07:00
Evan Duffield
019eb07ac0 almost compiles 2016-04-12 09:00:19 -07:00
Evan Duffield
3c42774eb7 more progress spliting up the clasess 2016-04-10 07:46:19 -07:00
Evan Duffield
ebaee8f083 moved serialdb to template based class 2016-04-09 23:31:32 -07:00
Evan Duffield
8a13bc5180 updating colateral algo 2016-04-09 17:43:15 -07:00
Evan Duffield
138511f879 splitting progress pt . 2016-04-09 13:55:52 -07:00
Evan Duffield
a89d3164f6 removed finalized budget functionality from governance.* 2016-04-09 13:31:01 -07:00
Evan Duffield
fe7946f9fa preparing to split budgets and governance 2016-04-09 12:57:53 -07:00
Evan Duffield
7539ec3af8 move file 2016-04-09 12:02:02 -07:00
Evan Duffield
03938d3b02 move file 2016-04-09 12:01:05 -07:00
Evan Duffield
e99f0f170a added new files 2016-04-09 10:17:17 -07:00
Evan Duffield
8b82271927 revert make file 2016-04-09 10:10:06 -07:00
Evan Duffield
dbd68e2341 init gov files 2016-04-08 10:47:00 -07:00
Suhas Daftuar
46898e7e94
Version 2 transactions remain non-standard until CSV activates
Before activation, such transactions might not be mined, so don't
allow into the mempool.

- Tests: move get_bip9_status to util.py

- Test relay of version 2 transactions

Github-Pull: #7835
Rebased-From: e4ba9f6b04 5cb1d8a207 da5fdbb3a2
2016-04-08 14:22:04 +02:00
Wladimir J. van der Laan
4c3a00d35c
Reduce block timeout to 10 minutes
Now that #7804 fixed the timeout handling, reduce the block timeout from
20 minutes to 10 minutes. 20 minutes is overkill.

Conflicts:
	src/main.h

Github-Pull: #7832
Rebased-From: 62b9a557fc
2016-04-07 13:53:48 +02:00
Pieter Wuille
90f1d246d3
Track block download times per individual block
Currently, we're keeping a timeout for each requested block, starting
from when it is requested, with a correction factor for the number of
blocks in the queue.

That's unnecessarily complicated and inaccurate.

As peers process block requests in order, we can make the timeout for each
block start counting only when all previous ones have been received, and
have a correction based on the number of peers, rather than the total number
of blocks.

Conflicts:
	src/main.cpp
	src/main.h

Self check after the last peer is removed

Github-Pull: #7804
Rebased-From: 2d1d6581ec 0e24bbf679
2016-04-07 13:16:16 +02:00
Wladimir J. van der Laan
4226aacdba
init: allow shutdown during 'Activating best chain...'
Two-line patch to make it possible to shut down bitcoind cleanly during
the initial ActivateBestChain.

Fixes #6459 (among other complaints).

To reproduce:

- shutdown bitcoind
- copy chainstate
- start bitcoind
- let the chain sync a bit
- shutdown bitcoind
- copy back old chainstate
- start bitcoind
- bitcoind will catch up with all blocks during Init()

(the `boost::this_thread::interruption_point` / `ShutdownRequested()`
dance is ugly, this should be refactored all over bitcoind at some point
when moving from boost::threads to c++11 threads, but it works...)

Github-Pull: #7821
Rebased-From: 07398e8e9d
2016-04-07 13:00:17 +02:00
evan82
5fc47d4c7b Merge pull request #752 from UdjinM6/fixAutocompleter
Clear the input line after activating autocomplete
2016-04-05 10:52:02 -07:00
evan82
abbfb0a6c9 Merge pull request #751 from UdjinM6/fixDS
Fix DS bugs
2016-04-05 10:51:38 -07:00
evan82
3ffecb74d0 Merge pull request #750 from UdjinM6/debugfixes
Few debug related fixes
2016-04-05 10:51:31 -07:00
Wladimir J. van der Laan
c2106543fe
pre-rc1 translations update
New languages:

- `af` Afrikaans
- `es_AR` Spanish (Argentina)
- `es_CO` Spanish (Colombia)
- `ro` Romanian
- `ta` Tamil
- `uz@Latn` Uzbek in Latin script
2016-04-05 18:01:12 +02:00
MarcoFalke
ad8c743421 [qa] Extend tests
Github-Pull: #7684
Rebased-From: fa3a81af18 fad7dc8a6c fad8cfb893
2016-04-05 11:53:50 +02:00
Wladimir J. van der Laan
834aaef7bd
Merge #7543: [0.12] Backport BIP9, BIP68 and BIP112 with softfork
640666b [qa] rpc-tests: Properly use integers, floats (BtcDrak)
c270b62 Fix comments in tests (BtcDrak)
caf1381 Add bip68-sequence.py to extended rpc tests (BtcDrak)
26e9a05 Test of BIP9 fork activation of mtp, csv, sequence_lock (NicolasDorier)
3a99feb Add RPC test for BIP 68/112/113 soft fork. (Alex Morcos)
159ee3d Policy: allow transaction version 2 relay policy. (BtcDrak)
9713ed3 Soft fork logic for BIP68 (BtcDrak)
648be9b Soft fork logic for BIP113 (BtcDrak)
ee40924 Add CHECKSEQUENCEVERIFY softfork through BIP9 (Pieter Wuille)
6ff0b9f RPC test for BIP9 warning logic (Suhas Daftuar)
0710b30 Test versionbits deployments (Suhas Daftuar)
8ebc6f2 Add testing of ComputeBlockVersion (Suhas Daftuar)
0bdaacd Softfork status report in RPC (Pieter Wuille)
5f90d4e Versionbits tests (Pieter Wuille)
6f83cf2 BIP9 Implementation (Pieter Wuille)
ade85e1 Add LockPoints (Alex Morcos)
c8d309e Code style fix. (BtcDrak)
6170506 Separate CheckLockTime() and CheckSequence() logic (BtcDrak)
c0c5e09 BIP112: Implement CHECKSEQUENCEVERIFY (Mark Friedenbach)
197c376 fix sdaftuar's nits again (Alex Morcos)
0a79c04 Bug fix to RPC test (Alex Morcos)
0d09af7 Add RPC test exercising BIP68 (mempool only) (Suhas Daftuar)
15ba08c Implement SequenceLocks functions (Alex Morcos)
2016-04-04 13:08:29 +02:00
Pavel Janík
ded163efd7 Clear the input line after activating autocomplete 2016-04-04 13:32:26 +03:00
BtcDrak
869262605f Disable bad chain alerts
Continuous false positives lead to them being ignored entirely
so it's better to disable now until this can be fixed more
thoroughly.
2016-03-31 20:50:54 +01:00
Wladimir J. van der Laan
ba80ceef59
bump version to 0.12.1 2016-03-30 20:12:21 +02:00
UdjinM6
543296dddc Fix DS:
- ds stuck once we reached DENOMS_COUNT_MAX and can't get any output at all, ignore DENOMS_COUNT_MAX if this happens
- parts of incomplete dstx (from each participant) can't get into mempool because of 0 fee, prioritize them
- refactor names to avoid potential conflicts (state -> validationState) and better readability (finalTransaction -> finalMutableTransaction)
2016-03-27 21:21:29 +03:00
UdjinM6
981efed749 Few debug related fixes
- make logthreadnames work correctly without logtimestamps (and with emty strings again)
 - fix crash in debug (it3)
 - log debug info about locks in one line
 - show actual DS rounds instead of n/a in coin control while in debug mode
 - fix initial string in debug.log: "Bitcoin version" -> "Dash version"
2016-03-25 16:41:11 +03:00
BtcDrak
c0fe2c9e03 Mark p2p alert system as deprecated.
Set default to off
This feature is removed entirely as of 0.13.0
2016-03-24 20:06:06 +00:00
UdjinM6
00915ca31a Fix IX (locks arrive faster then the lock request itself) and add ixnotify to trigger external script 2016-03-24 19:05:44 +03:00
Jonas Schnelli
597494f5a9
Remove openssl info from init/log and from Qt debug window
Conflicts:
	src/init.cpp

Github-Merge: #7605
Rebased-From: 5ecfa36fd0
2016-03-24 12:09:23 +01:00
evan82
dee72ad0cd Merge pull request #746 from UdjinM6/refactorixdstx
Refactor IX/DSTX messages handling
2016-03-23 11:18:56 -07:00
Jonas Schnelli
7ffc2bd943
[Wallet][RPC] add abandoned status to listtransactions
Github-Pull: #7739
Rebased-From: 263de3d1c8
2016-03-23 16:30:49 +01:00
UdjinM6
5e7496ee5e More refactoring for IX:
- move ix internal logic out of CMerkleTx
- fix bug in GetInputAgeIX
2016-03-23 17:51:41 +03:00
Alex Morcos
19866c1ffc
Fix calculation of balances and available coins.
No longer consider coins which aren't in our mempool.

Add test for regression in abandonconflict.py

Github-Pull: #7715
Rebased-From: 68d4282774
2016-03-23 15:11:22 +01:00
UdjinM6
f679e24316 Refactor IX/DSTX messages handling:
- Fix CreateTransaction and GetDepthInMainChain for IX compatibility
 - Prepare IsIXTXValid for the next update (see FIXME in CreateTransaction)
 - Unify processing of TX/IX/DSTX a bit more
 - Clean up some code
2016-03-22 02:24:36 +03:00
BtcDrak
159ee3dd90 Policy: allow transaction version 2 relay policy.
This commit introduces a way to gracefully bump the default
transaction version in a two step process.
2016-03-18 09:28:41 +00:00
BtcDrak
9713ed3015 Soft fork logic for BIP68 2016-03-18 09:28:40 +00:00
BtcDrak
648be9b442 Soft fork logic for BIP113 2016-03-18 09:28:40 +00:00
Pieter Wuille
ee40924fef Add CHECKSEQUENCEVERIFY softfork through BIP9 2016-03-18 09:28:40 +00:00
Suhas Daftuar
0710b303d6 Test versionbits deployments 2016-03-18 09:14:53 +00:00
Suhas Daftuar
8ebc6f2aac Add testing of ComputeBlockVersion 2016-03-18 09:14:53 +00:00
Pieter Wuille
0bdaacd791 Softfork status report in RPC 2016-03-18 09:14:52 +00:00
Pieter Wuille
5f90d4e294 Versionbits tests 2016-03-18 09:14:52 +00:00
Pieter Wuille
6f83cf2adb BIP9 Implementation
Inspired by former implementations by Eric Lombrozo and Rusty Russell, and
based on code by Jorge Timon.
2016-03-18 09:14:52 +00:00
Alex Morcos
ade85e126d Add LockPoints
Obtain LockPoints to store in CTxMemPoolEntry and during a reorg, evaluate whether they are still valid and if not, recalculate them.
2016-03-18 09:14:52 +00:00
BtcDrak
c8d309e4b4 Code style fix.
This if statement is a little obtuse and using braces here
improves readability.
2016-03-18 09:14:52 +00:00
BtcDrak
6170506fdf Separate CheckLockTime() and CheckSequence() logic
For the sake of a little repetition, make code more readable.
2016-03-18 09:14:52 +00:00
Mark Friedenbach
c0c5e09fe2 BIP112: Implement CHECKSEQUENCEVERIFY
- Replace NOP3 with CHECKSEQUENCEVERIFY (BIP112)
  <nSequence> CHECKSEQUENCEVERIFY -> <nSequence>
- Fails if txin.nSequence < nSequence, allowing funds of a txout to be locked for a number of blocks or a duration of time after its inclusion in a block.
- Pull most of CheckLockTime() out into VerifyLockTime(), a local function that will be reused for CheckSequence()
- Add bitwise AND operator to CScriptNum
- Enable CHECKSEQUENCEVERIFY as a standard script verify flag
- Transactions that fail CSV verification will be rejected from the mempool, making it easy to test the feature. However blocks containing "invalid" CSV-using transactions will still be accepted; this is *not* the soft-fork required to actually enable CSV for production use.
2016-03-18 09:14:52 +00:00
Alex Morcos
197c3760ff fix sdaftuar's nits again
it boggles the mind why these nits can't be delivered on a more timely basis
2016-03-18 09:14:52 +00:00
Alex Morcos
15ba08c3b5 Implement SequenceLocks functions
SequenceLocks functions are used to evaluate sequence lock times or heights per BIP 68.

The majority of this code is copied from maaku in #6312
Further credit: btcdrak, sipa, NicolasDorier
2016-03-18 09:14:52 +00:00
UdjinM6
be9e2f1d4f Fix GetHash() for CMasternodeBroadcast 2016-03-18 03:38:00 +03:00
UdjinM6
54096c30ec Allow user to use 2 modes for masternodebroadcast:
- safe - process mnb as if it was received via network
 - fast - skip most checks and relay
2016-03-18 02:37:48 +03:00
UdjinM6
c96284a787 Refactor masternodebroadcast to serialize/decode/relay multiple masternodes at once 2016-03-17 20:39:17 +03:00
Luv Khemani
4ce2b0214b Add autocomplete to bitcoin-qt's console window.
Removed externs
Added listCommands() to CRPCTable

Move autocomplete init to RPCConsole::setClientModel()

Closes #742
2016-03-17 08:39:05 +01:00
UdjinM6
eaf57b3fb7 Implemented masternodebroadcast
This set of rpc commands provide an ability to create masternode broadcast messages offline
and relay them from online node later (messages expire in ~1 hour).

Arguments:
1. command        (string or set of strings, required) The command to execute
2. passphrase     (string, optional) The wallet passphrase
Available commands:
  create-alias  - Create single remote masternode broadcast message by assigned alias configured in masternode.conf
  create-all    - Create remote masternode broadcast messages for all masternodes configured in masternode.conf
  decode        - Decode masternode broadcast message
  relay         - Relay masternode broadcast message to the network

Closes #741
2016-03-17 08:29:53 +01:00
UdjinM6
f39bc3b3cb Bump DEFAULT_TRANSACTION_MAXFEE
Should be smth like "smallest DS denomination (0.10000100)" + X * "denom tails"
to avoid triggering "absurd fee" error.
I think that 0.2 i.e. having 100 of 100s "tails" (or 1000 of 10s etc) should be enough.

Closes #737
2016-03-16 07:52:37 +01:00
UdjinM6
6f301d9a63 Fix unlock for sending txes from qt dialog
Closes #736
2016-03-16 07:51:17 +01:00
UdjinM6
4249b28230 Throw a bit more specific rpcerrors (error codes should be more granular/meaningful now), add missing fields, unify naming
Closes #735
2016-03-16 07:50:50 +01:00
UdjinM6
d406324573 Add options for getchaintips 2016-03-16 07:50:06 +01:00
UdjinM6
38f386ae1c Few small changes: - Better log output (a bit more granular for mnb, fixing "\n"s and few other small issues) - Unify variable/class members naming a bit
Closes #733
2016-03-16 07:48:37 +01:00
UdjinM6
2fc05e5b9d Add ability to change debug category on the fly from console
NOTE: Before switching to another debug catgory you'd need to turn debugging off via "debug 0"
      and wait a bit (each thread (de)activates debug mode on its own)
2016-03-16 07:46:35 +01:00
UdjinM6
a7fd7821e9 Add "-logthreadnames" cmd-line option to add thread names to debug messages 2016-03-16 07:46:29 +01:00
UdjinM6
e0c4dd0129 Fix crash in CheckAndRemove
Closes #732
2016-03-14 14:27:20 +01:00
UdjinM6
c872091296 Fix NetMsgType::DSCOMPLETE usage
Closes #731
2016-03-14 11:39:25 +01:00
MarcoFalke
f04f4fd2ee
[doc/log] Fix markdown syntax and line terminate LogPrint
- Fix doxygen comment for payTxFee
- [doc] Fix markdown
- Make sure LogPrintf strings are line-terminated

Github-Pull: #7617
Rebased-From: fa06ce0949 fa97f95c15 fa26652459
2016-03-11 09:44:17 +01:00
UdjinM6
5d42a372cf Fix CBudgetProposal::GetRemainingPaymentCount()
Closes #729
2016-03-09 07:23:20 +01:00
UdjinM6
04efdd1150 Fix mn sync: - reset lasttime* right before switching to next asset - adjust target block count by 1.2 coeff - lower MASTERNODE_SYNC_TIMEOUT 120 -> 30
Closes #728
2016-03-09 07:22:54 +01:00
UdjinM6
eeb4e9c11a Always clean ds queue
Closes #727
2016-03-09 07:22:17 +01:00
UdjinM6
1b41f851bf Fix CBudgetManager::CheckAndRemove() endless loop
Closes #726
2016-03-09 07:21:56 +01:00
UdjinM6
618c27a99d RPC changes
- add filter to `masternode winners`
- allow `masternode debug` right after blockchain is synced
- fix `masternode current`
- fix getpoolinfo, add ds queue size to output

Closes #725
2016-03-09 07:21:21 +01:00
TheLazieR Yip
d401d64281 Clean duplicated params setting for test network.
Closes #724
2016-03-09 07:18:59 +01:00
UdjinM6
9d151c25dd Use chainActive.Tip() in FillBlockPayee functions Turned out that pCurrentBlockIndex is an overkill here, we should just make sure that cs_main lock is already held for us.
Closes #723
2016-03-07 12:19:53 +01:00
UdjinM6
cadfa233a0 remove stdout debug spam 2016-03-07 12:18:48 +01:00
UdjinM6
6f5a9c10fc fix src/test/data 2016-03-07 12:18:47 +01:00
TheLazieR Yip
8675ce1929 Check New MasterNodeBroadcast Time
Closes #722
2016-03-07 12:00:29 +01:00
UdjinM6
18afe88401 Check vote time internally
Closes #721
2016-03-06 18:23:26 +01:00
UdjinM6
8e560080a1 Fix comments, remove ._str() from LogPrintfs, few trivial changes 2016-03-06 18:21:06 +01:00
UdjinM6
b682fcb8d6 Fix GetBlockSubsidy for regtest, bump regtest settings
Closes #719
2016-03-06 18:15:33 +01:00
UdjinM6
3cf048d01c Fix initial call of UpdatedBlockTip
Closes #718
2016-03-06 18:15:08 +01:00
UdjinM6
af1c321d16 Fix block reward verification
Closes #717
2016-03-06 18:14:42 +01:00
UdjinM6
4474de8573 Fix nChangePosRet in CreateTransaction
Closes #716
2016-03-06 18:14:16 +01:00
UdjinM6
c40fccce9a Only allow block to pass as a budget superblock if it came at or after Params().GetConsensus().nBudgetPaymentsStartBlock
Closes #715
2016-03-06 18:13:48 +01:00
evan82
b0064145db Merge pull request #701 from UdjinM6/logoIcon
Make Dash logo (app icon) theme-independent
2016-03-04 07:16:38 -07:00
evan82
3d4c56c19e Merge pull request #714 from UdjinM6/btcdash_
more bitcoin -> dash
2016-03-04 07:14:06 -07:00
UdjinM6
e8df74a18e fix miner_tests
(only in part related to this commit, for most miner_tests fixes see 124178b)
2016-03-04 12:10:37 +03:00
UdjinM6
a611fc3b1b Introduce CDSNotificationInterface - validation interface to listen to tip updates and trigger updates in DS, payments and budgets. Should significantly reduce number of references to chainActive.Tip() i.e.we should have less cs_main in dash-darksend thread and potential deadlocks. 2016-03-04 12:10:37 +03:00
UdjinM6
67cd10c87d Add some locks to protect chainActive.Tip() and mapBlockIndex
(fixing only few of them here, see next commit for further changes)
2016-03-04 12:10:37 +03:00
UdjinM6
95dab0b541 Remove unnecessary locks and chainActive.Tip() references 2016-03-04 12:10:37 +03:00
UdjinM6
b3d1140800 more bitcoin->dash 2016-03-04 12:09:03 +03:00
UdjinM6
3ad675aadb Fix tests
Closes #711
2016-03-04 06:52:57 +01:00
Evan Duffield
9a52925d5c fixed messages 2016-03-03 07:00:34 -07:00
UdjinM6
459472357f connections icon click was not working
Closes #709
2016-03-02 12:57:45 +01:00
UdjinM6
581312ff90 Fix default fees
Closes #708
2016-03-02 12:56:19 +01:00
UdjinM6
8cb8772d95 bitcoin -> dash 2016-03-02 12:55:37 +01:00
UdjinM6
3736403985 Make sure there is only one instance of dash-darksend thread
Closes #707
2016-03-02 12:55:27 +01:00
UdjinM6
5c2a0cc9ec Fix bug that prevented new blocks to update tip during mixing
Closes #706
2016-03-02 12:54:46 +01:00
UdjinM6
c8ba8a1be5 fix testnet quickfix (or "one does not simply replace a bunch of divisions" because there is rounding at each step)
Closes #702
2016-02-27 09:29:38 +01:00
UdjinM6
eed3a48150 Make Dash logo (app icon) theme-independent 2016-02-25 07:14:08 +03:00
TheLazieR Yip
4fce2910b4 Fix icons/bitcoin.ico not found. 2016-02-24 13:14:08 +07:00
Holger Schinzel
296373b108 fix test suite 2016-02-23 11:10:41 +01:00
Holger Schinzel
b5165fcfb6 passing -fPIC flag to crypto_lib 2016-02-23 06:55:37 +01:00
Holger Schinzel
8b824323e7 passing -fPIC flag to crypto_lib 2016-02-23 05:10:33 +01:00
Holger Schinzel
3d95db8b7c fixing Makefile.test.include
... Bitcoin 0.12 merging bug
2016-02-23 04:27:38 +01:00
UdjinM6
7fe88c24f9 clean fixed TODOs 2016-02-21 04:22:11 +03:00
UdjinM6
6ec64f8ff6 Merge remote-tracking branch 'bitcoin/0.12' into mergebtc0.12 2016-02-21 04:09:11 +03:00
UdjinM6
045877b93c fix crash 2016-02-20 22:03:19 +03:00
UdjinM6
29b1af2bb1 quick fix for testnet - we reeeeally should restart it one day.. 2016-02-19 21:11:44 +03:00
UdjinM6
b654a6a320 refactor sync progress ui to use signals, remove lock from masternode str ui 2016-02-19 21:09:54 +03:00
UdjinM6
06b6dce132 fix typo in GetNextWorkRequired 2016-02-19 21:08:30 +03:00
UdjinM6
f50d534440 fix nMaxTipAge 2016-02-19 07:59:22 +03:00
UdjinM6
c676748beb Replace all hardcoded network message strings with NetMsgType:: constants, log unknown commands (net debug category only) 2016-02-19 07:59:00 +03:00
UdjinM6
e8d9aabb62 Move many hardcoded mainnet/testnet magic numbers to consensus part of chainparams,
get rid of most `if(Params().NetworkIDString() == CBaseChainParams::MAIN)` and alike to unify formulas.
Further improvements will require testnet restart (see TODO notes in changed code) so I'm keeping few things as they are till then.
2016-02-17 21:54:24 +03:00
UdjinM6
8ad088ab75 Add few more debug messages for masternode category 2016-02-17 21:53:55 +03:00
UdjinM6
6fc9b4c772 Replace hardcoded 9999 with Params(CBaseChainParams::MAIN).GetDefaultPort() 2016-02-17 21:52:37 +03:00
UdjinM6
a4aef837bd Merge remote-tracking branch 'origin/v0.12.1.x' into mergebtc0.12 + fix 2016-02-16 03:17:25 +03:00
UdjinM6
fcad1c26ec fix peers subversion column width 2016-02-15 22:04:21 +03:00
UdjinM6
0d387900c5 Refactor tools menu signals/slots, add more shortcuts 2016-02-15 22:02:55 +03:00
UdjinM6
fd747bae01 Added note about GetBlockSubsidy using previous height, changed var names accordingly 2016-02-15 17:01:16 +03:00
UdjinM6
8092c84694 fix consensus.nSubsidyHalvingInterval (210000 -> 210240) and ConnectBlock 2016-02-15 16:40:35 +03:00
crowning-
1f70fb3c04 Fix crash in validateaddress with -disablewallet
Closes #696
2016-02-15 14:13:02 +01:00
crowning-
cfc8cc2fe5 dseg shouldn't be send for local addresses
Closes #695
2016-02-15 14:06:47 +01:00
Joseph Pentland
7a0354bb17 txmempool: Fix comparison between signed/unsigned int
Comparison between signed/unsigned int found in removeCoinbaseSpends

This commit is based on commit e617fe25 by Luke Dashjr in bitcoin.

Fixes: Dashpay github issue 540

Closes #694
2016-02-15 14:01:06 +01:00
UdjinM6
ad5da28cd8 UI fixes:
- fix icons in tx list
- fix about/cmd-line help dialog
- get rid of the warning icon (use old text label instead)
2016-02-15 09:03:14 +03:00
UdjinM6
0495d45ac1 update overview screen ds rounds/amount/progress when settings changed
(we were already sending signals but connectors in overview screen were missing)
2016-02-15 03:43:06 +03:00
UdjinM6
bff701f420 fix settings 2016-02-15 03:08:48 +03:00
UdjinM6
0e55aeb538 fix CreateTransaction (bip69 related)
add mempool debug msg in case AcceptToMemoryPool fails
2016-02-15 00:03:55 +03:00
UdjinM6
83813caafd Cleanup 2016-02-15 00:01:44 +03:00
Wladimir J. van der Laan
68134263e2
qt: Translation update pre-rc5 2016-02-10 21:18:33 +01:00
instagibbs
c3faf78c0e
Changed getnetworkhps value to double to avoid overflow.
Github-Pull; #7480
Rebased-From: 993d089e82
2016-02-10 20:45:42 +01:00
Matt
9cb31e664a
Fix spelling: misbeha{b,v}ing
Github-Pull: #7469
Rebased-From: 0830552673
2016-02-10 20:38:10 +01:00
Pieter Wuille
889e5b3050
Correctly report high-S violations
Github-Pull: #7500
Rebased-From: 9d95187d5d
2016-02-10 20:32:42 +01:00
Pieter Wuille
1329963001
Update the wallet best block marker when pruning
Github-Pull: #7502
Rebased-From: e4eebb604e
2016-02-10 19:59:01 +01:00
Wladimir J. van der Laan
00ec73e062
wallet: Ignore MarkConflict if block hash is not known
If number of conflict confirms cannot be determined, this means
that the block is still unknown or not yet part of the main chain,
for example during a reindex. Do nothing in that case,
instead of crash with an assertion.

Fixes #7234.

Github-Pull: #7491
Rebased-From: 40e7b61835
2016-02-10 19:58:19 +01:00
Wladimir J. van der Laan
827a2b6736
qt: Translations update pre-rc4 2016-02-09 10:53:13 +01:00
Suhas Daftuar
e16f5b40c2
Update nQueuedValidatedHeaders after peer disconnection
Github-Pull: #7482
Rebased-From: 301bc7bc7e
2016-02-09 08:55:03 +01:00
Wladimir J. van der Laan
b2f2b85ad5
rpc: Add WWW-Authenticate header to 401 response
A WWW-Authenticate header must be present in the 401
response to make clients know that they can authenticate,
and how.

    WWW-Authenticate: Basic realm="jsonrpc"

Fixes #7462.

Github-Pull: #7472
Rebased-From: 7c06fbd8f5
2016-02-09 08:52:33 +01:00
UdjinM6
832e7505dd Merge remote-tracking branch 'bitcoin/0.12' into mergebtc0.12
+ fix AcceptToMemoryPool fDryRun for mnb
2016-02-06 18:53:20 +03:00
UdjinM6
a5ac60b868 Merge remote-tracking branch 'bitcoin/0.12' into HEAD
+ merge fixes
+ keepass on evhttp
2016-02-06 16:48:04 +03:00
Evan Duffield
8628cb7992 removed printf debugging for syncing process 2016-02-04 15:54:35 -07:00
Evan Duffield
65e480fc62 Syncing is working quite nice :) 2016-02-04 15:48:23 -07:00
Evan Duffield
83f87b0f2d merged 2016-02-04 12:39:53 -07:00
Evan Duffield
eeb53b9682 Vastly faster syncing process / small budget system changes
- Syncing process is now event based, rather than timeout based. This means the system can tell when it's done with each step and moves on between phases much faster. In initial testing it seems to be about 10-15x faster and has synced everytime successfully.
- Please remove print debugging when the syncing system is proven to be debugged.
2016-02-04 12:29:09 -07:00
Wladimir J. van der Laan
b1f031d435
qt: translations update pre-rc3 2016-02-03 10:59:04 +01:00
MarcoFalke
294f4320a2
[qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH
Github-Pull: #7384
Rebased-From: faa9011d09
2016-02-03 10:31:34 +01:00
Wladimir J. van der Laan
c76bfff11e
Merge #7440: [0.12] Rename permitrbf to mempoolreplacement and provide minimal string-list forward compatibility
af9f564 release-notes: Update for replacebyfee->mempoolreplacement rename (Luke Dashjr)
4ad418b Rename replacebyfee=opt-in to mempoolreplacement=fee (Luke Dashjr)
b2287a7 release-notes: Update for permitrbf->replacebyfee rename (Luke Dashjr)
5f456a6 Simplify check for replacebyfee=opt-in (Luke Dashjr)
e8d19ab Accept replacebyfee=opt-in for turning on opt-in RBF (Luke Dashjr)
1205f87 Rename permitrbf to replacebyfee (Luke Dashjr)
2016-02-03 10:30:10 +01:00
Luke Dashjr
4ad418bc9b Rename replacebyfee=opt-in to mempoolreplacement=fee 2016-02-01 19:31:36 +00:00
UdjinM6
eb76f789f5 rpc changes:
- support ix and ds from cmd-line for sendtoaddress and sendmany
 - darksend cmd only controls process of mixing now (can't send funds anymore)

Closes #692
2016-02-01 19:49:42 +01:00
Gregory Maxwell
86755bc85a
Add whitelistforcerelay to control forced relaying. [#7099 redux]
- Add whitelistforcerelay to control forced relaying.

Also renames whitelistalwaysrelay.

Nodes relay all transactions from whitelisted peers, this
 gets in the way of some useful reasons for whitelisting
 peers-- for example, bypassing bandwidth limitations.

The purpose of this forced relaying is for specialized gateway
 applications where a node is being used as a P2P connection
 filter and multiplexer, but where you don't want it getting
 in the way of (re-)broadcast.

This change makes it configurable with whitelistforcerelay.

- Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay.

Github-Pull: #7439
Rebased-From: 325c725fb6 89d113e02a
2016-02-01 14:15:40 +01:00
UdjinM6
bbbbdd8100 more darkcoin->dash
Closes #690
2016-02-01 10:31:06 +01:00
UdjinM6
826cba78a5 more dashpay.io->dash.org
Closes #689
2016-02-01 10:30:23 +01:00
crowning-
c0ec48a51a [walletdb] Fix syntax error in key parser
Closes #691
2016-02-01 10:24:04 +01:00
Evan Duffield
0b02b56672 Vote-alias draft
- other mnbudget commands need casting from str to int
2016-01-31 17:44:18 -07:00
UdjinM6
e2aaf09700 Cleanup
- lower unobvious dependency through header files, move few includes to the right places
- some trivial code cleanup

Closes #680
2016-01-31 12:08:45 +01:00
UdjinM6
8143059f41 liquidity provider should always use queue
Closes #681
2016-01-31 11:56:44 +01:00
crowning-
255172e552 UI: URL in splash-screen changed
Closes #682
2016-01-31 11:53:30 +01:00
UdjinM6
93279e7944 expose fPrintToDebugLog to cmd-line as -printtodebuglog option
Closes #679
2016-01-31 11:48:37 +01:00
CryptoVote
3f4d5c4c7d Updates monetary variable int64_t types to CAmount.
Closes #677
2016-01-31 11:34:57 +01:00
Holger Schinzel
42121955b6 Merge pull request #684 from crowning-/patch-2
Change copyright from 2015 to 2016
2016-01-30 19:03:10 +01:00
Holger Schinzel
c1beae6866 Merge pull request #686 from dashpay/fix_tests
fix test suite
2016-01-29 23:49:44 +01:00
Holger Schinzel
66ce5f1d60 fix test suite 2016-01-29 23:35:23 +01:00
Evan Duffield
a6fbbe59eb Budget system improvements
- Remove old proposals from memory entirely
- Renamed Yea,Nay to Yes,No
- Show absolute yes count
- Fixed bug with nBlockEnd (incompatible with v12 now)
- Flag proposals that are downvoted
2016-01-29 13:41:04 -07:00
Luke Dashjr
5f456a6546 Simplify check for replacebyfee=opt-in 2016-01-29 01:31:55 +00:00
Luke Dashjr
e8d19ab79f Accept replacebyfee=opt-in for turning on opt-in RBF
Basic forward-compatibility with more flexible parameters like fss
2016-01-29 01:31:52 +00:00
Luke Dashjr
1205f87d36 Rename permitrbf to replacebyfee
"permit" is currently used to configure transaction filtering, whereas replacement is more to do with the memory pool state than the transaction itself.
2016-01-29 01:31:33 +00:00
Gregory Maxwell
8e09f914f8 Decide eviction group ties based on time.
This corrects a bug the case of tying group size where the code may
 fail to select the group with the newest member. Since newest time
 is the final selection criteria, failing to break ties on it
 on the step before can undermine the final selection.

Tied netgroups are very common.
2016-01-28 22:46:06 +00:00
Gregory Maxwell
46dbcd4833 Do not absolutely protect local peers from eviction.
With automatic tor HS support in place we should probably not be providing
 absolute protection for local peers, since HS inbound could be used to
 attack pretty easily.  Instead, this counts on the latency metric inside
 AttemptToEvictConnection to privilege actually local peers.
2016-01-28 22:45:22 +00:00
crowning-
af2a26ca54 Change copyright from 2015 to 2016 2016-01-28 23:31:50 +01:00
Evan Duffield
78ebf10ea2 added nextsuperblocksize command 2016-01-28 12:33:27 -07:00
Wladimir J. van der Laan
cb83beb375
net: Hardcoded seeds update January 2016
Github-Pull: #7415
Rebased-From: 4818dba900
2016-01-28 10:55:11 +01:00
Holger Schinzel
5da767b9eb fix more tests 2016-01-28 04:07:15 -05:00
Holger Schinzel
a0c77e007e fixed Checkpoints_tests.cpp 2016-01-27 06:55:54 -05:00
Holger Schinzel
4833ac71cf fix rpc_tests.cpp 2016-01-27 12:25:16 +01:00
Cory Fields
aa26ee0101
release: Add security/export checks to gitian and fix current failures
- fix parsing of BIND_NOW with older readelf
- add _IO_stdin_used to ignored exports

For details see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=634261#109

- add check-symbols and check-security make targets

These are not added to the default checks because some of them depend on
release-build configs.

- always link librt for glibc back-compat builds

glibc absorbed clock_gettime in 2.17. librt (its previous location) is safe to
link in anyway for back-compat.

Fixes #7420

- add security/symbol checks to gitian

Github-Pull: #7424
Rebased-From: cd27bf51e0 475813ba5b f3d3eaf78e a8ce872118 a81c87fafc
2016-01-27 11:33:33 +01:00
Holger Schinzel
40175f440a Merge pull request #683 from dashpay/fix_alerts_test
fix alerts test
2016-01-26 17:28:14 +01:00
Holger Schinzel
f07230c060 fix alerts test 2016-01-26 10:57:06 -05:00
Holger Schinzel
c8c855ec89 Merge pull request #678 from nmarley/dry-opcode-limit
DRY max opcodes per script
2016-01-24 12:24:33 +01:00
Nathan Marley
ed4d606722 DRY max opcodes per script
Currently hard-coded, this just reduces redunduncy and could prevent
future errors if the value ever changes.
2016-01-24 19:05:46 +08:00
Holger Schinzel
69867faca7 Merge pull request #676 from UdjinM6/unknMasternode
Move some messages to mnbudget debug category
2016-01-24 10:04:44 +01:00
UdjinM6
0c19fb5e90 move some messages to mnbudget debug category 2016-01-23 21:30:53 +03:00
Holger Schinzel
cc0fc399a4 Merge branch 'v0.12.0.x' into v0.12.1.x 2016-01-23 11:21:35 +01:00
Holger Schinzel
274145f1a7 checkpoint 2016-01-22 13:42:22 +01:00
Wladimir J. van der Laan
5df314b927
qt: pre-rc2 translations update 2016-01-22 11:43:19 +01:00
Wladimir J. van der Laan
b16b5bc191
Merge #7371: [0.12] backports
236686b [init] Add missing help for args (MarcoFalke)
44438a1 [init] Fix error message of maxtxfee invalid amount (MarcoFalke)
a74fa1f [Wallet] Transaction View: LastMonth calculation fixed (crowning-)
2016-01-22 11:41:04 +01:00
Wladimir J. van der Laan
f4b2ce8ee8
Merge #7387: Get rid of inaccurate ScriptSigArgsExpected
52b29dc Get rid of inaccurate ScriptSigArgsExpected (Pieter Wuille)
2016-01-22 11:39:58 +01:00
MarcoFalke
7726c487f8
[qt] Windows: Make rpcconsole monospace font larger
Github-Pull: #7364
Rebased-From: fa6a59dd39
2016-01-22 11:21:33 +01:00
Pieter Wuille
52b29dca76 Get rid of inaccurate ScriptSigArgsExpected 2016-01-21 13:52:32 +01:00
Wladimir J. van der Laan
da83ecd454
Add option -permitrbf to set transaction replacement policy
Add a configuration option `-permitrbf` to set transaction replacement policy
for the mempool.

Enabling it will enable (opt-in) RBF, disabling it will refuse all
conflicting transactions.

Conflicts:
	src/init.cpp
	src/main.cpp
	src/main.h

Github-Pull: #7386
Rebased-From: b768108d9c
2016-01-21 12:38:52 +01:00
Suhas Daftuar
e25b158ab8
RPC: indicate which transactions are replaceable
Add "bip125-replaceable" output field to listtransactions and gettransaction
which indicates if an unconfirmed transaction, or any unconfirmed parent, is
signaling opt-in RBF according to BIP 125.

Github-Pull: #7286
Rebased-From: eaa8d2754b
2016-01-20 13:50:58 +01:00
MarcoFalke
621bbd88ba
[walletdb] Fix syntax error in key parser
Github-Pull: #7381
Rebased-From: fa6d4cc095
2016-01-20 13:08:40 +01:00
MarcoFalke
236686b844 [init] Add missing help for args
Github-Pull: #7290
Rebased-From: fa6ab96799 faa572a329 fa461df685
2016-01-18 14:24:07 +01:00
MarcoFalke
44438a192a [init] Fix error message of maxtxfee invalid amount
Github-Pull: #7290
Rebased-From: fac11ea310
2016-01-18 14:18:49 +01:00
crowning-
a74fa1f06b [Wallet] Transaction View: LastMonth calculation fixed
Github-Pull: #7327
Rebased-From: 30cdacea3c
2016-01-18 14:14:31 +01:00
James O'Beirne
351ffd8482
Fix help, add RPC tests for getblockheader
- Add assert_is_hex_string and assert_is_hash_string to RPC test utils.
- Add RPC documentation for getblockheader[chainwork].
- Add RPC tests for getblockheader.

Github-Pull: #7194
Rebased-From: 16d4fce0b2 4745636126 135d6ec8ce
2016-01-18 12:25:50 +01:00
Gregory Sanders
c0d2382170
Added help text for chainwork value
Github-Pull: #7232
Rebased-From: 94bdd71f9b
2016-01-18 12:20:42 +01:00
Wladimir J. van der Laan
1709cc5cb0
Merge pull request #7338
f17b00b release-notes: Combine NOP2->CLTV asm change into "RPC: Low-level API changes" section (Luke Dashjr)
e20704b Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)
6f8346d qt5: Use the fixed font the system recommends (MarcoFalke)
605de4a Rename OP_NOP2 to OP_CHECKLOCKTIMEVERIFY. (mb300sd)
6191a9b [RPC-Tests] add option to run rpc test over QT clients (Jonas Schnelli)
6307beb Note that reviewers should mention the commit hash of the commits they reviewed. (Patrick Strateman)
6092ff2 Set link from http:// to https:// (Suriyaa Kudo)
2016-01-18 10:36:57 +01:00
Prayag Verma
098fcb5694
Update license year range to 2016
Conflicts:
	configure.ac

Github-Pull: #7363
Rebased-From: bd34174ebc
2016-01-18 10:31:30 +01:00
Veres Lajos
7710411e88 PARTIAL: typofixes (found by misspell_fixer)
Upstream: 9f68ed6b6d (PR #6539)
2016-01-16 17:04:08 +01:00
Cory Fields
a6b8f023d3 net: Set SO_REUSEADDR for Windows too
When running the rpc tests in Wine, nodes often fail to listen on localhost
due to a stale socket from a previous run. This aligns the behavior with other
platforms.
2016-01-16 17:04:06 +01:00
Alex Morcos
372dd395ce add unit test for CNetAddr::GetGroup. 2016-01-16 17:04:05 +01:00
Alex Morcos
857625aa5d Fix masking of irrelevant bits in address groups. 2016-01-16 17:04:04 +01:00
Adam Weiss
8c8d13660b Handle leveldb::DestroyDB() errors on wipe failure
Add error checking to CLevelDBWrapper for errors from
leveldb::DestroyDB().  Without it, if unlink() or DeleteFileW() fail to
delete files, they will fail silent.  If they fail to delete any files,
CLevelDBWrapper will silently open and read the existing database.

Typically any permissions issues would be caught by leveldb as it churns
through many files as part of its compaction process, but it is
conceivable that this could cause problems on Windows with anti-virus
and indexing software.
2016-01-16 17:04:03 +01:00
Casey Rodarmor
1425e2463c Use unique name for AlertNotify tempfile 2016-01-16 17:04:03 +01:00
J Ross Nicoll
1fedc75fde Make sure LogPrint strings are line-terminated 2016-01-16 17:04:02 +01:00
Casey Rodarmor
6010b5e7a0 Avoid leaking file descriptors in RegisterLoad
This is pretty trivial, but if there's an error here we'll leak a file
descriptor. Changed it to always close the file.
2016-01-16 17:04:01 +01:00
crowning-
1e59cf0ceb Transaction View: LastMonth calculation fixed 2016-01-16 13:58:33 +01:00
Holger Schinzel
a2c143f44e typo in translation config 2016-01-16 12:06:09 +01:00
fanquake
e20704ba71 Replace some instances of formatWithUnit with formatHtmlWithUnit
Strings in a HTML context should be using formatHtmlWithUnit.

Github-Pull: #7255
Rebased-From: 5fdf32de7e
2016-01-13 21:25:36 +00:00
MarcoFalke
6f8346db5f qt5: Use the fixed font the system recommends
Github-Pull: #7214
Rebased-From: fa2f4bc4eb
2016-01-13 21:25:36 +00:00
mb300sd
605de4a88a Rename OP_NOP2 to OP_CHECKLOCKTIMEVERIFY.
Github-Pull: #7213
Rebased-From: 37d271d7cc
2016-01-13 21:25:36 +00:00
Jonas Schnelli
a06a8b4888 add InMempool() function 2016-01-13 11:28:28 -05:00
Wladimir J. van der Laan
2a3161bf8b
Merge pull request #7332 2016-01-13 16:02:12 +01:00
Wladimir J. van der Laan
afe825f075
Update translations pre-rc1 2016-01-13 15:58:59 +01:00
Alex Morcos
fd4bd5009e
Add RPC call abandontransaction
- Make wallet descendant searching more efficient
- Add new rpc call: abandontransaction

Unconfirmed transactions that are not in your mempool either due to eviction or other means may be unlikely to be mined.  abandontransaction gives the wallet a way to no longer consider as spent the coins that are inputs to such a transaction.  All dependent transactions in the wallet will also be marked as abandoned.

- Add RPC test for abandoned and conflicted transactions.
- [Wallet] Call notification signal when a transaction is abandoned

Github-Pull: #7312
Rebased-From: 9e69717254 01e06d1fa3 df0e2226d9 d11fc1695c
2016-01-13 15:55:00 +01:00
MarcoFalke
faf671bca6 [wallet] Clarify rpc help message with regard to rounding 2016-01-13 12:06:24 +01:00
Alex Morcos
a36d79bfe2
Add sane fallback for fee estimation
- Always respect GetRequiredFee for wallet txs
- Add sane fallback for fee estimation
- SQUASHME: Fix rpc tests that assumed fallback to minRelayTxFee

Add new commandline option "-fallbackfee" to use when fee estimation does not have sufficient data.

Github-Pull: #7296
Rebased-From: 995b9f3 e420a1b bebe58b
2016-01-13 11:06:17 +01:00
crowning-
af4bc47a9b Transaction View: LastMonth calculation fixed 2016-01-11 21:49:42 +01:00
Amir
2491e2af3e Print hash in CMutableTransaction::ToString
Keep in line with CTransaction::ToString. Truncates the hash at 10.
2016-01-10 07:15:11 +01:00
Amir
338f106fe3 Removed Calculate() class methods. Not used.
Both Calculate methods are not implemented in masternode-budget.cpp and not used elsewhere in the code.
2016-01-10 07:12:03 +01:00
crowning-
acd952d18f UI: new wallet theme "DASH-light" (file permissions restored) 2016-01-09 23:25:07 +01:00
crowning-
ee2c595291 UI: new wallet theme "DASH-light" 2016-01-09 23:19:08 +01:00
Luke Dashjr
5b144b7113 Merge branch bytespersigop 2016-01-09 17:02:35 +00:00
Alex Morcos
4707797df2
Make sure conflicted wallet tx's update balances
Github-Pull: #7306
Rebased-From: f61766b37b
2016-01-08 17:38:04 +01:00
Wladimir J. van der Laan
9265e89a77
Merge pull request #7318
daa8da2 Backport: quickfix for RPC timer interface problem (Jonas Schnelli)
2016-01-08 17:33:59 +01:00
MarcoFalke
b1a8374aaa
[qt] Intro: Display required space
Required space depends on the user's choice:
 -prune=0
 -prune=<n>
2016-01-08 11:22:08 +01:00
Jonas Schnelli
daa8da281b
Backport: quickfix for RPC timer interface problem 2016-01-08 11:09:34 +01:00
MarcoFalke
ff9b610026
[wallet] Add regression test for vValue sort order
- [wallet] Add regression test for vValue sort order
- [trivial] Merge test cases and replace CENT with COIN

Github-Pull: #7293
Rebased-From: fa3c7e644f faf538bfdb
2016-01-07 09:25:57 +01:00
MarcoFalke
1ed938b5fe
[qa] wallet: Check if maintenance changes the balance
- [qa] Cleanup wallet.py test
- [qa] check if wallet or blochchain maintenance changes the balance
- [walletdb] Add missing LOCK() in Recover() for dummyWallet

Github-Pull: #7229
Rebased-From: fa0765d433 fa14d99484 fa33d9740c
2016-01-07 09:19:25 +01:00
evan82
eafba13a2e Merge pull request #657 from thelazier/v0.12.1.x_miniupnpc
Bump miniupnpc version to 1.9.20151026
2016-01-05 10:41:18 -07:00
evan82
54deb1e75b Merge pull request #650 from dashpay/v0.12.0.x
merge missing commits from V0.12.0.x
2016-01-05 10:39:39 -07:00