Wladimir J. van der Laan
cdae53e456
Merge pull request #5852
...
51598b2
2015-03-09 12:51:07 +01:00
Wladimir J. van der Laan
c1b723c30a
Merge pull request #5442
...
dca799e
2015-03-09 12:24:53 +01:00
Philip Kaufmann
8517e9709e
[Qt] rework setNumBlocks to have blockDate as parameter
...
- reduces some functional overhead and simplifies the code
2015-03-09 10:58:17 +01:00
Wladimir J. van der Laan
513e025239
Merge pull request #5858
...
9bbb880
2015-03-09 10:45:12 +01:00
Wladimir J. van der Laan
d26f0b263c
Merge pull request #5793
...
6cb4a529673c35
2015-03-09 09:55:49 +01:00
Pieter Wuille
2f10aa0fa1
Merge pull request #5151
...
eec3713
2015-03-07 05:38:34 -08:00
Wladimir J. van der Laan
a0ae79d775
Replace CBlockHeader::GetHash with call to SerializeHash
...
Removes variability between LE and BE.
As suggested by @sipa.
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
62b30f09ac
Add serialize float/double tests
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
9f4fac98c4
src/txmempool.cpp: make numEntries a uint32_t
...
Don't ever serialize a size_t or long, their sizes are platform
dependent.
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
f4e6487219
src/arith_256.cpp: bigendian compatibility
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
aac3205375
src/netbase.h: Fix endian in CNetAddr serialization
...
We've chosen to htons/ntohs explicitly on reading and writing
(I do not know why). But as READWRITE already does an endian swap
on big endian, this means the port number gets switched around,
which was what we were trying to avoid in the first place. So
to make this compatible, serialize it as FLATDATA.
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
01f9c3449a
src/serialize.h: base serialization level endianness neutrality
...
Serialization type-safety and endianness compatibility.
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
4e853aa163
src/script/script.h: endian compatibility for PUSHDATA sizes
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
4f92773f92
src/primitives/transaction.h: endian compatibility in serialization
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
81aeb28436
src/primitives/block.cpp: endian compatibility in GetHash
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
dec84cae2a
src/net.cpp: endian compatibility in EndMessage
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
556814ec4e
src/main.cpp: endian compatibility in packet checksum check
2015-03-06 17:21:55 +01:00
Wladimir J. van der Laan
3ca5852dc2
src/hash.cpp: endian compatibility
2015-03-06 15:54:53 +01:00
Wladimir J. van der Laan
4414f5ffe1
build: Endian compatibility
...
- Detect endian instead of stopping configure on big-endian
- Add `byteswap.h` and `endian.h` header for compatibility with
Windows and other operating systems that don't come with them
- Update `crypto/common.h` functions to use compat
endian header
2015-03-06 15:54:53 +01:00
Wladimir J. van der Laan
51377c2dbe
Merge pull request #5843
...
ba04c4a
2015-03-06 15:31:31 +01:00
Wladimir J. van der Laan
ee9f2bfa7b
Merge pull request #5813
...
34e5015
2015-03-06 15:27:00 +01:00
Pieter Wuille
ba04c4a780
Limit message sizes before transfer
...
This introduces a fixed limit for the size of p2p messages, and enforces it
before download.
2015-03-06 04:03:17 -08:00
Pieter Wuille
9519a9a420
Add correct bool combiner for net signals
2015-03-06 03:45:26 -08:00
Jonas Schnelli
9bbb880be4
[Qt] fix a issue where "command line options"-action overwrite "Preference"-action (on OSX)
...
- fixes #5800
2015-03-06 09:33:23 +01:00
Rob Van Mieghem
84a05b843b
QT: remove unused parameter
2015-03-05 12:20:49 -05:00
Wladimir J. van der Laan
215475aa00
Merge pull request #5830
...
6f1274c
2015-03-05 14:42:20 +01:00
Cozz Lovan
90a43c1e93
[Qt] Code-movement-only: Format confirmation message in sendcoinsdialog
2015-03-05 13:25:12 +01:00
Pieter Wuille
51598b2631
Reinitialize state in between individual unit tests.
...
This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.
2015-03-03 09:01:46 -08:00
Wladimir J. van der Laan
3dfcdf46c2
Merge pull request #5775
...
deda3e147ee8cf
2015-03-03 16:57:30 +01:00
Wladimir J. van der Laan
f8e68f7bfb
Merge pull request #5819
...
d23b0a23448b13c95ac830671516aa367303ee028f
2015-03-03 16:27:50 +01:00
Pieter Wuille
86eb461c5b
Merge pull request #5839
...
16a58a8
2015-03-03 04:08:15 -08:00
Cory Fields
16a58a8644
keys: remove libsecp256k1 verification until it's actually supported
...
This was added a while ago for testing purposes, but was never intended to be
used. Remove it until upstream libsecp256k1 decides that verification is
stable/ready.
2015-03-02 11:31:43 -05:00
Pieter Wuille
10a3ff07f5
Merge pull request #5832
...
9abbeea
2015-03-01 03:13:09 -08:00
Wladimir J. van der Laan
db4a1d598c
Merge pull request #5694
...
25cf6f3
2015-02-26 17:20:29 +01:00
Wladimir J. van der Laan
59310f1c02
Merge pull request #5820
...
85da07a
2015-02-26 17:13:13 +01:00
Pieter Wuille
9abbeeabd7
Remove obsolete pubsub method definitions
2015-02-26 05:30:59 -08:00
Wladimir J. van der Laan
482783b341
Merge pull request #5801
...
de5403f
2015-02-26 11:26:32 +01:00
Wladimir J. van der Laan
6f1274c8c9
qt: Don't save geometry for options and about/help window
...
These dialogs will be something that people occasionally open, not keep
open during their session, so just popping it up in a sensible place
is good enough. Remembering only creates potential issues, like spawning
it outside the current screen area.
On Ubuntu this causes the dialogs to be positioned in the
middle of the main dialog, so I didn't add code for that. YMMV.
Inspired by github pull #5777 by @L-Cranston-Shadow
2015-02-26 10:23:42 +01:00
Cory Fields
eec37136fd
make CMessageHeader a dumb storage class
...
It shouldn't know or care about bitcoind's chain param selection
2015-02-25 18:44:49 -05:00
21E14
32eaf8a3de
WIN32 Seed Cleanup: Move nLastPerfmon behind win32 ifdef.
...
Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called.
This is not intended to make any functional difference in the addition of entropy to the random pool.
2015-02-25 18:37:06 -05:00
Pieter Wuille
85da07a5a0
Better fingerprinting protection for non-main-chain getdatas.
...
With headers-first we can compare against the best header timestamp, rather
than using checkpoints which require code updates to maintain.
2015-02-24 04:35:13 -08:00
Cory Fields
aa3673064c
build: remove libstdc++ backwards-compat
...
Backwards-compatibility for libstdc++ is not limited to straightforward abi
changes. Symbol visibility also needs to be taken into consideration, and
that really can't be addressed simply.
Instead, just static-link libstdc++ for backwards-compat.
2015-02-23 17:56:15 -05:00
Ross Nicoll
34e5015cd2
Add unit tests for next difficulty calculations
...
Split GetNextWorkRequired() into two functions to allow the difficulty calculations to
be tested without requiring a full blockchain.
Add unit tests to cover basic difficulty calculation, plus each of the min/max actual
time, and maximum difficulty target conditions.
2015-02-21 13:14:19 +00:00
Michael Ford
de5403f878
[GUI] Move fee dialog minimise button away from "Transaction Fee"
...
Its original placement was causing confusion among some users.
2015-02-21 09:11:33 +08:00
Wladimir J. van der Laan
a026a56c4e
Merge #5706 : fix crash: RPC \
...
e5d9d77
2015-02-20 09:51:38 +01:00
Wladimir J. van der Laan
07f4386b38
Merge #5689 : openssl: abstract out OPENSSL_cleanse
...
1630219
2015-02-19 12:09:26 +01:00
Philip Kaufmann
6cb4a52535
[Qt, Linux] honor current network when creating autostart link
2015-02-19 12:08:47 +01:00
Philip Kaufmann
9673c35daf
[Qt, Win] honor current network when creating autostart link
...
- creates a "Bitcoin (testnet).lnk" when on testnet or a "Bitcoin
(regtest).lnk, when on regtest
- fixes #5778
2015-02-19 12:06:49 +01:00
Wladimir J. van der Laan
47a79bb880
Merge #5366 : No longer check osx compatibility in RenameThread
...
850c570
2015-02-18 17:36:39 +01:00
Wladimir J. van der Laan
8d0418720c
Merge #5799 : Rename Interval() to DifficultyAdjustmentInterval()
...
e5ece05
2015-02-18 17:29:28 +01:00
Wladimir J. van der Laan
e3a3cd7a28
Merge #5784 : Fix usage of NegateSignatureS in script_tests
...
78c6bed6f50dbd
2015-02-18 09:52:59 +01:00
Shaul Kfir
e5ece053da
Rename Interval() to DifficultyAdjustmentInterval()
2015-02-17 08:46:51 -05:00
Pieter Wuille
175d86e633
Merge #5710 : Add more information to errors in ReadBlockFromDisk
...
f5791c6
2015-02-16 11:58:35 -08:00
Cory Fields
1630219d90
openssl: abstract out OPENSSL_cleanse
...
This makes it easier for us to replace it if desired, since it's now only in
one spot. Also, it avoids the openssl include from allocators.h, which
essentially forced openssl to be included from every compilation unit.
2015-02-15 11:34:02 -05:00
Suhas Daftuar
78c6bedb9c
Add test for DER-encoding edge case
...
The fix to NegateSignatureS caused a test which had been failing
in IsValidSignatureEncoding to then fail in IsLowDERSignature.
Add new test so the original check remains exercised.
2015-02-10 13:25:41 -05:00
Suhas Daftuar
6f50dbd2fd
Fix NegateSignatureS to not duplicate last byte of S
...
NegateSignatureS is called with a signature without a hashtype, so
do not save the last byte and append it after S negation.
Updates the two tests which were affected by this bug.
2015-02-10 13:23:57 -05:00
Wladimir J. van der Laan
d48ce48093
Merge #5548 : [REST] add /rest/chaininfos
...
2c0f90159582c8
2015-02-10 12:08:07 +01:00
Wladimir J. van der Laan
a9565863e0
Merge #5629 : [Qt] prevent amount overflow problem with payment requests
...
a651668
2015-02-09 13:50:56 +01:00
Wladimir J. van der Laan
183ca292bd
Merge #5699 : Split logic to undo txin's off DisconnectBlock.
...
eb1c2cd
2015-02-09 13:22:35 +01:00
Wladimir J. van der Laan
beff11a3a1
Merge #5679 : Get rid of DetectShutdownThread
...
28ee7e8
2015-02-09 12:57:09 +01:00
Wladimir J. van der Laan
7225577f6b
Merge pull request #5739
...
f4b2078
2015-02-09 12:48:38 +01:00
Wladimir J. van der Laan
0f44672437
Merge pull request #5753
...
d67a642
2015-02-09 11:34:01 +01:00
Philip Kaufmann
deda3e156d
[Qt] remove unused getNumBlocksAtStartup() from ClientModel
2015-02-09 11:28:03 +01:00
Philip Kaufmann
47ee8cf091
[Qt] use qint64 in BitcoinGUI::setNumBlocks
...
- as QDateTime.secsTo() returns a qint64 also store in a qint64 and not in
an integer
2015-02-09 11:21:26 +01:00
Gregory Maxwell
28d4cff0ed
Sanitize command strings before logging them.
...
Normally bitcoin core does not display any network originated strings without
sanitizing or hex encoding. This wasn't done for strcommand in many places.
This could be used to play havoc with a terminal displaying the logs,
especially with printtoconsole in use.
Thanks to Evil-Knievel for reporting this issue.
2015-02-08 19:58:59 +00:00
Ivan Pustogarov
dca799e1db
Ignore getaddr messages on Outbound connections.
...
The only time when a client sends a "getaddr" message is when he
esatblishes an Outbound connection (see ProcessMessage() in
src/main.cpp). Another bitcoin client is expected to receive a
"getaddr" message only on Inbound connection. Ignoring "gettaddr"
requests on Outbound connections can resolve potential privacy issues
(and as was said such request normally do not happen anyway).
2015-02-06 22:03:42 +01:00
Wladimir J. van der Laan
fb6140b54b
Merge pull request #5721
...
cf008ac
2015-02-06 16:51:39 +01:00
Wladimir J. van der Laan
f5791c6ae3
Add more information to errors in ReadBlockFromDisk
...
A lot of times, disk corruption problems appear here.
To facilitate debugging and troubleshooting, add position information
to the error messages.
2015-02-05 14:21:25 +01:00
Jonas Schnelli
d67a642392
[Qt] add bitcoin logo to about screen
2015-02-04 20:52:18 +01:00
Jonas Schnelli
17115d0a34
fix getblocktemplate lock issue
...
getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.
2015-02-04 16:34:34 +01:00
Philip Kaufmann
25cf6f3d41
minor rework of SendMoney in rpcwallet
...
- rework the function to not log errors but use throw JSONRPCError
- remove a check for IsLocked() that is done in sendtoaddress and
sendfrom RPC calls already
- cache GetBalance() return value, because it's possibly used twice
2015-02-04 15:11:54 +01:00
Wladimir J. van der Laan
93b7544501
Merge pull request #5319
...
35f7227
2015-02-04 13:56:57 +01:00
Philip Kaufmann
a6516686dc
[Qt] prevent amount overflow problem with payment requests
...
Bitcoin amounts are stored as uint64 in the protobuf messages (see
paymentrequest.proto), but CAmount is defined as int64_t. Because
of that we need to verify that single and accumulated amounts are
in a valid range and no variable overflow has happened.
- fixes #5624 (#5622 )
Thanks @SergioDemianLerner for reporting that issue and also supplying us
with a possible solution.
- add static verifyAmount() function to PaymentServer and move the logging
on error into the function
- also add a unit test to paymentservertests.cpp
2015-02-04 13:47:32 +01:00
Wladimir J. van der Laan
31dedb463b
Merge pull request #5509
...
7f991e35a6155c3447cf8bbacd88a2b04dd
2015-02-04 13:06:16 +01:00
Wladimir J. van der Laan
87ecfb0f96
Merge pull request #5711
...
5ebe0954401b2d
2015-02-04 10:23:09 +01:00
Cory Fields
7f991e364e
c++11: These look like user-defined literals.
...
Add a space to keep the compiler happy
2015-02-03 23:31:00 -05:00
Cory Fields
5a6155ccfa
c++11: don't forward-declare types used in maps
2015-02-03 23:30:59 -05:00
Cory Fields
3447cf87e2
c++11: MOVEONLY: break circular dependency in wallet
...
c++11 (libc++'s stdlib implementation anyway) doesn't allow for map types to be
forward-declared. for example:
class foo;
std::map<int, foo> bar; // error, foo has not been defined.
class foo{};
Since CWallet and CWalletTx are inter-dependent, but only std::map<*,CWalletTx>
is used, forward-declare CWallet instead and define CWalletTx first.
Despite the mangled git diff, this change only amounts to moving ~320 lines in
a single chunk.
2015-02-03 23:30:59 -05:00
Cory Fields
bbacd88204
c++11: MOVEONLY: move function definitions out of the header
...
These need to be moved out of the header in order to resolve a circular
dependency between CWallet and CTxWallet. See next commit.
2015-02-03 22:41:33 -05:00
Cory Fields
a2b04ddfe6
build: fix newer boost build with c++11
2015-02-03 22:41:01 -05:00
Daniel Kraft
eb1c2cd37f
Split logic to undo txin's off DisconnectBlock.
...
Instead, create a separate function that applies the undo operation of a
CTxInUndo object onto a CCoinsViewCache. This method is used from
DisconnectBlock.
2015-02-03 15:44:39 +01:00
Suhas Daftuar
cf008ac8c3
Acquire CCheckQueue's lock to avoid race condition
...
This fixes a potential race condition in the CCheckQueueControl constructor,
which was looking directly at data in CCheckQueue without acquiring its lock.
Remove the now-unnecessary friendship for CCheckQueueControl
2015-02-03 08:53:08 -05:00
Wladimir J. van der Laan
fcf646c9b0
Merge pull request #5286
...
44e9a6ba930658
2015-02-03 13:12:44 +01:00
Wladimir J. van der Laan
e5f1f5a263
Merge pull request #5732
...
1371e6f
2015-02-03 13:12:12 +01:00
Wladimir J. van der Laan
6ee87f9bc5
Merge pull request #5647
...
3ff735c
2015-02-03 10:36:44 +01:00
Wladimir J. van der Laan
4e2b1fff98
Merge pull request #5675
...
2d9b0b7
2015-02-03 10:36:01 +01:00
Wladimir J. van der Laan
41e6e4caba
Merge pull request #5713
...
bf6cdeb819bcf95a47811092e9fe80ad135
2015-02-03 10:34:53 +01:00
Wladimir J. van der Laan
9c4a5a5067
Merge pull request #5729
...
fdf80ea
2015-02-03 09:49:26 +01:00
Pieter Wuille
9fddceda44
Avoid storing a reference passed to SignatureChecker constructors
2015-02-02 20:19:46 -08:00
Pieter Wuille
858809a33e
Use separate SignatureChecker for CMutableTransaction
2015-02-02 20:19:12 -08:00
Shaul Kfir
f4b2078f72
Replace difficulty readjustment blocks with Interval()
2015-02-02 14:36:00 -05:00
Pieter Wuille
bf6cdebdc5
Increase coverage of DERSIG edge cases
2015-02-01 17:51:25 -04:00
Pieter Wuille
5a47811da5
BIP66 changeover logic
2015-02-01 17:51:24 -04:00
Pieter Wuille
092e9fe5fb
Example unit tests from BIP66
2015-02-01 17:47:21 -04:00
Pieter Wuille
80ad135a5e
Change IsDERSignature to BIP66 implementation
2015-02-01 17:47:21 -04:00
Daira Hopwood
1371e6f5db
Change "insane" to "absurd" (referring to high fees) in text strings and identifiers.
...
Note that this will also require translation changes in Transifex for the key
"A fee higher than %1 is considered an insanely high fee." which is now
"A fee higher than %1 is considered an absurdly high fee."
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-01-31 23:23:20 +00:00
bikinibabe
ee932025c1
Changed pronouns for correctness and inclusivity
2015-01-31 17:38:28 -05:00
Vitalii Demianets
bd2b73bb9b
TRIVIAL: fix misleading comment
2015-01-31 17:38:28 -05:00
Pavel Janík
5262fde0ec
Remove whitespaces before double colon in errors and logs
2015-01-31 17:38:28 -05:00
Pavel Janík
91a9fe094b
Fix typo - sentence starts with capital letter
2015-01-31 17:37:01 -05:00
