sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 21:12:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
15,584 Commits 24 Branches 554 Tags 576 MiB
dad8c67d38
Commit Graph

730 Commits

Author SHA1 Message Date
UdjinM6
79e6d272ed
Merge pull request #1908 from codablock/pr_backport_bitcoin_0.14-12 
Collection of PRs and single commits missed in previous backports
 2018-02-08 08:45:02 +03:00
Alexander Block
bb20b4e7b5 Few cleanups after backporting (#1903) 
* Remove remains of workaround that was needed while backporting

* Add missing closing round bracket to help string

* Remove now unnecessary .encode() calls in wallet.py

Now that we only support python3, we can fix this TODO.
 2018-02-08 08:43:50 +03:00
Wladimir J. van der Laan
611b31ecea Merge #9650: Better handle invalid parameters to signrawtransaction 
6dbfe08 [qa] test signrawtransaction merge with missing inputs (Matt Corallo)
ec4f7e4 [qa] Add second input to signrawtransaction test case (Matt Corallo)
691710a [qa] Test that decoderawtransaction throws with extra data appended (Matt Corallo)
922bea9 Better handle invalid parameters to signrawtransaction (Matt Corallo)
7ea0ad5 Fail in DecodeHexTx if there is extra data at the end (Matt Corallo)
 2018-02-07 13:11:08 +01:00
MarcoFalke
ff335e47fd [qa] test_framework: Add wrapper for stop_node 2018-02-07 13:11:08 +01:00
Alexander Block
00a0bc7103 Remove "TODO: fix off-by-one" 2018-02-01 11:13:01 +01:00
Alexander Block
625252fb49 Allow to pass redirect_stderr=True to initialize_chain and use in wallet-dump.py 
Same as with start_node
 2018-02-01 11:13:01 +01:00
Alexander Block
d56ac5a747 Fix import-rescan.py and add workaround for pruning mode 
Added a workaround to the masternode+pruning mode check to allow pruning
in regtest. The actual bug behind the masternode+pruning check is not
touched this way. Please read the linked GitHub issues for details.
 2018-02-01 11:13:01 +01:00
Wladimir J. van der Laan
1ba1256217 Merge #9761: Use 2 hour grace period for key timestamps in importmulti rescans 
e662af3 Use 2 hour grace period for key timestamps in importmulti rescans (Russell Yanofsky)
38d3e9e [qa] Extend import-rescan.py to test imports on pruned nodes. (Russell Yanofsky)
c28583d [qa] Extend import-rescan.py to test specific key timestamps (Russell Yanofsky)
8be0866 [qa] Simplify import-rescan.py (Russell Yanofsky)
 2018-02-01 11:13:01 +01:00
Wladimir J. van der Laan
43f697866e Merge #9108: Use importmulti timestamp when importing watch only keys (on top of #9682) 
a80f98b Use importmulti timestamp when importing watch only keys (Russell Yanofsky)
a58370e Dedup nTimeFirstKey update logic (Russell Yanofsky)
 2018-02-01 11:13:01 +01:00
Wladimir J. van der Laan
6f86725d00 Merge #9682: Require timestamps for importmulti keys 
266a811 Use MTP for importmulti "now" timestamps (Russell Yanofsky)
3cf9917 Add test to check new importmulti "now" value (Russell Yanofsky)
442887f Require timestamps for importmulti keys (Russell Yanofsky)
 2018-02-01 11:13:01 +01:00
Alexander Block
9c5032c540 Explicitly start nodes with -usehd=1 in wallet-dump.py 
We currently have usehd defaulted to 0, so we need to explicitly start it
with usehd=1 in wallet-dump.py.

This requires setting up a new data dirs cache for hd as the wallets won't
be compatible otherwise. At the same time we need the initial state of
the wallet to test the dump functionality.

Also use redirect_stderr=True to fix failure when run from pull-tester
 2018-02-01 11:13:01 +01:00
Alexander Block
a92b7b2ede Add missed change from previous backport to wallet-dump.py 
#8840: test: Explicitly set encoding to utf8 when opening text files
 2018-02-01 11:13:01 +01:00
MarcoFalke
9bb9e9ea72 Merge #9077: [qa] Increase wallet-dump RPC timeout 
e89614b [qa] Add more helpful RPC timeout message (Russell Yanofsky)
8463aaa [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
 2018-02-01 11:13:01 +01:00
Wladimir J. van der Laan
8d90f295e8 Merge #8442: [qa] Rework hd wallet dump test 
fa4439d [qa] Rework hd wallet dump test (MarcoFalke)
 2018-02-01 11:13:01 +01:00
Wladimir J. van der Laan
9a37add21f Merge #8417: [QA] Add walletdump RPC test (including HD- & encryption-tests) 
54af51d [QA] Add walletdump RPC test (including HD- & encryption-tests) (Jonas Schnelli)
 2018-02-01 11:13:01 +01:00
Alexander Block
a42baec5e0 Remove SegWit related tests/code from nulldummy.py 2018-01-30 20:18:17 +01:00
Wladimir J. van der Laan
4bb0cdf400 Merge #8841: [qa] fix nulldummy test 
46a4774 Fix nulldummy.py test (Johnson Lau)
 2018-01-30 20:13:24 +01:00
Wladimir J. van der Laan
4a585b2f20 Merge #8835: [qa] nulldummy.py: Don't run unused code 
fa156c6 [qa] nulldummy: Don't run unused code (MarcoFalke)
 2018-01-30 20:12:50 +01:00
Wladimir J. van der Laan
075b4d320c Merge #8636: Implement NULLDUMMY softfork (BIP147) 
482f852 Implement NULLDUMMY softfork (Johnson Lau)
 2018-01-30 20:12:34 +01:00
Alexander Block
a4430b624f Fix rpc tests 2018-01-26 12:59:29 +01:00
Pieter Wuille
bcef7260d0 Merge #10196: Bugfix: PrioritiseTransaction updates the mempool tx counter 
6c2e25c [qa] Test prioritise_transaction / getblocktemplate interaction (Suhas Daftuar)
acc2e4b Bugfix: PrioritiseTransaction updates the mempool tx counter (Suhas Daftuar)

Tree-SHA512: dcf834df52d84d5eb86acb847c3f28d3cffd1f78f3092b8ff8913c2c400675a071c48a19cd852fdbaac1582aa1dba23433e0e16055831ef2a5e76dde91199941
 2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan
c45c767f8e Merge #10294: [Wallet] unset change position when there is no change 
7c58863 [Wallet] unset change position when there is no change on exact match (Gregory Sanders)

Tree-SHA512: ce8b9337e4132e32d80f954258d50938052c833a48e39431649d6adb16e3d18626a0ae5d300827e7fa397927fba72a1f066cb31af9b0a3ef7f1feb6024461626
 2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan
2e45791c95 Merge #10157: [0.14] Fix the mempool_packages.py test 
39febb8 [qa] Fix mempool_packages.py for the 0.14 branch (Suhas Daftuar)

Tree-SHA512: 7b5f2627a76d79da5d7c9d30794219a87bec99296d5f74f66b347c7c8914244bfd07f0d48231adda7269678706fd9158b846d710f942b724c8c5748cc4a49c7e
 2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan
96b457d47e Merge #10144: Prioritisetransaction wasn't always updating ancestor fee 
9bef02e Bugfix: ancestor modifed fees were incorrect for descendants (Suhas Daftuar)
ba7dd8b Test prioritisetransaction and ancestor fee state (Suhas Daftuar)

Tree-SHA512: 01977d88e1afb093a003f22a6f29ea60df3d70a179fe7e55910b9c8c340c4af9fb20cdc804c40235b62c43c453f0194eda0d0d4dbd365d2d98347f5dbe5de01c
 2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan
d88030845d Merge #9824: qa: Check return code when stopping nodes 
fa4cd2e qa: Check return code when stopping nodes (MarcoFalke)
 2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan
f09ae21c36 Merge #9820: Fix pruning test broken by 2 hour manual prune window 
874c736 Fix pruning test broken by 2 hour manual prune window (Russell Yanofsky)
 2018-01-26 12:59:29 +01:00
Wladimir J. van der Laan
da8808fba0 Merge #9756: Return error when importmulti called with invalid address. 
9acf25c Return error when importmulti called with invalid address. (Russell Yanofsky)
 2018-01-23 09:24:29 +01:00
Wladimir J. van der Laan
fe0ef87cd3 Merge #9720: net: fix banning and disallow sending messages before receiving verack 
d943491 qa: add a test to detect leaky p2p messages (Cory Fields)
8650bbb qa: Expose on-connection to mininode listeners (Matt Corallo)
5b5e4f8 qa: mininode learns when a socket connects, not its first action (Matt Corallo)
cbfc5a6 net: require a verack before responding to anything else (Cory Fields)
8502e7a net: parse reject earlier (Cory Fields)
c45b9fb net: correctly ban before the handshake is complete (Cory Fields)
 2018-01-23 09:24:28 +01:00
Wladimir J. van der Laan
588b8e5caf Merge #9715: Disconnect peers which we do not receive VERACKs from within 60 sec 
66f861a Add a test for P2P inactivity timeouts (Matt Corallo)
b436f92 qa: Expose on-connection to mininode listeners (Matt Corallo)
8aaba7a qa: mininode learns when a socket connects, not its first action (Matt Corallo)
2cbd119 Disconnect peers which we do not receive VERACKs from within 60 sec (Matt Corallo)
 2018-01-23 09:24:28 +01:00
MarcoFalke
8043468b3f Merge #9707: Fix RPC failure testing 
9db8eec Fix RPC failure testing (John Newbery)
 2018-01-23 09:24:28 +01:00
Wladimir J. van der Laan
767f5e436b Merge #9532: Remove unused variables 
90fd29b Remove unused int64_t nSinceLastSeen (practicalswift)
ac4a095 Remove unused Python variables (practicalswift)
 2018-01-23 09:24:27 +01:00
Alexander Block
715be73c6f Fix listsinceblock.py 2018-01-21 14:14:34 +01:00
Alexander Block
9bc404a8cc Add "setbip69enabled" RPC usable by tests only 
Needed by fundrawtransaction tests which rely on the ordering not being
changed.
 2018-01-21 14:14:34 +01:00
Russell Yanofsky
6bee150e8e Require timestamps for importmulti keys 
Additionally, accept a "now" timestamp, to allow avoiding rescans for keys
which are known never to have been used.

Note that the behavior when "now" is specified is slightly different than the
previous behavior when no timestamp was specified at all. Previously, when no
timestamp was specified, it would avoid rescanning during the importmulti call,
but set the key's nCreateTime value to 1, which would not prevent future block
reads in later ScanForWalletTransactions calls. With this change, passing a
"now" timestamp will set the key's nCreateTime to the current block time
instead of 1.

Fixes #9491
 2018-01-21 14:14:34 +01:00
Wladimir J. van der Laan
edf3a00a29 Merge #9638: qa: Actually test assertions in pruning.py 
fab035f qa: Actually test assertions in pruning.py (MarcoFalke)
 2018-01-21 12:48:34 +01:00
MarcoFalke
5a84b27dc1 Merge #9628: qa: Increase a sync_blocks timeout in pruning.py 
2f10f06 qa: Increase a sync_blocks timeout in pruning.py (Suhas Daftuar)
 2018-01-21 12:48:34 +01:00
Wladimir J. van der Laan
119c3fe62f Merge #9516: Bug-fix: listsinceblock: use fork point as reference for blocks in reorg'd chains 
7ba0a00 Testing: listsinceblock should not use orphan block height. (Karl-Johan Alm)
ee5c1ce Bug-fix: listsinceblock: use closest common ancestor when a block hash was provided for a chain that was not the main chain. (Karl-Johan Alm)
 2018-01-21 12:48:33 +01:00
Wladimir J. van der Laan
96b4910fbe Merge #9607: Remove redundant semicolons in Python code 
5cdf106 Remove redundant semicolons in Python code (practicalswift)
 2018-01-21 12:48:33 +01:00
Wladimir J. van der Laan
36109e0580 Merge #9377: fundrawtransaction: Keep change-output keys by default, make it optional 
c9f3062 Add fundrawtransactions new reserveChangeKey option to the release notes (Jonas Schnelli)
9eb325d [QA] Add test for fundrawtransactions new reserveChangeKey option (Jonas Schnelli)
9aa4e6a [Wallet] Add an option to keep the change address key, true by default (Jonas Schnelli)
 2018-01-21 12:48:33 +01:00
MarcoFalke
be63fb7953 Merge #9508: Remove unused Python imports 
95bab82 Remove unused Python imports (practicalswift)
 2018-01-21 12:48:33 +01:00
Alexander Block
2adb35533f Add assumevalid testcase 
Missed in original backport of assumevalid
 2018-01-21 12:48:33 +01:00
Wladimir J. van der Laan
4408b2d147 Merge #9222: Add 'subtractFeeFromAmount' option to 'fundrawtransaction'. 
453bda6 Add 'subtractFeeFromOutputs' option to 'fundrawtransaction'. (Chris Moore)
 2018-01-21 12:48:32 +01:00
MarcoFalke
cee8cf1be6 Merge #9518: Return height of last block pruned by pruneblockchain RPC 
918d1fb Return height of last block pruned by pruneblockchain RPC (Russell Yanofsky)
 2018-01-21 12:48:32 +01:00
Wladimir J. van der Laan
88b9aa45de Merge #7871: Manual block file pruning. 
afffeea fixup! Add pruneblockchain RPC to enable manual block file pruning. (Russell Yanofsky)
1fc4ec7 Add pruneblockchain RPC to enable manual block file pruning. (mrbandrews)
 2018-01-21 12:48:32 +01:00
Wladimir J. van der Laan
7321bfdd6b Merge #8391: Consensus: Remove ISM 
122786d Consensus: Remove ISM (NicolasDorier)
 2018-01-20 09:22:40 +01:00
Wladimir J. van der Laan
0fc37e8c56 Merge #7562: Bump transaction version default to 2 
c5c92c4 Update python tests for default tx version=2 (BtcDrak)
dab207e Preserve tx version=1 for certain tests (BtcDrak)
c5d746a tiny test fix for mempool_tests (Alex Morcos)
1f0ca1a Bump default transaction version to 2 (BtcDrak)
 2018-01-20 09:22:38 +01:00
Pieter Wuille
3235aad493 Implement SipHash in Python 2018-01-20 09:21:13 +01:00
Alexander Block
29d5bdb55c Fix import-rescan.py test 2018-01-18 07:38:58 +01:00
Wladimir J. van der Laan
eb7a6b08f1 Merge #8811: rpc: Add support for JSON-RPC named arguments 
4e7e2e1 Update RPC argument names (John Newbery)
481f289 rpc: Named argument support for bitcoin-cli (Wladimir J. van der Laan)
9adb4e1 rpc: Argument name consistency (Wladimir J. van der Laan)
8d713f7 rpc: Named arguments for rawtransaction calls (Wladimir J. van der Laan)
37a166f rpc: Named arguments for wallet calls (Wladimir J. van der Laan)
78b684f rpc: Named arguments for mining calls (Wladimir J. van der Laan)
b8ebc59 rpc: Named arguments for net calls (Wladimir J. van der Laan)
2ca9dcd test: Add test for RPC named arguments (Wladimir J. van der Laan)
fba1a61 rpc: Named arguments for misc calls (Wladimir J. van der Laan)
286ec08 rpc: Add 'echo' call for testing (Wladimir J. van der Laan)
495eb44 rpc: Named arguments for blockchain calls (Wladimir J. van der Laan)
6f1c76a rpc: Support named arguments (Wladimir J. van der Laan)
5865d41 authproxy: Add support for RPC named arguments (Wladimir J. van der Laan)
 2018-01-18 07:38:57 +01:00
MarcoFalke
d2a8ecc8db Merge #9395: Add test for -walletrejectlongchains 
ffeb195 add test for -walletrejectlongchains (Alex Morcos)
 2018-01-18 07:33:44 +01:00
Wladimir J. van der Laan
dc1df137e3 Merge #9262: Prefer coins that have fewer ancestors, sanity check txn before ATMP 
cee1612 reduce number of lookups in TransactionWithinChainLimit (Gregory Sanders)
af9bedb Test for fix of txn chaining in wallet (Gregory Sanders)
5882c09 CreateTransaction: Don't return success with too-many-ancestor txn (Gregory Sanders)
0b2294a SelectCoinsMinConf: Prefer coins with fewer ancestors (Gregory Sanders)
 2018-01-18 07:31:22 +01:00
Wladimir J. van der Laan
bf3cc9ff90 Merge #9331: [qa] Add test for rescan feature of wallet key import RPCs 
d8c0b9f [qa] Add test for rescan feature of wallet key import RPCs (Russell Yanofsky)
 2018-01-18 07:31:22 +01:00
MarcoFalke
c0b0ae8be4 Merge #9309: [qa] Wallet needs to stay unlocked for whole test 
9359f8a Wallet needs to stay unlocked for whole test (Alex Morcos)
 2018-01-17 17:31:12 +01:00
Alexander Block
7322489ca2 Merge #9276: Some minor testing cleanups 
30b620c remove obsolete run-bitcoind-for-test.sh (Alex Morcos)
2a99522 remove relaypriority from rpc tests (Alex Morcos)
e2184cc Reorder RPC tests for running time (Alex Morcos)

# Conflicts:
#	qa/pull-tester/rpc-tests.py
#	qa/pull-tester/run-bitcoind-for-test.sh.in
 2018-01-17 17:31:12 +01:00
MarcoFalke
19958fecf9 Merge #9274: [qa] Use cached utxo set to fix performance regression 
fab1af3 [qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4 [qa] pruning: Use cached utxo set to run faster (MarcoFalke)
 2018-01-17 17:31:12 +01:00
MarcoFalke
5d1f05afff Merge #9221: [qa] Get rid of duplicate code 
facbfa5 [qa] Get rid of duplicate code (MarcoFalke)
 2018-01-17 17:30:38 +01:00
MarcoFalke
5e09f275e2 Merge #9257: [qa] Dump debug logs on travis failures. 
0828619 [qa] Dump debug logs on travis failures. (Suhas Daftuar)
 2018-01-17 17:30:38 +01:00
MarcoFalke
df24dfd4bc Merge #9233: Fix some typos 
15fa95d Fix some typos (fsb4000)
 2018-01-17 17:27:24 +01:00
MarcoFalke
f831710f46 Merge #9139: Change sync_blocks to pick smarter maxheight (on top of #9196) 
1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)
 2018-01-17 17:25:36 +01:00
Alexander Block
9170c0e9c3 Fix rpc tests 
1. Missing TX fees in some tests. No-fee transactions stopped working because
   the free TX relay was set to 0
2. rawtransaction tests used "hash" instead of "txid". "hash" is only valid
   if SegWit changes are included.
 2018-01-15 08:26:15 +01:00
Wladimir J. van der Laan
ce3f38d6ca Merge #9025: getrawtransaction should take a bool for verbose 
240189b add testcases for getrawtransaction (John Newbery)
ce2bb23 getrawtransaction should take a bool for verbose (jnewbery)
 2018-01-15 06:14:16 +01:00
Wladimir J. van der Laan
e5cc7d0eb4 Merge #8872: Remove block-request logic from INV message processing 
037159c Remove block-request logic from INV message processing (Matt Corallo)
3451203 [qa] Respond to getheaders and do not assume a getdata on inv (Matt Corallo)
d768f15 [qa] Make comptool push blocks instead of relying on inv-fetch (mrbandrews)
 2018-01-15 06:14:16 +01:00
MarcoFalke
a9a2db9a53 Merge #9168: [qa] add assert_raises_message to check specific error message 
307acdd [qa] add assert_raises_message to check specific error message (mrbandrews)
 2018-01-15 06:14:16 +01:00
Wladimir J. van der Laan
e711f4ae23 Merge #9151: [qa] proxy_test: Calculate hardcoded port numbers 
fa80ef8 [qa] proxy_test: Calculate hardcoded port numbers instead (MarcoFalke)
 2018-01-15 06:14:16 +01:00
MarcoFalke
12883cfe4d Merge #9136: sync_blocks cleanup 
7943b13 [qa] Avoid 2 list comprehensions in sync_blocks (Russell Yanofsky)
05e57cc [qa] Fix sync_blocks timeout argument (Russell Yanofsky)
fd6bb70 [qa] Improve sync_blocks error messages. (Russell Yanofsky)
 2018-01-15 06:14:16 +01:00
MarcoFalke
3a388d9c01 Merge #9097: [qa] Rework sync_* and preciousblock.py 
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
 2018-01-15 06:14:15 +01:00
Wladimir J. van der Laan
56ed800843 Merge #8894: [Testing] Include fRelay in mininode version messages 
e5d682f Fix mininode version message format (jnewbery)
 2018-01-15 06:14:15 +01:00
Wladimir J. van der Laan
1121f2f951 Merge #9098: [qa] Handle zombies and cluttered tmpdirs 
fab0f07 [qa] rpc-tests: Apply random offset to portseed (MarcoFalke)
fae19aa [qa] test_framework: Exit when tmpdir exists (MarcoFalke)
 2018-01-15 06:14:15 +01:00
MarcoFalke
3d7bb9cf55 Merge #9077: [qa] Increase wallet-dump RPC timeout 
e89614b [qa] Add more helpful RPC timeout message (Russell Yanofsky)
8463aaa [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
 2018-01-15 06:14:11 +01:00
Wladimir J. van der Laan
9d661f4337 Merge #8675: Make copyright header lines uniform 
4b04e32 [copyright] copyright header style uniform (isle2983)
 2018-01-13 13:44:39 +01:00
Wladimir J. van der Laan
efded3ca9c Merge #7551: Add importmulti RPC call 
215caba Add consistency check to RPC call importmulti (Pedro Branco)
cb08fdb Add importmulti rpc call (Pedro Branco)
 2018-01-13 13:44:37 +01:00
Wladimir J. van der Laan
dc9556a890 Merge #7948: RPC: augment getblockchaininfo bip9_softforks data 
fc14609 RPC: augment getblockchaininfo bip9_softforks data (mruddy)
 2018-01-13 13:44:37 +01:00
Wladimir J. van der Laan
6e871c0c2e Merge #6996: Add preciousblock RPC 
5805ac8 Add preciousblock tests (Pieter Wuille)
5127c4f Add preciousblock RPC (Pieter Wuille)
 2018-01-12 09:58:15 +01:00
MarcoFalke
23ac000008 Merge #8860: [qa] util: Move wait_bitcoinds() into stop_nodes() 
fa7c35c [qa] util: Move wait_bitcoinds() into stop_nodes() (MarcoFalke)
 2018-01-12 09:57:56 +01:00
MarcoFalke
16532f8ee0 Merge #8857: [qa] mininode: Only allow named args in wait_until 
fa66609 [qa] mininode: Only allow named args in wait_until (MarcoFalke)
 2018-01-12 09:57:56 +01:00
Wladimir J. van der Laan
6b1842af87 Merge #8839: test: Avoid ConnectionResetErrors during RPC tests 
1d28faf test: Avoid ConnectionResetErrors during RPC tests (Wladimir J. van der Laan)
 2018-01-12 09:56:54 +01:00
Wladimir J. van der Laan
942fe0ed49 Merge #8840: test: Explicitly set encoding to utf8 when opening text files 
30930e8 test: Explicitly set encoding to utf8 when opening text files (Wladimir J. van der Laan)
 2018-01-12 09:56:53 +01:00
Wladimir J. van der Laan
e6af218659 Merge #8834: [qa] blockstore: Switch to dumb dbm 
fa9cd25 [qa] blockstore: Switch to dumb dbm (MarcoFalke)
 2018-01-12 09:56:53 +01:00
MarcoFalke
cf4bdab3b5 Merge #8827: [qa] Split up slow RPC calls to avoid pruning test timeouts 
a0f8482 [qa] Split up slow RPC calls to avoid pruning test timeouts (Suhas Daftuar)
 2018-01-12 08:02:45 +01:00
Alexander Block
205ff3519e Fix wallet.py test by redirecting stderr to stdout 
Changes in start_node args result in warnings being printed to stderr
 2018-01-11 14:47:10 +01:00
Wladimir J. van der Laan
acf0295014 Merge #8810: tests: Add exception error message for JSONRPCException 
42f6aed tests: Add exception error message for JSONRPCException (Wladimir J. van der Laan)
 2018-01-11 13:22:22 +01:00
Wladimir J. van der Laan
0028dbfbfd Merge #8780: [rpc] Deprecate getinfo 
fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke)
ddddaaf [rpc] Deprecate getinfo (MarcoFalke)
 2018-01-11 13:22:22 +01:00
MarcoFalke
7f4439fa63 Merge #8789: [qa] pull-tester: Only print output when failed 
fa427ce [qa] pull-tester: Only print output when failed (MarcoFalke)
 2018-01-11 13:22:22 +01:00
Wladimir J. van der Laan
d95a9728be Merge #8676: Add missing copyright headers 
783e930 [copyright] Add missing copyright headers (isle2983)
 2018-01-11 13:20:57 +01:00
Wladimir J. van der Laan
699db99321 Merge #8716: [qa] wallet: Check legacy wallet as well 
fa644d0 [qa] wallet: Check legacy wallet as well (MarcoFalke)
 2018-01-11 13:19:32 +01:00
MarcoFalke
9e0976ee0a Merge #8724: [qa] walletbackup: Sync blocks inside the loop 
fad41f3 [qa] walletbackup: Sync blocks inside the loop (MarcoFalke)
 2018-01-11 13:19:32 +01:00
MarcoFalke
9d86487352 Merge #8713: [qa] create_cache: Delete temp dir when done 
fa27d99 [qa] create_cache: Delete temp dir when done (MarcoFalke)
 2018-01-11 13:19:32 +01:00
MarcoFalke
93e857ed9c Merge #8652: [qa]: remove root test directory for RPC tests 
c62cc4e fix path for bak file (whythat)
438e94d remove root test directory for RPC tests (whythat)
 2018-01-11 13:19:32 +01:00
Alexander Block
8efec7b068 Fix wallet-accounts.py tests 2018-01-09 17:45:28 +01:00
MarcoFalke
85c0aabc11 Merge #8667: Fix SIGHASH_SINGLE bug in test_framework SignatureHash 
2f2548d Fix SIGHASH_SINGLE bug in test_framework SignatureHash (Johnson Lau)
 2018-01-09 14:16:39 +01:00
Wladimir J. van der Laan
c2a601f507 Merge #8680: Address Travis spurious failures 
d6a5dc4 add waitfornewblock/waitforblock/waitforblockheight rpcs and use them for tests (Cory Fields)
 2018-01-09 14:16:39 +01:00
Wladimir J. van der Laan
bc91f34da6 Merge #8638: rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST 
f012a85 rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST (djpnewton)
 2018-01-09 14:16:38 +01:00
MarcoFalke
e8e95994bb Merge #8625: [doc] - clarify statement about parallel jobs in rpc-tests.py 
1467561 [doc] - clarify statement about parallel jobs in rpc-tests.py (isle2983)
 2018-01-09 14:04:21 +01:00
Wladimir J. van der Laan
22604cbbcc Merge #8607: [doc] Fix doxygen off-by-one comments, fix typos 
fafe7b3 contrib: Make fix-copyright-headers.py more portable (MarcoFalke)
fa27c0a [doc] Fix typos in comments, doxygen: Fix comment syntax (MarcoFalke)
fabfd5d [qa] pull-tester: Don't mute zmq ImportError (MarcoFalke)
67a5502 init: Fix typo in help message for -whitelistforcerelay (Wladimir J. van der Laan)
 2018-01-09 14:04:21 +01:00
Wladimir J. van der Laan
15b9e43abe Merge #8581: [wallet] rpc: Drop misleading option 
fab5ecb [wallet] rpc: Drop misleading option (MarcoFalke)
 2018-01-09 14:04:20 +01:00
Wladimir J. van der Laan
e61556e20e Merge #8450: [Test] Replace rpc_wallet_tests.cpp with python RPC unit tests 
9578333 Remove rpc_wallet_tests.cpp (Patrick Strateman)
25400c4 Account wallet feature RPC tests. (Patrick Strateman)
 2018-01-09 14:04:19 +01:00
Alexander Block
f8ffc55af2 Partially cherry-pick tests refactorings found in Bitcoin SegWit PRs 
These were mixed into SegWit related PRs and are still needed in Dash.
 2018-01-08 18:04:55 +01:00
MarcoFalke
5b62ad34a3 Merge #8551: [qa] Remove unused code 
faaec13 [qa] Remove unused code (MarcoFalke)
 2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
7231c66901 Revert "[qa] Adjust timeouts for micro-optimization of run time" 
This reverts commit fa2d68f79c.

Temporary revert - see discussion in #8532.
 2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
6ac01da712 Merge #8531: [qa] abandonconflict: Use assert_equal 
fa64306 [qa] abandonconflict: Use assert_equal (MarcoFalke)
 2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
7bba7375d0 Merge #8482: [qa] Use single cache dir for chains 
fad8cf6 [qa] Use single cache dir for chains (MarcoFalke)
fa2d68f [qa] Adjust timeouts for micro-optimization of run time (MarcoFalke)
fae596f [qa] Sort scripts by time for pull_tester and don't overwrite setup_chain (MarcoFalke)
 2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
bdddabb3cf Merge #8521: qa: Remove duplicate hash160 implementation 
c1582d5 qa: Remove duplicate `hash160` implementation (Wladimir J. van der Laan)
 2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
549894bac7 Merge #8444: Fix p2p-feefilter.py for changed tx relay behavior 
2c517b3 Fix p2p-feefilter.py for changed tx relay behavior (Suhas Daftuar)
 2018-01-08 18:04:55 +01:00
MarcoFalke
8c76eb7394 Merge #8400: [qa]: enable rpcbind_test 
9bbb414 [qa]: enable rpcbind_test (whythat)
0ff4375 [qa]: add parsing for '<host>:<port>' argument form to rpc_url() (whythat)
 2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
bc257c1a08 Merge #8305: Improve handling of unconnecting headers 
e91cf4b Add test for handling of unconnecting headers (Suhas Daftuar)
96fa953 Improve handling of unconnecting headers (Suhas Daftuar)
 2017-12-28 11:44:59 +01:00
MarcoFalke
2c914e8ba2 Merge #8280: Tests: Increase sync_blocks() timeouts in pruning.py 
36f1b9d Tests: Increase sync_blocks() timeouts in pruning.py (Suhas Daftuar)
 2017-12-28 11:44:59 +01:00
MarcoFalke
5a844dcc49 Merge #8254: [doc] Add OSX ZMQ requirement to QA readme 
d241487 [doc] Add OS X ZMQ requirement to QA readme (fanquake)
 2017-12-28 11:44:59 +01:00
Wladimir J. van der Laan
e2bcf8ae0c Merge #8216: [qa] assert 'changePosition out of bounds' 
fa58f94 [qa] pull-tester: Start longest test first (MarcoFalke)
fa3b379 [qa] pull-tester: Fix assertion and check for run_parallel (MarcoFalke)
fa32465 [qa] fundrawtransaction: Create get_unspent() (MarcoFalke)
fa8ce3b [qa] assert 'changePosition out of bounds' (MarcoFalke)
 2017-12-28 11:44:59 +01:00
Wladimir J. van der Laan
782745b05b Merge #8066: [qa] test_framework: Use different rpc_auth_pair for each node 
fad1845 [qa] test_framework: Use different rpc_auth_pair for each node (MarcoFalke)
 2017-12-28 11:44:59 +01:00
MarcoFalke
6227cfdad5 Merge #8214: [qa] mininode: fail on send_message instead of silent return 
facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)
 2017-12-28 11:44:59 +01:00
Wladimir J. van der Laan
c783b39ce7 Merge #8171: [RPC] Fix createrawtx sequence number unsigned int parsing 
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)
 2017-12-28 11:44:59 +01:00
Alexander Block
f00aeb87c8 Fix failing test in p2p-fullblocktest.py 2017-12-22 19:35:34 +01:00
Wladimir J. van der Laan
2e51d82735 Merge #8201: [qa] fundrawtransaction: Fix race, assert amounts 
fae1d06 [qa] fundrawtransaction: Fix race, assert amounts (MarcoFalke)
fa26c42 [qa] util: Move check_fee_amount out of wallet.py (MarcoFalke)
 2017-12-22 17:20:43 +01:00
Wladimir J. van der Laan
e7e3a80712 Merge #8141: Continuing port of java comparison tool 
ff2dcf2 Tests: Edit bloated varint test and add option for 'barely expensive' tests (mrbandrews)
12c5a16 Catch exceptions from non-canonical encoding and print only to log (mrbandrews)
291f8aa Continuing port of java comptool (mrbandrews)
8c9e681 Tests: Rework blockstore to avoid re-serialization. (mrbandrews)
 2017-12-22 17:20:43 +01:00
Wladimir J. van der Laan
b95a338b30 Merge #8133: build: Finish up out-of-tree changes 
d1a3d57 bulid: fix "make translate" when out-of-tree (Cory Fields)
340012d build: add temporary fix for "bad magic number" error in out-of-tree builds (Cory Fields)
142ffc7 travis: use out-of-tree build (Cory Fields)
92e37a3 build: fix out-of-tree 'make deploy' for osx (Cory Fields)
ab95d5d build: a few ugly hacks to get the rpc tests working out-of-tree (Cory Fields)
fc4ad0c build: more out-of-tree fixups (Cory Fields)
0cb0f26 build: out-of-tree fixups (Cory Fields)
 2017-12-22 17:20:31 +01:00
Pieter Wuille
b9a00f6294 Merge #7292: [RPC] Expose ancestor/descendant information over RPC 
176e19b Mention new RPC's in release notes (Suhas Daftuar)
7f6eda8 Add ancestor statistics to mempool entry RPC output (Suhas Daftuar)
a9b8390 Add test coverage for new RPC calls (Suhas Daftuar)
b09b813 Add getmempoolentry RPC call (Suhas Daftuar)
0dfd869 Add getmempooldescendants RPC call (Suhas Daftuar)
8f7b5dc Add getmempoolancestors RPC call (Suhas Daftuar)
5ec0cde Refactor logic for converting mempool entries to JSON (Suhas Daftuar)
 2017-12-22 17:20:31 +01:00
Wladimir J. van der Laan
05419aba3c Merge #8153: [rpc] fundrawtransaction feeRate: Use BTC/kB 
fa7f4f5 [rpc] fundrawtransaction feeRate: Use BTC/kB (MarcoFalke)
faf82e8 [rpc] fundrawtransaction: Fix help text and interface (MarcoFalke)
 2017-12-22 16:33:56 +01:00
Wladimir J. van der Laan
2ee817fb0d Merge #8078: Disable the mempool P2P command when bloom filters disabled 
3d3602f Add RPC test for the p2p mempool command in conjunction with disabled bloomfilters (Jonas Schnelli)
beceac9 Disable the mempool P2P command when bloom filters disabled (Peter Todd)
 2017-12-22 16:33:55 +01:00
Wladimir J. van der Laan
9af87c8269 Merge #7957: [RPC][Bitcoin-TX] Add support for sequence number 
ae357d5 [Bitcoin-Tx] Add tests for sequence number support (Jonas Schnelli)
e59336f [bitcoin-tx] allow to set nSequence number over the in= command (Jonas Schnelli)
a946bb6 [RPC] createrawtransaction: add option to set the sequence number per input (Jonas Schnelli)
 2017-12-22 16:33:55 +01:00
Wladimir J. van der Laan
c69df9b82c Merge #7967: [RPC] add feerate option to fundrawtransaction 
04eaa90 Add more clear interface for CoinControl.h regarding individual feerate (Jonas Schnelli)
3b35e48 [RPC] add feerate option to fundrawtransaction (Jonas Schnelli)
 2017-12-22 16:33:55 +01:00
MarcoFalke
af51e591b4 Merge #8139: Fix interrupted HTTP RPC connection workaround for Python 3.5+ 
f45f51e Fix interrupted HTTP RPC connection workaround for Python 3.5+ (Pieter Wuille)
 2017-12-22 16:33:55 +01:00
Alexander Block
475dbd49be Pass sys.stdout to Popen instead of subprocess.STDOUT 
For some reason, subprocess.STDOUT is completely ignored when run on
Travis. Using sys.stdout however works as expected.
 2017-12-22 08:51:30 +01:00
Wladimir J. van der Laan
a0481f1ed0 Merge #8750: [qa] Refactor RPCTestHandler to prevent TimeoutExpired 
dddd04f [qa] Refactor RPCTestHandler to prevent TimeoutExpired (MarcoFalke)
 2017-12-22 06:33:01 +01:00
Alexander Block
a1111cdf65 Dashify addresses/keys in signmessages.py RPC test 2017-12-21 20:37:17 +01:00
Alexander Block
21aaf92896 Introduce redirect_stderr argument to start_node 
Also call it with redirect_stderr=True in all cases were non-critical
warnings are expected.
 2017-12-21 20:36:54 +01:00
Alexander Block
fbe36d3db6 Pass -createwalletbackups=0 to dashd when running rpc tests 
It was always complaining about failed backups due to dashd restarting too
fast. Additionally, since the recent RPC test framework backports, all
tests are expected to print NOTHING to stderr, otherwise they fail.
 2017-12-21 20:35:32 +01:00
Alexander Block
69dd8f4a64 Python 3 fixes/porting in rpc tests 2017-12-21 20:34:07 +01:00
Alexander Block
2924b34401 Cast command to str when calling show_debug_msg 
Throws exception otherwise.
 2017-12-21 19:17:59 +01:00
MarcoFalke
0027292ac6 Merge #8104: Tests: add timeout to sync_blocks() and sync_mempools() 
e871f83 Tests: add timeout to sync_blocks() and sync_mempools() (Suhas Daftuar)
 2017-12-21 18:50:14 +01:00
MarcoFalke
7db5be442a Merge #8098: [qa] test_framework: Append portseed to tmpdir 
fa57b0c [qa] test_framework: Append portseed to tmpdir (MarcoFalke)
 2017-12-21 18:50:14 +01:00
MarcoFalke
f50b8bf669 Merge #8095: Test framework: only cleanup on successful test runs 
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)
 2017-12-21 18:50:14 +01:00
MarcoFalke
62aaaaeac0 Merge #8047: [qa] test_framework: Set wait-timeout for bitcoind procs 
fab5233 [qa] test_framework: Set wait-timeout for bitcoind procs (MarcoFalke)
 2017-12-21 18:50:13 +01:00
MarcoFalke
bcecdcd8e9 Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 
fad68f7 [qa] Reduce node count for some tests (MarcoFalke)
fac9349 [qa] Remove hardcoded "4 nodes" from test_framework (MarcoFalke)
 2017-12-21 18:50:13 +01:00
MarcoFalke
a0afc3ee01 Merge #8038: [qa, doc] Various minor fixes 
fa83a5d [qa] wallet: Temporarily disable salvagewallet test (MarcoFalke)
fadd048 [doc] Link to clang-format in the developer notes (MarcoFalke)
fa72f7d [doc] Remove outdated line from listunspent RPC help, fix typo (MarcoFalke)
ac40ed7 Increase timeout waiting for pruned blk00000.dat (error10)
 2017-12-21 18:50:13 +01:00
Wladimir J. van der Laan
f0fe21d372 Merge #8041: [qa] Fix bip9-softforks blockstore issue 
fad60b3 [qa] Fix bip9-softforks blockstore issue (MarcoFalke)
 2017-12-21 18:50:13 +01:00
MarcoFalke
f1996dc8ca Merge #7972: [qa] pull-tester: Run rpc test in parallel 
ccccc59 [qa] Add option --portseed to test_framework (MarcoFalke)
fa494de [qa] pull-tester: Run rpc test in parallel (MarcoFalke)
 2017-12-21 18:50:13 +01:00
MarcoFalke
8bafa06b75 Merge #7971: [qa] Refactor test_framework and pull tester 
fad3366 [qa] pull-tester: Adjust comment (MarcoFalke)
fafb33c [qa] Stop other nodes, even when one fails to stop (MarcoFalke)
2222dae [qa] Update README.md (MarcoFalke)
fabbf6b [qa] Refactor test_framework and pull tester (MarcoFalke)
 2017-12-21 18:50:13 +01:00
MarcoFalke
24ff341025 Merge #8018: Autofind rpc tests --srcdir 
5ea4508 Autofind rpc tests --srcdir (Jonas Schnelli)
 2017-12-21 18:50:13 +01:00
Wladimir J. van der Laan
19a6c779e7 Merge #8030: test: Revert fatal-ness of missing python-zmq 
65fee8e test: Revert fatal-ness of missing python-zmq (Wladimir J. van der Laan)
 2017-12-21 18:50:13 +01:00
Wladimir J. van der Laan
25147c9dc7 Merge #7814: [qa] Switch to py3 
fa389d4 [qa] Switch to py3 (MarcoFalke)
 2017-12-21 17:31:54 +01:00
Wladimir J. van der Laan
90b00cfc66 Merge #7953: Create signmessagewithprivkey rpc 
7db0ecb Test for signing messages (Andrew Chow)
f90efbf Create signmessagewithprivkey rpc (Andrew)
 2017-12-21 17:30:51 +01:00
Alexander Block
7d40461862 Fix failing fundrawtransaction tests 2017-12-20 21:43:27 +01:00
Alexander Block
2c63839f23 Dashify fundrawtransaction exception 
Fixes test failure
 2017-12-20 17:32:14 +01:00
Alexander Block
c3e590968d Add missing parts from bitcoin PR #7762 2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
6c7d133801 Merge #7518: Add multiple options to fundrawtransaction 
f2d0944 Add lockUnspents option to fundrawtransaction (João Barbosa)
af4fe7f Add change options to fundrawtransaction (João Barbosa)
41e835d Add strict flag to RPCTypeCheckObj (João Barbosa)
 2017-12-20 17:25:02 +01:00
Wladimir J. van der Laan
ac53190bfe Add missing changes from Bitcoin #7853 
Missed due to conflict resolution in out-of-order backports
 2017-12-20 17:24:57 +01:00
Wladimir J. van der Laan
cc3a06bf53 Merge #7863: getblockchaininfo: make bip9_softforks an object, not an array. 
d12760b rpc-tests: handle KeyError nicely in test_framework.py (Rusty Russell)
85c807c getblockchaininfo: make bip9_softforks an object, not an array. (Rusty Russell)
 2017-12-20 14:58:27 +01:00
Wladimir J. van der Laan
a8aeff143b Merge #7801: [qa] Remove misleading "errorString syntax" 
ffff866 [qa] Remove misleading "errorString syntax" (MarcoFalke)
 2017-12-20 14:45:12 +01:00
Alexander Block
f235b6a6ac Apply review suggestions/fixes 2017-12-20 07:51:20 +01:00
Wladimir J. van der Laan
e7d9ffa5d7 Merge #7774: RPC: add versionHex in getblock and getblockheader JSON results 
92107d5 RPC: add versionHex in getblock and getblockheader JSON results; expand data in getblockchaininfo bip9_softforks field. (mruddy)
 2017-12-19 13:42:36 +01:00