UdjinM6
ed712eb819
Fix nDelayGetHeadersTime (int64_t max == never delay) ( #1916 )
...
* Fix nDelayGetHeadersTime (int64_t max == never delay)
* Rewrite conditions in a more natural way i.e. (now - last_best > threshold)
2018-02-12 21:34:53 +03:00
UdjinM6
f35b5979a7
Refactor CGovernanceManager::Sync (split in two) ( #1930 )
2018-02-12 15:49:28 +03:00
UdjinM6
b5046d59c5
Dseg fixes ( #1929 )
...
* Do not filter non-upgraded mns in DSEG
Reverts #1373 , we need non-upgraded MNs to verify their old govvotes
* Split mn list/single vin logic for DSEG
This should prevent looping till the end of the list if we were asked for a single mn and a) we have it but some following `if` has failed or b) we don't have it. It also should be a bit easier to follow the logic this way.
2018-02-12 15:49:15 +03:00
UdjinM6
d5ef77ba99
Refactor: use constant refs and Ret
suffix ( #1928 )
...
* Refactor function params from `std::string` to `const std::string&`
* Refactor more function params to use const references
2018-02-12 15:49:00 +03:00
UdjinM6
3f0c8723e9
Slightly refactor AutoBackupWallet ( #1927 )
...
- make incoming strWalletFile a const reference, do not modify it directly inside the function
- follow `false false ... false true` principle
2018-02-12 15:48:48 +03:00
UdjinM6
2e04864b26
Replace boost::lexical_cast<int> with atoi ( #1926 )
...
Also cleanup existing atoi-s in Dash code
2018-02-12 15:48:35 +03:00
UdjinM6
0f4d963baf
Add DSHA256 and X11 benchmarks, refactor names of other algo benchmarks to group them together ( #1925 )
...
DSHA256 and X11 also have additional tests for data from 32 to 2048 bytes (for comparison, in steps)
2018-02-12 15:48:20 +03:00
UdjinM6
4528c735f4
Replace some instantsend/privatesend magic numbers with constants ( #1924 )
2018-02-12 15:48:09 +03:00
UdjinM6
d7f55d5083
Switch nTimeLastSuccessfulStep from GetTimeMillis() to GetTime() ( #1923 )
...
This makes PS mockable. And we don't need that much of a precision here anyway.
2018-02-12 15:47:53 +03:00
UdjinM6
204b1fe997
Drop unnecessary AcceptToMemoryPool in PS (and corresponding cs-main locks), just relay what we have ( #1922 )
2018-02-12 15:47:35 +03:00
UdjinM6
271c249e15
Skip next mn payments winners when selecting a MN to mix on ( #1921 )
2018-02-12 15:47:20 +03:00
UdjinM6
0670695fea
Move prev/next sb height logic from rpc to CSuperblock::GetNearestSuperblocksHeights ( #1919 )
2018-02-12 15:46:55 +03:00
UdjinM6
312088b560
Fix connectivity check in CActiveMasternode::ManageStateInitial ( #1918 )
2018-02-12 15:46:38 +03:00
UdjinM6
741fcbc902
Remove excessive custom validation in CProposalValidator::ValidatePaymentAddress ( #1917 )
2018-02-12 15:46:27 +03:00
Nathan Marley
354aac8d1c
rename nEpochStart variable and adjust comments ( #1915 )
...
* rename nEpochStart variable and adjust comments
* rename GetBlockStart() -> GetBlockHeight()
* change var name to nBlockHeight
2018-02-12 15:46:01 +03:00
Nathan Marley
8ea1bd0f55
remove unused method GetObjectSubtype ( #1914 )
...
I believe this was stubbed to eventually read the string in the 1st
field of the inner array in the gobject JSON. Currently only Sentinel
uses this and I would like to move to just a single JSON object, so
don't think this is necessary any longer.
2018-02-12 15:45:38 +03:00
UdjinM6
6825b347f2
Merge pull request #1911 from codablock/pr_backports_from_cmptblk
...
Backports from compact block related Bitcoin PRs
2018-02-09 13:08:03 +03:00
Wladimir J. van der Laan
4ac4e96e8f
Merge #9765 : Harden against mistakes handling invalid blocks
...
ba803ef
Harden against mistakes handling invalid blocks (Suhas Daftuar)
2018-02-08 11:18:48 +01:00
Alexander Block
662ec024ab
Make peer id logging consistent ("peer=%d" instead of "peer %d")
2018-02-08 11:18:48 +01:00
Matt Corallo
592d8f0734
Use a temp pindex to avoid a const_cast in ProcessNewBlockHeaders
2018-02-08 11:06:22 +01:00
Matt Corallo
15a8fcf993
Add a CValidationInterface::NewPoWValidBlock callback
2018-02-08 11:06:22 +01:00
Matt Corallo
d28172f57e
Call AcceptBlock with the block's shared_ptr instead of CBlock&
2018-02-08 11:06:22 +01:00
Matt Corallo
c99dd97339
[qa] Avoid race in preciousblock test.
...
If node 0 is sufficiently fast to announce its block to node 1,
node 1 might already have the block by the time the
node_sync_via_rpc loop gets around to node 1, resulting in the
submitblock result "duplicate-inconclusive" as node 1 has the block,
but prefers an alternate chain.
2018-02-08 11:06:22 +01:00
Matt Corallo
807ae74c21
Make CBlockIndex*es in net_processing const
2018-02-08 11:06:22 +01:00
Alexander Block
1d1c31052a
Fix cmd args handling for -bip9params
2018-02-08 10:40:51 +01:00
Suhas Daftuar
64817fe1d3
[qa] Fix race condition in sendheaders.py
...
Also de-duplicates code that has been moved to mininode
2018-02-08 10:40:51 +01:00
Alexander Block
b2bc780994
Fix argument to wait_until
2018-02-08 10:40:51 +01:00
Wladimir J. van der Laan
026f2e2a8c
Merge #8446 : [Trivial] BIP9 parameters on regtest cleanup
...
0fc00be
Do not shadow previous local variable (Pavel Janík)
115265b
Trivial: bip -> BIP in help text and comment (Pavel Janík)
2018-02-08 10:40:51 +01:00
Suhas Daftuar
e326bda69e
Tests: refactor compact size serialization in mininode
2018-02-08 10:40:51 +01:00
Suhas Daftuar
2c810d2c3f
Allow changing BIP9 parameters on regtest
2018-02-08 10:40:51 +01:00
Matt Corallo
45151bd131
Move context-required checks from CheckBlockHeader to Contextual...
2018-02-08 10:40:51 +01:00
Alexander Block
120893c63d
Update timeLastMempoolReq when responding to MEMPOOL request ( #1904 )
...
This should have been part of the Bitcoin #8080 backporting but was missed
due to manual conflict resolution.
2018-02-08 08:47:27 +03:00
thephez
ca89c7b870
[Trivial] Update PrivateSend denominations in comments / typo fixes ( #1910 )
2018-02-08 08:46:44 +03:00
Alexander Block
8f2c1998de
Rename vBlockHashesFromINV to vDelayedGetHeaders ( #1909 )
...
Use a name that better says what it is for.
2018-02-08 08:45:20 +03:00
UdjinM6
79e6d272ed
Merge pull request #1908 from codablock/pr_backport_bitcoin_0.14-12
...
Collection of PRs and single commits missed in previous backports
2018-02-08 08:45:02 +03:00
Alexander Block
6e022c57b1
Remove src/drafted folder ( #1907 )
...
This contained old PoC code and is unused
2018-02-08 08:44:34 +03:00
Alexander Block
0318c76ba2
Update links and references to current communication channels ( #1906 )
...
We don't really use freenode anymore. Also, it's dash.org/forum instead of
dashtalk.org today.
2018-02-08 08:44:21 +03:00
Alexander Block
4719ec477c
Remove some locking in net.h/net.cpp ( #1905 )
...
* Remove unnecessary LOCK in ConnectNode
FindNode already does the necessary lock
* Remove unnecessary semicolon
* Remove critical section and assert for ref counts in CNode
nRefCount is an atomic now and thus doesn't need locking anymore.
2018-02-08 08:44:07 +03:00
Alexander Block
bb20b4e7b5
Few cleanups after backporting ( #1903 )
...
* Remove remains of workaround that was needed while backporting
* Add missing closing round bracket to help string
* Remove now unnecessary .encode() calls in wallet.py
Now that we only support python3, we can fix this TODO.
2018-02-08 08:43:50 +03:00
Nathan Marley
3c44dde2e7
Return JSON object for masternode count (by default but still support old modes for now) ( #1900 )
...
Get information about number of masternodes (DEPRECATED options: 'total', 'ps', 'enabled', 'qualify', 'all')
2018-02-08 08:43:19 +03:00
Wladimir J. van der Laan
1086851938
Merge pull request #7166
...
6aadc75
Disconnect on mempool requests from peers when over the upload limit. (Gregory Maxwell)
2018-02-07 13:11:09 +01:00
Wladimir J. van der Laan
cef919f182
Merge #9486 : Make peer=%d log prints consistent
...
e6111b2
Make peer id logging consistent ("peer=%d" instead of "peer %d") (Matt Corallo)
2018-02-07 13:11:09 +01:00
Russell Yanofsky
55ef4d0a9b
[wallet] Add include_unsafe argument to listunspent RPC
2018-02-07 13:11:09 +01:00
Suhas Daftuar
e1e03f42c4
[wallet] Add IsAllFromMe: true if all inputs are from wallet
2018-02-07 13:11:08 +01:00
Wladimir J. van der Laan
611b31ecea
Merge #9650 : Better handle invalid parameters to signrawtransaction
...
6dbfe08
[qa] test signrawtransaction merge with missing inputs (Matt Corallo)
ec4f7e4
[qa] Add second input to signrawtransaction test case (Matt Corallo)
691710a
[qa] Test that decoderawtransaction throws with extra data appended (Matt Corallo)
922bea9
Better handle invalid parameters to signrawtransaction (Matt Corallo)
7ea0ad5
Fail in DecodeHexTx if there is extra data at the end (Matt Corallo)
2018-02-07 13:11:08 +01:00
MarcoFalke
ff335e47fd
[qa] test_framework: Add wrapper for stop_node
2018-02-07 13:11:08 +01:00
Alexander Block
64e1bfacdc
Add BIP32 to bips.md
2018-02-07 10:50:13 +01:00
Wladimir J. van der Laan
4bb2af8d19
Merge #9114 : [depends] Set OSX_MIN_VERSION to 10.8
...
617c96d
[depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
2018-02-07 10:47:44 +01:00
UdjinM6
9f2467af8a
Hide autocompleter on Enter/Return key ( #1898 )
2018-02-06 20:24:37 +03:00
UdjinM6
a7fa07a30e
Drop BOOST_FOREACH and use references in loops (const ref where applicable, Dash code only) ( #1899 )
...
* Drop BOOST_FOREACH in Dash-specific code (only), no changes in behavior
* Use references in loops (use const references where applicable) in Dash-specific code (only)
And adjust related code to make it compilable.
* Loop through nodes via connman.ForEachNode in dsq Relay instead of creating a copy
2018-02-06 14:09:33 +03:00