Wladimir J. van der Laan
9958e09dbc
Revert "Now that send coins / receive coins etc are tabs, remove them from menu, and reorganize menu bar"
...
This reverts commit ea37fb9187
.
2011-07-16 19:28:15 +02:00
Wladimir J. van der Laan
a5e6d72339
add sendmany support
2011-07-16 19:25:02 +02:00
Eric Hosmer
88cab1e4a3
Added crypter to makefile.vc.
2011-07-15 23:38:46 -04:00
Wladimir J. van der Laan
d421117620
Merge branch 'master' of https://github.com/bitcoin/bitcoin
2011-07-15 16:42:44 +02:00
Wladimir J. van der Laan
19366be186
Merge remote-tracking branch 'satoshi/qtui'
...
Conflicts (resolved by copying files from remote branch):
.gitignore
src/cryptopp/cpu.cpp
src/cryptopp/cpu.h
src/cryptopp/cryptlib.h
src/cryptopp/iterhash.h
src/cryptopp/misc.h
src/cryptopp/secblock.h
src/cryptopp/sha.cpp
src/cryptopp/sha.h
src/cryptopp/smartptr.h
src/json/json_spirit_reader.cpp
src/json/json_spirit_value.cpp
src/json/json_spirit_writer.cpp
2011-07-15 15:12:17 +02:00
Wladimir J. van der Laan
a35ee96336
Add call to request unconfirmed balance
2011-07-15 15:09:49 +02:00
Wladimir J. van der Laan
ea37fb9187
Now that send coins / receive coins etc are tabs, remove them from menu, and reorganize menu bar
2011-07-15 14:55:21 +02:00
Celil
608810a3e7
Fix error when export is cancelled without specifying a filename.
2011-07-14 17:11:11 -07:00
Wladimir J. van der Laan
77b615ceba
solve warnings at startup
2011-07-14 21:21:17 +02:00
Matt Corallo
3a10d1c493
Fix bad return values in LoadWallet.
2011-07-14 18:15:50 +02:00
Pieter Wuille
24271c542b
Merge pull request #412 from sgimenez/db-transactions
...
Single DB transactions
2011-07-14 05:29:09 -07:00
Stéphane Gimenez
d655a26c9d
Single DB transaction for addresses from DNS seeds
2011-07-14 03:50:06 +02:00
Matt Corallo
a2606bad09
Fix Build in GetReservedKey() in wallet.cpp
2011-07-14 03:34:07 +02:00
Patrick Varilly
8c41469140
Single DB transaction for all addresses in a message
...
Cuts disk activity at startup immensely
2011-07-14 03:29:07 +02:00
Matt Corallo
cee69980b0
Generate Warning when using default key.
2011-07-14 03:28:31 +02:00
Matt Corallo
0d7b28e52e
Fix crashes when a wallet is locked and GetReservedKey() is called
2011-07-14 03:11:40 +02:00
Jeff Garzik
9cd22ab862
Merge pull request #406 from muggenhor/warning-fixes
...
Warning fixes
2011-07-13 08:55:49 -07:00
Jeff Garzik
b8cbbc2c28
Merge pull request #405 from sipa/syncdefault
...
Bugfix: add autogenerated addresses to address book
2011-07-13 08:53:57 -07:00
Giel van Schijndel
84c3c2ebe7
fix warning: control reaches end of non-void function [-Wreturn-type]
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 14:25:45 +02:00
Giel van Schijndel
93752b8a39
fix warning: variable ‘nMinDepth’ set but not used [-Wunused-but-set-variable]
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 13:43:24 +02:00
Matt Corallo
d5e9d0000d
Fix makefile.linux-mingw
2011-07-13 13:12:49 +02:00
Pieter Wuille
d5115a71a1
Bugfix: add autogenerated addresses to address book
2011-07-13 13:05:08 +02:00
Jeff Garzik
24a0def8cd
Bump version to 0.3.25
...
Yes, we might release as v0.4, but let's just do a simple increment
for now.
2011-07-13 01:19:26 -04:00
Jeff Garzik
116df55e21
Update CWallet::LoadWallet for proper return type.
2011-07-13 01:07:49 -04:00
Giel van Schijndel
d0538a81bb
fix warning: unused function 'SigIllHandlerSSE2' [-Wunused-function]
...
Only declare & define SigIllHandlerSSE2 when its used.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:10:15 +02:00
Giel van Schijndel
858cebed7d
fix warning: unused variable 'X' [-Wunused-variable]
...
Remove several unused variables.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:10:15 +02:00
Giel van Schijndel
225f222c9f
fix warning: X enumeration values not handled in switch [-Wswitch-enum]
...
Add default cases to opcode switches to assert that they should never
occur.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:10:15 +02:00
Giel van Schijndel
d7f1d200ab
fix warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
...
Don't check for a negative parameter count, because not only will it
never happen, it doesn't make any sense either.
Invalid sockets (as returned by socket(2)) are always exactly -1 (not
just negative as negative file descriptors are technically not
prohibited by POSIX) on POSIX systems. Since we store them in SOCKET
(unsigned int), however, that really is ~0U (or MAX_UINT) which happens
to be what INVALID_SOCKET is already defined to, so an additional check
for being negative is not only unnecessary (unsigned integers aren't
*ever* negative) its redundant as well (the INVALID_SOCKET comparison is
enough).
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:07:44 +02:00
Giel van Schijndel
f85c097449
fix warnings: using the result of an assignment as a condition without parentheses [-Wparentheses]
...
Don't unnecessarily assign to variables within the *boolean* expression
of a conditional.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:07:44 +02:00
Giel van Schijndel
ecf1c79aad
fix warnings: expression result unused [-Wunused-value]
...
In the assert()s take advantage of the fact that string constants
("string") are effectively of type 'const char []', which when used in
an expression yield a non-NULL pointer.
An assertion that should always fail can thus be formulated as:
assert(!"fail);
An assertion where a text message should be added to the expression can
be written as such:
assert("message" && expression);
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:07:44 +02:00
Giel van Schijndel
df40181417
fix warning on 64bit systems: cast to pointer from integer of different size [-Wint-to-pointer-cast]
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-07-13 05:07:44 +02:00
Matt Corallo
0ca8324f59
Update makefile.linux-mingw to work with crypter and UPnP fix.
2011-07-12 22:44:00 -04:00
Jeff Garzik
0fa89d8e81
Merge pull request #381 from TheBlueMatt/nminversion
...
Add minversion to wallet.
2011-07-12 19:34:30 -07:00
Jeff Garzik
0bad8e4237
Merge pull request #352 from TheBlueMatt/newenc
...
Wallet Private Key Encryption (on CWallet)
2011-07-12 19:10:12 -07:00
Matt Corallo
7414733bea
Make an invalid addrIncoming so that old clients crash.
...
This prevents old clients from opening, and thus corrupting
or otherwise causing harm to encrypted wallets.
2011-07-13 02:11:25 +02:00
Matt Corallo
96f34cd5c4
Use DB Transactions when encrypting wallet.
...
This speeds up the encryption process significantly.
2011-07-13 02:11:25 +02:00
Pieter Wuille
0efda1a79e
Do not use obsolete CPrivKey for passing keys around
2011-07-13 02:11:25 +02:00
Matt Corallo
fbeb5fb483
Add the walletlock RPC method to lock the wallet manually.
2011-07-13 02:11:25 +02:00
Matt Corallo
81598083e7
Dynamically remove/insert the Options for encryption in the menus.
2011-07-13 02:11:25 +02:00
Matt Corallo
98545d2cdf
Push unlocked_until in getinfo.
2011-07-13 02:11:25 +02:00
Matt Corallo
ddebdd9a8f
Set the number of SHA512 rounds based on the speed of the computer.
2011-07-13 02:11:25 +02:00
Matt Corallo
4e87d341f7
Add wallet privkey encryption.
...
This commit adds support for ckeys, or enCrypted private keys, to the wallet.
All keys are stored in memory in their encrypted form and thus the passphrase
is required from the user to spend coins, or to create new addresses.
Keys are encrypted with AES-256-CBC using OpenSSL's EVP library. The key is
calculated via EVP_BytesToKey using SHA512 with (by default) 25000 rounds and
a random salt.
By default, the user's wallet remains unencrypted until they call the RPC
command encryptwallet <passphrase> or, from the GUI menu, Options->
Encrypt Wallet.
When the user is attempting to call RPC functions which require the password
to unlock the wallet, an error will be returned unless they call
walletpassphrase <passphrase> <time to keep key in memory> first.
A keypoolrefill command has been added which tops up the users keypool
(requiring the passphrase via walletpassphrase first).
keypoolsize has been added to the output of getinfo to show the user the
number of keys left before they need to specify their passphrase (and call
keypoolrefill).
Note that walletpassphrase will automatically fill keypool in a separate
thread which it spawns when the passphrase is set. This could cause some
delays in other threads waiting for locks on the wallet passphrase, including
one which could cause the passphrase to be stored longer than expected,
however it will not allow the passphrase to be used longer than expected as
ThreadCleanWalletPassphrase will attempt to get a lock on the key as soon
as the specified lock time has arrived.
When the keypool runs out (and wallet is locked) GetOrReuseKeyFromPool
returns vchDefaultKey, meaning miners may start to generate many blocks to
vchDefaultKey instead of a new key each time.
A walletpassphrasechange <oldpassphrase> <newpassphrase> has been added to
allow the user to change their password via RPC.
Whenever keying material (unencrypted private keys, the user's passphrase,
the wallet's AES key) is stored unencrypted in memory, any reasonable attempt
is made to mlock/VirtualLock that memory before storing the keying material.
This is not true in several (commented) cases where mlock/VirtualLocking the
memory is not possible.
Although encryption of private keys in memory can be very useful on desktop
systems (as some small amount of protection against stupid viruses), on an
RPC server, the password is entered fairly insecurely. Thus, the only main
advantage encryption has for RPC servers is for RPC servers that do not spend
coins, except in rare cases, eg. a webserver of a merchant which only receives
payment except for cases of manual intervention.
Thanks to jgarzik for the original patch and sipa, gmaxwell and many others
for all their input.
Conflicts:
src/wallet.cpp
2011-07-13 02:11:25 +02:00
Wladimir J. van der Laan
4a843976e0
also show balloon on sent transaction, to notify when coins sent
2011-07-11 21:01:53 +02:00
Wladimir J. van der Laan
df5ccbd2b2
Show unconfirmed balance on overview page
2011-07-11 20:42:10 +02:00
Wladimir J. van der Laan
eee0d2391c
Make tooltip on refresh more clear
2011-07-11 19:35:08 +02:00
Doug Huff
a48c671957
Make mlock() and munlock() portable to systems that require the address to be on a page boundary.
2011-07-10 18:15:05 +02:00
Wladimir J. van der Laan
c87cdc9160
wxp/mingw build fixes
2011-07-09 15:58:05 +02:00
Wladimir J. van der Laan
0b814f9ea3
add better windows7/vista look by nico_w
2011-07-09 15:26:57 +02:00
Wladimir J. van der Laan
7668631d1b
remove placeholder text from ui form, code generator screws up on older qt
2011-07-09 14:00:00 +02:00
Wladimir J. van der Laan
f54d59ba4a
add export functionality for address book / receiving addresses
2011-07-09 10:54:17 +02:00
Wladimir J. van der Laan
2eace48d9a
remove magic number: change threshold for nLockTime to constant
2011-07-09 10:30:23 +02:00
Wladimir J. van der Laan
fa989f42c1
remove magic number: change threshold for nLockTime to constant
2011-07-09 10:25:12 +02:00
Wladimir J. van der Laan
aa496b75c2
remove magic number: change threshold for nLockTime to constant
2011-07-09 10:11:28 +02:00
Wladimir J. van der Laan
51d7cc07f1
Add context menu on transaction list: copy label, copy address, edit label, show details
2011-07-08 22:27:36 +02:00
Wladimir J. van der Laan
35105534e7
Transaction list: less terse tooltip
2011-07-08 19:56:28 +02:00
Wladimir J. van der Laan
3ddf10e5ca
send coins dialog: make sure send button remain default button (triggered with enter)
2011-07-08 19:51:24 +02:00
Wladimir J. van der Laan
83b8237046
forgot synced icons
2011-07-08 19:25:35 +02:00
Wladimir J. van der Laan
d8aeb8dd2a
Reorganize "send coins" tab
2011-07-08 19:09:13 +02:00
Wladimir J. van der Laan
84c8506e90
Display a "freshness" indicator instead of nr of blocks
2011-07-08 18:05:23 +02:00
Dylan Noblesmith
c1aacf0be3
mlock() all private keys in memory
...
Inline comment and idea come from the encprivkeys branch
by Matt Corallo <matt@bluematt.me>.
2011-07-08 15:46:47 +02:00
Pieter Wuille
acd6501610
Prepare codebase for Encrypted Keys.
2011-07-08 15:46:47 +02:00
Wladimir J. van der Laan
610121480c
"Status" doesn't fit into narrow first column in transaction history, make the header empty
2011-07-07 21:25:17 +02:00
Wladimir J. van der Laan
ba3d0255fc
Add German translation by nico_w
2011-07-07 21:19:25 +02:00
Wladimir J. van der Laan
0002bdddfa
add [testnet] to whatever the current window title is
2011-07-07 18:38:37 +02:00
Wladimir J. van der Laan
94fe42a945
Selection/tab navigation fixes
2011-07-07 18:25:27 +02:00
Wladimir J. van der Laan
3479849dc4
convert to full tab-based ui
2011-07-07 17:33:15 +02:00
Wladimir J. van der Laan
5eaa1b435c
Qt handles the "..." for too long table rows. Remove this functionality from TransactionTableModel...
2011-07-07 16:57:19 +02:00
Wladimir J. van der Laan
ae3d0aba15
Sync to bitcoin git e94010b239
2011-07-07 15:22:54 +02:00
Wladimir J. van der Laan
42c405ad23
temp patch for qtui
2011-07-07 15:18:35 +02:00
Wladimir J. van der Laan
33c75fd9aa
CKeyStore::AddKey must return a boolean
2011-07-07 15:16:26 +02:00
Wladimir J. van der Laan
fbaee7a853
Export functionality for transaction list
2011-07-07 14:27:16 +02:00
Wladimir J. van der Laan
d52a0f3bca
Rename "History" tab to more logical "Transactions", move "Number of transactions" from status bar to overview page
2011-07-07 10:59:00 +02:00
Wladimir J. van der Laan
fac047480d
minor language/text updates
2011-07-07 10:43:04 +02:00
Wladimir J. van der Laan
e599246803
Improve view of generated transactions (show clock icon when still maturing)
2011-07-07 10:29:07 +02:00
Wladimir J. van der Laan
393adf7acd
Address book: Disable "copy to clipboard" and "Delete" buttons when nothing selected
2011-07-06 21:52:23 +02:00
Wladimir J. van der Laan
8bca4099c7
Remove code for no longer existing edit button in address book dialog
2011-07-06 20:52:31 +02:00
Wladimir J. van der Laan
e1f3d64c4a
Add "BTC" to all amount widgets, to make clear what the unit is
2011-07-06 20:41:13 +02:00
Wladimir J. van der Laan
64c8b69948
tab reorg phase 1: split main gui into "overview" and "history"
2011-07-05 22:09:39 +02:00
Jeff Garzik
e94010b239
Merge pull request #383 from sipa/syncdefault
...
Fix synchronization of default key
2011-07-05 11:52:13 -07:00
Wladimir J. van der Laan
825aa7d8d8
make balance selectable / copyable
2011-07-05 20:21:33 +02:00
Matt Corallo
7ec552676c
Add minversion to wallet.
2011-07-05 18:36:01 +02:00
Matt Corallo
3f0950ea01
Revert "Make UPnP default on Bitcoin but not on Bitcoind."
...
This reverts commit ee1f884229
.
Stupid, stupid me...there is exactly 0 way to convince make to
execute a conditional based on a target-specific variable.
2011-07-05 18:19:34 +02:00
Pieter Wuille
e9f61c8787
Fix synchronization of default key
2011-07-05 17:42:44 +02:00
Gavin Andresen
9390431ce4
Merge pull request #379 from gavinandresen/nocommas
...
Do not use comma as thousands separator
2011-07-04 19:26:10 -07:00
Matt Corallo
fa105b1d3a
Added a couple minor things to match newer build process.
...
This adds the relevent patches which are applied to wx,
and updates for cross compiling.
2011-07-05 00:59:00 +02:00
Wladimir J. van der Laan
b8f174a5ce
as there is no "default receiving address" in this GUI, don't autogenerate new addresses on receiving
2011-07-04 20:12:58 +02:00
Gavin Andresen
59f9c8e8c9
Do not use comma as thousands separator
...
Using the comma as thousands separator causes problems for parts of the world
where comma == decimal point. Germans sending 0,001 bitcoins are unpleasantly
surprised when that results in 1 BTC getting sent.
2011-07-04 09:41:58 -04:00
Wladimir J. van der Laan
3913c387c9
Eliminate useless padding
2011-07-03 22:29:26 +02:00
Wladimir J. van der Laan
8fe2308b34
windows build fixes
2011-07-03 22:29:26 +02:00
Gavin Andresen
d547a44332
Block-chain lock-in at 134444
2011-07-03 11:20:39 -04:00
Wladimir J. van der Laan
482e57812b
move another setPlaceHolderText to 4.7+ only code
2011-07-03 08:24:07 +02:00
Jeff Garzik
b4b536d782
Bump version to 0.3.24.
2011-07-02 16:55:11 -04:00
Jeff Garzik
a76899624a
Merge branch 'tmp2' into tmp3
2011-07-02 16:46:07 -04:00
Jeff Garzik
1a19fc17b2
Merge pull request #374 from TheBlueMatt/neterror
...
Give more detailed error messages for connection failure.
2011-07-02 12:04:09 -07:00
Wladimir J. van der Laan
ecde936aee
remove "edit" button, document double-click behaviour to edit
2011-07-02 18:30:41 +02:00
Wladimir J. van der Laan
154e25ff60
ui improvements: allow inline editing of labels/addresses in address book table, better tab order in send dialog, set focus on sending address table when coming from send coins dialog
2011-07-02 17:31:27 +02:00
Wladimir J. van der Laan
c1ffa5b1c5
make tooltip equal to placeholder
2011-07-02 15:42:12 +02:00
Wladimir J. van der Laan
669b0a5835
Check addresses in address book for validity
2011-07-02 15:11:40 +02:00
Wladimir J. van der Laan
ebff5c40a2
Send: dialog redesign (automatically look up label for entered address)
2011-07-02 13:45:59 +02:00
Matt Corallo
013df1cc3b
Give more detailed error messages for connection failure.
2011-07-02 13:25:18 +02:00