Cory Fields
89f71c68c0
c++11: don't throw from the reverselock destructor
...
noexcept is default for destructors as of c++11. By throwing in reverselock's
destructor if it's lock has been tampered with, the likely result is
std::terminate being called. Indeed that happened before this change.
Once reverselock has taken another lock (its ctor didn't throw), it makes no
sense to try to grab or lock the parent lock. That is be broken/undefined
behavior depending on the parent lock's implementation, but it shouldn't cause
the reverselock to fail to re-lock when destroyed.
To avoid those problems, simply swap the parent lock's contents with a dummy
for the duration of the lock. That will ensure that any undefined behavior is
caught at the call-site rather than the reverse lock's destruction.
Barring a failed mutex unlock which would be indicative of a larger problem,
the destructor should now never throw.
2016-01-05 17:17:29 -05:00
Cory Fields
76ac35f36d
c++11: detect and correct for boost builds with an incompatible abi
...
This is ugly, but temporary. boost::filesystem will likely be dropped soon
after c++11 is enabled. Otherwise, we could simply roll our own copy_file. I've
fixed this at the buildsystem level for now in order to avoid mixing in
functional changes.
Explanation:
If boost (prior to 1.57) was built without c++11, it emulated scoped enums
using c++98 constructs. Unfortunately, this implementation detail leaked into
the abi. This was fixed in 1.57.
When building against that installed version using c++11, the headers pick up
on the native c++11 scoped enum support and enable it, however it will fail to
link. This can be worked around by disabling c++11 scoped enums if linking will
fail.
Add an autoconf test to determine incompatibility. At build-time, if native
enums are being used (a c++11 build), and force-disabling them causes a
successful link, we can be sure that there's an incompatibility and enable the
work-around.
2016-01-05 17:17:29 -05:00
Murch
96efcadfc0
Improved readability of sorting for coin selection.
...
Future proofing added lines
2016-01-05 22:03:43 +01:00
MarcoFalke
faf538bfdb
[trivial] Merge test cases and replace CENT with COIN
2016-01-05 20:36:03 +01:00
MarcoFalke
faf3299b73
[qt] Intro: Display required space
...
Required space depends on the user's choice:
-prune=0
-prune=<n>
2016-01-05 19:22:47 +01:00
Alex Morcos
e420a1b15e
Add sane fallback for fee estimation
...
Add new commandline option "-fallbackfee" to use when fee estimation does not have sufficient data.
2016-01-05 13:13:23 -05:00
Alex Morcos
995b9f385b
Always respect GetRequiredFee for wallet txs
2016-01-05 13:10:19 -05:00
Wladimir J. van der Laan
605c17844e
Merge pull request #7205
...
fa71669fa24439fa6ad85
2016-01-05 14:11:40 +01:00
Jonas Schnelli
aa413687de
Merge pull request #7282
...
621bd69
2016-01-05 13:02:00 +01:00
Wladimir J. van der Laan
2078495d9c
Merge pull request #7193
...
fafd093
2016-01-05 12:55:00 +01:00
Wladimir J. van der Laan
a10a7920c3
Merge pull request #7217
...
5246180
2016-01-05 12:04:53 +01:00
MarcoFalke
fa3c7e644f
[wallet] Add regression test for vValue sort order
2016-01-05 00:40:20 +01:00
MarcoFalke
fada0c90b6
[travis] Fail when documentation is outdated
2016-01-04 19:24:07 +01:00
Wladimir J. van der Laan
45d13abf4e
Merge pull request #7253
...
0d59589
2016-01-04 12:00:36 +01:00
Wladimir J. van der Laan
49a735cba4
Merge pull request #7250
...
fa0a974
2016-01-04 11:58:12 +01:00
Wladimir J. van der Laan
ac982a16e0
Merge pull request #7263
...
a5a0831
2016-01-04 10:17:09 +01:00
Wladimir J. van der Laan
c173013821
Merge pull request #7274
...
fa6ce44fae7a36
2016-01-04 10:04:11 +01:00
Wladimir J. van der Laan
136abda597
qt: periodic translations pull from transifex
2016-01-04 09:48:44 +01:00
Jonas Schnelli
621bd6919f
[Qt] fix coincontrol update issue when deleting a send coin entry
2016-01-04 09:44:36 +01:00
Wladimir J. van der Laan
eb2b74526a
Merge pull request #7251
...
fa09562
2016-01-04 09:29:58 +01:00
Jonas Schnelli
e289807e5a
Merge pull request #7255
...
6fd0a075fdf32d
2016-01-04 09:23:38 +01:00
Wladimir J. van der Laan
08ab9069af
Merge pull request #7256
...
33877ed
2016-01-04 09:21:35 +01:00
Wladimir J. van der Laan
d032b5b64b
Merge pull request #7276
...
7ef8f3c
2016-01-04 09:10:31 +01:00
Peter Todd
fd836153d5
Improve CheckInputs() comment about sig verification
2016-01-03 20:39:05 -08:00
Pieter Wuille
7ef8f3c072
Report non-mandatory script failures correctly
2016-01-03 16:50:31 +01:00
MarcoFalke
fa6ce44bf9
[debian] Update bitcoind manpage description
...
Update the description to match that description in
the main bitcoin README.md
2016-01-03 16:01:42 +01:00
MarcoFalke
fae7a369cb
[debian] Bump manpages and only mention -?
...
The manpages are outdated and are very rarely updated when changes
to the code happen.
2016-01-03 16:01:32 +01:00
fanquake
6fd0a079d8
Remove hardcoded fee from CoinControl ToolTip
2016-01-03 05:57:51 +08:00
MarcoFalke
fa095622c2
[gitian] Set reference date to something more recent
2016-01-02 18:11:49 +01:00
fanquake
33877ed3b8
Add note to CoinControl Dialog workaround
2016-01-02 17:35:33 +08:00
Marcel Krüger
6cd198f380
Removed comment about IsStandard for P2SH scripts
...
Since #4365 (6259937388
2015-12-30 21:53:40 +01:00
21E14
a5a0831458
Double semicolon cleanup.
2015-12-30 12:23:07 -05:00
Chris Moore
2409865e14
Reduce inefficiency of GetAccountAddress()
...
Don't scan the wallet to see if the current key has been used if we're going to make a new key anyway.
Stop scanning the wallet as soon as we see that the current key has been used.
Don't call isValid() twice on the current key.
2015-12-28 16:56:53 -08:00
MarcoFalke
fa71669452
[devtools] Use git pretty-format for year parsing
2015-12-26 17:53:42 +01:00
Luke Dashjr
5e109225ae
Combine common error strings for different options so translations can be shared and reused
2015-12-26 08:04:03 +00:00
fanquake
5fdf32de7e
Replace some instances of formatWithUnit with formatHtmlWithUnit
...
Strings in a HTML context should be using formatHtmlWithUnit.
2015-12-26 11:49:19 +08:00
Luke Dashjr
0d595894f0
Bugfix: update-translations: Allow numerus translations to omit %n specifier (usually when it only has one possible value)
2015-12-25 13:15:01 +00:00
MarcoFalke
fa0a9749eb
[qa] Move gen_return_txouts() to util.py
2015-12-24 12:26:36 +01:00
Jonas Schnelli
be9a9a3d22
Merge pull request #7214
...
fa2f4bc
2015-12-23 10:13:00 +01:00
Wladimir J. van der Laan
97d83739db
Merge pull request #7153
...
7632cf6110ff11
2015-12-22 14:06:50 +01:00
Jonas Schnelli
a1c185be54
Merge pull request #7218
...
fa5769efa8c8d7
2015-12-22 14:05:39 +01:00
Wladimir J. van der Laan
595f93977c
Merge pull request #7213
...
37d271d
2015-12-22 11:37:11 +01:00
Wladimir J. van der Laan
ed095f0407
Merge pull request #7226
...
9b41a5f
2015-12-22 09:54:27 +01:00
Wladimir J. van der Laan
c24337964f
Merge pull request #7062
...
901b01d27fae349ef2a25eb30666
2015-12-21 17:14:13 +01:00
Tom Harding
e279038e84
Use createrawtx locktime parm in txn_clone
...
Streamlines the test and serves as a test of the createrawtransaction
locktime parameter.
2015-12-20 15:41:20 -08:00
MarcoFalke
fa33d9740c
[walletdb] Add missing LOCK() in Recover() for dummyWallet
2015-12-19 14:26:46 +01:00
MarcoFalke
fa14d99484
[qa] check if wallet or blochchain maintenance changes the balance
2015-12-18 12:37:29 +01:00
MarcoFalke
fa0765d433
[qa] Cleanup wallet.py test
...
* Remove outdated comment
* Remove unneeded 0s
* Remove semicolons
2015-12-18 12:37:08 +01:00
Suhas Daftuar
9b41a5fba2
Add more tests to p2p-fullblocktest
2015-12-18 05:39:31 -05:00
Wladimir J. van der Laan
8ea5ef1d39
Merge pull request #6980
...
e0769e123a3c4710d3c7726f8ea517ad9649e940fa
2015-12-18 09:24:59 +01:00
