mirror of
https://github.com/dashpay/dash.git
synced 2024-12-24 11:32:46 +01:00
Compare commits
6 Commits
00c95757bd
...
8c7a970a67
Author | SHA1 | Date | |
---|---|---|---|
|
8c7a970a67 | ||
|
ad7a373529 | ||
|
d75ee3a9e1 | ||
|
f18b4e8ca9 | ||
|
7a32a409c0 | ||
|
fdd86b1b25 |
4
doc/release-notes-5772.md
Normal file
4
doc/release-notes-5772.md
Normal file
@ -0,0 +1,4 @@
|
||||
RPC changes
|
||||
-----------
|
||||
|
||||
`quorum getdata` RPC will no longer allow `proTxHash` to be specified when `dataMask` is set to `1`.
|
@ -86,10 +86,10 @@ likely require a reindex.
|
||||
- **glibc Requirement**
|
||||
- The minimum required glibc to run Dash Core is now **2.31**. This means that **RHEL 8** and **Ubuntu 18.04 (Bionic)** are no longer supported.
|
||||
|
||||
## New RPCs
|
||||
- **FreeBSD Improvements**
|
||||
- Fixed issues with building Dash Core on FreeBSD.
|
||||
|
||||
- **`quorum platformsign`**
|
||||
- A new subcommand has been introduced, offering a structured way to perform platform-related quorum signing operations.
|
||||
## New RPCs
|
||||
|
||||
- **`coinjoinsalt`**
|
||||
- Allows manipulation of a CoinJoin salt stored in a wallet.
|
||||
@ -153,7 +153,7 @@ likely require a reindex.
|
||||
## Devnet Breaking Changes
|
||||
|
||||
- **Hardfork Activation Changes**
|
||||
- `BRR` (`realloc`), `DIP0020`, `DIP0024`, `V19`, `V20`, and `MN_R` hardforks are now activated at **block 2** instead of block **300** on devnets.
|
||||
- `BRR` (`realloc`), `DIP0020`, `DIP0024`, `V19`, `V20`, and `MN_RR` hardforks are now activated at **block 2** instead of block **300** on devnets.
|
||||
- **Implications:**
|
||||
- Breaking change.
|
||||
- Inability to sync on devnets created with earlier Dash Core versions and vice versa.
|
||||
|
@ -235,7 +235,7 @@ Remote Procedure Calls (RPCs)
|
||||
support for coin selection and a custom fee rate. The `send` RPC is experimental
|
||||
and may change in subsequent releases. Using it is encouraged once it's no
|
||||
longer experimental: `sendmany` and `sendtoaddress` may be deprecated in a future release.
|
||||
- A new `quorum signplatform` RPC is added for Platform needs. This composite command limits Platform to only request signatures from the Platform quorum type. It is equivalent to `quorum sign <platform type>`.
|
||||
- A new `quorum platformsign` RPC is added for Platform needs. This composite command limits Platform to only request signatures from the Platform quorum type. It is equivalent to `quorum sign <platform type>`.
|
||||
|
||||
### RPC changes
|
||||
- `createwallet` has an updated argument list: `createwallet "wallet_name" ( disable_private_keys blank "passphrase" avoid_reuse descriptors load_on_startup )`
|
||||
|
@ -802,8 +802,8 @@ static RPCHelpMan quorum_getdata()
|
||||
uint16_t nDataMask = static_cast<uint16_t>(ParseInt32V(request.params[3], "dataMask"));
|
||||
uint256 proTxHash;
|
||||
|
||||
// Check if request wants ENCRYPTED_CONTRIBUTIONS data
|
||||
if (nDataMask & llmq::CQuorumDataRequest::ENCRYPTED_CONTRIBUTIONS) {
|
||||
// Require proTxHash if request wants ENCRYPTED_CONTRIBUTIONS data
|
||||
if (!request.params[4].isNull()) {
|
||||
proTxHash = ParseHashV(request.params[4], "proTxHash");
|
||||
if (proTxHash.IsNull()) {
|
||||
@ -812,6 +812,9 @@ static RPCHelpMan quorum_getdata()
|
||||
} else {
|
||||
throw JSONRPCError(RPC_INVALID_PARAMETER, "proTxHash missing");
|
||||
}
|
||||
} else if (!request.params[4].isNull()) {
|
||||
// Require no proTxHash otherwise
|
||||
throw JSONRPCError(RPC_INVALID_PARAMETER, "Should not specify proTxHash");
|
||||
}
|
||||
|
||||
const auto quorum = llmq_ctx.qman->GetQuorum(llmqType, quorumHash);
|
||||
|
@ -394,6 +394,8 @@ class QuorumDataMessagesTest(DashTestFramework):
|
||||
|
||||
def test_rpc_quorum_getdata_protx_hash():
|
||||
self.log.info("Test optional proTxHash of `quorum getdata`")
|
||||
assert_raises_rpc_error(-8, "Should not specify proTxHash",
|
||||
mn1.node.quorum, "getdata", 0, 100, quorum_hash, 0x01, mn1.proTxHash)
|
||||
assert_raises_rpc_error(-8, "proTxHash missing",
|
||||
mn1.node.quorum, "getdata", 0, 100, quorum_hash, 0x02)
|
||||
assert_raises_rpc_error(-8, "proTxHash invalid",
|
||||
|
Loading…
Reference in New Issue
Block a user