mirror of
https://github.com/dashpay/dash.git
synced 2024-12-24 11:32:46 +01:00
3931608858
08634e82c68ea1be79e1395f4f551082f497023f fix typos in logging messages (ShubhamPalriwala) d447ded6babebe7c7948e585c9e78bf34dbef226 replace: self.nodes[0] with node (ShubhamPalriwala) dddca3899c4738e512313a85aeb006310e34e31f test: use MiniWallet in mempool_limit.py (ShubhamPalriwala) Pull request description: This is a PR proposed in #20078 This PR enables running another non-wallet functional test even when the wallet is disabled thanks to the MiniWallet, i.e. it can be run even when bitcoin-core is compiled with --disable-wallet. It also includes changes in wallet.py in the form of a new method, `create_large_transactions()` for the MiniWallet to create large transactions. Efforts for this feature started in #20874 but were not continued and that PR was closed hence I picked this up. To test this PR locally, compile and build bitcoin-core without the wallet and run: ``` $ test/functional/mempool_limit.py ``` ACKs for top commit: amitiuttarwar: ACK 08634e8, only git changes since last push (and one new line). Zero-1729: ACK 08634e82c68ea1be79e1395f4f551082f497023f 🧉 Tree-SHA512: 0f744ad26bf7a5a784aac1ed5077b59c95a36d1ff3ad0087ffd10ac8d5979f7362c63c20c2ce2bfa650fda02dfbcd60b1fceee049a2465c8d221cce51c20369f
82 lines
3.9 KiB
Python
Executable File
82 lines
3.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test mempool limiting together/eviction with the wallet."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.blocktools import COINBASE_MATURITY
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_greater_than, assert_raises_rpc_error, gen_return_txouts
|
|
from test_framework.wallet import MiniWallet
|
|
|
|
|
|
class MempoolLimitTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [[
|
|
"-acceptnonstdtxn=1",
|
|
"-maxmempool=5",
|
|
"-spendzeroconfchange=0",
|
|
]]
|
|
self.supports_cli = False
|
|
|
|
def send_large_txs(self, node, miniwallet, txouts, fee_rate, tx_batch_size):
|
|
for _ in range(tx_batch_size):
|
|
tx = miniwallet.create_self_transfer(from_node=node, fee_rate=fee_rate)['tx']
|
|
for txout in txouts:
|
|
tx.vout.append(txout)
|
|
miniwallet.sendrawtransaction(from_node=node, tx_hex=tx.serialize().hex())
|
|
|
|
def run_test(self):
|
|
txouts = gen_return_txouts()
|
|
node=self.nodes[0]
|
|
miniwallet = MiniWallet(node)
|
|
relayfee = node.getnetworkinfo()['relayfee']
|
|
|
|
self.log.info('Check that mempoolminfee is minrelaytxfee')
|
|
assert_equal(node.getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_equal(node.getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
tx_batch_size = 25
|
|
num_of_batches = 3
|
|
# Generate UTXOs to flood the mempool
|
|
# 1 to create a tx initially that will be evicted from the mempool later
|
|
# 3 batches of multiple transactions with a fee rate much higher than the previous UTXO
|
|
# And 1 more to verify that this tx does not get added to the mempool with a fee rate less than the mempoolminfee
|
|
self.generate(miniwallet, 1 + (num_of_batches * tx_batch_size) + 1)
|
|
|
|
# Mine 99 blocks so that the UTXOs are allowed to be spent
|
|
self.generate(node, COINBASE_MATURITY - 1)
|
|
|
|
self.log.info('Create a mempool tx that will be evicted')
|
|
tx_to_be_evicted_id = miniwallet.send_self_transfer(from_node=node, fee_rate=relayfee)["txid"]
|
|
|
|
# Increase the tx fee rate massively to give the subsequent transactions a higher priority in the mempool
|
|
base_fee = relayfee * 1000
|
|
|
|
self.log.info("Fill up the mempool with txs with higher fee rate")
|
|
for batch_of_txid in range(num_of_batches):
|
|
fee_rate=(batch_of_txid + 1) * base_fee
|
|
self.send_large_txs(node, miniwallet, txouts, fee_rate, tx_batch_size)
|
|
|
|
self.log.info('The tx should be evicted by now')
|
|
# The number of transactions created should be greater than the ones present in the mempool
|
|
assert_greater_than(tx_batch_size * num_of_batches, len(node.getrawmempool()))
|
|
# Initial tx created should not be present in the mempool anymore as it had a lower fee rate
|
|
assert tx_to_be_evicted_id not in node.getrawmempool()
|
|
|
|
self.log.info('Check that mempoolminfee is larger than minrelaytxfee')
|
|
assert_equal(node.getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_greater_than(node.getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
# Deliberately try to create a tx with a fee less than the minimum mempool fee to assert that it does not get added to the mempool
|
|
self.log.info('Create a mempool tx that will not pass mempoolminfee')
|
|
assert_raises_rpc_error(-26, "mempool min fee not met", miniwallet.send_self_transfer, from_node=node, fee_rate=relayfee, mempool_valid=False)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MempoolLimitTest().main()
|