mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 03:52:49 +01:00
6dbc9aba0d
5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 tests: Use a default of supports_cli=True (instead of supports_cli=False) (practicalswift)
993e38a4e2fa66093314b988dfbe459f46aa5864 tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such (practicalswift)
Pull request description:
Annotate functional tests supporting `bitcoin-cli` (`--usecli`) as such.
Prior to this commit 74 tests were unnecessarily skipped when running `test_runner.py --usecli`.
Before [bitcoin original commit stats]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
9 ✓ Passed
126 ○ Skipped
```
After [dash numbers]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
110 ✓ Passed
51 ○ Skipped
```
Context: `--usecli` was introduced in f6ade9ce1a
ACKs for top commit:
laanwj:
Code review ACK 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805
Tree-SHA512: 249c0b691a74cf201c729df86c3db2b3faefa53b94703941e566943d252c6d14924e935a8da4f592951574235923fbb7cd22612a5e7e02ff6c762c55a2320ca3
66 lines
2.3 KiB
Python
Executable File
66 lines
2.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test RPC help output."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
|
|
|
import os
|
|
|
|
|
|
class HelpRpcTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.supports_cli = False
|
|
|
|
def run_test(self):
|
|
self.test_categories()
|
|
self.dump_help()
|
|
if self.is_wallet_compiled():
|
|
self.wallet_help()
|
|
|
|
def test_categories(self):
|
|
node = self.nodes[0]
|
|
|
|
# wrong argument count, note: Dash's help allows for two options since we utilize subcommands
|
|
assert_raises_rpc_error(-1, 'help', node.help, 'foo', 'bar', 'foobar')
|
|
|
|
# invalid argument
|
|
assert_raises_rpc_error(-1, 'JSON value is not a string as expected', node.help, 0)
|
|
|
|
# help of unknown command
|
|
assert_equal(node.help('foo'), 'help: unknown command: foo')
|
|
|
|
# command titles
|
|
titles = [line[3:-3] for line in node.help().splitlines() if line.startswith('==')]
|
|
|
|
components = ['Addressindex', 'Blockchain', 'Control', 'Dash', 'Evo', 'Generating', 'Mining', 'Network', 'Rawtransactions', 'Util']
|
|
|
|
if self.is_wallet_compiled():
|
|
components.append('Wallet')
|
|
|
|
if self.is_zmq_compiled():
|
|
components.append('Zmq')
|
|
|
|
assert_equal(titles, components)
|
|
|
|
def dump_help(self):
|
|
dump_dir = os.path.join(self.options.tmpdir, 'rpc_help_dump')
|
|
os.mkdir(dump_dir)
|
|
calls = [line.split(' ', 1)[0] for line in self.nodes[0].help().splitlines() if line and not line.startswith('==')]
|
|
for call in calls:
|
|
with open(os.path.join(dump_dir, call), 'w', encoding='utf-8') as f:
|
|
# Make sure the node can generate the help at runtime without crashing
|
|
f.write(self.nodes[0].help(call))
|
|
|
|
def wallet_help(self):
|
|
assert 'getnewaddress ( "label" )' in self.nodes[0].help('getnewaddress')
|
|
self.restart_node(0, extra_args=['-nowallet=1'])
|
|
assert 'getnewaddress ( "label" )' in self.nodes[0].help('getnewaddress')
|
|
|
|
|
|
if __name__ == '__main__':
|
|
HelpRpcTest().main()
|