mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
4d56397d96
ebfc308ea4b8851118e8194d837556bf443c329c test: add coverage for non-hex value to -minimumchainwork (brunoerg)
Pull request description:
This PR adds test coverage for the following init error:
b9ef5a10e2/src/init.cpp (L917-L919)
Passing a non-hex value to -minimumchainwork should throw an initial error.
ACKs for top commit:
laanwj:
Code review ACK ebfc308ea4b8851118e8194d837556bf443c329c
kristapsk:
re-ACK ebfc308ea4b8851118e8194d837556bf443c329c
Tree-SHA512: c665903757ae3b8b2480df97bb888e60ba4387b009fcb8031041822e87a155a0e4950ebe79873c1034f0826504521d82b1fdfdb5e8378b227d14ca545b8d4e11
101 lines
4.4 KiB
Python
Executable File
101 lines
4.4 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test logic for setting nMinimumChainWork on command line.
|
|
|
|
Nodes don't consider themselves out of "initial block download" until
|
|
their active chain has more work than nMinimumChainWork.
|
|
|
|
Nodes don't download blocks from a peer unless the peer's best known block
|
|
has more work than nMinimumChainWork.
|
|
|
|
While in initial block download, nodes won't relay blocks to their peers, so
|
|
test that this parameter functions as intended by verifying that block relay
|
|
only succeeds past a given node once its nMinimumChainWork has been exceeded.
|
|
"""
|
|
|
|
import time
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
# 2 hashes required per regtest block (with no difficulty adjustment)
|
|
REGTEST_WORK_PER_BLOCK = 2
|
|
|
|
class MinimumChainWorkTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
self.extra_args = [[], ["-minimumchainwork=0x65"], ["-minimumchainwork=0x65"]]
|
|
self.node_min_work = [0, 101, 101]
|
|
|
|
def setup_network(self):
|
|
# Force CanDirectFetch to return false (otherwise nMinimumChainWork is ignored)
|
|
self.bump_mocktime(21 * 2.6 * 60)
|
|
# This test relies on the chain setup being:
|
|
# node0 <- node1 <- node2
|
|
# Before leaving IBD, nodes prefer to download blocks from outbound
|
|
# peers, so ensure that we're mining on an outbound peer and testing
|
|
# block relay to inbound peers.
|
|
self.setup_nodes()
|
|
for i in range(self.num_nodes-1):
|
|
self.connect_nodes(i+1, i)
|
|
|
|
def run_test(self):
|
|
# Start building a chain on node0. node2 shouldn't be able to sync until node1's
|
|
# minchainwork is exceeded
|
|
starting_chain_work = REGTEST_WORK_PER_BLOCK # Genesis block's work
|
|
self.log.info("Testing relay across node %d (minChainWork = %d)", 1, self.node_min_work[1])
|
|
|
|
starting_blockcount = self.nodes[2].getblockcount()
|
|
|
|
num_blocks_to_generate = int((self.node_min_work[1] - starting_chain_work) / REGTEST_WORK_PER_BLOCK)
|
|
self.log.info("Generating %d blocks on node0", num_blocks_to_generate)
|
|
hashes = self.nodes[0].generatetoaddress(num_blocks_to_generate,
|
|
self.nodes[0].get_deterministic_priv_key().address)
|
|
|
|
self.log.info("Node0 current chain work: %s", self.nodes[0].getblockheader(hashes[-1])['chainwork'])
|
|
|
|
# Sleep a few seconds and verify that node2 didn't get any new blocks
|
|
# or headers. We sleep, rather than sync_blocks(node0, node1) because
|
|
# it's reasonable either way for node1 to get the blocks, or not get
|
|
# them (since they're below node1's minchainwork).
|
|
time.sleep(3)
|
|
|
|
self.log.info("Verifying node 2 has no more blocks than before")
|
|
self.log.info("Blockcounts: %s", [n.getblockcount() for n in self.nodes])
|
|
# Node2 shouldn't have any new headers yet, because node1 should not
|
|
# have relayed anything.
|
|
assert_equal(len(self.nodes[2].getchaintips()), 1)
|
|
assert_equal(self.nodes[2].getchaintips()[0]['height'], 0)
|
|
|
|
assert self.nodes[1].getbestblockhash() != self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[2].getblockcount(), starting_blockcount)
|
|
|
|
self.log.info("Generating one more block")
|
|
self.nodes[0].generatetoaddress(1, self.nodes[0].get_deterministic_priv_key().address)
|
|
|
|
self.log.info("Verifying nodes are all synced")
|
|
|
|
# Because nodes in regtest are all manual connections (eg using
|
|
# addnode), node1 should not have disconnected node0. If not for that,
|
|
# we'd expect node1 to have disconnected node0 for serving an
|
|
# insufficient work chain, in which case we'd need to reconnect them to
|
|
# continue the test.
|
|
|
|
self.sync_all()
|
|
self.log.info("Blockcounts: %s", [n.getblockcount() for n in self.nodes])
|
|
|
|
self.log.info("Test -minimumchainwork with a non-hex value")
|
|
self.stop_node(0)
|
|
self.nodes[0].assert_start_raises_init_error(
|
|
["-minimumchainwork=test"],
|
|
expected_msg='Error: Invalid non-hex (test) minimum chain work value specified',
|
|
)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MinimumChainWorkTest().main()
|