mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 03:52:49 +01:00
4aa197dbdb
fa4632c41714dfaa699bacc6a947d72668a4deef test: Move boost/stdlib includes last (MarcoFalke) fa488f131fd4f5bab0d01376c5a5013306f1abcd scripted-diff: Bump copyright headers (MarcoFalke) fac5c373006a9e4bcbb56843bb85f1aca4d87599 scripted-diff: Sort test includes (MarcoFalke) Pull request description: When writing tests, often includes need to be added or removed. Currently the list of includes is not sorted, so developers that write tests and have `clang-format` installed will either have an unrelated change (sorting) included in their commit or they will have to manually undo the sort. This pull preempts both issues by just sorting all includes in one commit. Please be aware that this is **NOT** a change to policy to enforce clang-format or any other developer guideline or process. Developers are free to use whatever tool they want, see also #18651. Edit: Also includes a commit to bump the copyright headers, so that the touched files don't need to be touched again for that. ACKs for top commit: practicalswift: ACK fa4632c41714dfaa699bacc6a947d72668a4deef jonatack: ACK fa4632c41714dfaa, light review and sanity checks with gcc build and clang fuzz build Tree-SHA512: 130a8d073a379ba556b1e64104d37c46b671425c0aef0ed725fd60156a95e8dc83fb6f0b5330b2f8152cf5daaf3983b4aca5e75812598f2626c39fd12b88b180
73 lines
2.4 KiB
Bash
Executable File
73 lines
2.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Copyright (c) 2018-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check for shellcheck warnings in shell scripts.
|
|
|
|
export LC_ALL=C
|
|
|
|
# The shellcheck binary segfault/coredumps in Travis with LC_ALL=C
|
|
# It does not do so in Ubuntu 14.04, 16.04, 18.04 in versions 0.3.3, 0.3.7, 0.4.6
|
|
# respectively. So export LC_ALL=C is set as required by lint-shell-locale.sh
|
|
# but unset here in case of running in Travis.
|
|
if [ "$TRAVIS" = "true" ]; then
|
|
unset LC_ALL
|
|
fi
|
|
|
|
# Disabled warnings:
|
|
disabled=(
|
|
SC2046 # Quote this to prevent word splitting.
|
|
SC2086 # Double quote to prevent globbing and word splitting.
|
|
SC2162 # read without -r will mangle backslashes.
|
|
)
|
|
disabled_gitian=(
|
|
SC2094 # Make sure not to read and write the same file in the same pipeline.
|
|
SC2129 # Consider using { cmd1; cmd2; } >> file instead of individual redirects.
|
|
)
|
|
|
|
EXIT_CODE=0
|
|
|
|
if ! command -v shellcheck > /dev/null; then
|
|
echo "Skipping shell linting since shellcheck is not installed."
|
|
exit $EXIT_CODE
|
|
fi
|
|
|
|
if ! command -v gawk > /dev/null; then
|
|
echo "Skipping shell linting since gawk is not installed."
|
|
exit $EXIT_CODE
|
|
fi
|
|
|
|
SHELLCHECK_CMD=(shellcheck --external-sources --check-sourced)
|
|
EXCLUDE="--exclude=$(IFS=','; echo "${disabled[*]}")"
|
|
SOURCED_FILES=$(git ls-files | xargs gawk '/^# shellcheck shell=/ {print FILENAME} {nextfile}') # Check shellcheck directive used for sourced files
|
|
if ! "${SHELLCHECK_CMD[@]}" "$EXCLUDE" $SOURCED_FILES $(git ls-files -- '*.sh' | grep -vE 'src/(dashbls|immer|leveldb|secp256k1|univalue)/'); then
|
|
EXIT_CODE=1
|
|
fi
|
|
|
|
if ! command -v yq > /dev/null; then
|
|
echo "Skipping Gitian descriptor scripts checking since yq is not installed."
|
|
exit $EXIT_CODE
|
|
fi
|
|
|
|
if ! command -v jq > /dev/null; then
|
|
echo "Skipping Gitian descriptor scripts checking since jq is not installed."
|
|
exit $EXIT_CODE
|
|
fi
|
|
|
|
EXCLUDE_GITIAN=${EXCLUDE}",$(IFS=','; echo "${disabled_gitian[*]}")"
|
|
for descriptor in $(git ls-files -- 'contrib/gitian-descriptors/*.yml')
|
|
do
|
|
script=$(basename "$descriptor")
|
|
# Use #!/bin/bash as gitian-builder/bin/gbuild does to complete a script.
|
|
echo "#!/bin/bash" > $script
|
|
yq -r .script "$descriptor" >> $script
|
|
if ! "${SHELLCHECK_CMD[@]}" "$EXCLUDE_GITIAN" $script; then
|
|
EXIT_CODE=1
|
|
fi
|
|
rm $script
|
|
done
|
|
|
|
exit $EXIT_CODE
|