sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity
v21.1.x
dash/src/wallet
History
pasta 8e70262db4
Merge #6131: feat: make a support of Qt app to show Platform transfer Tx 
21f174aff1 feat: improve query categorisation in Qt App (Konstantin Akimov)
c863473286 test: add spending asset unlock tx in functional tests (Konstantin Akimov)
1fb67ece0e feat: make a support of Qt app to show Platform Transfer transaction as a new type of transaction (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Transfers from platform have incorrectly shown amount in Dash Core wallet app.
  They also shown in Qt app as self-send that is not completely true.

  ## What was done?
  Added new type of transaction to Qt App, added a filter for its type, fixed calculation of output for tx records.
  As well added a new type of transaction `platform-transfer` in rpc output of `gettransaction` RPC

  ## How Has This Been Tested?
  Make a Platform Transfer transaction on RegTest and check it in Dash Core

  ![image](https://github.com/user-attachments/assets/16c83f09-724f-4b8b-99c8-9bb0df1428da)

  Helper to see it: export dpath=/tmp/dash_func_test_PATHPATH/ ; src/qt/dash-qt -regtest -conf=$dpath/node0/dash.conf -datadir=$dpath/node0/ -debug=0 -debuglogfile=/dev/stdout

  ## Breaking Changes
  There's new type of transaction "platform-transfer" in rpc output of `gettransaction`.

  **This PR DOES NOT change any consensus rules.**
  Breaking changes that makes withdrawal transaction immature is moved to https://github.com/dashpay/dash/pull/6128

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

Top commit has no ACKs.

Tree-SHA512: ec2a54a910f121ad30ff8e94cf17080b5b3c651872e9bc3de9ec0924ca7f7a0e526b74b05cde26aaf860e3809e67f66142112319a69c216527e5bcb1b8a2b8f6
2024-10-22 10:52:16 -05:00
..
test Merge #6328: backport: bitcoin/bitcoin#30131, #23258, #30504 - fix bild for Ubuntu 24.10 + clang 2024-10-22 09:14:40 -05:00
bdb.cpp
bdb.h
bip39_english.h
bip39.cpp
bip39.h
coincontrol.cpp
coincontrol.h merge bitcoin#21359: include_unsafe option for fundrawtransaction 2024-06-27 19:27:37 +00:00
coinselection.cpp
coinselection.h merge bitcoin#21359: include_unsafe option for fundrawtransaction 2024-06-27 19:27:37 +00:00
context.cpp
context.h
crypter.cpp
crypter.h
db.cpp
db.h
dump.cpp
dump.h
fees.cpp
fees.h
hdchain.cpp
hdchain.h
init.cpp
interfaces.cpp Merge #6131: feat: make a support of Qt app to show Platform transfer Tx 2024-10-22 10:52:16 -05:00
ismine.h
load.cpp
load.h
rpcdump.cpp merge bitcoin#19651: importdescriptors update existing 2024-06-27 19:27:37 +00:00
rpcwallet.cpp Merge #6131: feat: make a support of Qt app to show Platform transfer Tx 2024-10-22 10:52:16 -05:00
rpcwallet.h
salvage.cpp
salvage.h
scriptpubkeyman.cpp Merge #6116: fix: mitigate crashes associated with some upgradetohd edge cases 2024-07-23 12:46:41 -05:00
scriptpubkeyman.h Merge #6116: fix: mitigate crashes associated with some upgradetohd edge cases 2024-07-23 12:46:41 -05:00
sqlite.cpp
sqlite.h
wallet.cpp Merge #6328: backport: bitcoin/bitcoin#30131, #23258, #30504 - fix bild for Ubuntu 24.10 + clang 2024-10-22 09:14:40 -05:00
wallet.h Merge #6131: feat: make a support of Qt app to show Platform transfer Tx 2024-10-22 10:52:16 -05:00
walletdb.cpp merge bitcoin#19651: importdescriptors update existing 2024-06-27 19:27:37 +00:00
walletdb.h merge bitcoin#19651: importdescriptors update existing 2024-06-27 19:27:37 +00:00
wallettool.cpp
wallettool.h
walletutil.cpp
walletutil.h