mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
266aefc544
The key difference between bitcoin's and dash's implementation that sethdseed does not update existing seed for wallet. Seed can be set only once. It behave similarly to `upgradetohd` rpc, but since v20.1 all wallets are HD and the name `upgradetohd` is not relevant more.
286 lines
15 KiB
Python
Executable File
286 lines
15 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2016-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test Hierarchical Deterministic wallet function."""
|
|
|
|
import shutil
|
|
import os
|
|
|
|
from test_framework.blocktools import COINBASE_MATURITY
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
class WalletHDTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 2
|
|
self.extra_args = [['-usehd=0'], ['-usehd=1', '-keypool=0']]
|
|
|
|
def setup_network(self):
|
|
self.add_nodes(self.num_nodes, self.extra_args)
|
|
self.start_nodes()
|
|
self.import_deterministic_coinbase_privkeys()
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
# Make sure can't switch off usehd after wallet creation
|
|
self.stop_node(1)
|
|
self.nodes[1].assert_start_raises_init_error(['-usehd=0'], "Error: Error loading %s: You can't disable HD on an already existing HD wallet" % self.default_wallet_name)
|
|
self.start_node(1)
|
|
self.connect_nodes(0, 1)
|
|
|
|
# Make sure we use hd, keep chainid
|
|
hd_fingerprint = self.nodes[1].getaddressinfo(self.nodes[1].getnewaddress())['hdmasterfingerprint']
|
|
assert_equal(len(hd_fingerprint), 8)
|
|
|
|
# create an internal key
|
|
change_addr = self.nodes[1].getrawchangeaddress()
|
|
change_addrV= self.nodes[1].getaddressinfo(change_addr)
|
|
assert_equal(change_addrV["hdkeypath"], "m/44'/1'/0'/1/0") #first internal child key
|
|
|
|
# Import a non-HD private key in the HD wallet
|
|
non_hd_add = 'yLU9vxiAWUdiKKxn6EazLDFq9WXrK2T7RP'
|
|
non_hd_key = 'cVCzrzfxMhUMxV34UhTmdmntAqHvosAuNo2KUZsiHZSKLm73g35o'
|
|
self.nodes[1].importprivkey(non_hd_key)
|
|
|
|
# This should be enough to keep the master key and the non-HD key
|
|
self.nodes[1].backupwallet(os.path.join(self.nodes[1].datadir, "hd.bak"))
|
|
#self.nodes[1].dumpwallet(os.path.join(self.nodes[1].datadir, "hd.dump"))
|
|
|
|
# Derive some HD addresses and remember the last
|
|
# Also send funds to each add
|
|
self.nodes[0].generate(COINBASE_MATURITY + 1)
|
|
hd_add = None
|
|
NUM_HD_ADDS = 10
|
|
for i in range(1, NUM_HD_ADDS + 1):
|
|
hd_add = self.nodes[1].getnewaddress()
|
|
hd_info = self.nodes[1].getaddressinfo(hd_add)
|
|
assert_equal(hd_info["hdkeypath"], "m/44'/1'/0'/0/" + str(i))
|
|
assert_equal(hd_info["hdmasterfingerprint"], hd_fingerprint)
|
|
self.nodes[0].sendtoaddress(hd_add, 1)
|
|
self.nodes[0].generate(1)
|
|
self.nodes[0].sendtoaddress(non_hd_add, 1)
|
|
self.nodes[0].generate(1)
|
|
|
|
# create an internal key (again)
|
|
change_addr = self.nodes[1].getrawchangeaddress()
|
|
change_addrV= self.nodes[1].getaddressinfo(change_addr)
|
|
assert_equal(change_addrV["hdkeypath"], "m/44'/1'/0'/1/1") #second internal child key
|
|
|
|
self.sync_all()
|
|
assert_equal(self.nodes[1].getbalance(), NUM_HD_ADDS + 1)
|
|
|
|
self.log.info("Restore backup ...")
|
|
self.stop_node(1)
|
|
# we need to delete the complete chain directory
|
|
# otherwise node1 would auto-recover all funds in flag the keypool keys as used
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "blocks"))
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "chainstate"))
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "evodb"))
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "llmq"))
|
|
shutil.copyfile(
|
|
os.path.join(self.nodes[1].datadir, "hd.bak"),
|
|
os.path.join(self.nodes[1].datadir, self.chain, "wallets", self.default_wallet_name, self.wallet_data_filename),
|
|
)
|
|
self.start_node(1)
|
|
|
|
# Assert that derivation is deterministic
|
|
hd_add_2 = None
|
|
for i in range(1, NUM_HD_ADDS + 1):
|
|
hd_add_2 = self.nodes[1].getnewaddress()
|
|
hd_info_2 = self.nodes[1].getaddressinfo(hd_add_2)
|
|
assert_equal(hd_info_2["hdkeypath"], "m/44'/1'/0'/0/"+str(i))
|
|
assert_equal(hd_info_2["hdmasterfingerprint"], hd_fingerprint)
|
|
assert_equal(hd_add, hd_add_2)
|
|
self.connect_nodes(0, 1)
|
|
self.sync_all()
|
|
|
|
# Needs rescan
|
|
self.restart_node(1, extra_args=self.extra_args[1] + ['-rescan'])
|
|
assert_equal(self.nodes[1].getbalance(), NUM_HD_ADDS + 1)
|
|
|
|
# Try a RPC based rescan
|
|
self.stop_node(1)
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "blocks"))
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "chainstate"))
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "evodb"))
|
|
shutil.rmtree(os.path.join(self.nodes[1].datadir, self.chain, "llmq"))
|
|
shutil.copyfile(
|
|
os.path.join(self.nodes[1].datadir, "hd.bak"),
|
|
os.path.join(self.nodes[1].datadir, self.chain, "wallets", self.default_wallet_name, self.wallet_data_filename),
|
|
)
|
|
self.start_node(1, extra_args=self.extra_args[1])
|
|
self.connect_nodes(0, 1)
|
|
self.sync_all()
|
|
# Wallet automatically scans blocks older than key on startup
|
|
assert_equal(self.nodes[1].getbalance(), NUM_HD_ADDS + 1)
|
|
out = self.nodes[1].rescanblockchain(0, 1)
|
|
assert_equal(out['start_height'], 0)
|
|
assert_equal(out['stop_height'], 1)
|
|
out = self.nodes[1].rescanblockchain()
|
|
assert_equal(out['start_height'], 0)
|
|
assert_equal(out['stop_height'], self.nodes[1].getblockcount())
|
|
assert_equal(self.nodes[1].getbalance(), NUM_HD_ADDS + 1)
|
|
|
|
# send a tx and make sure its using the internal chain for the changeoutput
|
|
txid = self.nodes[1].sendtoaddress(self.nodes[0].getnewaddress(), 1)
|
|
outs = self.nodes[1].decoderawtransaction(self.nodes[1].gettransaction(txid)['hex'])['vout']
|
|
keypath = ""
|
|
for out in outs:
|
|
if out['value'] != 1:
|
|
keypath = self.nodes[1].getaddressinfo(out['scriptPubKey']['addresses'][0])['hdkeypath']
|
|
|
|
assert_equal(keypath[0:13], "m/44'/1'/0'/1")
|
|
|
|
if not self.options.descriptors:
|
|
# NOTE: sethdseed can't replace existing seed in Dash Core
|
|
# though bitcoin lets to do it. Therefore this functional test
|
|
# are not the same with bitcoin's
|
|
# Generate a new HD seed on node 1 and make sure it is set
|
|
|
|
self.nodes[1].createwallet(wallet_name='wallet_new_seed', blank=True)
|
|
wallet_new_seed = self.nodes[1].get_wallet_rpc('wallet_new_seed')
|
|
assert 'hdchainid' not in wallet_new_seed.getwalletinfo()
|
|
wallet_new_seed.sethdseed()
|
|
new_masterkeyid = wallet_new_seed.getwalletinfo()['hdchainid']
|
|
addr = wallet_new_seed.getnewaddress()
|
|
# Make sure the new address is the first from the keypool
|
|
assert_equal(wallet_new_seed.getaddressinfo(addr)['hdkeypath'], "m/44'/1'/0'/0/1")
|
|
wallet_new_seed.keypoolrefill(1) # Fill keypool with 1 key
|
|
|
|
# Set a new HD seed on node 1 without flushing the keypool
|
|
new_seed = self.nodes[0].dumpprivkey(self.nodes[0].getnewaddress())
|
|
assert_raises_rpc_error(-4, "Cannot set a HD seed. The wallet already has a seed", wallet_new_seed.sethdseed, False, new_seed)
|
|
self.nodes[1].createwallet(wallet_name='wallet_imported_seed', blank=True)
|
|
wallet_imported_seed = self.nodes[1].get_wallet_rpc('wallet_imported_seed')
|
|
wallet_imported_seed.sethdseed(False, new_seed)
|
|
|
|
new_masterkeyid = wallet_imported_seed.getwalletinfo()['hdchainid']
|
|
addr = wallet_imported_seed.getnewaddress()
|
|
assert_equal(new_masterkeyid, wallet_imported_seed.getaddressinfo(addr)['hdchainid'])
|
|
# Make sure the new address continues previous keypool
|
|
assert_equal(wallet_imported_seed.getaddressinfo(addr)['hdkeypath'], "m/44'/1'/0'/0/0")
|
|
|
|
# Check that the next address is from the new seed
|
|
wallet_imported_seed.keypoolrefill(1)
|
|
next_addr = wallet_imported_seed.getnewaddress()
|
|
assert_equal(new_masterkeyid, wallet_imported_seed.getaddressinfo(next_addr)['hdchainid'])
|
|
# Make sure the new address is not from previous keypool
|
|
assert_equal(wallet_imported_seed.getaddressinfo(next_addr)['hdkeypath'], "m/44'/1'/0'/0/1")
|
|
assert next_addr != addr
|
|
|
|
self.nodes[1].createwallet(wallet_name='wallet_no_seed', blank=True)
|
|
wallet_no_seed = self.nodes[1].get_wallet_rpc('wallet_no_seed')
|
|
wallet_no_seed.importprivkey(non_hd_key)
|
|
# Sethdseed parameter validity
|
|
assert_raises_rpc_error(-1, 'sethdseed', self.nodes[0].sethdseed, False, new_seed, 0)
|
|
assert_raises_rpc_error(-5, "Invalid private key", wallet_no_seed.sethdseed, False, "not_wif")
|
|
assert_raises_rpc_error(-1, "JSON value is not a boolean as expected", wallet_no_seed.sethdseed, "Not_bool")
|
|
assert_raises_rpc_error(-1, "JSON value is not a string as expected", wallet_no_seed.sethdseed, False, True)
|
|
assert_raises_rpc_error(-5, "Already have this key", wallet_no_seed.sethdseed, False, non_hd_key)
|
|
|
|
self.log.info('Test sethdseed restoring with keys outside of the initial keypool')
|
|
self.nodes[0].generate(10)
|
|
# Restart node 1 with keypool of 3 and a different wallet
|
|
self.nodes[1].createwallet(wallet_name='origin', blank=True)
|
|
self.restart_node(1, extra_args=['-keypool=3', '-wallet=origin'])
|
|
self.connect_nodes(0, 1)
|
|
|
|
# sethdseed restoring and seeing txs to addresses out of the keypool
|
|
origin_rpc = self.nodes[1].get_wallet_rpc('origin')
|
|
seed = self.nodes[0].dumpprivkey(self.nodes[0].getnewaddress())
|
|
origin_rpc.sethdseed(True, seed)
|
|
|
|
self.nodes[1].createwallet(wallet_name='restore', blank=True)
|
|
restore_rpc = self.nodes[1].get_wallet_rpc('restore')
|
|
restore_rpc.sethdseed(True, seed) # Set to be the same seed as origin_rpc
|
|
|
|
self.nodes[1].createwallet(wallet_name='restore2', blank=True)
|
|
restore2_rpc = self.nodes[1].get_wallet_rpc('restore2')
|
|
restore2_rpc.sethdseed(True, seed) # Set to be the same seed as origin_rpc
|
|
|
|
# Check persistence of inactive seed by reloading restore. restore2 is still loaded to test the case where the wallet is not reloaded
|
|
restore_rpc.unloadwallet()
|
|
self.nodes[1].loadwallet('restore')
|
|
restore_rpc = self.nodes[1].get_wallet_rpc('restore')
|
|
|
|
# Empty origin keypool and get an address that is beyond the initial keypool
|
|
origin_rpc.getnewaddress()
|
|
origin_rpc.getnewaddress()
|
|
last_addr = origin_rpc.getnewaddress() # Last address of initial keypool
|
|
addr = origin_rpc.getnewaddress() # First address beyond initial keypool
|
|
|
|
# Check that the restored seed has last_addr but does not have addr
|
|
info = restore_rpc.getaddressinfo(last_addr)
|
|
assert_equal(info['ismine'], True)
|
|
info = restore_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], False)
|
|
info = restore2_rpc.getaddressinfo(last_addr)
|
|
assert_equal(info['ismine'], True)
|
|
info = restore2_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], False)
|
|
# Check that the origin seed has addr
|
|
info = origin_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], True)
|
|
|
|
# Send a transaction to addr, which is out of the initial keypool.
|
|
# The wallet that has set a new seed (restore_rpc) should not detect this transaction.
|
|
txid = self.nodes[0].sendtoaddress(addr, 1)
|
|
origin_rpc.sendrawtransaction(self.nodes[0].gettransaction(txid)['hex'])
|
|
self.nodes[0].generate(1)
|
|
self.sync_blocks()
|
|
origin_rpc.gettransaction(txid)
|
|
assert_raises_rpc_error(-5, 'Invalid or non-wallet transaction id', restore_rpc.gettransaction, txid)
|
|
out_of_kp_txid = txid
|
|
|
|
# Send a transaction to last_addr, which is in the initial keypool.
|
|
# The wallet that has set a new seed (restore_rpc) should detect this transaction and generate 3 new keys from the initial seed.
|
|
# The previous transaction (out_of_kp_txid) should still not be detected as a rescan is required.
|
|
txid = self.nodes[0].sendtoaddress(last_addr, 1)
|
|
origin_rpc.sendrawtransaction(self.nodes[0].gettransaction(txid)['hex'])
|
|
self.nodes[0].generate(1)
|
|
self.sync_blocks()
|
|
origin_rpc.gettransaction(txid)
|
|
restore_rpc.gettransaction(txid)
|
|
assert_raises_rpc_error(-5, 'Invalid or non-wallet transaction id', restore_rpc.gettransaction, out_of_kp_txid)
|
|
restore2_rpc.gettransaction(txid)
|
|
assert_raises_rpc_error(-5, 'Invalid or non-wallet transaction id', restore2_rpc.gettransaction, out_of_kp_txid)
|
|
|
|
# After rescanning, restore_rpc should now see out_of_kp_txid and generate an additional key.
|
|
# addr should now be part of restore_rpc and be ismine
|
|
restore_rpc.rescanblockchain()
|
|
restore_rpc.gettransaction(out_of_kp_txid)
|
|
info = restore_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], True)
|
|
restore2_rpc.rescanblockchain()
|
|
restore2_rpc.gettransaction(out_of_kp_txid)
|
|
info = restore2_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], True)
|
|
|
|
# Check again that 3 keys were derived.
|
|
# Empty keypool and get an address that is beyond the initial keypool
|
|
origin_rpc.getnewaddress()
|
|
origin_rpc.getnewaddress()
|
|
last_addr = origin_rpc.getnewaddress()
|
|
addr = origin_rpc.getnewaddress()
|
|
|
|
# Check that the restored seed has last_addr but does not have addr
|
|
info = restore_rpc.getaddressinfo(last_addr)
|
|
assert_equal(info['ismine'], True)
|
|
info = restore_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], False)
|
|
info = restore2_rpc.getaddressinfo(last_addr)
|
|
assert_equal(info['ismine'], True)
|
|
info = restore2_rpc.getaddressinfo(addr)
|
|
assert_equal(info['ismine'], False)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
WalletHDTest().main ()
|