mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
376a6a04f1
7aab8d1024996c7c422bd34a8226df0117b813f7 [style] Code style fixups in GetWarnings() (John Newbery)
492c6dc1e742a62599dc6d5ba6c3896825b5144f util: change GetWarnings parameter to bool (John Newbery)
869b6314fd180856b6054fff28b5de994252c54c [qt] remove unused parameter from getWarnings() (John Newbery)
Pull request description:
`GetWarnings()` changes the format of the output warning string based on a passed-in string argument that can be set to "gui" or "statusbar".
Change the argument to a bool:
- there are only two types of behaviour, so a bool is a more natural argument type
- changing the name to `verbose` does not set any expectations for the how the calling code will use the returned string (currently, `statusbar` is used for RPC warnings, not a status bar)
- removes some error-handling code for when the passed-in string is not one of the two strings expected.
ACKs for top commit:
laanwj:
code review ACK 7aab8d1024996c7c422bd34a8226df0117b813f7
practicalswift:
ACK 7aab8d1024996c7c422bd34a8226df0117b813f7 -- diff looks correct :)
MarcoFalke:
ACK 7aab8d1024996c7c422bd34a8226df0117b813f7 otherwise.
promag:
Code review ACK 7aab8d1024996c7c422bd34a8226df0117b813f7.
Tree-SHA512: 75882c6e3e44aa9586411b803149b36ba487f4eb9cac3f5c8f07cd9f586870bba4488a51e674cf8147f05718534f482836e6a4e3f66e0d4ef6821900c7dfd04e
24 lines
827 B
C++
24 lines
827 B
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2016 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_WARNINGS_H
|
|
#define BITCOIN_WARNINGS_H
|
|
|
|
#include <string>
|
|
|
|
void SetMiscWarning(const std::string& strWarning);
|
|
void SetfLargeWorkForkFound(bool flag);
|
|
bool GetfLargeWorkForkFound();
|
|
void SetfLargeWorkInvalidChainFound(bool flag);
|
|
/** Format a string that describes several potential problems detected by the core.
|
|
* @param[in] verbose bool
|
|
* - if true, get all warnings, translated (where possible), separated by <hr />
|
|
* - if false, get the most important warning
|
|
* @returns the warning string
|
|
*/
|
|
std::string GetWarnings(bool verbose);
|
|
|
|
#endif // BITCOIN_WARNINGS_H
|