Dash - Reinventing Cryptocurrency
Go to file
PastaPastaPasta 052e7fcffd
Merge #10952: [wallet] Remove vchDefaultKey and have better first run… (#3319)
* Merge #10952: [wallet] Remove vchDefaultKey and have better first run detection

e53615b Remove vchDefaultKey and have better first run detection (Andrew Chow)

Pull request description:

  Removes vchDefaultKey which was only used for first run detection. Improves wallet first run detection by checking to see if any keys were read from the database.

  This also fixes a (rather contrived) case where an encrypted non-HD wallet has corruption such that the default key is no longer valid and is loaded into a Core version that supports HD wallets. This causes a runtime exception since a new hd master key is generated as the software believes the wallet file is newly created but cannot add the generated key to the wallet since it is encrypted. I was only able to replicate this error by creating a non-hd wallet, encrypting it, then editing the wallet using `db_dump` and `db_load` before loading the wallet with hd enabled. This problem has been reported by [two](https://bitcointalk.org/index.php?topic=1993244.0) [users](https://bitcointalk.org/index.php?topic=1746976.msg17511261#msg17511261) so it is something that can happen, although that raises the question of "what corrupted the default key".

  ~P.S. I don't know what's up with the whitespace changes. I think my text editor is doing something stupid but I don't think those are important enough to attempt undoing them.~ Undid those

Tree-SHA512: 63b485f356566e8ffa033ad9b7101f7f6b56372b29ec2a43b947b0eeb1ada4c2cfe24740515d013aedd5f51aa1890dfbe499d2c5c062fc1b5d272324728a7d55

* Update src/wallet/wallet.cpp

Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>

Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-02-04 15:34:18 +03:00
.github Add link to bugcrowd in issue template (#2716) 2019-02-19 13:05:59 +03:00
.tx
build-aux/m4 Merge #11711: bitcoin_qt.m4: Minor fixes and clean-ups. 2020-01-31 07:43:43 -06:00
ci More of 11300 2020-01-10 10:34:04 -06:00
contrib Merge pull request #3312 from PastaPastaPasta/backports-0.16-pr6 2020-01-31 14:05:32 +03:00
depends Merge #11286: [depends] Don't build libevent sample code 2020-01-10 10:33:55 -06:00
doc bitcoin -> Dash 2020-01-30 07:37:50 -06:00
docker
share trivial: adding SVG and high contrast icons (#3209) 2020-01-17 15:45:25 +01:00
src Merge #10952: [wallet] Remove vchDefaultKey and have better first run… (#3319) 2020-02-04 15:34:18 +03:00
test Merge #10952: [wallet] Remove vchDefaultKey and have better first run… (#3319) 2020-02-04 15:34:18 +03:00
.gitattributes
.gitignore bitcoin -> dash 2019-08-24 11:11:25 -05:00
.gitlab-ci.yml Fix pull request detection in .gitlab-ci.yml (#3256) 2019-12-31 13:02:03 +03:00
.travis.yml Fix empty TRAVIS_COMMIT_RANGE for one-commit-branch builds in Travis (#3299) 2020-01-24 19:59:06 +03:00
autogen.sh
CMakeLists.txt Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
configure.ac Merge #11936: [build] Warn that only libconsensus can be built without Boost 2020-01-31 07:43:43 -06:00
CONTRIBUTING.md Merge #11624: Docs: Change formatting for sequence of steps 2020-01-16 09:22:46 -06:00
COPYING Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00
INSTALL.md
Jenkinsfile
Jenkinsfile.gitian
libdashconsensus.pc.in
Makefile.am Merge #11541: Build: Fix Automake warnings when running autogen.sh 2020-01-16 09:22:46 -06:00
README.md Bump version to 0.16 on develop (#3239) 2019-12-13 18:52:52 +01:00

Dash Core staging tree 0.16

master: Build Status develop: Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.