sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
Dash - Reinventing Cryptocurrency
17,829 Commits 24 Branches 554 Tags 573 MiB
C++ 52.7%
C 24.2%
Python 10.5%
Assembly 3.3%
JavaScript 2.6%
Other 6.5%
0662f170f0
Go to file
PastaPastaPasta 0662f170f0
Merge #12836: Make WalletInitInterface and DummyWalletInit private, fix nullptr deref (#3498) 
d894894 wallet: Refactor to WalletInitInterface* const g_wallet_init_interface (João Barbosa)
39bc2fa wallet: Make WalletInitInterface and DummyWalletInit private (João Barbosa)

Pull request description:

  Implementations of `WalletInitInterface` don't have to be public, so make them private. This makes the interface instantiation static. Also reduces `ENABLE_WALLET` usage and removes the unnecessary `src/wallet/init.h` header.

Tree-SHA512: 203c49d8c85252d1bd0ff1d7ed8bcdc842d12d2d396e965cc70be5c8159a62e98ec23d32d2f3dc48a53e575844130d0a7dedac3cc2fe4621d31319b7a1c9ba89
Signed-off-by: pasta <pasta@dashboost.org>

# Conflicts:
#	src/qt/dash.cpp
#	src/wallet/init.cpp
#	src/wallet/init.h
#	src/walletinitinterface.h

Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
2020-05-20 12:24:51 +03:00
.github Add link to bugcrowd in issue template (#2716) 2019-02-19 13:05:59 +03:00
.tx
build-aux/m4 Merge #11711: bitcoin_qt.m4: Minor fixes and clean-ups. 2020-01-31 07:43:43 -06:00
ci Implement epoll support 2020-04-20 15:38:19 +02:00
contrib Merge #12075: [scripts] Add missing univalue file to copyright_header.py 2020-04-03 05:06:59 -05:00
depends change miniupnp lib server (#3452) 2020-04-26 03:41:42 +03:00
doc Merge #12384: [Docs] Add version footnote to tor.md (#3473) 2020-05-12 02:32:38 +03:00
docker Automatically build and push docker image to docker.io/dashpay/dashd-develop (#1809) 2018-01-10 12:17:43 +03:00
share Merge #12985: Windows: Avoid launching as admin when NSIS installer ends. 2020-04-03 04:10:18 -05:00
src Merge #12836: Make WalletInitInterface and DummyWalletInit private, fix nullptr deref (#3498) 2020-05-20 12:24:51 +03:00
test Merge bitcoin#11415: [RPC] Disallow using addresses in createmultisig (#3482) 2020-05-15 12:34:41 +03:00
.gitattributes
.gitignore Merge #11620: [build] .gitignore: add background.tiff 2020-02-08 23:33:25 -06:00
.gitlab-ci.yml CI: Fix Gitlab nowallet and release builds (#3491) 2020-05-18 15:26:53 +03:00
.travis.yml Refactor Gitlab builds to use multiple stages (#3377) 2020-03-28 00:58:51 +03:00
autogen.sh Merge #8784: Copyright headers for build scripts 2018-01-12 08:02:45 +01:00
CMakeLists.txt Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
configure.ac Backport bitcoin#14123 and bitcoin#16720 (#3463) 2020-04-30 13:28:44 +03:00
CONTRIBUTING.md add "Verifying a Rebase" section to CONTRIBUTING.md (#3487) 2020-05-18 15:26:42 +03:00
COPYING Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00
INSTALL.md Dashify INSTALL.md and build-unix.md 2018-01-12 16:12:54 +01:00
libdashconsensus.pc.in
Makefile.am Merge #11842: [build] Add missing stuff to clean-local 2020-04-03 05:06:59 -05:00
README.md Bump version to 0.16 on develop (#3239) 2019-12-13 18:52:52 +01:00

README.md

Dash Core staging tree 0.16

master: Build Status develop: Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.