mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
b07a7b810c
* Merge #11796: [tests] Functional test naming convention5fecd84
[tests] Remove redundant import in blocktools.py test (Anthony Towns)9b20bb4
[tests] Check tests conform to naming convention (Anthony Towns)7250b4e
[tests] README.md nit fixes (Anthony Towns)82b2712
[tests] move witness util functions to blocktools.py (John Newbery)1e10854
[tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting #11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80 * update violation count Signed-off-by: pasta <pasta@dashboost.org> * Merge #11774: [tests] Rename functional tests6f881cc880
[tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns)3150b3fea7
[tests] Rename misc functional tests. (Anthony Towns)81b79f2c39
[tests] Rename rpc_* functional tests. (Anthony Towns)61b8f7f273
[tests] Rename p2p_* functional tests. (Anthony Towns)90600bc7db
[tests] Rename wallet_* functional tests. (Anthony Towns)ca6523d0c8
[tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16 * rename tests and edit associated strings to align test-suite with test name standards Signed-off-by: pasta <pasta@dashboost.org> * fix grammar in test/functional/test_runner.py Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * ci: Fix excluded test names * rename feature_privatesend.py to rpc_privatesend.py Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com> Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
92 lines
4.0 KiB
Python
Executable File
92 lines
4.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test logic for setting nMinimumChainWork on command line.
|
|
|
|
Nodes don't consider themselves out of "initial block download" until
|
|
their active chain has more work than nMinimumChainWork.
|
|
|
|
Nodes don't download blocks from a peer unless the peer's best known block
|
|
has more work than nMinimumChainWork.
|
|
|
|
While in initial block download, nodes won't relay blocks to their peers, so
|
|
test that this parameter functions as intended by verifying that block relay
|
|
only succeeds past a given node once its nMinimumChainWork has been exceeded.
|
|
"""
|
|
|
|
import time
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import connect_nodes, assert_equal
|
|
|
|
# 2 hashes required per regtest block (with no difficulty adjustment)
|
|
REGTEST_WORK_PER_BLOCK = 2
|
|
|
|
class MinimumChainWorkTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
self.extra_args = [[], ["-minimumchainwork=0x65"], ["-minimumchainwork=0x65"]]
|
|
self.node_min_work = [0, 101, 101]
|
|
|
|
def setup_network(self):
|
|
# Force CanDirectFetch to return false (otherwise nMinimumChainWork is ignored)
|
|
self.bump_mocktime(21 * 2.6 * 60)
|
|
# This test relies on the chain setup being:
|
|
# node0 <- node1 <- node2
|
|
# Before leaving IBD, nodes prefer to download blocks from outbound
|
|
# peers, so ensure that we're mining on an outbound peer and testing
|
|
# block relay to inbound peers.
|
|
self.setup_nodes()
|
|
for i in range(self.num_nodes-1):
|
|
connect_nodes(self.nodes[i+1], i)
|
|
|
|
def run_test(self):
|
|
# Start building a chain on node0. node2 shouldn't be able to sync until node1's
|
|
# minchainwork is exceeded
|
|
starting_chain_work = REGTEST_WORK_PER_BLOCK # Genesis block's work
|
|
self.log.info("Testing relay across node %d (minChainWork = %d)", 1, self.node_min_work[1])
|
|
|
|
starting_blockcount = self.nodes[2].getblockcount()
|
|
|
|
num_blocks_to_generate = int((self.node_min_work[1] - starting_chain_work) / REGTEST_WORK_PER_BLOCK)
|
|
self.log.info("Generating %d blocks on node0", num_blocks_to_generate)
|
|
hashes = self.nodes[0].generate(num_blocks_to_generate)
|
|
|
|
self.log.info("Node0 current chain work: %s", self.nodes[0].getblockheader(hashes[-1])['chainwork'])
|
|
|
|
# Sleep a few seconds and verify that node2 didn't get any new blocks
|
|
# or headers. We sleep, rather than sync_blocks(node0, node1) because
|
|
# it's reasonable either way for node1 to get the blocks, or not get
|
|
# them (since they're below node1's minchainwork).
|
|
time.sleep(3)
|
|
|
|
self.log.info("Verifying node 2 has no more blocks than before")
|
|
self.log.info("Blockcounts: %s", [n.getblockcount() for n in self.nodes])
|
|
# Node2 shouldn't have any new headers yet, because node1 should not
|
|
# have relayed anything.
|
|
assert_equal(len(self.nodes[2].getchaintips()), 1)
|
|
assert_equal(self.nodes[2].getchaintips()[0]['height'], 0)
|
|
|
|
assert self.nodes[1].getbestblockhash() != self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[2].getblockcount(), starting_blockcount)
|
|
|
|
self.log.info("Generating one more block")
|
|
self.nodes[0].generate(1)
|
|
|
|
self.log.info("Verifying nodes are all synced")
|
|
|
|
# Because nodes in regtest are all manual connections (eg using
|
|
# addnode), node1 should not have disconnected node0. If not for that,
|
|
# we'd expect node1 to have disconnected node0 for serving an
|
|
# insufficient work chain, in which case we'd need to reconnect them to
|
|
# continue the test.
|
|
|
|
self.sync_all()
|
|
self.log.info("Blockcounts: %s", [n.getblockcount() for n in self.nodes])
|
|
|
|
if __name__ == '__main__':
|
|
MinimumChainWorkTest().main()
|