mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
ab430bdb81
1ef2138c0db3bd4f9332c777fa3fb2770dc1b08c lint: run mypy over contrib/devtools (fanquake) Pull request description: wumpus mentioned on IRC that we don't currently run `mypy` over the `contrib/devtools` directory, and that it would likely be worthwhile given #20434. This just adds that dir to the linter, as well as some missing annotations to fix existing errors. Note that now we require Python 3.6 we can make use of variable annotations. master (patched to check contrib devtools): ```bash test/lint/lint-python.sh contrib/devtools/symbol-check.py:154: error: Incompatible types in assignment (expression has type "List[str]", variable has type "str") contrib/devtools/circular-dependencies.py:35: error: Need type annotation for 'deps' (hint: "deps: Dict[<type>, <type>] = ...") contrib/devtools/circular-dependencies.py:67: error: Need type annotation for 'closure' (hint: "closure: Dict[<type>, <type>] = ...") Found 4 errors in 3 files (checked 187 source files) ``` I haven't quite gone as far as to add annotations like ```python CHECKS: Dict[str, List[Tuple[str, Callable[[Any], bool]]]] = {... ``` to `symbol-check.py`. ACKs for top commit: laanwj: ACK 1ef2138c0db3bd4f9332c777fa3fb2770dc1b08c Tree-SHA512: a58c2ece588c640289dc1d35dad5b1b8732788272daa0965d6bf44ee8a7f7c8e8585f94d233ac41c84b9ffcfc97841a00fe2c9acba41f58fd164f01de4b6512b
291 lines
9.3 KiB
Python
Executable File
291 lines
9.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014 Wladimir J. van der Laan
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
'''
|
|
A script to check that the (Linux) release executables only contain
|
|
certain symbols and are only linked against allowed libraries.
|
|
|
|
Example usage:
|
|
|
|
find ../path/to/binaries -type f -executable | xargs python3 contrib/devtools/symbol-check.py
|
|
'''
|
|
import sys
|
|
from typing import Dict, List
|
|
|
|
import lief
|
|
|
|
# Debian 11 (Bullseye) EOL: est. 2026 https://wiki.debian.org/LTS
|
|
#
|
|
# - libgcc version 10.2.1 (https://packages.debian.org/search?suite=bullseye&arch=any&searchon=names&keywords=libgcc-s1)
|
|
# - libc version 2.31 (https://packages.debian.org/search?suite=bullseye&arch=any&searchon=names&keywords=libc6)
|
|
#
|
|
# Ubuntu 20.04 (Focal) EOL: 2030. https://wiki.ubuntu.com/ReleaseTeam
|
|
#
|
|
# - libgcc version 10.3.0 (https://packages.ubuntu.com/focal/libgcc1)
|
|
# - libc version 2.31 (https://packages.ubuntu.com/focal/libc6)
|
|
#
|
|
# CentOS Stream 9 EOL: est. 2027 https://www.centos.org/cl-vs-cs
|
|
#
|
|
# - libgcc version 12.2.1 (https://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/Packages)
|
|
# - libc version 2.34 (https://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/Packages)
|
|
#
|
|
# See https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html for more info.
|
|
|
|
MAX_VERSIONS = {
|
|
'GCC': (4,8,0),
|
|
'GLIBC': {
|
|
lief.ELF.ARCH.x86_64: (2,31),
|
|
lief.ELF.ARCH.ARM: (2,31),
|
|
lief.ELF.ARCH.AARCH64:(2,31),
|
|
lief.ELF.ARCH.PPC64: (2,31),
|
|
lief.ELF.ARCH.RISCV: (2,31),
|
|
},
|
|
'LIBATOMIC': (1,0),
|
|
'V': (0,5,0), # xkb (bitcoin-qt only)
|
|
}
|
|
|
|
# Ignore symbols that are exported as part of every executable
|
|
IGNORE_EXPORTS = {
|
|
'_edata', '_end', '__end__', '_init', '__bss_start', '__bss_start__', '_bss_end__',
|
|
'__bss_end__', '_fini', '_IO_stdin_used', 'stdin', 'stdout', 'stderr',
|
|
'environ', '_environ', '__environ',
|
|
# Used in stacktraces.cpp
|
|
'__cxa_demangle'
|
|
}
|
|
|
|
# Expected linker-loader names can be found here:
|
|
# https://sourceware.org/glibc/wiki/ABIList?action=recall&rev=16
|
|
ELF_INTERPRETER_NAMES: Dict[lief.ELF.ARCH, Dict[lief.ENDIANNESS, str]] = {
|
|
lief.ELF.ARCH.x86_64: {
|
|
lief.ENDIANNESS.LITTLE: "/lib64/ld-linux-x86-64.so.2",
|
|
},
|
|
lief.ELF.ARCH.ARM: {
|
|
lief.ENDIANNESS.LITTLE: "/lib/ld-linux-armhf.so.3",
|
|
},
|
|
lief.ELF.ARCH.AARCH64: {
|
|
lief.ENDIANNESS.LITTLE: "/lib/ld-linux-aarch64.so.1",
|
|
},
|
|
lief.ELF.ARCH.PPC64: {
|
|
lief.ENDIANNESS.BIG: "/lib64/ld64.so.1",
|
|
lief.ENDIANNESS.LITTLE: "/lib64/ld64.so.2",
|
|
},
|
|
lief.ELF.ARCH.RISCV: {
|
|
lief.ENDIANNESS.LITTLE: "/lib/ld-linux-riscv64-lp64d.so.1",
|
|
},
|
|
}
|
|
|
|
# Allowed NEEDED libraries
|
|
ELF_ALLOWED_LIBRARIES = {
|
|
# dashd and dash-qt
|
|
'libgcc_s.so.1', # GCC base support
|
|
'libc.so.6', # C library
|
|
'libpthread.so.0', # threading
|
|
'libm.so.6', # math library
|
|
'librt.so.1', # real-time (clock)
|
|
'libatomic.so.1',
|
|
'ld-linux-x86-64.so.2', # 64-bit dynamic linker
|
|
'ld-linux.so.2', # 32-bit dynamic linker
|
|
'ld-linux-aarch64.so.1', # 64-bit ARM dynamic linker
|
|
'ld-linux-armhf.so.3', # 32-bit ARM dynamic linker
|
|
'ld64.so.1', # POWER64 ABIv1 dynamic linker
|
|
'ld64.so.2', # POWER64 ABIv2 dynamic linker
|
|
'ld-linux-riscv64-lp64d.so.1', # 64-bit RISC-V dynamic linker
|
|
'libz.so.1', # zlib
|
|
# dash-qt only
|
|
'libxcb.so.1', # part of X11
|
|
'libxcb-shm.so.0', # X11 shared memory extension
|
|
'libxkbcommon.so.0', # keyboard keymapping
|
|
'libxkbcommon-x11.so.0', # keyboard keymapping
|
|
'libfontconfig.so.1', # font support
|
|
'libfreetype.so.6', # font parsing
|
|
'libdl.so.2', # programming interface to dynamic linker
|
|
'libxcb-icccm.so.4',
|
|
'libxcb-image.so.0',
|
|
'libxcb-shm.so.0',
|
|
'libxcb-keysyms.so.1',
|
|
'libxcb-randr.so.0',
|
|
'libxcb-render-util.so.0',
|
|
'libxcb-render.so.0',
|
|
'libxcb-shape.so.0',
|
|
'libxcb-sync.so.1',
|
|
'libxcb-xfixes.so.0',
|
|
'libxcb-xinerama.so.0',
|
|
'libxcb-xkb.so.1',
|
|
}
|
|
|
|
MACHO_ALLOWED_LIBRARIES = {
|
|
# bitcoind and bitcoin-qt
|
|
'libc++.1.dylib', # C++ Standard Library
|
|
'libSystem.B.dylib', # libc, libm, libpthread, libinfo
|
|
# bitcoin-qt only
|
|
'AppKit', # user interface
|
|
'ApplicationServices', # common application tasks.
|
|
'Carbon', # deprecated c back-compat API
|
|
'ColorSync',
|
|
'CoreFoundation', # low level func, data types
|
|
'CoreGraphics', # 2D rendering
|
|
'CoreServices', # operating system services
|
|
'CoreText', # interface for laying out text and handling fonts.
|
|
'CoreVideo', # video processing
|
|
'Foundation', # base layer functionality for apps/frameworks
|
|
'ImageIO', # read and write image file formats.
|
|
'IOKit', # user-space access to hardware devices and drivers.
|
|
'IOSurface', # cross process image/drawing buffers
|
|
'libobjc.A.dylib', # Objective-C runtime library
|
|
'Metal', # 3D graphics
|
|
'Security', # access control and authentication
|
|
'QuartzCore', # animation
|
|
}
|
|
|
|
PE_ALLOWED_LIBRARIES = {
|
|
'ADVAPI32.dll', # security & registry
|
|
'IPHLPAPI.DLL', # IP helper API
|
|
'KERNEL32.dll', # win32 base APIs
|
|
'msvcrt.dll', # C standard library for MSVC
|
|
'SHELL32.dll', # shell API
|
|
'USER32.dll', # user interface
|
|
'WS2_32.dll', # sockets
|
|
'bcrypt.dll',
|
|
# bitcoin-qt only
|
|
'dwmapi.dll', # desktop window manager
|
|
'GDI32.dll', # graphics device interface
|
|
'IMM32.dll', # input method editor
|
|
'NETAPI32.dll',
|
|
'ole32.dll', # component object model
|
|
'OLEAUT32.dll', # OLE Automation API
|
|
'SHLWAPI.dll', # light weight shell API
|
|
'USERENV.dll',
|
|
'UxTheme.dll',
|
|
'VERSION.dll', # version checking
|
|
'WINMM.dll', # WinMM audio API
|
|
'WTSAPI32.dll',
|
|
}
|
|
|
|
def check_version(max_versions, version, arch) -> bool:
|
|
(lib, _, ver) = version.rpartition('_')
|
|
ver = tuple([int(x) for x in ver.split('.')])
|
|
if not lib in max_versions:
|
|
return False
|
|
if isinstance(max_versions[lib], tuple):
|
|
return ver <= max_versions[lib]
|
|
else:
|
|
return ver <= max_versions[lib][arch]
|
|
|
|
def check_imported_symbols(binary) -> bool:
|
|
ok: bool = True
|
|
|
|
for symbol in binary.imported_symbols:
|
|
if not symbol.imported:
|
|
continue
|
|
|
|
version = symbol.symbol_version if symbol.has_version else None
|
|
|
|
if version:
|
|
aux_version = version.symbol_version_auxiliary.name if version.has_auxiliary_version else None
|
|
if aux_version and not check_version(MAX_VERSIONS, aux_version, binary.header.machine_type):
|
|
print(f'{filename}: symbol {symbol.name} from unsupported version {version}')
|
|
ok = False
|
|
return ok
|
|
|
|
def check_exported_symbols(binary) -> bool:
|
|
ok: bool = True
|
|
|
|
for symbol in binary.dynamic_symbols:
|
|
if not symbol.exported:
|
|
continue
|
|
name = symbol.name
|
|
if binary.header.machine_type == lief.ELF.ARCH.RISCV or name in IGNORE_EXPORTS:
|
|
continue
|
|
print(f'{binary.name}: export of symbol {name} not allowed!')
|
|
ok = False
|
|
return ok
|
|
|
|
def check_ELF_libraries(binary) -> bool:
|
|
ok: bool = True
|
|
for library in binary.libraries:
|
|
if library not in ELF_ALLOWED_LIBRARIES:
|
|
print(f'{filename}: {library} is not in ALLOWED_LIBRARIES!')
|
|
ok = False
|
|
return ok
|
|
|
|
def check_MACHO_libraries(binary) -> bool:
|
|
ok: bool = True
|
|
for dylib in binary.libraries:
|
|
split = dylib.name.split('/')
|
|
if split[-1] not in MACHO_ALLOWED_LIBRARIES:
|
|
print(f'{split[-1]} is not in ALLOWED_LIBRARIES!')
|
|
ok = False
|
|
return ok
|
|
|
|
def check_MACHO_min_os(binary) -> bool:
|
|
if binary.build_version.minos == [10,15,0]:
|
|
return True
|
|
return False
|
|
|
|
def check_MACHO_sdk(binary) -> bool:
|
|
if binary.build_version.sdk == [11, 0, 0]:
|
|
return True
|
|
return False
|
|
|
|
def check_PE_libraries(binary) -> bool:
|
|
ok: bool = True
|
|
for dylib in binary.libraries:
|
|
if dylib not in PE_ALLOWED_LIBRARIES:
|
|
print(f'{dylib} is not in ALLOWED_LIBRARIES!')
|
|
ok = False
|
|
return ok
|
|
|
|
def check_PE_subsystem_version(binary) -> bool:
|
|
major: int = binary.optional_header.major_subsystem_version
|
|
minor: int = binary.optional_header.minor_subsystem_version
|
|
if major == 6 and minor == 1:
|
|
return True
|
|
return False
|
|
|
|
def check_ELF_interpreter(binary) -> bool:
|
|
expected_interpreter = ELF_INTERPRETER_NAMES[binary.header.machine_type][binary.abstract.header.endianness]
|
|
|
|
return binary.concrete.interpreter == expected_interpreter
|
|
|
|
CHECKS = {
|
|
lief.EXE_FORMATS.ELF: [
|
|
('IMPORTED_SYMBOLS', check_imported_symbols),
|
|
('EXPORTED_SYMBOLS', check_exported_symbols),
|
|
('LIBRARY_DEPENDENCIES', check_ELF_libraries),
|
|
('INTERPRETER_NAME', check_ELF_interpreter),
|
|
],
|
|
lief.EXE_FORMATS.MACHO: [
|
|
('DYNAMIC_LIBRARIES', check_MACHO_libraries),
|
|
('MIN_OS', check_MACHO_min_os),
|
|
('SDK', check_MACHO_sdk),
|
|
],
|
|
lief.EXE_FORMATS.PE: [
|
|
('DYNAMIC_LIBRARIES', check_PE_libraries),
|
|
('SUBSYSTEM_VERSION', check_PE_subsystem_version),
|
|
]
|
|
}
|
|
|
|
if __name__ == '__main__':
|
|
retval: int = 0
|
|
for filename in sys.argv[1:]:
|
|
try:
|
|
binary = lief.parse(filename)
|
|
etype = binary.format
|
|
if etype == lief.EXE_FORMATS.UNKNOWN:
|
|
print(f'{filename}: unknown executable format')
|
|
retval = 1
|
|
continue
|
|
|
|
failed: List[str] = []
|
|
for (name, func) in CHECKS[etype]:
|
|
if not func(binary):
|
|
failed.append(name)
|
|
if failed:
|
|
print(f'{filename}: failed {" ".join(failed)}')
|
|
retval = 1
|
|
except IOError:
|
|
print(f'{filename}: cannot open')
|
|
retval = 1
|
|
sys.exit(retval)
|