mirror of https://github.com/dashpay/dash.git synced 2024-12-24 19:42:46 +01:00

Dash - Reinventing Cryptocurrency

bitcoin blockchain cryptocurrency dash governance instant masternode p2p privacy

Go to file

pasta 0946eec692 Merge #6327 : backport: merge bitcoin#23046, #24138 , #24812 , #24626 , #21726 , #25123 , #25074 , #24832 , #26215 , #24858 , #26417 , #16981 (index backports) `7d9ff96091` merge bitcoin#16981: Improve runtime performance of --reindex (Kittywhiskers Van Gogh) `e531dff5f7` merge bitcoin#26417: fix intermittent failure in feature_index_prune.py (Kittywhiskers Van Gogh) `b04b71a957` merge bitcoin#24858: incorrect blk file size calculation during reindex results in recoverable blk file corruption (Kittywhiskers Van Gogh) `9e75b99c53` merge bitcoin#26215: Improve BaseIndex::BlockUntilSyncedToCurrentChain reliability (Kittywhiskers Van Gogh) `3bd584c845` merge bitcoin#24832: Verify the block filter hash when reading the filter from disk (Kittywhiskers Van Gogh) `e507a51323` fix: avoid `mandatory-script-verify-flag-failed` crash in bench test (Kittywhiskers Van Gogh) `a86109a017` merge bitcoin#25074: During sync, commit best block after indexing (Kittywhiskers Van Gogh) `e6867a35ce` merge bitcoin#25123: Fix race condition in index prune test (Kittywhiskers Van Gogh) `baf6e26eed` merge bitcoin#21726: Improve Indices on pruned nodes via prune blockers (Kittywhiskers Van Gogh) `c65ec190c5` merge bitcoin#24626: disallow reindex-chainstate when pruning (Kittywhiskers Van Gogh) `bcd24a25e3` fix: push activation height for forks ahead, fix `feature_pruning.py` (Kittywhiskers Van Gogh) `10203560f5` merge bitcoin#24812: Add CHECK_NONFATAL identity function and NONFATAL_UNREACHABLE macro (Kittywhiskers Van Gogh) `1caaa85716` merge bitcoin#24138: Commit MuHash and best block together for coinstatsindex (Kittywhiskers Van Gogh) `b218f123b7` merge bitcoin#23046: Add txindex migration test (Kittywhiskers Van Gogh) `ebae59eedf` fix: make sure we flush our committed best block in no-upgrade cases (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * When backporting [bitcoin#23046](https://github.com/bitcoin/bitcoin/pull/23046), it was discovered that there has been a longstanding bug in `CDeterministicMNManager::MigrateDBIfNeeded`(`2`)`()` that flagged a database taken from an older version for failing its "previous migration attempt", requiring the database to be fully rebuilt through a reindex. This occurred because the older database would be read pre-DIP3 in `MigrateDBIfNeeded()`, which then caused the migration logic to write the new best block ([source](`3f0c2ff324/src/evo/deterministicmns.cpp (L1236-L1241)`)) (the legacy best block is erased before the DIP3 condition is checked, [source](`3f0c2ff324/src/evo/deterministicmns.cpp (L1233)`)) but while it completed the transaction ([source](`3f0c2ff324/src/evo/deterministicmns.cpp (L1240)`)), critically, it didn't write it to disk (example of writing to disk, [here](`3f0c2ff324/src/evo/deterministicmns.cpp (L1288-L1292)`)). This meant that when it was read again by `MigrateDBIfNeeded2()`, it saw three things a) there is no new best block (because it didn't get written), b) there is no legacy best block (because it gets erased before the new best block is written) and c) that the chain height is greater than 1 (since this isn't a new datadir and the chain has already advanced), it concludes that it was a botched migration attempt and fails ([source](`3f0c2ff324/src/evo/deterministicmns.cpp (L1337-L1343)`)). This bug affects v19 to `develop` (`3f0c2ff3` as of this writing) and prevents `feature_txindex_compatibility.py` from working as expected as it would migrate legacy databases to newer versions to test txindex migration code and get stuck at unhappy EvoDB migration logic, to allow the test to function properly when testing against the latest version of the client, this bug has been fixed as part of this PR. * In [bitcoin#23046](https://github.com/bitcoin/bitcoin/pull/23046), version v0.17 was used as the last version to support legacy txindex as the updated txindex format was introduced in [dash#4178](https://github.com/dashpay/dash/pull/4178) (i.e. after v0.17) and the version selected for having migration code in it (note, migration code was removed in [dash#6296](https://github.com/dashpay/dash/pull/6296), so far not included as part of any release) was v18.2.2 despite the range being v18.x to v21.x was a) due to the bug mentioned above affecting v19.x onwards and b) v18.2.2 being the latest release in the v18.x lifecycle. * The specific version number used for v0.17 is `170003` as the binaries corresponding to `170000` are not populated in `releases/`, which causes a CI failure ([source](https://gitlab.com/dashpay/dash/-/jobs/8073041955#L380)) * As of `develop` (`3f0c2ff3` as of this writing), `feature_pruning.py` was broken due to changes in Core that were not adjusted for, namely: * The enforcement of `MAX_STANDARD_TX_SIZE` ([source](`3f0c2ff324/src/policy/policy.h (L23-L24)`)) from DIP1 onwards ([source](`3f0c2ff324/src/validation.cpp (L299-L301)`)) resulting in `bad-txns-oversize` errors in blocks generated for the test as the transactions generated are ~9.5x larger than the now-enforced limit ([source](`3f0c2ff324/test/functional/feature_pruning.py (L48C51-L48C57)`)), this is resolved by pushing the DIP1 activation height upwards to `2000` (the same activation height used for DIP3 and DIP8). * Change in subsidy logic in v20 ([source](`3f0c2ff324/src/validation.cpp (L1073-L1082)`)) that results in `bad-cb-amount` errors, this is resolved by pushing the v20 activation height upwards. Additionally, an inopportune implicit post-`generate` sync ([source](`3f0c2ff324/test/functional/feature_pruning.py (L215)`)) also causes the test to fail. Alongside the above, they have been resolved in this PR. * As of `develop` (`3f0c2ff3` as of this writing), `bench_dash` crashes when running the `AssembleBlock` benchmark. The regression was traced back to [bitcoin#21840](https://github.com/bitcoin/bitcoin/pull/21840) (`5d10b41`) in [dash#6152](https://github.com/dashpay/dash/pull/6152) due to the switch to `P2SH_OP_TRUE`. This has been resolved by reverting this particular change. <details> <summary>Pre-fix test failure:</summary> ``` $ ./src/bench/bench_dash Warning, results might be unstable: * CPU governor is '' but should be 'performance' * Turbo is enabled, CPU frequency will fluctuate Recommendations * Use 'pyperf system tune' before benchmarking. See https://github.com/psf/pyperf \| ns/op \| op/s \| err% \| ins/op \| bra/op \| miss% \| total \| benchmark \|--------------------:\|--------------------:\|--------:\|----------------:\|---------------:\|--------:\|----------:\|:---------- \| 17,647,657.00 \| 56.66 \| 0.1% \| 231,718,349.00 \| 42,246,265.00 \| 0.1% \| 0.20 \| `AddrManAdd` \| 42,201,861.00 \| 23.70 \| 0.1% \| 544,366,811.00 \| 102,569,244.00 \| 0.0% \| 0.46 \| `AddrManAddThenGood` \| 189,697.83 \| 5,271.54 \| 0.1% \| 1,763,991.40 \| 356,189.40 \| 0.3% \| 0.01 \| `AddrManGetAddr` \| 454.38 \| 2,200,808.04 \| 0.6% \| 6,229.11 \| 1,343.92 \| 0.1% \| 0.01 \| `AddrManSelect` \| 1,066,471.00 \| 937.67 \| 67.6% \| 13,350,463.00 \| 3,150,465.00 \| 0.4% \| 0.01 \| 〰️ `AddrManSelectByNetwork` (Unstable with ~1.0 iters. Increase `minEpochIterations` to e.g. 10) \| 1,181,774.50 \| 846.19 \| 49.0% \| 18,358,489.50 \| 4,224,642.50 \| 0.0% \| 0.02 \| 〰️ `AddrManSelectFromAlmostEmpty` (Unstable with ~1.1 iters. Increase `minEpochIterations` to e.g. 11) bench_dash: bench/block_assemble.cpp:46: void AssembleBlock(benchmark::Bench &): Assertion `res.m_result_type == MempoolAcceptResult::ResultType::VALID' failed. [1] 2343746 IOT instruction (core dumped) ./src/bench/bench_dash ``` </details> ## Breaking changes None expected ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation (note: N/A) - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK `7d9ff96091` PastaPastaPasta: utACK `7d9ff96091` Tree-SHA512: e2f1e58abb0a0368c4f1d5e488520957e042e6207b7d2d68a15eb18662405a3cdac91c5ff8e93c8a94c0fdab9b1412bd608d055f196230506c1640439939c25d		2024-10-21 11:32:29 -05:00
.github	Squashed 'src/dashbls/' changes from 795660db76..4e070243ae	2024-10-09 17:25:18 +03:00
.tx	fix: follow-up #5393 - should be used `[dash.dash_ents]` (#5472 )	2023-07-01 14:16:50 +03:00
build-aux/m4	Merge bitcoin/bitcoin#30567 : qt, build: Drop `QT_STATICPLUGIN` macro	2024-10-03 01:16:40 -05:00
ci	chore: run `contrib/devtools/copyright_header.py update .`	2024-10-05 23:17:41 +03:00
contrib	Squashed 'src/dashbls/' changes from 795660db76..4e070243ae	2024-10-09 17:25:18 +03:00
depends	build: set `-march` irrespective of target operating system	2024-10-08 14:52:16 +00:00
doc	Merge #6319 : backport: bitcoin#19668, #21598 , #19979 , #28774 - lock annotations	2024-10-21 09:08:38 -05:00
share	Merge #6111 : backport: bitcoin-core/gui#154 , #176 , #221 , #248 , #251 - qt improvements and related fixes	2024-07-23 14:17:33 -05:00
src	Merge #6327 : backport: merge bitcoin#23046, #24138 , #24812 , #24626 , #21726 , #25123 , #25074 , #24832 , #26215 , #24858 , #26417 , #16981 (index backports)	2024-10-21 11:32:29 -05:00
test	Merge #6327 : backport: merge bitcoin#23046, #24138 , #24812 , #24626 , #21726 , #25123 , #25074 , #24832 , #26215 , #24858 , #26417 , #16981 (index backports)	2024-10-21 11:32:29 -05:00
.cirrus.yml	merge bitcoin#23564: don't use deprecated brew package names	2024-10-08 15:59:17 +00:00
.dockerignore	build: add dash minimal development environment container	2021-12-21 12:43:37 +05:30
.editorconfig	Merge #21123 : code style: Add EditorConfig file	2021-07-16 10:04:09 -05:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	Merge bitcoin/bitcoin#29733 : build, macos: Drop unused `osx_volname` target	2024-10-04 12:54:24 -05:00
.gitlab-ci.yml	fix: missing changes from bitcoin#19267 - run multiprocess on CI	2024-07-24 20:06:12 +07:00
.python-version	partial bitcoin#27483: Bump python minimum version to 3.8	2023-05-11 09:18:48 -05:00
.style.yapf	Merge #15533 : test: .style.yapf: Set column_limit=160	2021-07-10 12:10:51 -05:00
autogen.sh	Merge #17829 : scripted-diff: Bump copyright of files changed in 2019	2023-12-06 11:40:14 -06:00
CMakeLists.txt	chore: Added missing sources files in CMake (#5503 )	2023-07-25 12:23:56 -05:00
configure.ac	Squashed 'src/dashbls/' changes from 795660db76..4e070243ae	2024-10-09 17:25:18 +03:00
CONTRIBUTING.md	Merge #6220 : backport: Merge bitcoin#18448,24433, 24139, 23001, (partial) 24339, (partial) core/gui#420	2024-09-27 12:29:08 -05:00
COPYING	docs: update license year range to 2024 (#5890 )	2024-02-22 20:56:43 -06:00
INSTALL.md	Dashify INSTALL.md and build-unix.md	2018-01-12 16:12:54 +01:00
libdashconsensus.pc.in	revert dash#1432: Rename consensus source library and API	2022-08-09 14:16:28 +05:30
Makefile.am	Squashed 'src/dashbls/' changes from 795660db76..4e070243ae	2024-10-09 17:25:18 +03:00
README.md	doc: make build steps more prominent	2024-07-18 01:22:42 -06:00
SECURITY.md	docs: update SECURITY.md supported versions	2024-07-16 15:32:39 +00:00

README.md

Dash Core staging tree

CI	master	develop
Gitlab

https://www.dash.org

For an immediately usable, binary version of the Dash Core software, see https://www.dash.org/downloads/.

Further information about Dash Core is available in ./doc/.

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information read the original Dash whitepaper.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The develop branch is regularly built (see doc/build-*.md for instructions) and tested, but is not guaranteed to be completely stable.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Build / Compile from Source

The ./configure, make, and cmake steps, as well as build dependencies, are in ./doc/ as well:

Linux: ./doc/build-unix.md
Ubuntu, Debian, Fedora, Arch, and others
macOS: ./doc/build-osx.md
Windows: ./doc/build-windows.md
OpenBSD: ./doc/build-openbsd.md
FreeBSD: ./doc/build-freebsd.md
NetBSD: ./doc/build-netbsd.md

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.