mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
3233445aa7
747cd17404832604c50d03d58e11ba816bb229f7 build: no-longer fail default configure if BDB isn't available (fanquake)
Pull request description:
Inline with moving to descriptor (sqlite) wallets by default for 0.23,
this adapts the build system so that a default `./configure` invocation
no-longer fails if BDB isn't present. Currently, if configure is run
with no options, and no BDB is present, we'll fail with:
```bash
checking for Berkeley DB C++ headers... no
configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support)
```
If descriptor wallets are to be the default, this behaviour no longer
makes sense, as a builder should be able to configure and build, to use
a wallet, without BDB installed, and without passing additional
arguments, i.e `--without-bdb` or `--with-incompatible-bdb`, to
configure.
With this change, running configure will no-longer fail, but will
instead print:
```bash
checking for Berkeley DB C++ headers... no
configure: WARNING: libdb_cxx headers missing
configure: WARNING: Bitcoin Core requires this library for BDB (legacy) wallet support
configure: WARNING: Passing --without-bdb will suppress this warning
checking for sqlite3 >= 3.7.17... yes
checking whether to build wallet with support for sqlite... yes
```
ACKs for top commit:
hebasto:
ACK 747cd17404832604c50d03d58e11ba816bb229f7, tested on Linux Mint 20.2 (x86_64) with the (un)installed system packages `libdb-dev` and `libdb++-dev`.
Tree-SHA512: ae316d71ad0803c9d4b02a5fedcade08242650d987cc047840493ba4a881e71ff48b099075bb7c325307d44744fcdeccb57f7fa8db4135c81a5835841f562afa
|
||
|---|---|---|
| .. | ||
| ax_boost_base.m4 | ||
| ax_boost_filesystem.m4 | ||
| ax_boost_thread.m4 | ||
| ax_boost_unit_test_framework.m4 | ||
| ax_check_compile_flag.m4 | ||
| ax_check_link_flag.m4 | ||
| ax_check_preproc_flag.m4 | ||
| ax_cxx_compile_stdcxx.m4 | ||
| ax_gcc_func_attribute.m4 | ||
| ax_pthread.m4 | ||
| bitcoin_find_bdb48.m4 | ||
| bitcoin_qt.m4 | ||
| bitcoin_runtime_lib.m4 | ||
| bitcoin_subdir_to_include.m4 | ||
| l_atomic.m4 | ||
| l_socket.m4 | ||