mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
9f4f52ae4e
68400d8b96 tests: Use explicit imports (practicalswift) Pull request description: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools. An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports. Before this commit: ``` $ contrib/devtools/lint-python.sh | head -10 ./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util $ ``` After this commit: ``` $ contrib/devtools/lint-python.sh | head -10 $ ``` Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
126 lines
4.6 KiB
Python
Executable File
126 lines
4.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2021 The Dash Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
'''
|
|
feature_llmq_connections.py
|
|
|
|
Checks intra quorum connections
|
|
|
|
'''
|
|
|
|
import time
|
|
|
|
from test_framework.test_framework import DashTestFramework
|
|
from test_framework.util import assert_greater_than_or_equal, connect_nodes, wait_until
|
|
|
|
|
|
class LLMQConnections(DashTestFramework):
|
|
def set_test_params(self):
|
|
self.set_dash_test_params(15, 14, fast_dip3_enforcement=True)
|
|
self.set_dash_llmq_test_params(5, 3)
|
|
|
|
def run_test(self):
|
|
self.nodes[0].spork("SPORK_17_QUORUM_DKG_ENABLED", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
q = self.mine_quorum()
|
|
|
|
self.log.info("checking for old intra quorum connections")
|
|
total_count = 0
|
|
for mn in self.get_quorum_masternodes(q):
|
|
count = self.get_mn_connection_count(mn.node)
|
|
total_count += count
|
|
assert_greater_than_or_equal(count, 2)
|
|
assert(total_count < 40)
|
|
|
|
self.check_reconnects(2)
|
|
|
|
self.log.info("Activating SPORK_23_QUORUM_POSE")
|
|
self.nodes[0].spork("SPORK_23_QUORUM_POSE", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
self.log.info("mining one block and waiting for all members to connect to each other")
|
|
self.nodes[0].generate(1)
|
|
for mn in self.get_quorum_masternodes(q):
|
|
self.wait_for_mnauth(mn.node, 4)
|
|
|
|
self.log.info("mine a new quorum and verify that all members connect to each other")
|
|
q = self.mine_quorum()
|
|
|
|
self.log.info("checking that all MNs got probed")
|
|
for mn in self.get_quorum_masternodes(q):
|
|
wait_until(lambda: self.get_mn_probe_count(mn.node, q, False) == 4)
|
|
|
|
self.log.info("checking that probes age")
|
|
self.bump_mocktime(60)
|
|
for mn in self.get_quorum_masternodes(q):
|
|
wait_until(lambda: self.get_mn_probe_count(mn.node, q, False) == 0)
|
|
|
|
self.log.info("mine a new quorum and re-check probes")
|
|
q = self.mine_quorum()
|
|
for mn in self.get_quorum_masternodes(q):
|
|
wait_until(lambda: self.get_mn_probe_count(mn.node, q, True) == 4)
|
|
|
|
self.log.info("Activating SPORK_21_QUORUM_ALL_CONNECTED")
|
|
self.nodes[0].spork("SPORK_21_QUORUM_ALL_CONNECTED", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
self.check_reconnects(4)
|
|
|
|
def check_reconnects(self, expected_connection_count):
|
|
self.log.info("disable and re-enable networking on all masternodes")
|
|
for mn in self.mninfo:
|
|
mn.node.setnetworkactive(False)
|
|
for mn in self.mninfo:
|
|
wait_until(lambda: len(mn.node.getpeerinfo()) == 0)
|
|
for mn in self.mninfo:
|
|
mn.node.setnetworkactive(True)
|
|
self.bump_mocktime(60)
|
|
|
|
self.log.info("verify that all masternodes re-connected")
|
|
for q in self.nodes[0].quorum('list')['llmq_test']:
|
|
for mn in self.get_quorum_masternodes(q):
|
|
self.wait_for_mnauth(mn.node, expected_connection_count)
|
|
|
|
# Also re-connect non-masternode connections
|
|
for i in range(1, len(self.nodes)):
|
|
connect_nodes(self.nodes[i], 0)
|
|
self.nodes[i].ping()
|
|
# wait for ping/pong so that we can be sure that spork propagation works
|
|
time.sleep(1) # needed to make sure we don't check before the ping is actually sent (fPingQueued might be true but SendMessages still not called)
|
|
for i in range(1, len(self.nodes)):
|
|
wait_until(lambda: all('pingwait' not in peer for peer in self.nodes[i].getpeerinfo()))
|
|
|
|
def get_mn_connection_count(self, node):
|
|
peers = node.getpeerinfo()
|
|
count = 0
|
|
for p in peers:
|
|
if 'verified_proregtx_hash' in p and p['verified_proregtx_hash'] != '':
|
|
count += 1
|
|
return count
|
|
|
|
def get_mn_probe_count(self, node, q, check_peers):
|
|
count = 0
|
|
mnList = node.protx('list', 'registered', 1)
|
|
peerList = node.getpeerinfo()
|
|
mnMap = {}
|
|
peerMap = {}
|
|
for mn in mnList:
|
|
mnMap[mn['proTxHash']] = mn
|
|
for p in peerList:
|
|
if 'verified_proregtx_hash' in p and p['verified_proregtx_hash'] != '':
|
|
peerMap[p['verified_proregtx_hash']] = p
|
|
for mn in self.get_quorum_masternodes(q):
|
|
pi = mnMap[mn.proTxHash]
|
|
if pi['metaInfo']['lastOutboundSuccessElapsed'] < 60:
|
|
count += 1
|
|
elif check_peers and mn.proTxHash in peerMap:
|
|
count += 1
|
|
return count
|
|
|
|
|
|
if __name__ == '__main__':
|
|
LLMQConnections().main()
|