mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 03:52:49 +01:00
0fe885f5de
72eaab073bc747425fe551777154b13a6c4c37c9 tests: functional watch-only wallet tests (William Casarin)
72ffbdc5799c1707ecad674d701b43fb80b031d0 doc: add release note for include_watchonly default changes (William Casarin)
003a3c73c0450aa18ac2ab2ca47def2b8c53a7df rpcwallet: document include_watchonly default for watchonly wallets (William Casarin)
a50d9e6c0b8e8144d3deec58ec2e3449ba081151 rpcwallet: default include_watchonly to true for watchonly wallets (William Casarin)
Pull request description:
Right now it's a bit annoying to deal with watchonly wallets, many rpc commands have an `include_watchonly` argument that needs to be explicitly set.
Wallets created with `createwallet` can have a `disable_private_keys` parameter, for those wallets we already know that they are watchonly, so there's no reason to have to explicitly ask for it for every command. Instead we check this wallet flag when the `include_watchonly` parameter isn't set.
ACKs for top commit:
achow101:
Code review ACK 72eaab073bc747425fe551777154b13a6c4c37c9
Sjors:
ACK 72eaab073bc747425fe551777154b13a6c4c37c9
promag:
ACK 72eaab073bc747425fe551777154b13a6c4c37c9, code review only, didn't look closely to the test.
kallewoof:
ACK 72eaab073bc747425fe551777154b13a6c4c37c9
fanquake:
ACK 72eaab073bc747425fe551777154b13a6c4c37c9 - I've looked over the changes, they make sense to me. Compiled and ran the tests etc.
Tree-SHA512: d3646b55e97f386594d7efc994f0712f3888475c6a5dc7f131ac9f8c49bf5d4677182b88f42b34152abe1ad101ecadd152b4c20e9d3c1267190db36f77ab8bd7
|
||
|---|---|---|
| .. | ||
| gitian-building | ||
| man | ||
| release-notes/dash | ||
| .gitignore | ||
| assets-attribution.md | ||
| benchmarking.md | ||
| bips.md | ||
| bitcoin_logo_doxygen.png | ||
| build-cross.md | ||
| build-generic.md | ||
| build-netbsd.md | ||
| build-osx.md | ||
| build-unix.md | ||
| build-windows.md | ||
| dash-conf.md | ||
| descriptors.md | ||
| developer-notes.md | ||
| dnsseed-policy.md | ||
| Doxyfile.in | ||
| files.md | ||
| fuzzing.md | ||
| gitian-building.md | ||
| init.md | ||
| instantsend.md | ||
| JSON-RPC-interface.md | ||
| masternode-budget.md | ||
| productivity.md | ||
| psbt.md | ||
| README_doxygen.md | ||
| README_windows.txt | ||
| README.md | ||
| reduce-memory.md | ||
| reduce-traffic.md | ||
| release-notes-4023.md | ||
| release-notes-4704.md | ||
| release-notes-4751.md | ||
| release-notes-4756.md | ||
| release-notes-4822.md | ||
| release-notes-4885.md | ||
| release-notes-13152.md | ||
| release-notes-13756.md | ||
| release-notes-14021.md | ||
| release-notes-14023.md | ||
| release-notes-14468.md | ||
| release-notes-14802.md | ||
| release-notes-14941.md | ||
| release-notes-14954.md | ||
| release-notes-14982.md | ||
| release-notes-15006.md | ||
| release-notes-15226.md | ||
| release-notes-15492.md | ||
| release-notes-15566.md | ||
| release-notes-15637.md | ||
| release-notes-15937.md | ||
| release-notes-16383.md | ||
| release-notes-16394.md | ||
| release-notes-16512.md | ||
| release-notes-17410.md | ||
| release-notes-19219.md | ||
| release-notes-19671.md | ||
| release-notes-pr12255.md | ||
| release-notes-pr13381.md | ||
| release-notes.md | ||
| release-process.md | ||
| REST-interface.md | ||
| shared-libraries.md | ||
| tor.md | ||
| translation_process.md | ||
| translation_strings_policy.md | ||
| travis-ci.md | ||
| zmq.md | ||
Dash Core
This is the official reference wallet for Dash digital currency and comprises the backbone of the Dash peer-to-peer network. You can download Dash Core or build it yourself using the guides below.
Running
The following are some helpful notes on how to run Dash Core on your native platform.
Unix
Unpack the files into a directory and run:
bin/dash-qt(GUI) orbin/dashd(headless)
Windows
Unpack the files into a directory, and then run dash-qt.exe.
macOS
Drag Dash Core to your applications folder, and then run Dash Core.
Need Help?
- See the Dash documentation for help and more information.
- Ask for help on Dash Discord
- Ask for help on the Dash Forum
Building
The following are developer notes on how to build Dash Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.
- macOS Build Notes
- Unix Build Notes
- Windows Build Notes
- OpenBSD Build Notes
- NetBSD Build Notes
- Gitian Building Guide
Development
The Dash Core repo's root README contains relevant information on the development process and automated testing.
- Developer Notes
- Productivity Notes
- Release Notes
- Release Process
- Source Code Documentation TODO
- Translation Process
- Translation Strings Policy
- Travis CI
- JSON-RPC Interface
- Unauthenticated REST Interface
- Shared Libraries
- BIPS
- Dnsseed Policy
- Benchmarking
Resources
- See the Dash Developer Documentation for technical specifications and implementation details.
- Discuss on the Dash Forum, in the Development & Technical Discussion board.
- Discuss on Dash Discord
- Discuss on Dash Developers Discord
Miscellaneous
- Assets Attribution
- dash.conf Configuration File
- Files
- Fuzz-testing
- Reduce Memory
- Reduce Traffic
- Tor Support
- Init Scripts (systemd/upstart/openrc)
- ZMQ
- PSBT support
License
Distributed under the MIT software license.