mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
7cc77f3a30
ccd976dd3dbb8f991dc1203ada2043f1736be5a4 test: use 327 fewer blocks in feature_nulldummy (Jon Atack) 68c280f19732fb96bc29113ce9c8007d0101868c test, refactor: abstract the feature_nulldummy blockheight values (Jon Atack) Pull request description: The resolved timeout issue seen in the CI can be reproduced locally by running `test/functional/feature_nulldummy.py --valgrind --loglevel=debug` Speeds up the normal test runtime for me from 3.8 to 2.2 seconds (debug build). Thanks to Marco Falke for the approach suggestion. ACKs for top commit: AnthonyRonning: reACK ccd976dd3dbb8f991dc1203ada2043f1736be5a4 - ran a few times with the rest of the tests and still passing for me with just the fewer block change. MarcoFalke: review ACK ccd976dd3dbb8f991dc1203ada2043f1736be5a4 🏝 Tree-SHA512: 38339dca4276d1972e3a5a5ee436da64e9e58fd3b50b186e34b07ade9523ac4c03f6c3869c5f2a59c23b43c44f87e712f8297a01a8d83202049c081e3eeb4445
124 lines
5.9 KiB
Python
Executable File
124 lines
5.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2016-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test NULLDUMMY softfork.
|
|
|
|
Connect to a single node.
|
|
Generate 2 blocks (save the coinbases for later).
|
|
Generate COINBASE_MATURITY (CB) more blocks to ensure the coinbases are mature.
|
|
[Policy/Consensus] Check that NULLDUMMY compliant transactions are accepted in block CB + 3.
|
|
[Policy] Check that non-NULLDUMMY transactions are rejected before activation.
|
|
[Consensus] Check that the new NULLDUMMY rules are not enforced on block CB + 4.
|
|
[Policy/Consensus] Check that the new NULLDUMMY rules are enforced on block CB + 5.
|
|
"""
|
|
|
|
from test_framework.blocktools import (
|
|
COINBASE_MATURITY,
|
|
NORMAL_GBT_REQUEST_PARAMS,
|
|
create_block,
|
|
create_transaction,
|
|
)
|
|
from test_framework.messages import CTransaction
|
|
from test_framework.script import CScript
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
|
|
|
NULLDUMMY_ERROR = "non-mandatory-script-verify-flag (Dummy CHECKMULTISIG argument must be zero)"
|
|
|
|
def trueDummy(tx):
|
|
scriptSig = CScript(tx.vin[0].scriptSig)
|
|
newscript = []
|
|
for i in scriptSig:
|
|
if len(newscript) == 0:
|
|
assert len(i) == 0
|
|
newscript.append(b'\x51')
|
|
else:
|
|
newscript.append(i)
|
|
tx.vin[0].scriptSig = CScript(newscript)
|
|
tx.rehash()
|
|
|
|
class NULLDUMMYTest(BitcoinTestFramework):
|
|
|
|
def set_test_params(self):
|
|
# Need two nodes so GBT (getblocktemplate) doesn't complain that it's not connected.
|
|
self.num_nodes = 2
|
|
self.setup_clean_chain = True
|
|
self.extra_args = [['-whitelist=127.0.0.1', '-dip3params=105:105', '-bip147height=105']] * 2
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
self.nodes[0].createwallet(wallet_name='wmulti', disable_private_keys=True)
|
|
wmulti = self.nodes[0].get_wallet_rpc('wmulti')
|
|
w0 = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
|
|
self.address = w0.getnewaddress()
|
|
self.pubkey = w0.getaddressinfo(self.address)['pubkey']
|
|
self.ms_address = wmulti.addmultisigaddress(1, [self.pubkey])['address']
|
|
if not self.options.descriptors:
|
|
# Legacy wallets need to import these so that they are watched by the wallet. This is unnecssary (and does not need to be tested) for descriptor wallets
|
|
wmulti.importaddress(self.ms_address)
|
|
|
|
self.coinbase_blocks = self.nodes[0].generate(2) # block height = 2
|
|
coinbase_txid = []
|
|
for i in self.coinbase_blocks:
|
|
coinbase_txid.append(self.nodes[0].getblock(i)['tx'][0])
|
|
self.nodes[0].generate(COINBASE_MATURITY) # block height = COINBASE_MATURITY + 2
|
|
self.lastblockhash = self.nodes[0].getbestblockhash()
|
|
self.lastblockheight = COINBASE_MATURITY + 2
|
|
self.lastblocktime = self.mocktime + self.lastblockheight
|
|
|
|
self.log.info(f"Test 1: NULLDUMMY compliant base transactions should be accepted to mempool and mined before activation [{COINBASE_MATURITY + 3}]")
|
|
test1txs = [create_transaction(self.nodes[0], coinbase_txid[0], self.ms_address, amount=49)]
|
|
txid1 = self.nodes[0].sendrawtransaction(test1txs[0].serialize().hex(), 0)
|
|
test1txs.append(create_transaction(self.nodes[0], txid1, self.ms_address, amount=48))
|
|
txid2 = self.nodes[0].sendrawtransaction(test1txs[1].serialize().hex(), 0)
|
|
self.block_submit(self.nodes[0], test1txs, True)
|
|
|
|
self.log.info("Test 2: Non-NULLDUMMY base multisig transaction should not be accepted to mempool before activation")
|
|
test2tx = create_transaction(self.nodes[0], txid2, self.ms_address, amount=47)
|
|
trueDummy(test2tx)
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test2tx.serialize().hex(), 0)
|
|
|
|
self.log.info(f"Test 3: Non-NULLDUMMY base transactions should be accepted in a block before activation [{COINBASE_MATURITY + 4}]")
|
|
self.block_submit(self.nodes[0], [test2tx], True)
|
|
|
|
self.log.info("Test 4: Non-NULLDUMMY base multisig transaction is invalid after activation")
|
|
test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)
|
|
test6txs=[CTransaction(test4tx)]
|
|
trueDummy(test4tx)
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test4tx.serialize().hex(), 0)
|
|
self.block_submit(self.nodes[0], [test4tx])
|
|
|
|
self.log.info(f"Test 6: NULLDUMMY compliant base/witness transactions should be accepted to mempool and in block after activation [{COINBASE_MATURITY + 5}]")
|
|
for i in test6txs:
|
|
self.nodes[0].sendrawtransaction(i.serialize().hex(), 0)
|
|
self.block_submit(self.nodes[0], test6txs, True)
|
|
|
|
|
|
def block_submit(self, node, txs, accept = False):
|
|
dip4_activated = self.lastblockheight + 1 >= COINBASE_MATURITY + 5
|
|
tmpl = node.getblocktemplate(NORMAL_GBT_REQUEST_PARAMS)
|
|
assert_equal(tmpl['previousblockhash'], self.lastblockhash)
|
|
assert_equal(tmpl['height'], self.lastblockheight + 1)
|
|
block = create_block(tmpl=tmpl, ntime=self.lastblocktime + 1, dip4_activated=dip4_activated)
|
|
for tx in txs:
|
|
tx.rehash()
|
|
block.vtx.append(tx)
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
block.rehash()
|
|
block.solve()
|
|
assert_equal(None if accept else 'block-validation-failed', node.submitblock(block.serialize().hex()))
|
|
if (accept):
|
|
assert_equal(node.getbestblockhash(), block.hash)
|
|
self.lastblockhash = block.hash
|
|
self.lastblocktime += 1
|
|
self.lastblockheight += 1
|
|
else:
|
|
assert_equal(node.getbestblockhash(), self.lastblockhash)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
NULLDUMMYTest().main()
|