dash/qa/rpc-tests
Suhas Daftuar 12c469b236
[Mempool] Fix mempool limiting and replace-by-fee for PrioritiseTransaction
1) Fix mempool limiting for PrioritiseTransaction

Redo the feerate index to be based on mining score, rather than fee.

Update mempool_packages.py to test prioritisetransaction's effect on
package scores.

2) Update replace-by-fee logic to use fee deltas

3) Use fee deltas for determining mempool acceptance

4) Remove GetMinRelayFee

One test in AcceptToMemoryPool was to compare a transaction's fee
agains the value returned by GetMinRelayFee. This value was zero for
all small transactions.  For larger transactions (between
DEFAULT_BLOCK_PRIORITY_SIZE and MAX_STANDARD_TX_SIZE), this function
was preventing low fee transactions from ever being accepted.

With this function removed, we will now allow transactions in that range
with fees (including modifications via PrioritiseTransaction) below
the minRelayTxFee, provided that they have sufficient priority.

Github-Pull: #7062
Rebased-From: eb306664e7 9ef2a25603 27fae3484c 901b01d674
2015-12-21 17:19:53 +01:00
..
test_framework net: Fix sent reject messages for blocks and transactions 2015-12-10 11:59:34 +01:00
.gitignore
bip65-cltv-p2p.py Fix BIP65 p2p test 2015-10-27 15:36:06 -04:00
bip65-cltv.py Add RPC tests for the CHECKLOCKTIMEVERIFY (BIP65) soft-fork 2015-10-08 17:25:25 +02:00
bipdersig-p2p.py Add p2p-fullblocktest.py 2015-08-21 15:31:37 -04:00
bipdersig.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
blockchain.py Fix chainstate serialized_size computation 2015-10-28 01:05:32 +01:00
decodescript.py Resolve issue 3166. 2015-07-30 19:56:00 -04:00
disablewallet.py Fix crash in validateaddress with -disablewallet 2015-11-09 08:44:19 +01:00
forknotify.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
fundrawtransaction.py [rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase 2015-10-20 10:25:45 +02:00
getblocktemplate_longpoll.py Add basic coverage reporting for RPC tests 2015-11-11 10:33:43 -08:00
getblocktemplate_proposals.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
getchaintips.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
httpbasics.py http: Restrict maximum size of request line + headers 2015-10-20 14:31:40 +02:00
invalidateblock.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
invalidblockrequest.py net: Fix sent reject messages for blocks and transactions 2015-12-10 11:59:34 +01:00
invalidtxrequest.py net: Fix sent reject messages for blocks and transactions 2015-12-10 11:59:34 +01:00
keypool.py [qa] keypool: DRY: Use test framework 2015-11-16 12:01:32 +01:00
listtransactions.py Add p2sh option to importaddress to import redeemScripts 2015-07-20 16:01:37 -07:00
maxblocksinflight.py test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
maxuploadtarget.py test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
mempool_packages.py [Mempool] Fix mempool limiting and replace-by-fee for PrioritiseTransaction 2015-12-21 17:19:53 +01:00
mempool_reorg.py Add failing test checking timelocked-txn removal during reorg 2015-11-30 13:02:04 -05:00
mempool_resurrect_test.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
mempool_spendcoinbase.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
merkle_blocks.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
multi_rpc.py Added additional config option for multiple RPC users. 2015-11-29 08:34:20 -05:00
nodehandling.py [QA] fix netbase tests because of new CSubNet::ToString() output 2015-09-16 16:50:20 +02:00
p2p-acceptblock.py test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
p2p-fullblocktest.py Add p2p-fullblocktest.py 2015-08-21 15:31:37 -04:00
prioritise_transaction.py [Mempool] Fix mempool limiting and replace-by-fee for PrioritiseTransaction 2015-12-21 17:19:53 +01:00
proxy_test.py tests: Extend RPC proxy tests 2015-06-15 12:45:13 +02:00
pruning.py Make fee aware of min relay in pruning.py RPC test 2015-10-17 15:52:40 -04:00
rawtransactions.py [QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction.py RPC test 2015-07-10 21:13:33 +02:00
README.md test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
receivedby.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
reindex.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
replace-by-fee.py [Mempool] Fix mempool limiting and replace-by-fee for PrioritiseTransaction 2015-12-21 17:19:53 +01:00
rest.py tests: GET requests cannot have request body, use POST in rest.py 2015-09-02 18:38:42 +02:00
rpcbind_test.py Add basic coverage reporting for RPC tests 2015-11-11 10:33:43 -08:00
sendheaders.py test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
signrawtransactions.py pull-tester/rpc-tests.sh: allow passing throug of arguments 2015-05-18 15:29:20 +02:00
smartfees.py Add rounding helper function to util.py 2015-12-01 11:03:37 +01:00
txn_clone.py Keep track of explicit wallet conflicts instead of using mempool 2015-11-29 13:24:02 +01:00
txn_doublespend.py Keep track of explicit wallet conflicts instead of using mempool 2015-11-29 13:24:02 +01:00
wallet.py [wallet] Add rpc tests to verify fee calculations 2015-11-28 22:52:13 +01:00
walletbackup.py Fix walletbackup.py after directory restructuring 2015-05-27 10:00:15 -04:00
zapwallettxes.py [QA] restructure rpc tests directory 2015-05-18 15:25:45 +02:00
zmq_test.py travis: install a recent libzmq and pyzmq for tests 2015-10-01 15:40:57 +02:00

Regression tests

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for new regression tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support p2p connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, p2p tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

P2P test design notes

Mininode

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • NodeConn is the class used to connect to a bitcoind. If you implement a callback class that derives from NodeConnCB and pass that to the NodeConn object, your code will receive the appropriate callbacks when events of interest arrive.

  • You can pass the same handler to multiple NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test.

  • Call NetworkThread.start() after all NodeConn objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • RPC calls are available in p2p tests.

  • Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples: p2p-accept-block.py, maxblocksinflight.py.

Comptool

  • Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • a list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.