mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
b07a7b810c
* Merge #11796: [tests] Functional test naming convention5fecd84
[tests] Remove redundant import in blocktools.py test (Anthony Towns)9b20bb4
[tests] Check tests conform to naming convention (Anthony Towns)7250b4e
[tests] README.md nit fixes (Anthony Towns)82b2712
[tests] move witness util functions to blocktools.py (John Newbery)1e10854
[tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting #11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80 * update violation count Signed-off-by: pasta <pasta@dashboost.org> * Merge #11774: [tests] Rename functional tests6f881cc880
[tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns)3150b3fea7
[tests] Rename misc functional tests. (Anthony Towns)81b79f2c39
[tests] Rename rpc_* functional tests. (Anthony Towns)61b8f7f273
[tests] Rename p2p_* functional tests. (Anthony Towns)90600bc7db
[tests] Rename wallet_* functional tests. (Anthony Towns)ca6523d0c8
[tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16 * rename tests and edit associated strings to align test-suite with test name standards Signed-off-by: pasta <pasta@dashboost.org> * fix grammar in test/functional/test_runner.py Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * ci: Fix excluded test names * rename feature_privatesend.py to rpc_privatesend.py Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com> Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
114 lines
4.9 KiB
Python
Executable File
114 lines
4.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the preciousblock RPC."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
connect_nodes_bi,
|
|
sync_chain,
|
|
)
|
|
|
|
def unidirectional_node_sync_via_rpc(node_src, node_dest):
|
|
blocks_to_copy = []
|
|
blockhash = node_src.getbestblockhash()
|
|
while True:
|
|
try:
|
|
assert(len(node_dest.getblock(blockhash, False)) > 0)
|
|
break
|
|
except:
|
|
blocks_to_copy.append(blockhash)
|
|
blockhash = node_src.getblockheader(blockhash, True)['previousblockhash']
|
|
blocks_to_copy.reverse()
|
|
for blockhash in blocks_to_copy:
|
|
blockdata = node_src.getblock(blockhash, False)
|
|
assert(node_dest.submitblock(blockdata) in (None, 'inconclusive'))
|
|
|
|
def node_sync_via_rpc(nodes):
|
|
for node_src in nodes:
|
|
for node_dest in nodes:
|
|
if node_src is node_dest:
|
|
continue
|
|
unidirectional_node_sync_via_rpc(node_src, node_dest)
|
|
|
|
class PreciousTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
def setup_network(self):
|
|
self.setup_nodes()
|
|
|
|
def run_test(self):
|
|
self.log.info("Ensure submitblock can in principle reorg to a competing chain")
|
|
self.nodes[0].generate(1)
|
|
assert_equal(self.nodes[0].getblockcount(), 1)
|
|
hashZ = self.nodes[1].generate(2)[-1]
|
|
assert_equal(self.nodes[1].getblockcount(), 2)
|
|
node_sync_via_rpc(self.nodes[0:3])
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashZ)
|
|
|
|
self.log.info("Mine blocks A-B-C on Node 0")
|
|
hashC = self.nodes[0].generate(3)[-1]
|
|
assert_equal(self.nodes[0].getblockcount(), 5)
|
|
self.log.info("Mine competing blocks E-F-G on Node 1")
|
|
hashG = self.nodes[1].generate(3)[-1]
|
|
assert_equal(self.nodes[1].getblockcount(), 5)
|
|
assert(hashC != hashG)
|
|
self.log.info("Connect nodes and check no reorg occurs")
|
|
# Submit competing blocks via RPC so any reorg should occur before we proceed (no way to wait on inaction for p2p sync)
|
|
node_sync_via_rpc(self.nodes[0:2])
|
|
connect_nodes_bi(self.nodes,0,1)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block G")
|
|
self.nodes[0].preciousblock(hashG)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block C again")
|
|
self.nodes[0].preciousblock(hashC)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashC)
|
|
self.log.info("Make Node1 prefer block C")
|
|
self.nodes[1].preciousblock(hashC)
|
|
sync_chain(self.nodes[0:2]) # wait because node 1 may not have downloaded hashC
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashC)
|
|
self.log.info("Make Node1 prefer block G again")
|
|
self.nodes[1].preciousblock(hashG)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block G again")
|
|
self.nodes[0].preciousblock(hashG)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashG)
|
|
self.log.info("Make Node1 prefer block C again")
|
|
self.nodes[1].preciousblock(hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashC)
|
|
self.log.info("Mine another block (E-F-G-)H on Node 0 and reorg Node 1")
|
|
self.nodes[0].generate(1)
|
|
assert_equal(self.nodes[0].getblockcount(), 6)
|
|
self.sync_blocks(self.nodes[0:2])
|
|
hashH = self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
self.log.info("Node1 should not be able to prefer block C anymore")
|
|
self.nodes[1].preciousblock(hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
self.log.info("Mine competing blocks I-J-K-L on Node 2")
|
|
self.nodes[2].generate(4)
|
|
assert_equal(self.nodes[2].getblockcount(), 6)
|
|
hashL = self.nodes[2].getbestblockhash()
|
|
self.log.info("Connect nodes and check no reorg occurs")
|
|
node_sync_via_rpc(self.nodes[1:3])
|
|
connect_nodes_bi(self.nodes,1,2)
|
|
connect_nodes_bi(self.nodes,0,2)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashH)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
assert_equal(self.nodes[2].getbestblockhash(), hashL)
|
|
self.log.info("Make Node1 prefer block L")
|
|
self.nodes[1].preciousblock(hashL)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashL)
|
|
self.log.info("Make Node2 prefer block H")
|
|
self.nodes[2].preciousblock(hashH)
|
|
assert_equal(self.nodes[2].getbestblockhash(), hashH)
|
|
|
|
if __name__ == '__main__':
|
|
PreciousTest().main()
|