mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
65226da849
68faa87881f5334b2528db4adc72ec19d94316a3 test: use f-strings in mining_*.py tests (fanquake) c2a5d560df2824df5731100c2584e8ad7a3d7bc2 test: use f-strings in interface_*.py tests (fanquake) 86d958262dff43002820d58ccb8958e2dbfb9d5b test: use f-strings in feature_proxy.py (fanquake) 31bdb33dcb8345df1bb94b28e811252a918d7dcb test: use f-strings in feature_segwit.py (fanquake) b166d54c3cbb0c028210cee977b3dcde5ac5474f test: use f-strings in feature_versionbits_warning.py (fanquake) cf6d66bf941d946600047d712c7cd15d7605322e test: use f-strings in feature_settings.py (fanquake) 6651d77f22862716f5bd7d0b31cfbd3937ab7b1d test: use f-strings in feature_pruning.py (fanquake) 961f5813ba65b6a601081912c4ece96c2679794d test: use f-strings in feature_notifications.py (fanquake) 1a546e6f6ca95772f0d7dbc2792477becbb8ea63 test: use f-strings in feature_minchainwork.py (fanquake) 6679eceacc915a8ea7cd7063f103ffc5eb9da884 test: use f-strings in feature_logging.py (fanquake) fb633933ab570e945d2a366f37eeff39f516c613 test: use f-strings in feature_loadblock.py (fanquake) e9ca8b254d4b9567831c0e113ce1c0a2b4795a95 test: use f-strings in feature_help.py (fanquake) ff7e3309995a8960ac371741b2b00c6da40f7490 test: use f-strings in feature_filelock.py (fanquake) d5a6adc5e478fa5c6e562377eea873dc38e66578 test: use f-strings in feature_fee_estimation.py (fanquake) a2de33cbdc79202bccddb4beadfde88266ac979f test: use f-strings in feature_dersig.py (fanquake) a2502cc63fd308be8af840962da9c53339433fa6 test: use f-strings in feature_dbcrash.py (fanquake) 3e2f84e7a96cb4b97b609ac853f78edd0ed43f82 test: use f-strings in feature_csv_activation.py (fanquake) e2f1fd8ee92fa421b6d293169044d6ddd5a9b8df test: use f-strings in feature_config_args.py (fanquake) 36d33d32b1b498b61f56d552f6e2c1d064f978c3 test: use f-strings in feature_cltv.py (fanquake) dca173cc044270b30782b1e3355e9dcb8c534295 test: use f-strings in feature_blocksdir.py (fanquake) 5453e8706278918ac51a725e81599cfa18c8cdbc test: use f-strings in feature_backwards_compatibility.py (fanquake) 6f3d5ad67ac8e7b50abae1a2949898d858e38106 test: use f-strings in feature_asmap.py (fanquake) Pull request description: Rather than using 3 different ways to build/format strings (sometimes all in the same test, i.e [`feature_config_args.py`](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_config_args.py)), consolidate to using [f-strings (3.6+)](https://docs.python.org/3/reference/lexical_analysis.html#f-strings), which are generally more concise / readable, as well as more performant than existing methods. This deals with the `feature_*.py`, `interface_*.py` and `mining_*.py` tests. See also: [PEP 498](https://www.python.org/dev/peps/pep-0498/) ACKs for top commit: mjdietzx: reACK 68faa87881f5334b2528db4adc72ec19d94316a3 Zero-1729: crACK 68faa87881f5334b2528db4adc72ec19d94316a3 Tree-SHA512: d4e1a42e07d96d2c552387a46da1534223c4ce408703d7568ad2ef580797dd68d9695b8d19666b567af37f44de6e430e8be5db5d5404ba8fcecf9f5b026a6efb
63 lines
2.4 KiB
Python
Executable File
63 lines
2.4 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Verify that starting dashd with -h works as expected."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
class HelpTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
|
|
def setup_network(self):
|
|
self.add_nodes(self.num_nodes)
|
|
# Don't start the node
|
|
|
|
def get_node_output(self, *, ret_code_expected):
|
|
ret_code = self.nodes[0].process.wait(timeout=60)
|
|
assert_equal(ret_code, ret_code_expected)
|
|
self.nodes[0].stdout.seek(0)
|
|
self.nodes[0].stderr.seek(0)
|
|
out = self.nodes[0].stdout.read()
|
|
err = self.nodes[0].stderr.read()
|
|
self.nodes[0].stdout.close()
|
|
self.nodes[0].stderr.close()
|
|
|
|
# Clean up TestNode state
|
|
self.nodes[0].running = False
|
|
self.nodes[0].process = None
|
|
self.nodes[0].rpc_connected = False
|
|
self.nodes[0].rpc = None
|
|
|
|
return out, err
|
|
|
|
def run_test(self):
|
|
self.log.info("Start dashd with -h for help text")
|
|
self.nodes[0].start(extra_args=['-h'])
|
|
# Node should exit immediately and output help to stdout.
|
|
output, _ = self.get_node_output(ret_code_expected=0)
|
|
assert b'Options' in output
|
|
self.log.info(f"Help text received: {output[0:60]} (...)")
|
|
|
|
self.log.info("Start dashd with -version for version information")
|
|
self.nodes[0].start(extra_args=['-version'])
|
|
# Node should exit immediately and output version to stdout.
|
|
output, _ = self.get_node_output(ret_code_expected=0)
|
|
assert b'version' in output
|
|
self.log.info(f"Version text received: {output[0:60]} (...)")
|
|
|
|
# Test that arguments not in the help results in an error
|
|
self.log.info("Start dashdd with -fakearg to make sure it does not start")
|
|
self.nodes[0].start(extra_args=['-fakearg'])
|
|
# Node should exit immediately and output an error to stderr
|
|
_, output = self.get_node_output(ret_code_expected=1)
|
|
assert b'Error parsing command line arguments' in output
|
|
self.log.info(f"Error message received: {output[0:60]} (...)")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
HelpTest().main()
|