sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-29 05:49:11 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
15f6a9c26b
dash/src/util
History
fanquake 15f6a9c26b Merge bitcoin/bitcoin#24297: Fix unintended unsigned integer overflow in strencodings 
fac9fe5d051264fcd16e8e36d30f28c05c999837 Fix unintended unsigned integer overflow in strencodings (MarcoFalke)

Pull request description:

  This fixes two issues for strings that start with a colon and only have one colon:

  * `fMultiColon` is incorrectly set to `true`
  * There is an unsigned integer overflow `colon - 1` (`0 - 1`)

  Neither issue matters, as the result is discarded. Though, it makes sense to still fix the issue for clarity and to avoid sanitizer issues in the function.

ACKs for top commit:
  laanwj:
    Code review ACK fac9fe5d051264fcd16e8e36d30f28c05c999837
  shaavan:
    Code Review ACK fac9fe5d051264fcd16e8e36d30f28c05c999837

Tree-SHA512: e71c21a0b617abf241e561ce6b90b963e2d5e2f77bd9547ce47209a1a94b454384391f86ef5d35fedd4f4df19add3896bb3d61fed396ebba8e864e3eeb75ed59
2023-04-18 23:24:06 +03:00
..
asmap.cpp merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
asmap.h merge bitcoin#18512: Improve asmap checks and add sanity check 2022-03-25 00:58:20 +05:30
bip32.cpp Merge #14021: Import key origin data through descriptors in importmulti (+ changes from PRs partially merged earlier: 15368, 15749) 2022-02-18 03:42:05 +03:00
bip32.h fix: Fix missing includes (#5295) 2023-04-05 21:20:41 -05:00
bytevectorhash.cpp
bytevectorhash.h
check.h partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
enumerate.h refactor: introduce a python-like enumerate() method, and use it in block_reward_reallocation_tests.cpp 2022-10-24 00:00:17 +03:00
error.cpp Merge #16745: wallet: Translate all initErrors in CreateWalletFromFile 2022-04-08 14:12:56 -05:00
error.h Merge #16745: wallet: Translate all initErrors in CreateWalletFromFile 2022-04-08 14:12:56 -05:00
fees.cpp merge bitcoin#16257: abort when attempting to fund a transaction above -maxtxfee 2021-12-22 19:43:18 +05:30
fees.h
getuniquepath.cpp Merge bitcoin/bitcoin#22916: doc: add missing copyright header to getuniquepath.cpp 2022-03-13 14:52:24 -05:00
getuniquepath.h
golombrice.h Merge bitcoin/bitcoin#23760: util: move MapIntoRange() for reuse in fuzz tests 2023-04-17 11:17:34 -05:00
irange.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
macros.h
message.cpp Merge #18115: wallet: Pass in transactions and messages for signing instead of exporting the private keys 2023-03-19 11:08:31 -05:00
message.h Merge #18115: wallet: Pass in transactions and messages for signing instead of exporting the private keys 2023-03-19 11:08:31 -05:00
moneystr.cpp merge bitcoin#20452: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) 2023-01-02 14:19:33 -06:00
moneystr.h merge bitcoin#22220: make ParseMoney return a std::optional<CAmount> 2023-01-02 14:19:33 -06:00
ranges.h chore: bump copyrights (#4873) 2022-06-08 02:36:46 +03:00
serfloat.cpp
serfloat.h
settings.cpp Merge bitcoin/bitcoin#24095: util: Fix mis-swapped prettyIndent and indentLevel arguments 2022-09-03 10:43:16 -05:00
settings.h merge #15935: Add <datadir>/settings.json persistent settings storage 2022-06-21 19:08:55 +05:30
sock.cpp merge bitcoin#20788: add RAII socket and use it instead of bare SOCKET 2022-11-01 00:28:53 -05:00
sock.h merge bitcoin#20788: add RAII socket and use it instead of bare SOCKET 2022-11-01 00:28:53 -05:00
spanparsing.cpp merge bitcoin#22953: introduce single-separator split helper 2023-01-19 03:42:51 +00:00
spanparsing.h merge bitcoin#25057: replace remaining boost::split with SplitString 2023-01-19 03:49:04 +00:00
strencodings.cpp Merge bitcoin/bitcoin#24297: Fix unintended unsigned integer overflow in strencodings 2023-04-18 23:24:06 +03:00
strencodings.h Merge bitcoin#13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool 2023-02-10 23:34:57 +03:00
string.cpp merge bitcoin#25068: Wrap boost::replace_all 2023-01-19 03:49:04 +00:00
string.h merge bitcoin#25068: Wrap boost::replace_all 2023-01-19 03:49:04 +00:00
system.cpp Merge #18437: util: Detect posix_fallocate() instead of assuming 2023-03-03 23:07:18 +05:30
system.h Merge bitcoin#13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool 2023-02-10 23:34:57 +03:00
threadnames.cpp partial revert dash#2911: s/dash-config/bitcoin-config/g 2022-08-09 14:16:28 +05:30
threadnames.h
time.cpp merge bitcoin#20788: add RAII socket and use it instead of bare SOCKET 2022-11-01 00:28:53 -05:00
time.h merge bitcoin#20788: add RAII socket and use it instead of bare SOCKET 2022-11-01 00:28:53 -05:00
translation.h Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
underlying.h refactor: implement c++23 inspired ToUnderlying (#5210) 2023-02-20 13:12:12 +03:00
url.cpp
url.h
validation.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
validation.h Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
vector.h