sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 21:12:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
188f4a7522
dash/src
History
Pieter Wuille 188f4a7522
Merge #10735: Avoid static analyzer warnings regarding uninitialized arguments 
6835cb0ab Avoid static analyzer warnings regarding uninitialized arguments (practicalswift)

Pull request description:

  Avoid static analyzer warnings regarding _"Function call argument is a pointer to uninitialized value"_ in cases where we are intentionally using such arguments.

  This is achieved by using `f(b.begin(), b.end())` (`std::array<char, N>`) instead of `f(b, b + N)` (`char b[N]`).

  Rationale:
  * Reduce false positives by guiding static analyzers regarding our intentions.

  Before this commit:

  ```shell
  $ clang-tidy-3.5 -checks=* src/bench/base58.cpp
  bench/base58.cpp:23:9: warning: Function call argument is a pointer to uninitialized value [clang-analyzer-core.CallAndMessage]
          EncodeBase58(b, b + 32);
          ^
  $ clang-tidy-3.5 -checks=* src/bench/verify_script.cpp
  bench/verify_script.cpp:59:5: warning: Function call argument is a pointer to uninitialized value [clang-analyzer-core.CallAndMessage]
      key.Set(vchKey, vchKey + 32, false);
      ^
  $
  ```

  After this commit:

  ```shell
  $ clang-tidy-3.5 -checks=* src/bench/base58.cpp
  $ clang-tidy-3.5 -checks=* src/bench/verify_script.cpp
  $
  ```

Tree-SHA512: 5814a320ca8b959d0954bb64393424bcad73f942d2e988de1cd6788f39153b93900325532f2e340de02d740a3953385d212ae08e7ec72bb4c394a40475f251df
2019-07-17 19:01:41 -05:00
..
bench Merge #10735: Avoid static analyzer warnings regarding uninitialized arguments 2019-07-17 19:01:41 -05:00
bls Fix excessive memory use when flushing chainstate and EvoDB (#3008) 2019-07-02 07:16:27 +03:00
compat Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
config
consensus Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
crypto Merge #10521: Limit variable scope 2019-07-08 13:50:05 -05:00
evo add end commend for all llmq namespace 2019-07-15 13:55:01 -05:00
governance Optimize on-disk deterministic masternode storage to reduce size of evodb (#3017) 2019-07-09 08:59:57 +03:00
immer
leveldb Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
llmq add end commend for all llmq namespace 2019-07-15 13:55:01 -05:00
masternode Optimize on-disk deterministic masternode storage to reduce size of evodb (#3017) 2019-07-09 08:59:57 +03:00
obj
obj-test
policy scripted diff: #10502 Fully remove BOOST_FOREACH 2019-07-09 13:08:21 -05:00
primitives Merge #10523: Perform member initialization in initialization lists where possible 2019-07-08 10:24:26 -05:00
privatesend Backport #8694: Basic multiwallet support (#3022) 2019-07-11 10:50:52 +03:00
qt Merge #10673: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked() 2019-07-17 10:05:13 -05:00
rpc Merge #10676: document script-based return fields for validateaddress 2019-07-17 19:01:41 -05:00
script Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
secp256k1 Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
support Merge #10631: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2019-07-17 10:05:12 -05:00
test Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
univalue
wallet Merge #10807: getbalance example covers at least 6 confirms 2019-07-17 19:01:41 -05:00
zmq add end commend for all llmq namespace 2019-07-15 13:55:01 -05:00
.clang-format Merge #10602: Make clang-format use C++11 features (e.g. A<A<int>> instead of A<A<int> >) 2019-07-09 13:08:21 -05:00
addrdb.cpp Merge #10248: Rewrite addrdb with less duplication using CHashVerifier 2019-07-11 10:34:46 -05:00
addrdb.h Merge #10248: Rewrite addrdb with less duplication using CHashVerifier 2019-07-11 10:34:46 -05:00
addressindex.h
addrman.cpp Merge pull request #2974 from PastaPastaPasta/backports-0.15-pr14 2019-06-19 14:30:54 +03:00
addrman.h Merge pull request #2974 from PastaPastaPasta/backports-0.15-pr14 2019-06-19 14:30:54 +03:00
amount.h Merge #9279: Consensus: Move CFeeRate out of libconsensus 2019-06-26 15:26:07 -05:00
arith_uint256.cpp Merge #10530: Fix invalid instantiation and possibly unsafe accesses of array in class base_uint<BITS> 2019-07-11 10:34:46 -05:00
arith_uint256.h Merge #10530: Fix invalid instantiation and possibly unsafe accesses of array in class base_uint<BITS> 2019-07-11 10:34:46 -05:00
base58.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
base58.h Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
batchedlogger.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
batchedlogger.h Backport Bitcoin#9424, Bitcoin#10123 and Bitcoin#10153 (#2918) 2019-05-23 00:51:39 +03:00
bip39_english.h
bip39.cpp
bip39.h
blockencodings.cpp Merge #10553: Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon. 2019-07-09 13:08:20 -05:00
blockencodings.h
bloom.cpp scripted diff: #10502 Fully remove BOOST_FOREACH 2019-07-09 13:08:21 -05:00
bloom.h Merge #9750: Bloomfilter: parameter variables made constant 2019-06-24 11:39:34 -05:00
cachemap.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
cachemultimap.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
chain.cpp Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
chain.h Add blocks conflicting with ChainLocks to block index (#2923) 2019-05-16 10:12:36 +02:00
chainparams.cpp update seeds emplace_back based on code review 2019-07-12 11:34:49 -05:00
chainparams.h Merge #10446: net: avoid extra dns query per seed 2019-07-11 10:34:46 -05:00
chainparamsbase.cpp Merge #8855: Use a proper factory for creating chainparams 2019-06-26 12:45:10 -05:00
chainparamsbase.h Merge #8855: Use a proper factory for creating chainparams 2019-06-26 12:45:10 -05:00
chainparamsseeds.h
checkpoints.cpp
checkpoints.h
checkqueue.h scripted diff: #10502 Fully remove BOOST_FOREACH 2019-07-09 13:08:21 -05:00
clientversion.cpp
clientversion.h Merge #10168: Fix build warning from #error text 2019-06-14 01:25:59 -05:00
coins.cpp Merge #10538: [trivial] Fix typo: "occurrences" (misspelled as "occurrances") 2019-05-19 20:43:03 -05:00
coins.h Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
compat.h Merge #9921: build: Probe MSG_DONTWAIT in the same way as MSG_NOSIGNAL 2019-05-06 14:51:42 -05:00
compressor.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
compressor.h
core_io.h Backport 8824 (#2968) 2019-06-11 14:42:17 +03:00
core_memusage.h Merge #9208: Improve DisconnectTip performance 2019-06-24 11:39:34 -05:00
core_read.cpp Merge #10808: Avoid some new gcc warnings in 15 2019-07-17 19:01:41 -05:00
core_write.cpp scripted diff: #10502 Fully remove BOOST_FOREACH 2019-07-09 13:08:21 -05:00
ctpl.h
cuckoocache.h Merge #10577: Add an explanation of quickly hashing onto a non-power of two range. 2019-07-11 10:34:46 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp Merge #10840: Remove duplicate include 2019-07-17 19:01:41 -05:00
dash-tx-res.rc
dash-tx.cpp Merge #10536: Remove unreachable or otherwise redundant code 2019-07-11 10:34:46 -05:00
dashd-res.rc
dashd.cpp Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
dbwrapper.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
dbwrapper.h Optimize on-disk deterministic masternode storage to reduce size of evodb (#3017) 2019-07-09 08:59:57 +03:00
dsnotificationinterface.cpp Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
dsnotificationinterface.h Drop CDSNotificationInterface::SyncTransaction() 2019-05-28 11:59:55 +02:00
flat-database.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
fs.cpp Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
fs.h Merge #10432: [Trivial] Add BITCOIN_FS_H endif footer in fs.h 2019-06-24 11:39:34 -05:00
hash.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
hash.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
hdchain.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
hdchain.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
httprpc.cpp Merge #10118: Util: Remove redundant calls to argsGlobal.IsArgSet() 2019-07-11 10:34:46 -05:00
httprpc.h Merge #10568: Remove unnecessary forward class declarations in header files 2019-07-09 13:08:20 -05:00
httpserver.cpp Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
httpserver.h Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
indirectmap.h
init.cpp Merge #10714: Avoid printing incorrect block indexing time due to uninitialized variable 2019-07-17 19:01:41 -05:00
init.h
keepass.cpp Scripted diff find src/ -name "*.cpp" ! -wholename "src/util.h" ! -wholename "src/util.cpp" | xargs perl -i -pe 's/(?<!\.)(ParseParameters|ReadConfigFile|IsArgSet|(Soft|Force)?(Get|Set)(|Bool|)Arg(s)?)\(/gArgs.\1(/g' based on bb81e17355 2019-06-24 12:03:00 -05:00
keepass.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
key.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
key.h Merge #10075: Remove unused C++ code not covered by unit tests 2019-06-14 14:47:39 -05:00
keystore.cpp Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
keystore.h Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
limitedmap.h
Makefile.am Merge #10544: Update to LevelDB 1.20 2019-07-09 13:08:20 -05:00
Makefile.bench.include Merge #10544: Update to LevelDB 1.20 2019-07-09 13:08:20 -05:00
Makefile.leveldb.include Merge #10806: build: verify that the assembler can handle crc32 functions 2019-07-17 19:01:41 -05:00
Makefile.qt.include Backport #12783: macOS: disable AppNap during sync (and mixing) (#3024) 2019-07-15 14:38:55 +03:00
Makefile.qttest.include Merge #10295: [qt] Move some WalletModel functions into CWallet 2019-07-11 10:34:46 -05:00
Makefile.test.include Merge #10544: Update to LevelDB 1.20 2019-07-09 13:08:20 -05:00
memusage.h Merge #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} 2019-07-08 10:24:29 -05:00
merkleblock.cpp
merkleblock.h
messagesigner.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
messagesigner.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
miner.cpp scripted diff: #10502 Fully remove BOOST_FOREACH 2019-07-09 13:08:21 -05:00
miner.h Merge #10568: Remove unnecessary forward class declarations in header files 2019-07-09 13:08:20 -05:00
net_processing.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
net_processing.h Merge #9725: CValidationInterface Cleanups 2019-05-27 09:03:19 -05:00
net.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
net.h Merge #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options 2019-07-11 10:34:46 -05:00
netaddress.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
netaddress.h Merge #10446: net: avoid extra dns query per seed 2019-07-11 10:34:46 -05:00
netbase.cpp Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
netbase.h Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
netfulfilledman.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
netfulfilledman.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
netmessagemaker.h
noui.cpp
noui.h
pow.cpp
pow.h
prevector.h Merge #10808: Avoid some new gcc warnings in 15 2019-07-17 19:01:41 -05:00
protocol.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
protocol.h Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
pubkey.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
pubkey.h
random.cpp Merge #10820: Use cpuid intrinsics instead of asm code 2019-07-17 19:01:41 -05:00
random.h Merge #10377: Use rdrand as entropy source on supported platforms 2019-07-09 13:08:21 -05:00
rest.cpp Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
reverselock.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp Merge #10372: Add perf counter data to GetStrongRandBytes state in scheduler 2019-06-24 11:39:34 -05:00
scheduler.h Merge #10395: Replace boost::function with std::function (C++11) 2019-06-24 11:39:34 -05:00
serialize.h Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
spentindex.h Optimize on-disk deterministic masternode storage to reduce size of evodb (#3017) 2019-07-09 08:59:57 +03:00
spork.cpp Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
spork.h Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
stacktraces.cpp Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
stacktraces.h Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
streams.h Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
sync.cpp scripted-diff: Remove PAIRTYPE #10502 2019-07-09 13:08:21 -05:00
sync.h Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp scripted diff: #10502 Fully remove BOOST_FOREACH 2019-07-09 13:08:21 -05:00
timedata.h
tinyformat.h Merge bitcoin#9963: util: Properly handle errors during log message formatting (#2917) 2019-05-21 15:32:33 +02:00
torcontrol.cpp Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. 2019-07-17 19:01:41 -05:00
torcontrol.h
txdb.cpp Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() 2019-07-11 10:34:46 -05:00
txdb.h Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() 2019-07-11 10:34:46 -05:00
txmempool.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
txmempool.h Merge #10685: Clarify CCoinsViewMemPool documentation. 2019-07-17 10:05:13 -05:00
ui_interface.cpp
ui_interface.h Merge #10568: Remove unnecessary forward class declarations in header files 2019-07-09 13:08:20 -05:00
uint256.cpp
uint256.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
undo.h
unordered_lru_cache.h
util.cpp Merge #10118: Util: Remove redundant calls to argsGlobal.IsArgSet() 2019-07-11 10:34:46 -05:00
util.h Merge #10400: [RPC] Add an uptime command that displays the amount of time (in seconds) bitcoind has been running 2019-07-11 10:34:46 -05:00
utilmoneystr.cpp
utilmoneystr.h
utilstrencodings.cpp Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
utilstrencodings.h Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
utiltime.cpp Revert " Add real timestamp to log output when mock time is enabled (#2604)" 2019-06-24 11:39:34 -05:00
utiltime.h Revert " Add real timestamp to log output when mock time is enabled (#2604)" 2019-06-24 11:39:34 -05:00
validation.cpp Merge #10557: Make check to distinguish between orphan txs and old txs more efficient. 2019-07-17 19:01:41 -05:00
validation.h Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn 2019-07-09 13:09:21 -05:00
validationinterface.cpp Remove CValidationInterface::UpdatedTransaction 2019-06-14 01:25:32 -05:00
validationinterface.h add end commend for all llmq namespace 2019-07-15 13:55:01 -05:00
version.h Merge #10560: Remove unused constants 2019-07-08 13:50:05 -05:00
versionbits.cpp Merge #9544: [trivial] Add end of namespace comments. Improve consistency. 2019-07-11 10:34:46 -05:00
versionbits.h Merge #10463: Names: BIP9 vs versionbits 2019-07-08 10:23:19 -05:00
warnings.cpp Scripted diff find src/ -name "*.cpp" ! -wholename "src/util.h" ! -wholename "src/util.cpp" | xargs perl -i -pe 's/(?<!\.)(ParseParameters|ReadConfigFile|IsArgSet|(Soft|Force)?(Get|Set)(|Bool|)Arg(s)?)\(/gArgs.\1(/g' based on bb81e17355 2019-06-24 12:03:00 -05:00
warnings.h