2f21e55514
* Remove ppszTypeName from protocol.cpp and reimplement GetCommand This removes the need to carefully maintain ppszTypeName, which required correct order and also did not allow to permanently remove old message types. To get the command name for an INV type, GetCommandInternal uses a switch which needs to be maintained from now on. The way this is implemented also resembles the way it is implemented in Bitcoin today, but it's not identical. The original PR that introduced the switch case in Bitcoin was part of the Segwit changes and thus never got backported. I decided to implement it in a slightly different way that avoids throwing exceptions when an unknown INV type is encountered. IsKnownType will now also leverage GetCommandInternal() to figure out if the INV type is known locally. This has the side effect of old/legacy message types to return false from now on. We will depend on this side effect in later commits when we remove legacy InstantSend code. * Stop handling/relaying legacy IX messages When we receive an IX message, we simply treat it as a regular TX and relay it as such. We'll however still request IX messages when they are announced to us. We can't simply revert to requesting TX messages in this case as it might result in the other peer not answering due to the TX not being in mapRelay yet. We should at some point in the future completely drop handling of IX messages instead. * Remove IsNewInstantSendEnabled() and only use IsInstantSendEnabled() * Remove legacy InstantSend from GUI * Remove InstantSend from Bitcoin/Dash URIs * Remove legacy InstantSend from RPC commands * Remove legacy InstantSend from wallet * Remove legacy instantsend.h include * Remove legacy InstantSend from validation code * Completely remove remaining legacy InstantSend code * Remove now unused spork * Fix InstantSend related test failures * Remove now obsolete auto IS tests * Make spork2 and spork3 disabled by default This should have no influence on mainnet as these sporks are actually set there. This will however affect regtest, which shouldn't have LLMQ based InstantSend enabled by default. * Remove instantsend tests from dip3-deterministicmns.py These were only testing legacy InstantSend * Fix .QCheckBox#checkUsePrivateSend styling a bit * s/TXLEGACYLOCKREQUEST/LEGACYTXLOCKREQUEST/ * Revert "verified via InstantSend" back to "verified via LLMQ based InstantSend" * Use cmd == nullptr instead of !cmd * Remove last parameter from AvailableCoins call This was for fUseInstantSend which is not present anymore since rebase |
||
---|---|---|
.. | ||
test_framework | ||
.gitignore | ||
abandonconflict.py | ||
addressindex.py | ||
assumevalid.py | ||
bip9-softforks.py | ||
bip65-cltv-p2p.py | ||
bip65-cltv.py | ||
bip68-112-113-p2p.py | ||
bip68-sequence.py | ||
bipdersig-p2p.py | ||
bipdersig.py | ||
blockchain.py | ||
combine_logs.py | ||
combined_log_template.html | ||
create_cache.py | ||
decodescript.py | ||
dip3-deterministicmns.py | ||
dip4-coinbasemerkleroots.py | ||
disablewallet.py | ||
disconnect_ban.py | ||
forknotify.py | ||
fundrawtransaction-hd.py | ||
fundrawtransaction.py | ||
getblocktemplate_longpoll.py | ||
getblocktemplate_proposals.py | ||
getchaintips.py | ||
httpbasics.py | ||
import-rescan.py | ||
importmulti.py | ||
importprunedfunds.py | ||
invalidateblock.py | ||
invalidblockrequest.py | ||
invalidtxrequest.py | ||
keypool-hd.py | ||
keypool.py | ||
listsinceblock.py | ||
listtransactions.py | ||
llmq-chainlocks.py | ||
llmq-dkgerrors.py | ||
llmq-is-cl-conflicts.py | ||
llmq-signing.py | ||
llmq-simplepose.py | ||
maxuploadtarget.py | ||
mempool_limit.py | ||
mempool_packages.py | ||
mempool_persist.py | ||
mempool_reorg.py | ||
mempool_resurrect_test.py | ||
mempool_spendcoinbase.py | ||
merkle_blocks.py | ||
multi_rpc.py | ||
multikeysporks.py | ||
net.py | ||
nulldummy.py | ||
p2p-acceptblock.py | ||
p2p-compactblocks.py | ||
p2p-fingerprint.py | ||
p2p-fullblocktest.py | ||
p2p-instantsend.py | ||
p2p-leaktests.py | ||
p2p-mempool.py | ||
p2p-timeouts.py | ||
p2p-versionbits-warning.py | ||
preciousblock.py | ||
prioritise_transaction.py | ||
proxy_test.py | ||
pruning.py | ||
rawtransactions.py | ||
README.md | ||
receivedby.py | ||
reindex.py | ||
rest.py | ||
rpcbind_test.py | ||
rpcnamedargs.py | ||
sendheaders.py | ||
signmessages.py | ||
signrawtransactions.py | ||
smartfees.py | ||
spentindex.py | ||
sporks.py | ||
test_runner.py | ||
timestampindex.py | ||
txindex.py | ||
txn_clone.py | ||
txn_doublespend.py | ||
wallet-accounts.py | ||
wallet-dump.py | ||
wallet-hd.py | ||
wallet.py | ||
walletbackup.py | ||
zapwallettxes.py | ||
zmq_test.py |
Regression tests
test_framework/authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework/test_framework.py
Base class for new regression tests.
test_framework/util.py
Generally useful functions.
test_framework/mininode.py
Basic code to support p2p connectivity to a bitcoind.
test_framework/comptool.py
Framework for comparison-tool style, p2p tests.
test_framework/script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
test_framework/blockstore.py
Implements disk-backed block and tx storage.
test_framework/key.py
Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)
test_framework/bignum.py
Helpers for script.py
test_framework/blocktools.py
Helper functions for creating blocks and transactions.
P2P test design notes
Mininode
-
mininode.py
contains all the definitions for objects that pass over the network (CBlock
,CTransaction
, etc, along with the network-level wrappers for them,msg_block
,msg_tx
, etc). -
P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.
-
NodeConn
is the class used to connect to a bitcoind. If you implement a callback class that derives fromNodeConnCB
and pass that to theNodeConn
object, your code will receive the appropriate callbacks when events of interest arrive. -
You can pass the same handler to multiple
NodeConn
's if you like, or pass different ones to each -- whatever makes the most sense for your test. -
Call
NetworkThread.start()
after allNodeConn
objects are created to start the networking thread. (Continue with the test logic in your existing thread.) -
RPC calls are available in p2p tests.
-
Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples:
p2p-accept-block.py
,p2p-compactblocks.py
.
Comptool
-
Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.
-
Set the
num_nodes
variable (defined inComparisonTestFramework
) to start up 1 or more nodes. If using 1 node, then--testbinary
can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then--refbinary
can be optionally used to change the bitcoind that will be used on nodes 2 and up. -
Implement a (generator) function called
get_tests()
which yieldsTestInstance
s. EachTestInstance
consists of:- a list of
[object, outcome, hash]
entriesobject
is aCBlock
,CTransaction
, orCBlockHeader
.CBlock
's andCTransaction
's are tested for acceptance.CBlockHeader
s can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.outcome
isTrue
,False
, orNone
. IfTrue
orFalse
, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. IfNone
is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.hash
is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
sync_every_block
:True/False
. IfFalse
, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. IfTrue
, then each block is tested in sequence and synced (this is slower when processing many blocks).sync_every_transaction
:True/False
. Analogous tosync_every_block
, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. IfTrue
orFalse
, then only the last tx's acceptance is tested against the given outcome.
- a list of
-
For examples of tests written in this framework, see
invalidblockrequest.py
andp2p-fullblocktest.py
.