dash/test/functional
Alexander Block 2f21e55514 Remove legacy InstantSend code (#3020)
* Remove ppszTypeName from protocol.cpp and reimplement GetCommand

This removes the need to carefully maintain ppszTypeName, which required
correct order and also did not allow to permanently remove old message
types.

To get the command name for an INV type, GetCommandInternal uses a switch
which needs to be maintained from now on.

The way this is implemented also resembles the way it is implemented in
Bitcoin today, but it's not identical. The original PR that introduced the
switch case in Bitcoin was part of the Segwit changes and thus never got
backported. I decided to implement it in a slightly different way that
avoids throwing exceptions when an unknown INV type is encountered.

IsKnownType will now also leverage GetCommandInternal() to figure out if
the INV type is known locally. This has the side effect of old/legacy
message types to return false from now on. We will depend on this side
effect in later commits when we remove legacy InstantSend code.

* Stop handling/relaying legacy IX messages

When we receive an IX message, we simply treat it as a regular TX and relay
it as such.

We'll however still request IX messages when they are announced to us. We
can't simply revert to requesting TX messages in this case as it might
result in the other peer not answering due to the TX not being in mapRelay
yet. We should at some point in the future completely drop handling of IX
messages instead.

* Remove IsNewInstantSendEnabled() and only use IsInstantSendEnabled()

* Remove legacy InstantSend from GUI

* Remove InstantSend from Bitcoin/Dash URIs

* Remove legacy InstantSend from RPC commands

* Remove legacy InstantSend from wallet

* Remove legacy instantsend.h include

* Remove legacy InstantSend from validation code

* Completely remove remaining legacy InstantSend code

* Remove now unused spork

* Fix InstantSend related test failures

* Remove now obsolete auto IS tests

* Make spork2 and spork3 disabled by default

This should have no influence on mainnet as these sporks are actually set
there. This will however affect regtest, which shouldn't have LLMQ based
InstantSend enabled by default.

* Remove instantsend tests from dip3-deterministicmns.py

These were only testing legacy InstantSend

* Fix .QCheckBox#checkUsePrivateSend styling a bit

* s/TXLEGACYLOCKREQUEST/LEGACYTXLOCKREQUEST/

* Revert "verified via InstantSend" back to "verified via LLMQ based InstantSend"

* Use cmd == nullptr instead of !cmd

* Remove last parameter from AvailableCoins call

This was for fUseInstantSend which is not present anymore since rebase
2019-07-09 17:50:08 +03:00
..
test_framework Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
.gitignore Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
abandonconflict.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
addressindex.py Fix start_/stop_node-s 2019-07-05 12:15:32 -05:00
assumevalid.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
bip9-softforks.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
bip65-cltv-p2p.py Disable DIP3 in multiple tests 2019-06-22 14:14:01 +02:00
bip65-cltv.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
bip68-112-113-p2p.py fix bip68-112-113-p2p.py 2019-06-21 09:26:41 -05:00
bip68-sequence.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
bipdersig-p2p.py Disable DIP3 in multiple tests 2019-06-22 14:14:01 +02:00
bipdersig.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
blockchain.py fix tx rate 2019-07-05 12:13:15 -05:00
combine_logs.py Merge #10076: [qa] combine_logs: Use ordered list for logfiles 2019-05-21 08:52:46 -05:00
combined_log_template.html Merge #10017: combine_logs.py - aggregates log files from multiple bitcoinds during functional tests. 2019-05-21 08:52:43 -05:00
create_cache.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
decodescript.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
dip3-deterministicmns.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
dip4-coinbasemerkleroots.py update dip4-coinbasemerkalroots.py and llmq-is-cl-conflicts.py 2019-05-21 08:52:48 -05:00
disablewallet.py Merge #10361: qa: disablewallet: Check that wallet is really disabled 2019-06-19 08:20:15 -05:00
disconnect_ban.py Revert "Merge #10376: [tests] fix disconnect_ban intermittency" 2019-07-05 12:11:56 -05:00
forknotify.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
fundrawtransaction-hd.py wait for node1 in fundrawtransaction(-hd).py tests 2019-07-05 22:21:00 -05:00
fundrawtransaction.py wait for node1 in fundrawtransaction(-hd).py tests 2019-07-05 22:21:00 -05:00
getblocktemplate_longpoll.py Remove unnecessary and forever-blocking wait_to_sync calls 2019-06-22 14:14:01 +02:00
getblocktemplate_proposals.py Remove unnecessary and forever-blocking wait_to_sync calls 2019-06-22 14:14:01 +02:00
getchaintips.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
httpbasics.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
import-rescan.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
importmulti.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
importprunedfunds.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
invalidateblock.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
invalidblockrequest.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
invalidtxrequest.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
keypool-hd.py start_node -> self.start_node 2019-07-04 23:46:15 -05:00
keypool.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
listsinceblock.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
listtransactions.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
llmq-chainlocks.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
llmq-dkgerrors.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
llmq-is-cl-conflicts.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
llmq-signing.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
llmq-simplepose.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
maxuploadtarget.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
mempool_limit.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
mempool_packages.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
mempool_persist.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
mempool_reorg.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
mempool_resurrect_test.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
mempool_spendcoinbase.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
merkle_blocks.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
multi_rpc.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
multikeysporks.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
net.py Merge #10478: rpc: Add listen address to incoming connections in getpeerinfo 2019-06-26 12:44:45 -05:00
nulldummy.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
p2p-acceptblock.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
p2p-compactblocks.py Other fixes 2019-06-21 09:33:27 -05:00
p2p-fingerprint.py Fix start_/stop_node-s 2019-07-05 12:15:32 -05:00
p2p-fullblocktest.py start_node -> self.start_node 2019-07-04 23:46:15 -05:00
p2p-instantsend.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
p2p-leaktests.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
p2p-mempool.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
p2p-timeouts.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
p2p-versionbits-warning.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
preciousblock.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
prioritise_transaction.py Other fixes 2019-06-21 09:33:27 -05:00
proxy_test.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
pruning.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
rawtransactions.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
README.md Merge #10023: [tests] remove maxblocksinflight.py (functionality covered by other test) 2019-06-08 09:36:57 -05:00
receivedby.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
reindex.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
rest.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
rpcbind_test.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
rpcnamedargs.py Merge #10317: Remove unused Python imports 2019-06-24 11:39:34 -05:00
sendheaders.py Use sync_with_ping to ensure that we don't start generating blocks too early 2019-07-08 07:42:27 -05:00
signmessages.py Merge #10317: Remove unused Python imports 2019-06-24 11:39:34 -05:00
signrawtransactions.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
smartfees.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
spentindex.py Fix start_/stop_node-s 2019-07-05 12:15:32 -05:00
sporks.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
test_runner.py Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
timestampindex.py Fix start_/stop_node-s 2019-07-05 12:15:32 -05:00
txindex.py Fix start_/stop_node-s 2019-07-05 12:15:32 -05:00
txn_clone.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
txn_doublespend.py Merge #10198: [tests] Remove is_network_split from functional test framework 2019-06-19 08:20:15 -05:00
wallet-accounts.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
wallet-dump.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
wallet-hd.py Fix start_/stop_node-s 2019-07-05 12:15:32 -05:00
wallet.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
walletbackup.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
zapwallettxes.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00
zmq_test.py Merge #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods 2019-06-26 12:44:45 -05:00

Regression tests

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for new regression tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support p2p connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, p2p tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

P2P test design notes

Mininode

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • NodeConn is the class used to connect to a bitcoind. If you implement a callback class that derives from NodeConnCB and pass that to the NodeConn object, your code will receive the appropriate callbacks when events of interest arrive.

  • You can pass the same handler to multiple NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test.

  • Call NetworkThread.start() after all NodeConn objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • RPC calls are available in p2p tests.

  • Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples: p2p-accept-block.py, p2p-compactblocks.py.

Comptool

  • Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • a list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.