mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
df80a6d2b9
5b77f8098de537898151ab116d0e547fd6ff9466 test: add p2p_lock acquires in p2p_leak_tx.py (Sebastian Falbesoner) cc8c6823b4a8b74922f78ce6ce527ced9325bd49 test: use MiniWallet for p2p_leak_tx.py (Sebastian Falbesoner) Pull request description: This PR enables one more of the non-wallet functional tests (p2p_leak_tx.py) to be run even with the Bitcoin Core wallet disabled by using the new MiniWallet instead, as proposed in #20078. It also adds missing p2p_lock acquires that need to be held while modifying internal p2p Interface state (in this case the `last_message` dictionary) to avoid data races. ACKs for top commit: laanwj: Code review ACK 5b77f8098de537898151ab116d0e547fd6ff9466 Tree-SHA512: 6661bc6e3491a9af4bf040f379e5955c525136397e99d3eadde92e247580d0d87efff750e6d3b1f6d9a4e578144a433a982f574ef056b44dd6bca33873a1bae6
60 lines
2.3 KiB
Python
Executable File
60 lines
2.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test that we don't leak txs to inbound peers that we haven't yet announced to"""
|
|
|
|
from test_framework.messages import msg_getdata, CInv, MSG_TX
|
|
from test_framework.p2p import p2p_lock, P2PDataStore
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
)
|
|
from test_framework.wallet import MiniWallet
|
|
|
|
|
|
class P2PNode(P2PDataStore):
|
|
def on_inv(self, msg):
|
|
pass
|
|
|
|
|
|
class P2PLeakTxTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def run_test(self):
|
|
gen_node = self.nodes[0] # The block and tx generating node
|
|
miniwallet = MiniWallet(gen_node)
|
|
# Add enough mature utxos to the wallet, so that all txs spend confirmed coins
|
|
miniwallet.generate(1)
|
|
gen_node.generate(100)
|
|
|
|
inbound_peer = self.nodes[0].add_p2p_connection(P2PNode()) # An "attacking" inbound peer
|
|
|
|
MAX_REPEATS = 100
|
|
self.log.info("Running test up to {} times.".format(MAX_REPEATS))
|
|
for i in range(MAX_REPEATS):
|
|
self.log.info('Run repeat {}'.format(i + 1))
|
|
txid = miniwallet.send_self_transfer(from_node=gen_node)['txid']
|
|
|
|
want_tx = msg_getdata()
|
|
want_tx.inv.append(CInv(t=MSG_TX, h=int(txid, 16)))
|
|
with p2p_lock:
|
|
inbound_peer.last_message.pop('notfound', None)
|
|
inbound_peer.send_and_ping(want_tx)
|
|
|
|
if inbound_peer.last_message.get('notfound'):
|
|
self.log.debug('tx {} was not yet announced to us.'.format(txid))
|
|
self.log.debug("node has responded with a notfound message. End test.")
|
|
assert_equal(inbound_peer.last_message['notfound'].vec[0].hash, int(txid, 16))
|
|
with p2p_lock:
|
|
inbound_peer.last_message.pop('notfound')
|
|
break
|
|
else:
|
|
self.log.debug('tx {} was already announced to us. Try test again.'.format(txid))
|
|
assert int(txid, 16) in [inv.hash for inv in inbound_peer.last_message['inv'].inv]
|
|
|
|
|
|
if __name__ == '__main__':
|
|
P2PLeakTxTest().main()
|