mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
2c7c4bcc08
fa4760fbb3f1099dcd3c43ebc53c2a761a2170e8 qa: Increase includeconf test coverage (MarcoFalke) Pull request description: This adds some missing `return false` for error conditions and adds test coverage [1] for those. Also, extend recursion warning when the chain was set in one of the includeconfs. [1] See the red lines in https://marcofalke.github.io/btc_cov/total.coverage/src/util.cpp.gcov.html for missing coverage. Tree-SHA512: d32563c9bb277879895a173e699034db5ecdb4061a1ec8890c566d61e36a09efa5eda19a029baf952ff6d568f8b9684a13a0bb90827850075470975e2088fee4
81 lines
3.9 KiB
Python
Executable File
81 lines
3.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Tests the includeconf argument
|
|
|
|
Verify that:
|
|
|
|
1. adding includeconf to the configuration file causes the includeconf
|
|
file to be loaded in the correct order.
|
|
2. includeconf cannot be used as a command line argument.
|
|
3. includeconf cannot be used recursively (ie includeconf can only
|
|
be used from the base config file).
|
|
4. multiple includeconf arguments can be specified in the main config
|
|
file.
|
|
"""
|
|
import os
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
class IncludeConfTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = False
|
|
self.num_nodes = 1
|
|
|
|
def setup_chain(self):
|
|
super().setup_chain()
|
|
# Create additional config files
|
|
# - tmpdir/node0/relative.conf
|
|
with open(os.path.join(self.options.tmpdir, "node0", "relative.conf"), "w", encoding="utf8") as f:
|
|
f.write("uacomment=relative\n")
|
|
# - tmpdir/node0/relative2.conf
|
|
with open(os.path.join(self.options.tmpdir, "node0", "relative2.conf"), "w", encoding="utf8") as f:
|
|
f.write("uacomment=relative2\n")
|
|
with open(os.path.join(self.options.tmpdir, "node0", "dash.conf"), "a", encoding='utf8') as f:
|
|
f.write("uacomment=main\nincludeconf=relative.conf\n")
|
|
|
|
def run_test(self):
|
|
self.log.info("-includeconf works from config file. subversion should end with 'main; relative)/'")
|
|
|
|
subversion = self.nodes[0].getnetworkinfo()["subversion"]
|
|
assert subversion.endswith("main; relative)/")
|
|
|
|
self.log.info("-includeconf cannot be used as command-line arg")
|
|
self.stop_node(0)
|
|
self.nodes[0].assert_start_raises_init_error(extra_args=["-includeconf=relative2.conf"], expected_msg="Error parsing command line arguments: -includeconf cannot be used from commandline; -includeconf=relative2.conf")
|
|
|
|
self.log.info("-includeconf cannot be used recursively. subversion should end with 'main; relative)/'")
|
|
with open(os.path.join(self.options.tmpdir, "node0", "relative.conf"), "a", encoding="utf8") as f:
|
|
f.write("includeconf=relative2.conf\n")
|
|
self.start_node(0)
|
|
|
|
subversion = self.nodes[0].getnetworkinfo()["subversion"]
|
|
assert subversion.endswith("main; relative)/")
|
|
self.stop_node(0, expected_stderr="warning: -includeconf cannot be used from included files; ignoring -includeconf=relative2.conf")
|
|
|
|
self.log.info("-includeconf cannot contain invalid arg")
|
|
with open(os.path.join(self.options.tmpdir, "node0", "relative.conf"), "w", encoding="utf8") as f:
|
|
f.write("foo=bar\n")
|
|
self.nodes[0].assert_start_raises_init_error(expected_msg="Error reading configuration file: Invalid configuration value foo")
|
|
|
|
self.log.info("-includeconf cannot be invalid path")
|
|
os.remove(os.path.join(self.options.tmpdir, "node0", "relative.conf"))
|
|
self.nodes[0].assert_start_raises_init_error(expected_msg="Error reading configuration file: Failed to include configuration file relative.conf")
|
|
|
|
self.log.info("multiple -includeconf args can be used from the base config file. subversion should end with 'main; relative; relative2)/'")
|
|
with open(os.path.join(self.options.tmpdir, "node0", "relative.conf"), "w", encoding="utf8") as f:
|
|
# Restore initial file contents
|
|
f.write("uacomment=relative\n")
|
|
|
|
with open(os.path.join(self.options.tmpdir, "node0", "dash.conf"), "a", encoding='utf8') as f:
|
|
f.write("includeconf=relative2.conf\n")
|
|
|
|
self.start_node(0)
|
|
|
|
subversion = self.nodes[0].getnetworkinfo()["subversion"]
|
|
assert subversion.endswith("main; relative; relative2)/")
|
|
|
|
if __name__ == '__main__':
|
|
IncludeConfTest().main()
|