mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
20e1f4a8ef
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott) 736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott) 157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott) Pull request description: There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other. This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149) 1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey 2. `create_transaction`: Return transaction object spending coinbase tx 2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx I am not committed to any of these function names, so I'll gladly take suggestions on there. Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output. Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
98 lines
4.6 KiB
Python
Executable File
98 lines
4.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test mempool re-org scenarios.
|
|
|
|
Test re-org scenarios with a mempool that contains transactions
|
|
that spend (directly or indirectly) coinbase transactions.
|
|
"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.blocktools import create_raw_transaction
|
|
from test_framework.util import *
|
|
|
|
|
|
class MempoolCoinbaseTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
|
|
alert_filename = None # Set by setup_network
|
|
|
|
def run_test(self):
|
|
# Start with a 200 block chain
|
|
assert_equal(self.nodes[0].getblockcount(), 200)
|
|
|
|
# Mine four blocks. After this, nodes[0] blocks
|
|
# 101, 102, and 103 are spend-able.
|
|
new_blocks = self.nodes[1].generate(4)
|
|
self.sync_all()
|
|
|
|
node0_address = self.nodes[0].getnewaddress()
|
|
node1_address = self.nodes[1].getnewaddress()
|
|
|
|
# Three scenarios for re-orging coinbase spends in the memory pool:
|
|
# 1. Direct coinbase spend : spend_101
|
|
# 2. Indirect (coinbase spend in chain, child in mempool) : spend_102 and spend_102_1
|
|
# 3. Indirect (coinbase and child both in chain) : spend_103 and spend_103_1
|
|
# Use invalidatblock to make all of the above coinbase spends invalid (immature coinbase),
|
|
# and make sure the mempool code behaves correctly.
|
|
b = [ self.nodes[0].getblockhash(n) for n in range(101, 105) ]
|
|
coinbase_txids = [ self.nodes[0].getblock(h)['tx'][0] for h in b ]
|
|
spend_101_raw = create_raw_transaction(self.nodes[0], coinbase_txids[1], node1_address, 499.99)
|
|
spend_102_raw = create_raw_transaction(self.nodes[0], coinbase_txids[2], node0_address, 499.99)
|
|
spend_103_raw = create_raw_transaction(self.nodes[0], coinbase_txids[3], node0_address, 499.99)
|
|
|
|
# Create a transaction which is time-locked to two blocks in the future
|
|
timelock_tx = self.nodes[0].createrawtransaction([{"txid": coinbase_txids[0], "vout": 0}], {node0_address: 499.9})
|
|
# Set the time lock
|
|
timelock_tx = timelock_tx.replace("ffffffff", "11111191", 1)
|
|
timelock_tx = timelock_tx[:-8] + hex(self.nodes[0].getblockcount() + 2)[2:] + "000000"
|
|
timelock_tx = self.nodes[0].signrawtransactionwithwallet(timelock_tx)["hex"]
|
|
# This will raise an exception because the timelock transaction is too immature to spend
|
|
assert_raises_rpc_error(-26, "non-final", self.nodes[0].sendrawtransaction, timelock_tx)
|
|
|
|
# Broadcast and mine spend_102 and 103:
|
|
spend_102_id = self.nodes[0].sendrawtransaction(spend_102_raw)
|
|
spend_103_id = self.nodes[0].sendrawtransaction(spend_103_raw)
|
|
self.nodes[0].generate(1)
|
|
# Time-locked transaction is still too immature to spend
|
|
assert_raises_rpc_error(-26,'non-final', self.nodes[0].sendrawtransaction, timelock_tx)
|
|
|
|
# Create 102_1 and 103_1:
|
|
spend_102_1_raw = create_raw_transaction(self.nodes[0], spend_102_id, node1_address, 499.98)
|
|
spend_103_1_raw = create_raw_transaction(self.nodes[0], spend_103_id, node1_address, 499.98)
|
|
|
|
# Broadcast and mine 103_1:
|
|
spend_103_1_id = self.nodes[0].sendrawtransaction(spend_103_1_raw)
|
|
last_block = self.nodes[0].generate(1)
|
|
# Time-locked transaction can now be spent
|
|
timelock_tx_id = self.nodes[0].sendrawtransaction(timelock_tx)
|
|
|
|
# ... now put spend_101 and spend_102_1 in memory pools:
|
|
spend_101_id = self.nodes[0].sendrawtransaction(spend_101_raw)
|
|
spend_102_1_id = self.nodes[0].sendrawtransaction(spend_102_1_raw)
|
|
|
|
self.sync_all()
|
|
|
|
assert_equal(set(self.nodes[0].getrawmempool()), {spend_101_id, spend_102_1_id, timelock_tx_id})
|
|
|
|
for node in self.nodes:
|
|
node.invalidateblock(last_block[0])
|
|
# Time-locked transaction is now too immature and has been removed from the mempool
|
|
# spend_103_1 has been re-orged out of the chain and is back in the mempool
|
|
assert_equal(set(self.nodes[0].getrawmempool()), {spend_101_id, spend_102_1_id, spend_103_1_id})
|
|
|
|
# Use invalidateblock to re-org back and make all those coinbase spends
|
|
# immature/invalid:
|
|
for node in self.nodes:
|
|
node.invalidateblock(new_blocks[0])
|
|
|
|
self.sync_all()
|
|
|
|
# mempool should be empty.
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
|
|
if __name__ == '__main__':
|
|
MempoolCoinbaseTest().main()
|