mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
20e1f4a8ef
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott) 736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott) 157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott) Pull request description: There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other. This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149) 1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey 2. `create_transaction`: Return transaction object spending coinbase tx 2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx I am not committed to any of these function names, so I'll gladly take suggestions on there. Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output. Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
68 lines
2.8 KiB
Python
Executable File
68 lines
2.8 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test resurrection of mined transactions when the blockchain is re-organized."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.blocktools import create_raw_transaction
|
|
from test_framework.util import *
|
|
|
|
|
|
class MempoolCoinbaseTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def run_test(self):
|
|
node0_address = self.nodes[0].getnewaddress()
|
|
# Spend block 1/2/3's coinbase transactions
|
|
# Mine a block.
|
|
# Create three more transactions, spending the spends
|
|
# Mine another block.
|
|
# ... make sure all the transactions are confirmed
|
|
# Invalidate both blocks
|
|
# ... make sure all the transactions are put back in the mempool
|
|
# Mine a new block
|
|
# ... make sure all the transactions are confirmed again.
|
|
|
|
b = [ self.nodes[0].getblockhash(n) for n in range(1, 4) ]
|
|
coinbase_txids = [ self.nodes[0].getblock(h)['tx'][0] for h in b ]
|
|
spends1_raw = [ create_raw_transaction(self.nodes[0], txid, node0_address, 500) for txid in coinbase_txids ]
|
|
spends1_id = [ self.nodes[0].sendrawtransaction(tx, False, False, True) for tx in spends1_raw ]
|
|
|
|
blocks = []
|
|
blocks.extend(self.nodes[0].generate(1))
|
|
|
|
spends2_raw = [ create_raw_transaction(self.nodes[0], txid, node0_address, 499.99) for txid in spends1_id ]
|
|
spends2_id = [ self.nodes[0].sendrawtransaction(tx, False, False, True) for tx in spends2_raw ]
|
|
|
|
blocks.extend(self.nodes[0].generate(1))
|
|
|
|
# mempool should be empty, all txns confirmed
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
for txid in spends1_id+spends2_id:
|
|
tx = self.nodes[0].gettransaction(txid)
|
|
assert(tx["confirmations"] > 0)
|
|
|
|
# Use invalidateblock to re-org back
|
|
for node in self.nodes:
|
|
node.invalidateblock(blocks[0])
|
|
|
|
# All txns should be back in mempool with 0 confirmations
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set(spends1_id+spends2_id))
|
|
for txid in spends1_id+spends2_id:
|
|
tx = self.nodes[0].gettransaction(txid)
|
|
assert(tx["confirmations"] == 0)
|
|
|
|
# Generate another block, they should all get mined
|
|
self.nodes[0].generate(1)
|
|
# mempool should be empty, all txns confirmed
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
for txid in spends1_id+spends2_id:
|
|
tx = self.nodes[0].gettransaction(txid)
|
|
assert(tx["confirmations"] > 0)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MempoolCoinbaseTest().main()
|