Wladimir J. van der Laan 80f9dad0b7 Merge #11809: gui: Fix proxy setting options dialog crash ... f05d349 gui: Fix proxy setting options dialog crash (Wladimir J. van der Laan) Pull request description: This fixes a crash bug when opening the options dialog. - Check the return value of split() to avoid segmentation faults due to out of bounds when the user manages to enter invalid proxy settings. This is reported resonably often. - Move the default proxy/port to a constant instead of hardcoding magic values. - Factor out some common code. - Revert #11448 because this proves a more robust replacement, it is no longer necessary and didn't generally solve the issue. No attempt is made to do full sanity checking on the proxy, so it can still be rejected by the core with an InitError message. Tree-SHA512: 72b700b7d6c4d3e3410f0c60e9e4facf93d7c6c1a1b6b23957c48b074a045970f518166952859d1ebca8620062cb70d222670a7310bbd6fe50550ec6d04417b5		2017-12-07 17:40:11 +01:00
..
forms	[Qt] Improved copy: RBF checkbox, tooltip and confirmation screen	2017-11-18 13:12:07 +01:00
locale	qt: Periodic translations update	2017-08-09 12:04:41 +02:00
res
test	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
addressbookpage.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
addressbookpage.h	Remove unnecessary forward class declarations in header files	2017-06-12 20:37:43 +02:00
addresstablemodel.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
addresstablemodel.h
askpassphrasedialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
askpassphrasedialog.h	[ui] Add toggle for unblinding password fields	2017-10-18 13:22:30 -07:00
bantablemodel.cpp	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
bantablemodel.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoin_locale.qrc
bitcoin.cpp	Create walletdir if datadir doesn't exist and fix tests	2017-11-18 00:50:59 +13:00
bitcoin.qrc
bitcoinaddressvalidator.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoinaddressvalidator.h
bitcoinamountfield.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
bitcoinamountfield.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoingui.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoingui.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoinstrings.cpp	qt: Periodic translations update	2017-07-31 12:19:05 +02:00
bitcoinunits.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
bitcoinunits.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
callback.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
clientmodel.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
clientmodel.h	Remove unnecessary forward class declarations in header files	2017-06-12 20:37:43 +02:00
coincontroldialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
coincontroldialog.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
coincontroltreewidget.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
coincontroltreewidget.h
csvmodelwriter.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
csvmodelwriter.h
editaddressdialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
editaddressdialog.h
guiconstants.h
guiutil.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
guiutil.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
intro.cpp	Create walletdir if datadir doesn't exist and fix tests	2017-11-18 00:50:59 +13:00
intro.h
macdockiconhandler.h
macdockiconhandler.mm	Document the preference of nullptr over NULL or (void*)0	2017-08-18 09:51:00 +02:00
macnotificationhandler.h	[macOS] remove Growl support, remove unused code	2017-09-07 10:11:44 -07:00
macnotificationhandler.mm	[macOS] remove Growl support, remove unused code	2017-09-07 10:11:44 -07:00
Makefile
modaloverlay.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
modaloverlay.h	Add const to methods that do not modify the object for which it is called	2017-07-25 13:46:52 +02:00
networkstyle.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
networkstyle.h
notificator.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
notificator.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
openuridialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
openuridialog.h
optionsdialog.cpp	gui: Fix proxy setting options dialog crash	2017-12-07 17:34:16 +01:00
optionsdialog.h	Add a button to open the config file in a text editor	2017-03-23 12:54:36 -04:00
optionsmodel.cpp	gui: Fix proxy setting options dialog crash	2017-12-07 17:34:16 +01:00
optionsmodel.h	gui: Fix proxy setting options dialog crash	2017-12-07 17:34:16 +01:00
overviewpage.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
overviewpage.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
paymentrequest.proto
paymentrequestplus.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
paymentrequestplus.h	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
paymentserver.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
paymentserver.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
peertablemodel.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
peertablemodel.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
platformstyle.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
platformstyle.h
qvalidatedlineedit.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
qvalidatedlineedit.h
qvaluecombobox.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
qvaluecombobox.h
receivecoinsdialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
receivecoinsdialog.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
receiverequestdialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
receiverequestdialog.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
recentrequeststablemodel.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
recentrequeststablemodel.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
rpcconsole.cpp	Merge #11698: [Docs] [Qt] RPC-Console nested commands documentation	2017-11-19 13:04:43 +01:00
rpcconsole.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
sendcoinsdialog.cpp	[Qt] Improved copy: RBF checkbox, tooltip and confirmation screen	2017-11-18 13:12:07 +01:00
sendcoinsdialog.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
sendcoinsentry.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
sendcoinsentry.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
signverifymessagedialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
signverifymessagedialog.h
splashscreen.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
splashscreen.h	Drop upgrade-cancel callback registration for a generic "resumeable"	2017-08-20 20:04:15 -04:00
trafficgraphwidget.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
trafficgraphwidget.h
transactiondesc.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
transactiondesc.h
transactiondescdialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
transactiondescdialog.h
transactionfilterproxy.cpp	Merge #11395: Qt: Enable searching by transaction id	2017-11-29 13:51:16 -10:00
transactionfilterproxy.h	Merge #11395: Qt: Enable searching by transaction id	2017-11-29 13:51:16 -10:00
transactionrecord.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
transactionrecord.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
transactiontablemodel.cpp	Merge #10493: Use range-based for loops (C++11) when looping over map elements	2017-11-30 17:10:05 -05:00
transactiontablemodel.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
transactionview.cpp	Merge #11395: Qt: Enable searching by transaction id	2017-11-29 13:51:16 -10:00
transactionview.h	Merge #11395: Qt: Enable searching by transaction id	2017-11-29 13:51:16 -10:00
utilitydialog.cpp	qt: refactor: Changes to make include paths absolute	2017-11-16 08:23:02 +13:00
utilitydialog.h	Declare single-argument (non-converting) constructors "explicit"	2017-08-16 16:33:25 +02:00
walletframe.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
walletframe.h
walletmodel.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
walletmodel.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
walletmodeltransaction.cpp	Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)	2017-11-17 13:07:37 +01:00
walletmodeltransaction.h	Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)	2017-11-17 13:07:37 +01:00
walletview.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
walletview.h	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
winshutdownmonitor.cpp	scripted-diff: Replace #include "" with #include <> (ryanofsky)	2017-11-16 08:23:01 +13:00
winshutdownmonitor.h