mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
666e6e2015
1f05dbd06d896849d16b026bfc3315ee8b73a89f util: Avoid invalid integer negation in ValueFromAmount: make ValueFromAmount(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min() (practicalswift) 7cc75c9ba38e516067e5a4ab84311c62ddddced7 util: Avoid invalid integer negation in FormatMoney: make FormatMoney(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min() (practicalswift) Pull request description: Avoid invalid integer negation in `FormatMoney` and `ValueFromAmount`. Fixes #20402. Before this patch: ``` $ CC=clang CXX=clang++ ./configure --with-sanitizers=undefined $ make -C src/ test/test_bitcoin $ src/test/test_bitcoin -t rpc_tests/rpc_format_monetary_values -t util_tests/util_FormatMoney core_write.cpp:21:29: runtime error: negation of -9223372036854775808 cannot be represented in type 'CAmount' (aka 'long'); cast to an unsigned type to negate this value to itself SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior core_write.cpp:21:29 in test/rpc_tests.cpp(186): error: in "rpc_tests/rpc_format_monetary_values": check ValueFromAmount(std::numeric_limits<CAmount>::min()).write() == "-92233720368.54775808" has failed [--92233720368.-54775808 != -92233720368.54775808] util/moneystr.cpp:16:34: runtime error: negation of -9223372036854775808 cannot be represented in type 'CAmount' (aka 'long'); cast to an unsigned type to negate this value to itself SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior util/moneystr.cpp:16:34 in test/util_tests.cpp(1188): error: in "util_tests/util_FormatMoney": check FormatMoney(std::numeric_limits<CAmount>::min()) == "-92233720368.54775808" has failed [--92233720368.-54775808 != -92233720368.54775808] ``` After this patch: ``` $ CC=clang CXX=clang++ ./configure --with-sanitizers=undefined $ make -C src/ test/test_bitcoin $ src/test/test_bitcoin -t rpc_tests/rpc_format_monetary_values -t util_tests/util_FormatMoney ``` ACKs for top commit: laanwj: re-ACK 1f05dbd06d896849d16b026bfc3315ee8b73a89f Tree-SHA512: 5aaeb8e2178f1597921f53c12bdfc2f3d5993d10c41658dcd25943e54e8cc2116a411bc71d928f890b33bc0b3761a8ee4449b0532bce41125b6c60692808c8c3
53 lines
1.9 KiB
C++
53 lines
1.9 KiB
C++
// Copyright (c) 2009-2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_CORE_IO_H
|
|
#define BITCOIN_CORE_IO_H
|
|
|
|
#include <amount.h>
|
|
#include <attributes.h>
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
class CBlock;
|
|
class CBlockHeader;
|
|
class CScript;
|
|
class CTransaction;
|
|
struct CMutableTransaction;
|
|
class uint256;
|
|
class UniValue;
|
|
class CTxUndo;
|
|
|
|
struct CSpentIndexTxInfo;
|
|
|
|
// core_read.cpp
|
|
CScript ParseScript(const std::string& s);
|
|
std::string ScriptToAsmStr(const CScript& script, const bool fAttemptSighashDecode = false);
|
|
[[nodiscard]] bool DecodeHexTx(CMutableTransaction& tx, const std::string& hex_tx);
|
|
[[nodiscard]] bool DecodeHexBlk(CBlock&, const std::string& strHexBlk);
|
|
bool DecodeHexBlockHeader(CBlockHeader&, const std::string& hex_header);
|
|
/**
|
|
* Parse a hex string into 256 bits
|
|
* @param[in] strHex a hex-formatted, 64-character string
|
|
* @param[out] result the result of the parasing
|
|
* @returns true if successful, false if not
|
|
*
|
|
* @see ParseHashV for an RPC-oriented version of this
|
|
*/
|
|
bool ParseHashStr(const std::string& strHex, uint256& result);
|
|
std::vector<unsigned char> ParseHexUV(const UniValue& v, const std::string& strName);
|
|
int ParseSighashString(const UniValue& sighash);
|
|
|
|
// core_write.cpp
|
|
UniValue ValueFromAmount(const CAmount amount);
|
|
std::string FormatScript(const CScript& script);
|
|
std::string EncodeHexTx(const CTransaction& tx);
|
|
std::string SighashToStr(unsigned char sighash_type);
|
|
void ScriptPubKeyToUniv(const CScript& scriptPubKey, UniValue& out, bool fIncludeHex);
|
|
void ScriptToUniv(const CScript& script, UniValue& out, bool include_address);
|
|
void TxToUniv(const CTransaction& tx, const uint256& hashBlock, UniValue& entry, bool include_hex = true, const CSpentIndexTxInfo* ptxSpentInfo = nullptr, const CTxUndo* txundo = nullptr);
|
|
|
|
#endif // BITCOIN_CORE_IO_H
|