dash/src/wallet
Konstantin Akimov ae051bb6e0
Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938)
* Move wallet enums to walletutil.h

* MOVEONLY: Move key handling code out of wallet to keyman file

Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp

The easiest way to review this commit is to run:

   git log -p -n1 --color-moved=dimmed_zebra

And check that everything is a move (other than includes and copyrights comments).

This commit is move-only and doesn't change code or affect behavior.

* Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

This moves CWallet members and methods dealing with keys to a new
LegacyScriptPubKeyMan class, and updates calling code to reference the new
class instead of CWallet.

Most of the changes are simple text replacements and variable substitutions
easily verified with:

    git log -p -n1 -U0 --word-diff-regex=.

The only nontrivial chunk of code added is the new LegacyScriptPubKeyMan class
declaration, but this code isn't new and is just selectively copied and moved
from the previous CWallet class declaration. This can be verified with:

    git log -p -n1 --color-moved=dimmed_zebra src/wallet/scriptpubkeyman.h src/wallet/wallet.h

or

    git diff HEAD~1:src/wallet/wallet.h HEAD:src/wallet/scriptpubkeyman.h

This commit does not change behavior.

* Renamed classes in scriptpubkeyman

* Fixes for conflicts, compilation and linkage errors due to previous commits

* Reordered methods in scriptpubkeyman to make further backports easier

* Reordered methods in scriptpubkeyman to make further backports easier (part II)

* Remove HDChain copy from SigningProvider class

* fixes/suggestions

Co-authored-by: Andrew Chow <achow101-github@achow101.com>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2022-08-08 11:05:21 -05:00
..
test Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
bdb.cpp
bdb.h
coincontrol.cpp Merge #13756: wallet: "avoid_reuse" wallet flag for improved privacy 2022-06-17 04:06:49 +07:00
coincontrol.h Merge #13756: wallet: "avoid_reuse" wallet flag for improved privacy 2022-06-17 04:06:49 +07:00
coinselection.cpp
coinselection.h
context.cpp
context.h merge bitcoin#18923: Never schedule MaybeCompactWalletDB when -flushwallet is off 2022-07-03 00:14:47 +05:30
crypter.cpp Bitcoin backport #16227 refactoring CWallet (#4903) 2022-07-12 22:46:31 -05:00
crypter.h Bitcoin backport #16227 refactoring CWallet (#4903) 2022-07-12 22:46:31 -05:00
db.cpp
db.h
fees.cpp
fees.h
init.cpp merge bitcoin#18923: Never schedule MaybeCompactWalletDB when -flushwallet is off 2022-07-03 00:14:47 +05:30
ismine.h Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
load.cpp merge bitcoin#18923: Never schedule MaybeCompactWalletDB when -flushwallet is off 2022-07-03 00:14:47 +05:30
load.h merge bitcoin#18923: Never schedule MaybeCompactWalletDB when -flushwallet is off 2022-07-03 00:14:47 +05:30
psbtwallet.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
psbtwallet.h
rpcdump.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
rpcwallet.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
rpcwallet.h Merge #18499: rpc: Make rpc documentation not depend on call-time rpc args (#4893) 2022-06-27 11:40:22 -05:00
salvage.cpp Merge #19805: wallet: Avoid deserializing unused records when salvaging 2022-06-07 16:11:23 -05:00
salvage.h
scriptpubkeyman.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
scriptpubkeyman.h Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
wallet.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
wallet.h Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
walletdb.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
walletdb.h Merge #19805: wallet: Avoid deserializing unused records when salvaging 2022-06-07 16:11:23 -05:00
wallettool.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
wallettool.h
walletutil.cpp
walletutil.h Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00