mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
0c97cd5cee
dcfef27 cli: Reject arguments to -getinfo (Wladimir J. van der Laan)
Pull request description:
Currently it's possible to accidentally type e.g.
bitcoin-cli -getinfo getbalance
and get an answer which can be confusing; the trailing arguments are just ignored.
To avoid this, throw an error if the user provides arguments to
`-getinfo`.
Tree-SHA512: 3603e8fa852b884d1dd3b7462db40b092fe8b3390fd4384b4ee330315d797aff711e9f62990012fd4b5a55c8678734ba8497a5488a09ee6b65cf8a99017d6eb4
67 lines
3.7 KiB
Python
Executable File
67 lines
3.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test dash-cli"""
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_raises_process_error, get_auth_cookie
|
|
|
|
class TestBitcoinCli(BitcoinTestFramework):
|
|
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
|
|
def run_test(self):
|
|
"""Main test logic"""
|
|
|
|
self.log.info("Compare responses from gewalletinfo RPC and `dash-cli getwalletinfo`")
|
|
cli_response = self.nodes[0].cli.getwalletinfo()
|
|
rpc_response = self.nodes[0].getwalletinfo()
|
|
assert_equal(cli_response, rpc_response)
|
|
|
|
self.log.info("Compare responses from getblockchaininfo RPC and `dash-cli getblockchaininfo`")
|
|
cli_response = self.nodes[0].cli.getblockchaininfo()
|
|
rpc_response = self.nodes[0].getblockchaininfo()
|
|
assert_equal(cli_response, rpc_response)
|
|
|
|
user, password = get_auth_cookie(self.nodes[0].datadir)
|
|
|
|
self.log.info("Test -stdinrpcpass option")
|
|
assert_equal(0, self.nodes[0].cli('-rpcuser=%s' % user, '-stdinrpcpass', input=password).getblockcount())
|
|
assert_raises_process_error(1, "incorrect rpcuser or rpcpassword", self.nodes[0].cli('-rpcuser=%s' % user, '-stdinrpcpass', input="foo").echo)
|
|
|
|
self.log.info("Test -stdin and -stdinrpcpass")
|
|
assert_equal(["foo", "bar"], self.nodes[0].cli('-rpcuser=%s' % user, '-stdin', '-stdinrpcpass', input=password + "\nfoo\nbar").echo())
|
|
assert_raises_process_error(1, "incorrect rpcuser or rpcpassword", self.nodes[0].cli('-rpcuser=%s' % user, '-stdin', '-stdinrpcpass', input="foo").echo)
|
|
|
|
self.log.info("Make sure that -getinfo with arguments fails")
|
|
assert_raises_process_error(1, "-getinfo takes no arguments", self.nodes[0].cli('-getinfo').help)
|
|
|
|
self.log.info("Compare responses from `dash-cli -getinfo` and the RPCs data is retrieved from.")
|
|
cli_get_info = self.nodes[0].cli().send_cli('-getinfo')
|
|
wallet_info = self.nodes[0].getwalletinfo()
|
|
network_info = self.nodes[0].getnetworkinfo()
|
|
blockchain_info = self.nodes[0].getblockchaininfo()
|
|
|
|
assert_equal(cli_get_info['version'], network_info['version'])
|
|
assert_equal(cli_get_info['protocolversion'], network_info['protocolversion'])
|
|
assert_equal(cli_get_info['walletversion'], wallet_info['walletversion'])
|
|
assert_equal(cli_get_info['balance'], wallet_info['balance'])
|
|
assert_equal(cli_get_info['privatesend_balance'], wallet_info['privatesend_balance'])
|
|
assert_equal(cli_get_info['blocks'], blockchain_info['blocks'])
|
|
assert_equal(cli_get_info['timeoffset'], network_info['timeoffset'])
|
|
assert_equal(cli_get_info['connections'], network_info['connections'])
|
|
assert_equal(cli_get_info['proxy'], network_info['networks'][0]['proxy'])
|
|
assert_equal(cli_get_info['difficulty'], blockchain_info['difficulty'])
|
|
assert_equal(cli_get_info['testnet'], blockchain_info['chain'] == "test")
|
|
assert_equal(cli_get_info['balance'], wallet_info['balance'])
|
|
assert_equal(cli_get_info['keypoololdest'], wallet_info['keypoololdest'])
|
|
assert_equal(cli_get_info['keypoolsize'], wallet_info['keypoolsize'])
|
|
assert_equal(cli_get_info['paytxfee'], wallet_info['paytxfee'])
|
|
assert_equal(cli_get_info['relayfee'], network_info['relayfee'])
|
|
# unlocked_until is not tested because the wallet is not encrypted
|
|
|
|
if __name__ == '__main__':
|
|
TestBitcoinCli().main()
|