mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
a42d62d89e
fb00c45c3[tests] Explicitly disallow support for p2p versions below 60001 (John Newbery)3858aabbd[tests] Remove support for p2p alert messages (John Newbery)c0b127470[tests] Remove support for bre-BIP31 ping messages (John Newbery)2904e301c[tests] Remove dead code from mininode.py (John Newbery) Pull request description: This is the first part of #11518. It removes a ~150 lines of unused code from the mininode module: - remove unused `deliver_sleep_time` and `EarlyDisconnectError` code - remove support for pre-BIP31 ping messages - remove support for alert message - explicitly don't support p2p versions lower than 60001 Should be an easy ACK for reviewers. If all extended tests pass, then this code really was dead :) Tree-SHA512: 508e612ceb0b094250d18e75522d51e6b14cd069443050ba4af34d6f890c58721cb5653e8bc000b60635b9474d035b0dcd9c509c0dcdb3a7501df17b787f83b0 readd is None check Signed-off-by: Pasta <pasta@dashboost.org>
127 lines
5.1 KiB
Python
Executable File
127 lines
5.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test message sending before handshake completion.
|
|
|
|
A node should never send anything other than VERSION/VERACK/REJECT until it's
|
|
received a VERACK.
|
|
|
|
This test connects to a node and sends it a few messages, trying to intice it
|
|
into sending us something it shouldn't.
|
|
"""
|
|
|
|
from test_framework.mininode import *
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import *
|
|
|
|
banscore = 10
|
|
|
|
class CLazyNode(NodeConnCB):
|
|
def __init__(self):
|
|
super().__init__()
|
|
self.unexpected_msg = False
|
|
self.ever_connected = False
|
|
|
|
def bad_message(self, message):
|
|
self.unexpected_msg = True
|
|
self.log.info("should not have received message: %s" % message.command)
|
|
|
|
def on_open(self, conn):
|
|
self.connected = True
|
|
self.ever_connected = True
|
|
|
|
def on_version(self, conn, message): self.bad_message(message)
|
|
def on_verack(self, conn, message): self.bad_message(message)
|
|
def on_reject(self, conn, message): self.bad_message(message)
|
|
def on_inv(self, conn, message): self.bad_message(message)
|
|
def on_addr(self, conn, message): self.bad_message(message)
|
|
def on_getdata(self, conn, message): self.bad_message(message)
|
|
def on_getblocks(self, conn, message): self.bad_message(message)
|
|
def on_tx(self, conn, message): self.bad_message(message)
|
|
def on_block(self, conn, message): self.bad_message(message)
|
|
def on_getaddr(self, conn, message): self.bad_message(message)
|
|
def on_headers(self, conn, message): self.bad_message(message)
|
|
def on_getheaders(self, conn, message): self.bad_message(message)
|
|
def on_ping(self, conn, message): self.bad_message(message)
|
|
def on_mempool(self, conn): self.bad_message(message)
|
|
def on_pong(self, conn, message): self.bad_message(message)
|
|
def on_sendheaders(self, conn, message): self.bad_message(message)
|
|
def on_sendcmpct(self, conn, message): self.bad_message(message)
|
|
def on_cmpctblock(self, conn, message): self.bad_message(message)
|
|
def on_getblocktxn(self, conn, message): self.bad_message(message)
|
|
def on_blocktxn(self, conn, message): self.bad_message(message)
|
|
|
|
# Node that never sends a version. We'll use this to send a bunch of messages
|
|
# anyway, and eventually get disconnected.
|
|
class CNodeNoVersionBan(CLazyNode):
|
|
# send a bunch of veracks without sending a message. This should get us disconnected.
|
|
# NOTE: implementation-specific check here. Remove if bitcoind ban behavior changes
|
|
def on_open(self, conn):
|
|
super().on_open(conn)
|
|
for i in range(banscore):
|
|
self.send_message(msg_verack())
|
|
|
|
def on_reject(self, conn, message): pass
|
|
|
|
# Node that never sends a version. This one just sits idle and hopes to receive
|
|
# any message (it shouldn't!)
|
|
class CNodeNoVersionIdle(CLazyNode):
|
|
def __init__(self):
|
|
super().__init__()
|
|
|
|
# Node that sends a version but not a verack.
|
|
class CNodeNoVerackIdle(CLazyNode):
|
|
def __init__(self):
|
|
self.version_received = False
|
|
super().__init__()
|
|
|
|
def on_reject(self, conn, message): pass
|
|
def on_verack(self, conn, message): pass
|
|
# When version is received, don't reply with a verack. Instead, see if the
|
|
# node will give us a message that it shouldn't. This is not an exhaustive
|
|
# list!
|
|
def on_version(self, conn, message):
|
|
self.version_received = True
|
|
conn.send_message(msg_ping())
|
|
conn.send_message(msg_getaddr())
|
|
|
|
class P2PLeakTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.extra_args = [['-banscore='+str(banscore)]]
|
|
|
|
def run_test(self):
|
|
|
|
no_version_bannode = self.nodes[0].add_p2p_connection(CNodeNoVersionBan(), send_version=False)
|
|
no_version_idlenode = self.nodes[0].add_p2p_connection(CNodeNoVersionIdle(), send_version=False)
|
|
no_verack_idlenode = self.nodes[0].add_p2p_connection(CNodeNoVerackIdle())
|
|
|
|
network_thread_start()
|
|
|
|
wait_until(lambda: no_version_bannode.ever_connected, timeout=10, lock=mininode_lock)
|
|
wait_until(lambda: no_version_idlenode.ever_connected, timeout=10, lock=mininode_lock)
|
|
wait_until(lambda: no_verack_idlenode.version_received, timeout=10, lock=mininode_lock)
|
|
|
|
# Mine a block and make sure that it's not sent to the connected nodes
|
|
self.nodes[0].generate(1)
|
|
|
|
#Give the node enough time to possibly leak out a message
|
|
time.sleep(5)
|
|
|
|
#This node should have been banned
|
|
assert not no_version_bannode.connected
|
|
|
|
self.nodes[0].disconnect_p2ps()
|
|
|
|
# Wait until all connections are closed
|
|
wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 0)
|
|
|
|
# Make sure no unexpected messages came in
|
|
assert(no_version_bannode.unexpected_msg == False)
|
|
assert(no_version_idlenode.unexpected_msg == False)
|
|
assert(no_verack_idlenode.unexpected_msg == False)
|
|
|
|
if __name__ == '__main__':
|
|
P2PLeakTest().main()
|